[FFmpeg-devel] [PATCH] avcodec/vulkan: Add support for generating GLSL strings from comp shaders

2024-10-05 Thread IndecisiveTurtle
--- libavcodec/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 4eed81ed03..734ab14596 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1371,3 +1371,10 @@ $(SUBDIR)pcm.o: $(SUBDIR)pcm_tables.h $(SUBDIR)qdm2.o: $(SUBD

[FFmpeg-devel] [PATCH v2] avcodec/hevc/ps: add a range check for sps_max_sub_layers

2024-10-05 Thread James Almer
It can't be higher than vps_max_sub_layers. Do this while keeping the workaround for qsvenc_hevc calling ff_hevc_parse_sps() without a vps_list, as in some cases it needs to parse an sps to generate a fake vps derived from it. Signed-off-by: James Almer --- libavcodec/hevc/ps.c | 9 +++-- 1

Re: [FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-05 Thread Lynne via ffmpeg-devel
On 05/10/2024 20:58, Sean McGovern wrote: --- libavcodec/aacenc_pred.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index a486c44d42..a6dfaa25fb 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c

[FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-05 Thread Sean McGovern
--- libavcodec/aacenc_pred.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index a486c44d42..a6dfaa25fb 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c @@ -153,9 +153,7 @@ void ff_aac_adjust_common

[FFmpeg-devel] [PATCH 02/12] tests/swscale: fix minor typos

2024-10-05 Thread Niklas Haas
From: Niklas Haas Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/tests/swscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c index cf8d04de89..8e57c0a7cf 100644 --- a/libswscale/test

[FFmpeg-devel] [PATCH 01/12] avfilter/src_movie: configure correct YUV attributes

2024-10-05 Thread Niklas Haas
From: Niklas Haas Missed by the YUV negotiation series. --- libavfilter/src_movie.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 65091b65f0..d2aa572d12 100644 --- a/libavfilter/src_movie.c +++ b/libavfilter/src_movie.c @@ -430,

[FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

2024-10-05 Thread Niklas Haas
From: Niklas Haas I want to move away from having random leaf processing functions mutate plane pointers, and while we're at it, we might as well make the strides and tables const as well. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/aarch64/swscale_unscaled.c |

[FFmpeg-devel] [PATCH 06/12] swscale/internal: expose low level swscale() internally

2024-10-05 Thread Niklas Haas
From: Niklas Haas And give it const parameters while we're at it, because this function does not mutate its parameters. Used as an intermediate entry point for the new swscale context. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/slice.c| 3 ++- lib

[FFmpeg-devel] [PATCH 08/12] swscale/internal: turn cascaded_tmp into an array

2024-10-05 Thread Niklas Haas
From: Niklas Haas Slightly more convenient to access from the new wrapping code. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/swscale.c | 20 ++-- libswscale/swscale_internal.h | 6 ++ libswscale/utils.c| 16 -

[FFmpeg-devel] [PATCH 07/12] swscale/internal: expose ff_update_palette() internally

2024-10-05 Thread Niklas Haas
From: Niklas Haas Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/swscale.c | 4 ++-- libswscale/swscale_internal.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 4ba35a61e1..e9323efb8

[FFmpeg-devel] [PATCH 05/12] swscale/internal: fix and expose xyz12Torgb48 and rgb48Toxyz12

2024-10-05 Thread Niklas Haas
From: Niklas Haas In the process of refactoring the signature to be more generically useful, this fixes an 11-year-old bug where the functions (incorrectly) did nothing when the stride was negative, since the stride was being used as the loop bounds for x. Sponsored-by: Sovereign Tech Fund Signe

[FFmpeg-devel] [PATCH 03/12] swscale/internal: rename NB_SWS_DITHER for consistency

2024-10-05 Thread Niklas Haas
From: Niklas Haas Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/options.c | 2 +- libswscale/swscale_internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/options.c b/libswscale/options.c index 53c4f0651b..6337a9f28d

[FFmpeg-devel] [PATCH 04/12] swscale/internal: swap SWS_DITHER_NONE and SWS_DITHER_AUTO

2024-10-05 Thread Niklas Haas
From: Niklas Haas This is done for consistency with the other public enums which will be added in the upcoming swscale API refactor. I went through the code and checked carefully that the value of `dither` is never implicitly compared against zero, so this change should not break anything. Spons

[FFmpeg-devel] [PATCH 12/12] swscale/input: parametrize ff_sws_init_input_funcs() pointers

2024-10-05 Thread Niklas Haas
From: Niklas Haas Following the precedent set by ff_sws_init_output_funcs(). Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/input.c| 388 +- libswscale/swscale.c | 3 +- libswscale/swscale_internal.h | 8 +-

[FFmpeg-devel] [PATCH 11/12] swscale/internal: add typedefs for input reading functions

2024-10-05 Thread Niklas Haas
From: Niklas Haas Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/swscale_internal.h | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 0e9d37b5

[FFmpeg-devel] [PATCH 10/12] swscale/internal: forward typedef SwsContext

2024-10-05 Thread Niklas Haas
From: Niklas Haas Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas --- libswscale/swscale_internal.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 7b7dfafac1..0e9d37b5b0 100644 --- a/li

[FFmpeg-devel] [PATCH] avcodec/hevc/ps: add a range check for sps_max_sub_layers

2024-10-05 Thread James Almer
It can't be higher than vps_max_sub_layers. Signed-off-by: James Almer --- libavcodec/hevc/ps.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/hevc/ps.c b/libavcodec/hevc/ps.c index 993c60144f..bd01f63956 100644 --- a/libavcodec/hevc/ps.c +++ b/libavco

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: unbreak build for X265_BUILD >= 213

2024-10-05 Thread Gyan Doshi
On 2024-10-05 06:21 pm, James Almer wrote: On 10/5/2024 1:44 AM, Gyan Doshi wrote: Earlier, x265 made an API change to support alpha and other multiple layer pictures. We added guards to accommodate that in 1f801dfdb5 They have now reverted that API change in https://bitbucket.org/multicorewa

[FFmpeg-devel] [PATCH] update release number

2024-10-05 Thread Martin Schitter
Shouldn't the number in RELEASE reflect the present release version? Martin --- RELEASE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE b/RELEASE index 72ec89d..9fa1d2c 100644 --- a/RELEASE +++ b/RELEASE @@ -1 +1 @@ -7.0.git +7.1.git -- 2.45.2 __

Re: [FFmpeg-devel] RFC - Uncompressed MP4

2024-10-05 Thread Devon Sookhoo
Martin, thanks again, I find your comments very helpful. I will do some more research to determine what the best CLI arguments would be. On Fri, Oct 4, 2024 at 7:55 PM martin schitter wrote: > > > On 04.10.24 18:10, Devon Sookhoo wrote: > > I thought the option "-c:v rawvideo" was the way to g

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: unbreak build for X265_BUILD >= 213

2024-10-05 Thread James Almer
On 10/5/2024 1:44 AM, Gyan Doshi wrote: Earlier, x265 made an API change to support alpha and other multiple layer pictures. We added guards to accommodate that in 1f801dfdb5 They have now reverted that API change in https://bitbucket.org/multicoreware/x265_git/commits/78e5b703b1 And they did

[FFmpeg-devel] [PATCH] lavu/common: Fix AV_CEIL_RSHIFT for unsigned LHS

2024-10-05 Thread Frank Plowman
The first branch of this ternary expression was intended to avoid having two shift operations in the case the RHS is not known at compile time. It only works if the LHS has a signed type however, otherwise the result is invalid. We could alternatively have different versions of AV_CEIL_RSHIFT for

[FFmpeg-devel] [PATCH] lavc/vvc: Validate subpartitioning structure

2024-10-05 Thread Frank Plowman
H.266 (V3) section 6.3.3 dictates that the division of the picture into subpictures must be exhaustive and mutually exclusive, i.e. that each CTU "belongs to" one and only one subpicture. In most cases this is guaranteed by the syntax, but in the case sps_subpic_same_size_flag=0, we must check thi

Re: [FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-05 Thread Sean McGovern
Hi On Sat, Oct 5, 2024, 19:15 Lynne via ffmpeg-devel wrote: > On 05/10/2024 20:58, Sean McGovern wrote: > > --- > > libavcodec/aacenc_pred.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c > > index a486c

Re: [FFmpeg-devel] [PATCH 1/5] configure: drop yasm support

2024-10-05 Thread Lynne via ffmpeg-devel
On 03/10/2024 15:40, Lynne wrote: We started defauling to nasm 8 years ago. We are still compatible with yasm 0.8.0, released in 2009. **15 years ago**. The time has more than come to remove support for it. Maintaining compatibility started cutting into writing new code long ago. We still can't