[FFmpeg-devel] [PATCH 1/4] avformat/avformat: add a new disposition to signal the stream is an HDR gainmap

2024-09-25 Thread James Almer
HDR images photos taken by certain cameras split this as a separate image. Signed-off-by: James Almer --- libavformat/avformat.h | 5 + libavformat/dump.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 56c1c80289..6d9f5c4399 1

[FFmpeg-devel] [PATCH 3/4] avformat/mov: add referenced thumbnail streams to tile stream groups

2024-09-25 Thread James Almer
Signed-off-by: James Almer --- libavformat/dump.c | 9 -- libavformat/isom.h | 3 +- libavformat/mov.c | 71 +++--- 3 files changed, 64 insertions(+), 19 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 5178f19685..ba30b92aaf

[FFmpeg-devel] [PATCH 4/4] avformat/mov: support parsing auxl iref type

2024-09-25 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 8a257ba535..f1274392f3 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8844,8 +8844,8 @@ static int m

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Implement CRC with -1 initial and final value

2024-09-25 Thread Leo Izen
On 9/25/24 4:06 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h| 1 + libavcodec/ffv1dec.c | 10 ++ libavcodec/ffv1enc.c | 12 +--- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv

[FFmpeg-devel] [PATCH 2/4] avformat/mov: add support for auxC box

2024-09-25 Thread James Almer
It's used to signal an item is an auxiliary image. Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 47 +- 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 472339

Re: [FFmpeg-devel] [PATCH 1/4] avformat/avformat: add a new disposition to signal the stream is an HDR gainmap

2024-09-25 Thread Anton Khirnov
Quoting James Almer (2024-09-26 00:52:16) > HDR images photos taken by certain cameras split this as a separate image. > > Signed-off-by: James Almer > --- > libavformat/avformat.h | 5 + > libavformat/dump.c | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/libavformat/avform

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mov: add referenced thumbnail streams to tile stream groups

2024-09-25 Thread Anton Khirnov
> Subject: avformat/mov: add referenced thumbnail streams to tile stream groups This could use some more explanation. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscrib

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mov: support parsing auxl iref type

2024-09-25 Thread Anton Khirnov
> Subject: avformat/mov: support parsing auxl iref type This could use some more explanation. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

[FFmpeg-devel] [PATCH v2] avcodec/videotoolbox: add AV1 hardware acceleration

2024-09-25 Thread Martin Storsjö
From: Jan Ekström Use AV1DecContext's current_obu to access the original OBUs, and feed them to videotoolbox, rather than the bare slice data passed via decode_slice. This requires a small addition to AV1DecContext, for keeping track of the current range of OBUs that belong to the current frame.

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale/aarch64: Fix rgb24toyv12 only works with aligned width

2024-09-25 Thread Martin Storsjö
On Wed, 25 Sep 2024, Zhao Zhili wrote: On Sep 25, 2024, at 16:01, Martin Storsjö wrote: On Tue, 24 Sep 2024, Zhao Zhili wrote: ffmpeg | branch: master | Zhao Zhili | Wed Sep 18 21:11:44 2024 +0800| [e18b46d95fadcbaaf450bda9f1871849f2b0c586] | committer: Zhao Zhili swscale/aarch64: Fix rg

Re: [FFmpeg-devel] [PATCH 2/7] lavfi/buffersink: add a flag for retrieving stream parameters

2024-09-25 Thread James Almer
On 9/25/2024 4:27 PM, Marton Balint wrote: On Wed, 25 Sep 2024, Nicolas George wrote: Anton Khirnov (12024-09-25): Because AVFilterLink is internal state of the filtergraph and should not be exposed at all. Anyway, if you cannot come up with an API that does not require dynamic allocations

Re: [FFmpeg-devel] [PATCH] doc: Add email URLs for Fate sample-request

2024-09-25 Thread Martin Schitter
On 25.09.24 21:30, Thilo Borgmann via ffmpeg-devel wrote: Am 20.09.24 um 02:50 schrieb Martin Schitter: Because I'm now waiting for one week that someone finally puts my contributed DNxUncompressed sample files to the Fate sample repo (see: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024

[FFmpeg-devel] [PATCH 1/2] configure: fix passing Objective-C flags

2024-09-25 Thread Marvin Scholz
Passing Objective-C flags from configure to the Makefiles was broken, as configure incorrectly used the OBJCCFLAGS instead of OBJCFLAGS variable which was then later overwritten in the common.mak: OBJCCFLAGS = $(CPPFLAGS) $(CFLAGS) $(OBJCFLAGS) The fix for this is simple, analogous to how it i

[FFmpeg-devel] [PATCH 2/2] configure: allow mixed declarations and code for Objective-C

2024-09-25 Thread Marvin Scholz
Mixing declarations and code is quite common in Objective-C (as can be seen by the number of warnings we have for this in Objective-C files) and forcing to not do it usually results in worse code, with unnecessary widely scoped variables, which in turn makes variable shadowing and accidentally usin

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add an LCEVC merger bsf

2024-09-25 Thread Anton Khirnov
Missing documentation. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/get_bits: dont add a null to a 0

2024-09-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-09-23 23:32:48) > Fixes: undefined behavior > Fixes: > 71747/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5427736120721408 Seems like a bug for a decoder to call init_get_bits() with a NULL buffer. -- Anton Khirnov _

Re: [FFmpeg-devel] [PATCH] doc: Add email URLs for Fate sample-request

2024-09-25 Thread Thilo Borgmann via ffmpeg-devel
Am 20.09.24 um 02:50 schrieb Martin Schitter: Because I'm now waiting for one week that someone finally puts my contributed DNxUncompressed sample files to the Fate sample repo (see: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333471.html), [...] I see a v6 version not yet o

[FFmpeg-devel] [PATCH] MAINTAINERS: update myself for dvdvideo, rcwtdec, rcwtenc

2024-09-25 Thread Marth64
I plan to look after and test them for the forseeable future. I am not a committer but do care for these muxers/demuxers. Signed-off-by: Marth64 --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 76651d5ff8..65fd9d6e86 100644

[FFmpeg-devel] [PATCH v3 1/2] avformat/utils: added av_get_frame_filename3() (changed parameter int -> int64_t)

2024-09-25 Thread Filip Mašić
On Wed, 25 Sept 2024 at 09:59, Marton Balint wrote: > In general AVBPrint based API for functions like this is preferred to > discuourage users from limiting the filenames to a fixed size (which > usually becomes a limitation sooner or later). > > E.g: av_get_frame_filename_bprint() > > Regards,

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

2024-09-25 Thread Martin Storsjö
On Tue, 24 Sep 2024, Cameron Gutman wrote: On Tue, Sep 24, 2024 at 7:16 AM Martin Storsjö wrote: I don't hit any issues with any AV1 samples that I have, I guess I don't have any samples with tile groups? Can you or someone else grab and share a small sample of a stream that fails to decode

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/utils: added av_get_frame_filename3() (changed parameter int -> int64_t)

2024-09-25 Thread Marton Balint
On Mon, 23 Sep 2024, Filip Mašić wrote: Resolves an integer overflow with the frame_pts option (issue 11194). Signed-off-by: Filip Mašić --- doc/APIchanges | 3 +++ libavformat/avformat.h | 7 +-- libavformat/img2enc.c | 6 ++ libavformat/utils.c| 12 +--- libavfo

Re: [FFmpeg-devel] [PATCH 2/7] lavfi/buffersink: add a flag for retrieving stream parameters

2024-09-25 Thread Marton Balint
On Mon, 23 Sep 2024, Anton Khirnov wrote: This way, av_buffersink_get_frame_flags() can replace almost all av_buffersink_get_*(), including some future parameters we will want to export. Why don't you simply expose the AVFilterLink which contains all the parameters of the sink? That seems

[FFmpeg-devel] FFmpeg 6.1.2 about vulkan h264 video decode

2024-09-25 Thread Wonskuis Yu(SH-RD)
Hi, When I use ffmpeg 6.1.2 to do transcode as flow cmd: ffmpeg.exe �Chwaccel vulkan �CI H264-4k.mp4 output.mp4 The assert of null pointer occur, after debug source code, I found the pointer of layered_frame is null, because it doesn’t created. Further, I found it only be created when d

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ffv1enc: Fix >8bit context size

2024-09-25 Thread Michael Niedermayer
On Wed, Sep 25, 2024 at 12:24:10AM +0200, Michael Niedermayer wrote: > Fixes: Ticket5405 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B1

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ffv1dec: Blow up if user asks for explosion

2024-09-25 Thread Michael Niedermayer
On Wed, Sep 25, 2024 at 12:24:08AM +0200, Michael Niedermayer wrote: > Fixes: Ticket8403 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1dec.c | 3 +++ > 1 file changed, 3 insertions(+) will apply -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No sn

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale/aarch64: Fix rgb24toyv12 only works with aligned width

2024-09-25 Thread Martin Storsjö
On Tue, 24 Sep 2024, Zhao Zhili wrote: ffmpeg | branch: master | Zhao Zhili | Wed Sep 18 21:11:44 2024 +0800| [e18b46d95fadcbaaf450bda9f1871849f2b0c586] | committer: Zhao Zhili swscale/aarch64: Fix rgb24toyv12 only works with aligned width Since c0666d8b, rgb24toyv12 is broken for width non

[FFmpeg-devel] [PATCH] avcodec/ffv1: Implement CRC with -1 initial and final value

2024-09-25 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h| 1 + libavcodec/ffv1dec.c | 10 ++ libavcodec/ffv1enc.c | 12 +--- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index 9aa04529228..06125d2be5f 100644 --- a/libav

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale/aarch64: Fix rgb24toyv12 only works with aligned width

2024-09-25 Thread Zhao Zhili
> On Sep 25, 2024, at 16:01, Martin Storsjö wrote: > > On Tue, 24 Sep 2024, Zhao Zhili wrote: > >> ffmpeg | branch: master | Zhao Zhili | Wed Sep 18 >> 21:11:44 2024 +0800| [e18b46d95fadcbaaf450bda9f1871849f2b0c586] | committer: >> Zhao Zhili >> >> swscale/aarch64: Fix rgb24toyv12 only wor

[FFmpeg-devel] [PATCH] MAINTAINERS: remove libopenjpeg decoder entry

2024-09-25 Thread Gyan Doshi
The decoder wrapper was removed in 60ccb3fe78 --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 76651d5ff8..c968fc765c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -206,7 +206,6 @@ Codecs: libgsm.c Michel Bardiaux

[FFmpeg-devel] [PATCH 06/22] lavfi/asrc_hilbert: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_hilbert.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavfilter/asrc_hilbert.c b/libavfilter/asrc_hilbert.c index e38af7123b..3cf5e8728e 100644 --- a/libavfilter/asrc_hilbert.c +++ b/libavfilter/asrc_hilbert.c @@ -75,7 +75,9 @@ static av_

[FFmpeg-devel] [PATCH 04/22] lavfi/asrc_anullsrc: convert to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop a redundant call that also happens implicitly in generic code. --- libavfilter/asrc_anullsrc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/asrc_anullsrc.c b/libavfilter/asrc_anullsrc.c index 3249cc33ad..d8fd5e7c06 100644 --- a/libavfilt

[FFmpeg-devel] [PATCH 03/22] lavfi/asrc_anoisesrc: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_anoisesrc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/asrc_anoisesrc.c b/libavfilter/asrc_anoisesrc.c index a67b2abe9c..0206fd69ce 100644 --- a/libavfilter/asrc_anoisesrc.c +++ b/libavfilter/asrc_anoisesrc.c @@ -83,24 +83,26

[FFmpeg-devel] [PATCH 01/22] lavfi/asrc_afdelaysrc: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_afdelaysrc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/asrc_afdelaysrc.c b/libavfilter/asrc_afdelaysrc.c index c235f0c27a..cb6f236ba6 100644 --- a/libavfilter/asrc_afdelaysrc.c +++ b/libavfilter/asrc_afdelaysrc.c @@ -80,22 +

[FFmpeg-devel] [PATCH 02/22] lavfi/asrc_afirsrc: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_afirsrc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavfilter/asrc_afirsrc.c b/libavfilter/asrc_afirsrc.c index bc450ec822..0ea611d837 100644 --- a/libavfilter/asrc_afirsrc.c +++ b/libavfilter/asrc_afirsrc.c @@ -113,24 +113,26 @@ st

[FFmpeg-devel] [PATCH 13/22] lavfi/avf_aphasemeter: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_aphasemeter.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/libavfilter/avf_aphasemeter.c b/libavfilter/avf_aphasemeter.c index fe0968c974..adcfcb3c5a

[FFmpeg-devel] [PATCH 17/22] lavfi/avf_showcwt: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showcwt.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libavfilter/avf_showcwt.c b/libavfilter/avf_showcwt.c index 760a07f2ff..dbb9fc7e2f 100644 --- a/libavfilt

[FFmpeg-devel] [PATCH 09/22] lavfi/*_vaapi: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/vaapi_vpp.c| 17 ++--- libavfilter/vaapi_vpp.h| 4 +++- libavfilter/vf_deinterlace_vaapi.c | 2 +- libavfilter/vf_drawbox_vaapi.c | 2 +- libavfilter/vf_misc_vaapi.c

[FFmpeg-devel] [PATCH 05/22] lavfi/asrc_flite: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_flite.c | 39 +-- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/libavfilter/asrc_flite.c b/libavfilter/asrc_flite.c index 5962bf55bb..1bbd329177 100644 --- a/libavfilter/asrc_flite.c +++ b/libavfilter/asrc_flite.c @@ -255,2

[FFmpeg-devel] [PATCH 07/22] lavfi/asrc_sinc: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_sinc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/asrc_sinc.c b/libavfilter/asrc_sinc.c index 94046f76b9..22b031a60d 100644 --- a/libavfilter/asrc_sinc.c +++ b/libavfilter/asrc_sinc.c @@ -74,22 +74,24 @@ static int activate(A

[FFmpeg-devel] [PATCH 11/22] lavfi/avf_abitscope: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_abitscope.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/libavfilter/avf_abitscope.c b/libavfilter/avf_abitscope.c index 30ed7d95e3..6d3a40d8d0 100644 --- a/l

[FFmpeg-devel] [PATCH 22/22] lavfi/avf_showwaves: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showwaves.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index 868e6a22d9..de73d8050f 100644 --- a/l

[FFmpeg-devel] [PATCH 08/22] lavfi/asrc_sine: convert to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/asrc_sine.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/asrc_sine.c b/libavfilter/asrc_sine.c index 2e444ba196..96b603dd26 100644 --- a/libavfilter/asrc_sine.c +++ b/libavfilter/asrc_sine.c @@ -178,22 +178,24 @@ static av_cold void

[FFmpeg-devel] [PATCH 15/22] lavfi/avf_concat: switch to query_func2()

2024-09-25 Thread Anton Khirnov
--- libavfilter/avf_concat.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index 2a3d4c8b52..5a4319123f 100644 --- a/libavfilter/avf_concat.c +++ b/libavfilter/avf_concat.c @@ -72,9 +72,11 @@ static con

[FFmpeg-devel] [PATCH 16/22] lavfi/avf_showcqt: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showcqt.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c index 00f679bc9e..9633f36edb 100644 --- a/libavfilt

[FFmpeg-devel] [PATCH 12/22] lavfi/avf_ahistogram: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_ahistogram.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/libavfilter/avf_ahistogram.c b/libavfilter/avf_ahistogram.c index b77307f137..baa95c0539 100644 --- a/li

[FFmpeg-devel] [PATCH 20/22] lavfi/avf_showspectrum: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showspectrum.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index 565f23c28b..c6594177eb 10064

[FFmpeg-devel] [PATCH 18/22] lavfi/avf_showfreqs: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showfreqs.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c index da31b3215e..91e3a339e4 100644 --- a/lib

[FFmpeg-devel] [PATCH 14/22] lavfi/avf_avectorscope: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_avectorscope.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/libavfilter/avf_avectorscope.c b/libavfilter/avf_avectorscope.c index 96bef32e2c..cfcedfda00 1006

[FFmpeg-devel] [PATCH 19/22] lavfi/avf_showspatial: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showspatial.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavfilter/avf_showspatial.c b/libavfilter/avf_showspatial.c index f7380f885a..285f2f1a81 100644 ---

[FFmpeg-devel] [PATCH 10/22] lavfi/avf_a3dscope: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_a3dscope.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libavfilter/avf_a3dscope.c b/libavfilter/avf_a3dscope.c index dd08990512..18f647e8a6 100644 --- a/libavf

[FFmpeg-devel] [PATCH 21/22] lavfi/avf_showvolume: switch to query_func2()

2024-09-25 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/avf_showvolume.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libavfilter/avf_showvolume.c b/libavfilter/avf_showvolume.c index d26fc8841d..8caabf5376 100644 --- a/

[FFmpeg-devel] [PATCH] fftools/ffplay: use swapchain_colorspace_hint to get better HDR support

2024-09-25 Thread Zhao Zhili
From: Zhao Zhili For example, the default surface configuration on macOS is: VK_FORMAT_A2B10G10R10_UNORM_PACK32 + VK_COLOR_SPACE_PASS_THROUGH_EXT With HDR10 content and swapchain_colorspace_hint, the surface configuration updated to: VK_FORMAT_A2B10G10R10_UNORM_PACK32 + VK_COLOR_SPACE_HDR10_ST20

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

2024-09-25 Thread Zhao Zhili
> On Sep 25, 2024, at 20:04, Martin Storsjö wrote: > > On Wed, 25 Sep 2024, Martin Storsjö wrote: > >> On Tue, 24 Sep 2024, Cameron Gutman wrote: >> >>> On Tue, Sep 24, 2024 at 7:16 AM Martin Storsjö wrote: I don't hit any issues with any AV1 samples that I have, I guess I don't ha

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

2024-09-25 Thread Martin Storsjö
On Wed, 25 Sep 2024, Martin Storsjö wrote: On Tue, 24 Sep 2024, Cameron Gutman wrote: On Tue, Sep 24, 2024 at 7:16 AM Martin Storsjö wrote: I don't hit any issues with any AV1 samples that I have, I guess I don't have any samples with tile groups? Can you or someone else grab and share a s

[FFmpeg-devel] [PATCH] configure: Silence Xcode warnings about duplicate libraries

2024-09-25 Thread Martin Storsjö
Since Xcode 15, macOS developer tools use a new linker. The new linker by default warns for duplicate -l options. As this is a known and expected thing, not to be considered an issue, ask for the warning to be silenced. This silences linker warnings like this: ld: warning: ignoring duplicate

Re: [FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

2024-09-25 Thread Nuo Mi
On Tue, Sep 24, 2024 at 11:44 PM Anton Khirnov wrote: > Quoting Nuo Mi (2024-09-24 16:56:46) > > On Tue, Sep 24, 2024 at 10:43 PM Nuo Mi wrote: > > > > Currently, the pure decode speed for 8K is around 27–30 fps. > > To achieve stable 8K@30 playback, we may need to go through several > rounds >

Re: [FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

2024-09-25 Thread Anton Khirnov
Quoting Nuo Mi (2024-09-25 14:37:43) > On Tue, Sep 24, 2024 at 11:44 PM Anton Khirnov wrote: > > > Quoting Nuo Mi (2024-09-24 16:56:46) > > > On Tue, Sep 24, 2024 at 10:43 PM Nuo Mi wrote: > > > > > > Currently, the pure decode speed for 8K is around 27–30 fps. > > > To achieve stable 8K@30 play

Re: [FFmpeg-devel] [PATCH 10/14] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

2024-09-25 Thread Ramiro Polla
On Tue, Sep 24, 2024 at 2:24 PM Michael Niedermayer wrote: > On Mon, Sep 23, 2024 at 02:40:13PM +0200, Ramiro Polla wrote: > > There is an issue with the constants used in YUV to YUV range conversion, > > where the upper bound is not respected when converting to mpeg range. > > > > With this commi

Re: [FFmpeg-devel] [PATCH 10/14] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

2024-09-25 Thread Ramiro Polla
On Wed, Sep 25, 2024 at 7:24 AM Derek Buitenhuis wrote: > On 9/23/2024 1:40 PM, Ramiro Polla wrote: > > { > > +#if 0 > > int cpu_flags = av_get_cpu_flags(); > > Are these '#if 0' throughout this patch intended? Yes, some simd code is disabled because the function changed. Instead of changin

Re: [FFmpeg-devel] [PATCH 11/14] swscale/x86/range_convert: update sse2 and avx2 range_convert functions to new API

2024-09-25 Thread Ramiro Polla
On Tue, Sep 24, 2024 at 6:39 PM Rémi Denis-Courmont wrote: > Le maanantaina 23. syyskuuta 2024, 15.40.14 EEST Ramiro Polla a écrit : > > chrRangeFromJpeg8_1920_c: 3874.8 ( 1.00x) > > chrRangeFromJpeg8_1920_sse2: 1493.8 ( 2.59x) > > chrRangeFromJ

Re: [FFmpeg-devel] [PATCH 08/10] swscale/swscale_unscaled: Fix odd height with nv24_to_yuv420p_chroma()

2024-09-25 Thread Ramiro Polla
On Tue, Sep 24, 2024 at 3:35 PM Michael Niedermayer wrote: > On Mon, Sep 23, 2024 at 12:42:22AM +0200, Ramiro Polla wrote: > > Hi, > > > > On Mon, Sep 23, 2024 at 12:04 AM Michael Niedermayer > > wrote: > > > > > > Fixes: out of array read > > > Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer

[FFmpeg-devel] [PATCH 06/10] lavfi/buffersink: allow av_buffersink_set_frame_size() to be called earlier

2024-09-25 Thread Anton Khirnov
The function currently writes directly into the input link, which requires it to be called after the filter has been linked. However, the documentation does not mention this restriction and the natural place to call av_buffersink_set_frame_size() during the options-setting stage, that is before fil

[FFmpeg-devel] [PATCH 02/10] doc/examples/decode_filter_audio: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
See previous commit for details. --- doc/examples/decode_filter_audio.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/doc/examples/decode_filter_audio.c b/doc/examples/decode_filter_audio.c index d637ca1724..6d148f7ab4 100644 --- a/doc/examples/decode_filter_aud

[FFmpeg-devel] [PATCH 09/10] lavd/lavfi: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
See previous commits for details. --- libavdevice/lavfi.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c index ce10d61f8a..17657a0638 100644 --- a/libavdevice/lavfi.c +++ b/libavdevice/lavfi.c @@ -249,18 +249,24 @@

[FFmpeg-devel] [PATCH 04/10] doc/examples/transcode: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
See previous commits for details. --- doc/examples/transcode.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index cbe5088ef6..7d1e1826a3 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/tra

[FFmpeg-devel] [PATCH 08/10] fftools/ffplay: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
This function creates AND initializes a filter, so setting any filter options after it is wrong. It happens to work when the filter's init function does not touch the options in question, but is forbidden by the API and is not guaranteed to remain functional. Instead, use avfilter_graph_alloc_filt

[FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_filter: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
This function creates AND initializes a filter, so setting any filter options after it is wrong. It happens to work when the filter's init function does not touch the options in question, but is forbidden by the API and is not guaranteed to remain functional. Instead, use avfilter_graph_alloc_filt

[FFmpeg-devel] [PATCH 07/10] doc/examples/transcode: handle audio encoder frame size restrictions

2024-09-25 Thread Anton Khirnov
--- doc/examples/transcode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 54fb315236..1dc1b50502 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -374,6 +374,9 @@ static int init_filter(FilteringContext* fct

[FFmpeg-devel] [PATCH 05/10] doc/examples/transcode: switch to avcodec_get_supported_config()

2024-09-25 Thread Anton Khirnov
--- doc/examples/transcode.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 7d1e1826a3..54fb315236 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -171,23 +171,38 @@ st

[FFmpeg-devel] [PATCH 03/10] doc/examples/decode_filter_video: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
See previous commits for details. --- doc/examples/decode_filter_video.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/doc/examples/decode_filter_video.c b/doc/examples/decode_filter_video.c index b91ca56d4e..4a5247dbf2 100644 --- a/doc/examples/decode_filter_vi

Re: [FFmpeg-devel] [PATCH 2/7] lavfi/buffersink: add a flag for retrieving stream parameters

2024-09-25 Thread Anton Khirnov
Quoting Marton Balint (2024-09-25 10:25:44) > > > On Mon, 23 Sep 2024, Anton Khirnov wrote: > > > This way, av_buffersink_get_frame_flags() can replace almost all > > av_buffersink_get_*(), including some future parameters we will want to > > export. > > Why don't you simply expose the AVFilter

[FFmpeg-devel] [PATCH 10/10] lavfi: clarify the behaviour of avfilter_graph_create_filter()

2024-09-25 Thread Anton Khirnov
Mention explicitly that no options can be set manually when using this function. --- libavfilter/avfilter.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 1401577c50..21066dd8da 100644 --- a/libavfilter/avfilter

Re: [FFmpeg-devel] [PATCH 2/7] lavfi/buffersink: add a flag for retrieving stream parameters

2024-09-25 Thread Nicolas George
Anton Khirnov (12024-09-25): > Because AVFilterLink is internal state of the filtergraph and should not > be exposed at all. Anyway, if you cannot come up with an API that does not require dynamic allocations and all the boilerplate code it requires just to retrieve a few integers, then drop the s

Re: [FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_filter: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-25 Thread Anton Khirnov
> fftools/ffmpeg_filter: stop using avfilter_graph_alloc_filter() incorrectly ^ Should be s/alloc/create/, fixed locally in all the commits. Thanks to ePirat for noticing. -- Anton Khirnov ___ ffmp

Re: [FFmpeg-devel] [PATCH 2/7] lavfi/buffersink: add a flag for retrieving stream parameters

2024-09-25 Thread Marton Balint
On Wed, 25 Sep 2024, Nicolas George wrote: Anton Khirnov (12024-09-25): Because AVFilterLink is internal state of the filtergraph and should not be exposed at all. Anyway, if you cannot come up with an API that does not require dynamic allocations and all the boilerplate code it requires j