On Sun, Aug 25, 2024 at 12:36 PM Nuo Mi wrote:
> Fixes:
>
> https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-tsan&time=20240823175808
>
> Reproduction steps:
> ./configure --enable-memory-poisoning --toolchain=gcc-tsan
> --disable-stripping && make fate-vvc
>
> Root cause:
> We hold t
On Sat, Aug 24, 2024 at 5:28 PM Frank Plowman wrote:
> Signed-off-by: Frank Plowman
> ---
> libavcodec/vvc/ctu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c
> index 139d3dded5..9ac3684ec9 100644
> --- a/libavcodec/vvc/
From: sunyuechi
C908 X60
vp9_avg_8tap_smooth_4hv_8bpp_c : 32.0 28.0
vp9_avg_8tap_smooth_4hv_8bpp_rvv_i32 : 15.0 13.2
vp9_avg_8tap_smooth_8hv_8bpp_c : 98.0 86.2
vp9_avg_8tap_smo
From: sunyuechi
C908 X60
vp9_avg_8tap_smooth_4h_8bpp_c : 12.7 11.2
vp9_avg_8tap_smooth_4h_8bpp_rvv_i32:4.74.2
vp9_avg_8tap_smooth_4v_8bpp_c : 29.7 12.5
vp9_avg_8tap_smo
> Does not assemble with binutils 2.43.1 and default flags.
Fixed through zve32x -> zve32x, zba
于2024年8月25日周日 19:40写道：
> From: sunyuechi
>
> C908 X60
> vp9_avg_8tap_smooth_4h_8bpp_c : 12.7 11.2
> vp9_avg_8tap_smoot
These assertions are not violated, even by illegal bitstreams.
Additionally, the upper bound should be <= 63, rather than < 63.
Signed-off-by: Frank Plowman
---
Changes since v1
(https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240824092842.69365-1-p...@frankplowman.com/):
* Remove the asserti
On 25/08/2024 09:11, Nuo Mi wrote:
> On Sat, Aug 24, 2024 at 5:28 PM Frank Plowman wrote:
>
>> Signed-off-by: Frank Plowman
>> ---
>> libavcodec/vvc/ctu.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c
>> index 139d3
Nuo Mi (12024-08-25):
> Thank you for the patch.
> Perhaps we can consider removing the assert, as other processes guarantee
> the range, correct?"
Uh, what?!?
The point of an assert is precisely to check that the “other processes”
that are supposed to guarantee something are really doing it.
W
On Sun, Aug 25, 2024 at 8:00 PM Nicolas George wrote:
> Nuo Mi (12024-08-25):
> > Thank you for the patch.
> > Perhaps we can consider removing the assert, as other processes
> guarantee
> > the range, correct?"
>
> Uh, what?!?
>
> The point of an assert is precisely to check that the “other pro
On Sat, Aug 24, 2024 at 5:01 PM Frank Plowman wrote:
> Hi,
>
> Thanks for your review.
>
> On 24/08/2024 04:40, Nuo Mi wrote:
> > Hi Frank,
> > thank you for the patch
> > On Fri, Aug 23, 2024 at 7:45 PM Frank Plowman
> wrote:
> >
> >> The previous logic relied on the subpicture boundaries coinc
Nuo Mi (12024-08-25):
> Thank you for the feedback.
> assert0 will cause a released program to crash, and we have a task to
> remove assert0 in the VVC decoder.
Then something needs to be fixed. Removing the assert is not a fix. It
might be worse than a fix: turning a crash into a silent corruptio
On Sat, Aug 24, 2024 at 5:28 PM Frank Plowman wrote:
> Implement the missing requirements from H.266 (V3) p. 106 on the width
> and height of subpictures whose dimensions are provided explicitly.
>
> Signed-off-by: Frank Plowman
> ---
> libavcodec/cbs_h266_syntax_template.c | 35 +++
On Sun, Aug 25, 2024 at 10:22 PM Nicolas George wrote:
> Nuo Mi (12024-08-25):
> > Thank you for the feedback.
> > assert0 will cause a released program to crash, and we have a task to
> > remove assert0 in the VVC decoder.
>
> Then something needs to be fixed. Removing the assert is not a fix. I
On Tue, Aug 20, 2024 at 9:22 PM Nuo Mi wrote:
> Major changes since v1:
> remove hadd and pmulld as James suggested
> reduce vextracti128
>
> I'll plan to merge next week to stay on track for the next release, unless
there are any objections
Thank you.
> Nuo Mi (4):
> avcodec/vvcdec: misc, ren
Nuo Mi (12024-08-25):
> Yes, I mean the v1. sorry for misleading you.
Ah, ok. Then… maybe.
Maybe v1 is the proper fix. Maybe the proper fix is to find where qPy_a
or qPy_b are set to 63 if they can only be <63 and fix that part of the
code. Only somebody who knows the codec can say which is the p
Implement the missing requirements from H.266 (V3) p. 106 on the
position and size of subpictures whose dimensions are provided
explicitly.
Signed-off-by: Frank Plowman
---
Changes since v1 (20240824092827.68912-1-p...@frankplowman.com):
* Use temporary variables and AV_CEIL_RSHIFT to make bound
On Thu, Aug 22, 2024, at 16:57, Ramiro Polla wrote:
> On Wed, Aug 21, 2024 at 1:26 PM J. Dekker wrote:
>>
>> Port dav1d's checkasm output format to FFmpeg's checkasm, includes
>> relative speedups and aligns results.
>>
>> Signed-off-by: J. Dekker
>> ---
>> tests/checkasm/checkasm.c | 53 +++
On Thu, Aug 22, 2024, at 16:57, Ramiro Polla wrote:
> On Wed, Aug 21, 2024 at 1:26 PM J. Dekker wrote:
>>
>> Port dav1d's checkasm output format to FFmpeg's checkasm, includes
>> relative speedups and aligns results.
>>
>> Signed-off-by: J. Dekker
>> ---
>> tests/checkasm/checkasm.c | 53 +
If there are no objections, I would like to merge this patch series on the
next week.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@f
On Sat, Aug 24, 2024 at 05:19:01PM +0200, Martin Schitter wrote:
> This is am implementation of an DNxUncomressed / SMPTE 50 decoder.
> It's not supporting all possible subtypes, but a wide range of them.
> For more info read the comment sections included in the source file.
>
> Please review this
On Sat, Aug 24, 2024 at 01:22:48PM +0200, AndreaMastroberti wrote:
> From: dre-droid <10736...@polimi.it>
>
> ---
> doc/filters.texi | 14 +++
> libavfilter/ssim.h| 8 +-
> libavfilter/version.h | 4 +-
> libavfilter/vf_ssim.c | 274 --
> 4 fi
From: Fei Wang
Signed-off-by: Fei Wang
---
doc/encoders.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 496852faeb..1035be0052 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -4105,7 +4105,7 @@ Setting this flag turn
From: Fei Wang
Signed-off-by: Fei Wang
---
doc/encoders.texi | 8
1 file changed, 8 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 1035be0052..0749417db4 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -4109,6 +4109,14 @@ by frame. Value: -1-default 0
From: Fei Wang
Signed-off-by: Fei Wang
---
libavcodec/qsvenc.h | 2 --
libavcodec/qsvenc_av1.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h
index e3eb083746..4bc77f2f7c 100644
--- a/libavcodec/qsvenc.h
+++ b/libavcodec/qsvenc.h
@@ -26,8 +26
24 matches
Mail list logo
