Re: [FFmpeg-devel] [PATCH] lavc/vvc: Prevent OOB access in subpic_tiles

2024-08-24 Thread Frank Plowman
Hi, Thanks for your review. On 24/08/2024 04:40, Nuo Mi wrote: > Hi Frank, > thank you for the patch > On Fri, Aug 23, 2024 at 7:45 PM Frank Plowman wrote: > >> The previous logic relied on the subpicture boundaries coinciding with >> the tile boundaries. Per 6.3.1 of H.266 (V3), vertical subp

[FFmpeg-devel] [PATCH] lavc/vvc: Validate explicit subpic locations

2024-08-24 Thread Frank Plowman
Implement the missing requirements from H.266 (V3) p. 106 on the width and height of subpictures whose dimensions are provided explicitly. Signed-off-by: Frank Plowman --- libavcodec/cbs_h266_syntax_template.c | 35 +-- 1 file changed, 28 insertions(+), 7 deletions(-) di

[FFmpeg-devel] [PATCH] lavc/vvc: Fix assertion bound on qPy_{a,b}

2024-08-24 Thread Frank Plowman
Signed-off-by: Frank Plowman --- libavcodec/vvc/ctu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c index 139d3dded5..9ac3684ec9 100644 --- a/libavcodec/vvc/ctu.c +++ b/libavcodec/vvc/ctu.c @@ -115,8 +115,8 @@ static int get_qp

[FFmpeg-devel] [PATCH] Integral images and Minkowski pooling for SSIM

2024-08-24 Thread Andrea Mastroberti
0001-Implemented-integral-images-and-minkowski-pooling.patch Description: 0001-Implemented-integral-images-and-minkowski-pooling.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe

[FFmpeg-devel] [PATCH] libavfilter: Integral Images and Minkowski pooling for SSIM

2024-08-24 Thread Andrea Mastroberti
--- Begin Message --- --- End Message --- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavfilter: integral images and minkowski pooling for SSIM

2024-08-24 Thread Andrea Mastroberti
--- Begin Message --- --- doc/filters.texi | 14 +++ libavfilter/ssim.h| 8 +- libavfilter/version.h | 4 +- libavfilter/vf_ssim.c | 274 -- 4 files changed, 289 insertions(+), 11 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi i

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-24 Thread Stefan Oltmanns via ffmpeg-devel
Am 23.08.24 um 14:25 schrieb Ramiro Polla: I finally managed to test the patches on a real Windows system. They both look good to me, I'll apply them in a couple of days if there are no other comments. It would be helpful to write a page in the trac wiki with a basic howto and common pitfalls.

[FFmpeg-devel] [PATCH] libavfilter: implemented integral images and minkowski pooling for SSIM

2024-08-24 Thread AndreaMastroberti
From: dre-droid <10736...@polimi.it> --- doc/filters.texi | 14 +++ libavfilter/ssim.h| 8 +- libavfilter/version.h | 4 +- libavfilter/vf_ssim.c | 274 -- 4 files changed, 289 insertions(+), 11 deletions(-) diff --git a/doc/filters.texi b/do

[FFmpeg-devel] [PATCH] avutil/cpu_internal: Provide ff_getauxval() wrapper for getauxvaul()

2024-08-24 Thread Brad Smith
avutil/cpu_internal: Provide ff_getauxval() wrapper for getauxvaul() Initially used for getauxval() but will be used to add support for other API. Signed-off-by: Brad Smith --- libavutil/aarch64/cpu.c | 4 ++-- libavutil/arm/cpu.c | 2 +- libavutil/cpu.c | 14 ++

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Skip dequeue buffer in draining state

2024-08-24 Thread Matthieu Bouron
On Fri, Aug 23, 2024 at 7:20 PM Zhao Zhili wrote: > > From: Zhao Zhili > > There is no more buffer to queue in draining state nit: There is no more input buffer to dequeue in draining state. > > Signed-off-by: Zhao Zhili > --- > libavcodec/mediacodecdec.c | 2 +- > 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH v2] avcodec: add Mediacodec audio decoders support

2024-08-24 Thread Matthieu Bouron
--- Diff with the v1: - dropped support of ENCODING_PCM_24BIT_PACKED as it uses 3 consecutive bytes for one sample and there is no direct AVSampleFormat equivalent (that would require a dedicated copy routine to copy the 3 bytes into the 4 bytes provided by AV_SAMPLE_FMT_S32). I believe this

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Skip dequeue buffer in draining state

2024-08-24 Thread Zhao Zhili
> On Aug 24, 2024, at 22:11, Matthieu Bouron wrote: > > On Fri, Aug 23, 2024 at 7:20 PM Zhao Zhili wrote: >> >> From: Zhao Zhili >> >> There is no more buffer to queue in draining state > > nit: There is no more input buffer to dequeue in draining state. Actually I mean there is no more d

[FFmpeg-devel] [PATCH] libavcodec: Implementation of DNxUncompressed decoder

2024-08-24 Thread Martin Schitter
This is am implementation of an DNxUncomressed / SMPTE 50 decoder. It's not supporting all possible subtypes, but a wide range of them. For more info read the comment sections included in the source file. Please review this contribution and merge it. thanks martin --- Changelog

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Skip dequeue buffer in draining state

2024-08-24 Thread Matthieu Bouron
On Sat, Aug 24, 2024 at 5:07 PM Zhao Zhili wrote: > > > > > On Aug 24, 2024, at 22:11, Matthieu Bouron > > wrote: > > > > On Fri, Aug 23, 2024 at 7:20 PM Zhao Zhili wrote: > >> > >> From: Zhao Zhili > >> > >> There is no more buffer to queue in draining state > > > > nit: There is no more inpu

Re: [FFmpeg-devel] [RFC] 7.1 Release

2024-08-24 Thread Michael Niedermayer
On Wed, Aug 14, 2024 at 02:41:55PM +0200, Michael Niedermayer wrote: > Hi all > > Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? > If so please reply here and list the date before which we would have to > finish the 7.1 release so it can be included with no problems >

[FFmpeg-devel] [PATCH] avcodec/vvcdec: fix potential deadlock in report_frame_progress

2024-08-24 Thread Nuo Mi
Fixes: https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-tsan&time=20240823175808 Reproduction steps: ./configure --enable-memory-poisoning --toolchain=gcc-tsan --disable-stripping && make fate-vvc Root cause: We hold the current frame's lock while updating progress for other frames.

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-08-24 Thread Nuo Mi
On Sat, Aug 24, 2024 at 5:40 AM James Almer wrote: > On 8/23/2024 10:17 AM, Anton Khirnov wrote: > > tsan reports races in the decoder, it would be nice if someone could > > look at them before this goes in. > > Not data races, but "lock-order-inversion (potential deadlock)", which > sounds worse