[FFmpeg-devel] [PATCH v2 1/2] avformat/mxfenc: Fix guess frame_rate

2024-08-23 Thread Nicolas Gaullier
The time_base was a bad guess. Currently, fate-time_base test data assumed that overriding the input time_base would affect the frame_rate, but this behaviour is not documented, so just fix the fate data now that this is fixed. Fix regression since 10185e2d4c1e9839bc58a1d6a63c861677b13fd0: previo

[FFmpeg-devel] [PATCH v2 2/2] tests: Remove void time_base overrides when streamcopying to mxf

2024-08-23 Thread Nicolas Gaullier
For fate-copy-trac4914, this is a revert of 10185e2d4c1e9839bc58a1d6a63c861677b13fd0. Signed-off-by: Nicolas Gaullier --- tests/fate/ffmpeg.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 9e0c68da20..4f15356e0e 10064

[FFmpeg-devel] [PATCH v2 0/2] avformat/mxfenc: Fix guess frame_rate

2024-08-23 Thread Nicolas Gaullier
v2: - keep time_base as default if frame_rate is undetermined - fix mixed declaration and code Nicolas Gaullier (2): avformat/mxfenc: Fix guess frame_rate tests: Remove void time_base overrides when streamcopying to mxf libavformat/mxfenc.c | 6 +- tests/fate/ffmpeg.mak| 4 ++--

[FFmpeg-devel] [PATCH] avfilter: add pu21 filter

2024-08-23 Thread Rajiv Harlalka
Adds the PU21 encoding filter for high dynamic range images and video quality assessment Mantiuk, R., & Azimi, M. PU21: A novel perceptually uniform encoding for adapting existing quality metrics for HDR https://github.com/gfxdisp/pu21 Signed-off-by: Rajiv Harlalka --- Changelog

[FFmpeg-devel] [PATCH v2] avfilter: add pu21 filter

2024-08-23 Thread Rajiv Harlalka
Adds the PU21 encoding filter for high dynamic range images and video quality assessment Mantiuk, R., & Azimi, M. PU21: A novel perceptually uniform encoding for adapting existing quality metrics for HDR https://github.com/gfxdisp/pu21 --- Changelog| 1 + libavfilter/Makefile

[FFmpeg-devel] [PATCH] lavc/vvc: Prevent OOB access in subpic_tiles

2024-08-23 Thread Frank Plowman
The previous logic relied on the subpicture boundaries coinciding with the tile boundaries. Per 6.3.1 of H.266 (V3), vertical subpicture boundaries are always tile boundaries however the same cannot be said for horizontal subpicture boundaries. Furthermore, it is possible to construct an illegal

[FFmpeg-devel] [PATCH] tools/target_{bsf, dec}_fuzzer: Stop skipping end of input

2024-08-23 Thread Frank Plowman
For the final input in a file, the while loop above will not break and as a result data + sizeof(fuzz_tag) == end when it exits. There is an off-by-one error in the changed line, which is meant to handle this case. The result is that the final 8 bytes of all input files are skipped. Signed-off

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-23 Thread Ramiro Polla
On Tue, Jul 30, 2024 at 4:12 PM Ramiro Polla wrote: > On Mon, Jul 29, 2024 at 5:56 AM Stefan Oltmanns via ffmpeg-devel > wrote: > > Am 28.07.24 um 15:15 schrieb Ramiro Polla: > > > I think calling win32_dlopen() with a full path will be problematic for > > > systems without KB2533623. win32_dlope

[FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-08-23 Thread Frank Plowman
This reverts commit 110d8549d575aae6b2f627cd63e2eb7082ab8926. I have been working through fixing bugs, particularly crashes I've found using a fuzzer, in the VVC decoder for the past few months. While I won't claim it is now bug-free, it is considerably more resilient than it was and I think in a

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-08-23 Thread Nuo Mi
On Fri, Aug 23, 2024 at 8:37 PM Frank Plowman wrote: > This reverts commit 110d8549d575aae6b2f627cd63e2eb7082ab8926. > > I have been working through fixing bugs, particularly crashes I've > found using a fuzzer, in the VVC decoder for the past few months. > While I won't claim it is now bug-free,

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-08-23 Thread Anton Khirnov
tsan reports races in the decoder, it would be nice if someone could look at them before this goes in. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link ab

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-08-23 Thread James Almer
On 8/23/2024 10:17 AM, Anton Khirnov wrote: tsan reports races in the decoder, it would be nice if someone could look at them before this goes in. Not data races, but "lock-order-inversion (potential deadlock)", which sounds worse. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-08-23 Thread Nuo Mi
On Fri, Aug 23, 2024 at 9:17 PM Anton Khirnov wrote: > tsan reports races in the decoder, it would be nice if someone could > look at them before this goes in. > sure, I will check > > -- > Anton Khirnov > ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

[FFmpeg-devel] [PATCH 1/2] avcodec/vvcdec: filter, fix uninitialized variables for YUV400 format

2024-08-23 Thread Nuo Mi
fix ==135000== Conditional jump or move depends on uninitialised value(s) ==135000==at 0x169FF95: vvc_deblock_bs (filter.c:699) and ==135000== Conditional jump or move depends on uninitialised value(s) ==135000==at 0x16A2E72: ff_vvc_alf_filter (filter.c:1217) Reported-by: James Almer ---

[FFmpeg-devel] [PATCH 2/2] avcodec/vvcdec: format, fix indent for vvc_deblock_bs

2024-08-23 Thread Nuo Mi
--- libavcodec/vvc/filter.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index aa0d542271..25bef45eed 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -680,12 +680,12 @@ typedef void (*debloc

Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: Merge header into .c

2024-08-23 Thread Zhao Zhili
> On Aug 14, 2024, at 21:36, Zhao Zhili wrote: > > From: Zhao Zhili > > It was shared with opencl implementation. Ping. Any comments? > --- > libavfilter/unsharp.h| 62 > libavfilter/vf_unsharp.c | 34 +- > 2 files changed, 33 i

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: Fix leaking of supported_props

2024-08-23 Thread Zhao Zhili
From: Zhao Zhili There are two VTCompressionSessionRef been created, one for generating extradata, and another for normal encoding. supported_props was been overwritten without release. --- libavcodec/videotoolboxenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/videotoolb

Re: [FFmpeg-devel] [PATCH v2] avfilter: add pu21 filter

2024-08-23 Thread Frank Plowman
Thank you for your patch. Some comments inline. On 23/08/2024 10:07, Rajiv Harlalka wrote: > Adds the PU21 encoding filter for high dynamic range images and video > quality assessment > Mantiuk, R., & Azimi, M. PU21: A novel perceptually uniform encoding for > adapting existing quality metrics fo

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Skip dequeue buffer in draining state

2024-08-23 Thread Zhao Zhili
From: Zhao Zhili There is no more buffer to queue in draining state Signed-off-by: Zhao Zhili --- libavcodec/mediacodecdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index 6d8dc600fe..0da5fe6729 100644 --- a/lib

[FFmpeg-devel] [PATCH v3 1/3] avfilter: add pu21 filter

2024-08-23 Thread Rajiv Harlalka
Adds the PU21 encoding filter for high dynamic range images and video quality assessment Mantiuk, R., & Azimi, M. PU21: A novel perceptually uniform encoding for adapting existing quality metrics for HDR https://github.com/gfxdisp/pu21 Signed-off-by: Rajiv Harlalka --- Changelog

[FFmpeg-devel] [PATCH v3 2/3] suppress build warnings

2024-08-23 Thread Rajiv Harlalka
Signed-off-by: Rajiv Harlalka --- libavfilter/vf_pu21.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_pu21.c b/libavfilter/vf_pu21.c index c3b56f9c1b..e47ef065e8 100644 --- a/libavfilter/vf_pu21.c +++ b/libavfilter/vf_pu21.c @@ -8,7 +8,7 @@ #include "li

[FFmpeg-devel] [PATCH v3 3/3] add license header

2024-08-23 Thread Rajiv Harlalka
Signed-off-by: Rajiv Harlalka --- libavfilter/vf_pu21.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavfilter/vf_pu21.c b/libavfilter/vf_pu21.c index e47ef065e8..9935071dc2 100644 --- a/libavfilter/vf_pu21.c +++ b/libavfilter/vf_pu21.c @@ -1,3 +1,20 @@ +/* + * This fi

Re: [FFmpeg-devel] [PATCH v3 2/3] suppress build warnings

2024-08-23 Thread Zhao Zhili
Please squash these patches into a single one. We don’t use a incomplete patch and then fix it with another one (of course unless the first one has already got merged). > On Aug 24, 2024, at 01:23, Rajiv Harlalka wrote: > > Signed-off-by: Rajiv Harlalka > --- > libavfilter/vf_pu21.c | 6 ++---

[FFmpeg-devel] [PATCH v4] avfilter: add pu21 filter

2024-08-23 Thread Rajiv Harlalka
Adds the PU21 encoding filter for high dynamic range images and video quality assessment Mantiuk, R., & Azimi, M. PU21: A novel perceptually uniform encoding for adapting existing quality metrics for HDR https://github.com/gfxdisp/pu21 Signed-off-by: Rajiv Harlalka --- Changelog|

Re: [FFmpeg-devel] [PATCH 1/3] lavu/opt: document underlying C types for enum AVOptionType

2024-08-23 Thread Michael Niedermayer
On Thu, Aug 22, 2024 at 02:39:10PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-08-20 22:57:37) > > Hi > > > > On Sun, Aug 18, 2024 at 01:26:53PM +0200, Anton Khirnov wrote: > > > --- > > > libavutil/opt.h | 78 +++-- > > > 1 file cha

Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: Merge header into .c

2024-08-23 Thread Michael Niedermayer
On Sat, Aug 24, 2024 at 12:39:13AM +0800, Zhao Zhili wrote: > > > On Aug 14, 2024, at 21:36, Zhao Zhili wrote: > > > > From: Zhao Zhili > > > > It was shared with opencl implementation. > > Ping. Any comments? not my filter but patch looks trivial, LGTM thx [...] -- Michael GnuPG fing

Re: [FFmpeg-devel] [RFC] 7.1 Release

2024-08-23 Thread Neal Gompa
On Wed, Aug 14, 2024 at 11:11 AM Michael Niedermayer wrote: > > Hi all > > Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? > If so please reply here and list the date before which we would have to > finish the 7.1 release so it can be included with no problems > > Other

Re: [FFmpeg-devel] [PATCH v3] avfilter: add XPSNR filter

2024-08-23 Thread Michael Niedermayer
On Thu, Jul 04, 2024 at 03:50:34PM +, Helmrich, Christian wrote: > This is a continuation of last year's version of this filter patch, see also > > https://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305517.html > > It includes a fix in one of the stride variables and some cleanup in order

Re: [FFmpeg-devel] [PATCH v2 1/7] avcodec/x86/mpegvideoencdsp: support negative strides in draw_edges_mmx()

2024-08-23 Thread Michael Niedermayer
On Wed, Aug 21, 2024 at 04:55:49PM +0200, Ramiro Polla wrote: > --- > libavcodec/x86/mpegvideoencdsp_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is a danger to trust the dream

Re: [FFmpeg-devel] [PATCH] tools/target_{bsf, dec}_fuzzer: Stop skipping end of input

2024-08-23 Thread Michael Niedermayer
On Fri, Aug 23, 2024 at 12:49:30PM +0100, Frank Plowman wrote: > For the final input in a file, the while loop above will not break and > as a result > > data + sizeof(fuzz_tag) == end > > when it exits. There is an off-by-one error in the changed line, > which is meant to handle this case. The

[FFmpeg-devel] [PATCH v1 0/1] avfilter/vf_libvmaf: Add metadata propagation support

2024-08-23 Thread Yigithan Yigit
This patch adds metadata propagation support to vf_libvmaf filter according to changes in libvmaf library. For test you should set vmaf_version < 3.0.0 in filter. Yigithan Yigit (1): avfilter/vf_libvmaf: Add metadata propagation support libavfilter/vf_libvmaf.c | 271 ++

[FFmpeg-devel] [PATCH v1] avfilter/vf_libvmaf: Add metadata propagation support

2024-08-23 Thread Yigithan Yigit
--- libavfilter/vf_libvmaf.c | 271 +++ 1 file changed, 271 insertions(+) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index f655092b20..0b4a63cf92 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/vf_libvmaf.c @@ -27,8 +27,11 @@ #inc

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Prevent OOB access in subpic_tiles

2024-08-23 Thread Nuo Mi
Hi Frank, thank you for the patch On Fri, Aug 23, 2024 at 7:45 PM Frank Plowman wrote: > The previous logic relied on the subpicture boundaries coinciding with > the tile boundaries. Per 6.3.1 of H.266 (V3), vertical subpicture > boundaries are always tile boundaries however the same cannot be s