[FFmpeg-devel] [PATCH] tools/target_enc_fuzzer: Add slices and level for FFv1

2024-08-11 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- tools/target_enc_fuzzer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/target_enc_fuzzer.c b/tools/target_enc_fuzzer.c index 059d7830710..59c2db4bb42 100644 --- a/tools/target_enc_fuzzer.c +++ b/tools/target_e

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-11 Thread Stefan Oltmanns via ffmpeg-devel
Am 30.07.24 um 16:12 schrieb Ramiro Polla: On Mon, Jul 29, 2024 at 5:56 AM Stefan Oltmanns via ffmpeg-devel wrote: Am 28.07.24 um 15:15 schrieb Ramiro Polla: I think calling win32_dlopen() with a full path will be problematic for systems without KB2533623. win32_dlopen() might need to be fixed

[FFmpeg-devel] [PATCH] lavc/libx265: unbreak build for X265_BUILD >= 210

2024-08-11 Thread Gyan Doshi
x265 added support for alpha starting with build 210. While doing so, x265_encoder_encode() changed its fifth arg to an array of pointers to x265_picture. This broke building lavc/libx265.c This patch simply unbreaks the build and maintains existing single-layer non-alpha encoding support. Fixes

Re: [FFmpeg-devel] [PATCH 1/3] avformat/lmlm4: Move subtraction after check

2024-08-11 Thread Michael Niedermayer
On Sat, Jul 13, 2024 at 05:51:03PM +0200, Michael Niedermayer wrote: > This is not a bugfix in code but coverity only, it does look a little nicer > though > > Fixes: CID732224 > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/lmlm4.c | 2 +- > 1 fi

Re: [FFmpeg-devel] [PATCH v2] avfilter/af_surround: Check output format

2024-08-11 Thread Michael Niedermayer
On Fri, Jul 12, 2024 at 10:18:09PM +0200, Michael Niedermayer wrote: > Fixes: CID1516994 Out-of-bounds access > Fixes: CID1516996 Out-of-bounds access > Fixes: CID1516999 Out-of-bounds access > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_surrou

Re: [FFmpeg-devel] [PATCH 3/6] avfilter/vf_tpad: Dont clone NULL

2024-08-11 Thread Michael Niedermayer
On Thu, Jul 11, 2024 at 12:50:09AM +0200, Michael Niedermayer wrote: > untested > > Fixes: CID1440836 Dereference after null check will apply patchset except this [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsib

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/aac/aacdec_usac: Avoid doing the same thing twice each iteration

2024-08-11 Thread Michael Niedermayer
On Sun, Jul 21, 2024 at 03:56:16PM +0200, Michael Niedermayer wrote: > On Mon, Jul 01, 2024 at 01:12:49AM +0200, Michael Niedermayer wrote: > > This requires review by the author of the code, i have just changed > > this so it looks plausible, this needs to be checked against the spec > > > > Fixe

Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame()

2024-08-11 Thread Michael Niedermayer
On Sun, Jul 07, 2024 at 09:48:40PM +0200, Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 10:27:55PM +0200, Michael Niedermayer wrote: > > On Sun, Jun 02, 2024 at 09:10:33PM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > Fixes: CID1591924 Uninitialized scalar variable > >

Re: [FFmpeg-devel] [PATCH 3/3] checkasm: add tests for vvc dmvr

2024-08-11 Thread Nuo Mi
will apply next week if there are no objections On Fri, Jul 26, 2024 at 3:42 PM Nuo Mi wrote: > > > On Fri, Jul 26, 2024 at 9:36 AM James Almer wrote: > >> On 7/25/2024 10:35 AM, Nuo Mi wrote: >> > dmvr_8_12x20_c: 186.2 >> > dmvr_8_12x20_avx2: 25.7 >> > dmvr_8_20x12_c: 181.7 >> > dmvr_8_20x12_a

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: move frame tab memset from the main thread to worker threads

2024-08-11 Thread Nuo Mi
On Sun, Jul 28, 2024 at 11:19 AM Nuo Mi wrote: > memset tables in the main thread can become a bottleneck for the decoder. > For example, if it takes 1% of the processing time for one core, the > maximum achievable FPS will be 100. > Move the memeset to worker threads will fix the issue. > will a

[FFmpeg-devel] [PATCH 01/10] lavfi: set AVFilterLink.graph on link creation

2024-08-11 Thread Anton Khirnov
There is no reason to delay this. --- libavfilter/avfilter.c | 1 + libavfilter/avfiltergraph.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 2dc8820184..c4bd134fb2 100644 --- a/libavfilter/avfilter.c +++ b/libavfil

[FFmpeg-devel] [PATCH 02/10] lavfi: add a new struct for private link properties

2024-08-11 Thread Anton Khirnov
Specifically those that should be visible to filters, but hidden from API callers. Such properties are currently located at the end of the public AVFilterLink struct, demarcated by a comment marking them as private. However it is generally better to hide them explicitly, using the same pattern alre

[FFmpeg-devel] [PATCH 04/10] lavfi/vf_*_cuda: do not access hw contexts before checking they exist

2024-08-11 Thread Anton Khirnov
The checks are performed in init_processing_chain(). --- libavfilter/vf_bilateral_cuda.c | 13 - libavfilter/vf_chromakey_cuda.c | 13 - libavfilter/vf_colorspace_cuda.c | 14 -- libavfilter/vf_scale_cuda.c | 13 - 4 files changed, 32 insertio

[FFmpeg-devel] [PATCH 06/10] lavfi: move AVFilterLink.current_pts(_us) to FilterLink

2024-08-11 Thread Anton Khirnov
--- libavfilter/avfilter.c | 14 +++--- libavfilter/avfilter.h | 12 libavfilter/avfiltergraph.c | 6 +++--- libavfilter/f_graphmonitor.c | 5 +++-- libavfilter/filters.h| 12 5 files changed, 25 insertions(+), 24 deletions(-) diff --git a/

[FFmpeg-devel] [PATCH 05/10] lavfi: move AVFilterLink.hw_frames_ctx to FilterLink

2024-08-11 Thread Anton Khirnov
--- libavfilter/avfilter.c | 24 +++- libavfilter/avfilter.h | 6 -- libavfilter/buffersink.c| 7 ++- libavfilter/buffersrc.c | 5 +++-- libavfilter/filters.h | 8 libavfilter/opencl.c

[FFmpeg-devel] [PATCH 08/10] lavfi: move AVFilterLink.{frame, sample}_count_{in, out} to FilterLink

2024-08-11 Thread Anton Khirnov
--- libavfilter/af_adrc.c | 3 ++- libavfilter/af_afftdn.c | 3 ++- libavfilter/af_ashowinfo.c| 4 +++- libavfilter/af_dynaudnorm.c | 3 ++- libavfilter/af_volume.c | 4 +++- libavfilter/asrc_sine.c | 3 ++- libavfilter/avf_showfreqs.c | 5 +++-- libavfilte

[FFmpeg-devel] [PATCH 10/10] lavfi: move AVFilterLink.graph to FilterLink

2024-08-11 Thread Anton Khirnov
--- libavfilter/avfilter.c | 6 +++--- libavfilter/avfilter.h | 5 - libavfilter/avfiltergraph.c | 2 +- libavfilter/f_sendcmd.c | 2 +- libavfilter/filters.h | 5 + 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/av

[FFmpeg-devel] [PATCH 03/10] lavfi: move AVFilterLink.m{ax, in}_samples to FilterLink

2024-08-11 Thread Anton Khirnov
Also, document who sets these fields and when. --- libavfilter/af_firequalizer.c | 4 +++- libavfilter/af_lv2.c | 3 ++- libavfilter/af_replaygain.c | 6 -- libavfilter/avfilter.c| 13 +++-- libavfilter/avfilter.h| 15 --- libavfilter/buffersin

[FFmpeg-devel] [PATCH 09/10] lavfi: move AVFilterLink.frame_wanted_out to FilterLinkInternal

2024-08-11 Thread Anton Khirnov
--- libavfilter/avfilter.c | 22 ++ libavfilter/avfilter.h | 7 --- libavfilter/avfilter_internal.h | 7 +++ libavfilter/avfiltergraph.c | 2 +- libavfilter/buffersink.c| 3 ++- libavfilter/filters.h | 5 + 6 files change

[FFmpeg-devel] [PATCH 07/10] lavfi: move AVFilterLink.frame_rate to FilterLink

2024-08-11 Thread Anton Khirnov
Co-developed-by: James Almer --- libavfilter/af_aiir.c | 6 -- libavfilter/avf_a3dscope.c | 5 +++-- libavfilter/avf_abitscope.c| 5 +++-- libavfilter/avf_ahistogram.c | 5 +++-- libavfilter/avf_aphasemeter.c | 5 +++-- libavfilter/avf_avectorscope

[FFmpeg-devel] avformat/mxf: improve parsing

2024-08-11 Thread Marc-Antoine ARNAUD
-- Marc-Antoine ARNAUD CEO & Founder mobile: +33 6 84 71 84 45 email: arnaud.marc-anto...@luminvent.com website: luminvent.com 0002-avformat-mxf-stop-parsing-if-index-table-is-coherent.patch Description: Binary data 0001-avformat-mxf-start-to-add-mxf_inspect_mode-and-skip-.patch Descrip

Re: [FFmpeg-devel] avformat/mxf: improve parsing

2024-08-11 Thread Marc-Antoine ARNAUD
Yes but it's incorrect for now regarding https://ffmpeg.org/pipermail/ffmpeg-devel/2024-August/thread.html And the CI build is not started: https://patchwork.ffmpeg.org/project/ffmpeg/list/ I have to send another email ... Le dim. 11 août 2024 à 17:52, Robert Nagy a écrit : > Thx. Did you send

[FFmpeg-devel] avformat/mxf: improve parsing

2024-08-11 Thread Marc-Antoine ARNAUD
-- Marc-Antoine ARNAUD CEO & Founder mobile: +33 6 84 71 84 45 email: arnaud.marc-anto...@luminvent.com website: luminvent.com --- Begin Message --- sponsored by nxtedition Signed-off-by: Marc-Antoine Arnaud --- libavformat/mxfdec.c | 56 1 fi

Re: [FFmpeg-devel] PATCH: Fallback to NV12 format in VAAPI drivers

2024-08-11 Thread Mark Thompson
On 10/08/2024 09:51, Lluís Batlle i Rossell wrote: > On Fri, Aug 09, 2024 at 09:43:53AM +0200, Lluís Batlle i Rossell wrote: >> On Fri, Aug 09, 2024 at 11:49:54AM +0800, Zhao Zhili wrote: vaapi drivers often lack proper image converesions and not all situations allow vagetimage or vaputim

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_vp9: Try to store fewer than 2 things in the same bit

2024-08-11 Thread Mark Thompson
On 08/08/2024 00:53, Michael Niedermayer wrote: > Fixes: use of uninitialized value > Fixes: > 70907/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_METADATA_fuzzer-6339363208757248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-o

[FFmpeg-devel] [PATCH] cbs_vp9: Ensure that the two superframe_header instances are identical

2024-08-11 Thread Mark Thompson
Fixes: use of uninitialized value Fixes: 70907/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_METADATA_fuzzer-6339363208757248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg --- On 11/08/2024 19:05, Mark Thompson wrote: > The correct fix theref

Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support.

2024-08-11 Thread Mark Thompson
On 30/07/2024 21:02, David (Ming Qiang) Wu via ffmpeg-devel wrote: > AV1Profile2 VAAPI is supported and tested on AMD VCN5. > > Signed-off-by: David (Ming Qiang) Wu > --- > libavcodec/av1dec.c | 3 +++ > libavcodec/vaapi_decode.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support.

2024-08-11 Thread Mark Thompson
On 11/08/2024 19:27, Mark Thompson wrote: > On 30/07/2024 21:02, David (Ming Qiang) Wu via ffmpeg-devel wrote: >> AV1Profile2 VAAPI is supported and tested on AMD VCN5. >> >> Signed-off-by: David (Ming Qiang) Wu >> --- >> libavcodec/av1dec.c | 3 +++ >> libavcodec/vaapi_decode.c | 3 +++ >>

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use stream indexes when generating track ids

2024-08-11 Thread Marton Balint
On Sat, 3 Aug 2024, James Almer wrote: In some scenarios nb_tracks isn't the same as nb_streams, so a given id may end up being used for two separate streams. e.g. when muxing an IAMF track followed by a video track, if the IAMF track consists of several streams, the video track would end up

Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-08-11 Thread Stephen Hutchinson
On 7/28/24 11:59 AM, Stephen Hutchinson wrote: On 7/28/24 9:38 AM, Ramiro Polla wrote: @@ -1134,6 +1089,7 @@ static av_cold int avisynth_read_close(AVFormatContext *s)   return AVERROR_UNKNOWN;   avisynth_context_destroy(s->priv_data); +    dlclose(avs_library.library); Maybe it'

Re: [FFmpeg-devel] PATCH: Fallback to NV12 format in VAAPI drivers

2024-08-11 Thread Lluís Batlle i Rossell
On Sun, Aug 11, 2024 at 06:57:49PM +0100, Mark Thompson wrote: > On 10/08/2024 09:51, Lluís Batlle i Rossell wrote: > > On Fri, Aug 09, 2024 at 09:43:53AM +0200, Lluís Batlle i Rossell wrote: > >> On Fri, Aug 09, 2024 at 11:49:54AM +0800, Zhao Zhili wrote: > vaapi drivers often lack proper ima

Re: [FFmpeg-devel] [PATCH] tools/target_enc_fuzzer: Add slices and level for FFv1

2024-08-11 Thread Kacper Michajlow
On Sun, 11 Aug 2024 at 10:59, Michael Niedermayer wrote: > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > tools/target_enc_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/target_enc_fuzzer.c b/tools/target_enc_fuzzer.c > index 059d78307

Re: [FFmpeg-devel] [PATCH] tools/target_enc_fuzzer: Add slices and level for FFv1

2024-08-11 Thread Kacper Michajlow
On Mon, 12 Aug 2024 at 02:06, Kacper Michajlow wrote: > > On Sun, 11 Aug 2024 at 10:59, Michael Niedermayer > wrote: > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > tools/target_enc_fuzzer.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --

[FFmpeg-devel] Can't use __musl__ macro

2024-08-11 Thread Lance Fredrickson
Hi all,  I use ffmpeg by way of minidlna. In commit 9e674b31606c805dd31b4bb754364a72a5877238 of ffmpeg this change tries to detect musl libc by way of a "__musl__" macro.  This macro however, doesn't exist in musl. This results in an "incompatible pointer type" error under gcc-14.2 as detectio

[FFmpeg-devel] [PATCH] avformat/movenc: don't look at previous track_id as it may not be set

2024-08-11 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8d91059081..d20e45cf81 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4952,7 +4952,7 @@ static int mov_setup_