Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: call MediaCodec.stop on close

2024-08-08 Thread Zhao Zhili
> On Aug 8, 2024, at 00:27, sfan5 wrote: > > Hi all, > > attached is a small fix for the MediaCodec code. Tested on Android 14. > This can free up vital resources in case of using multiple > decoding instances and there are buffer references left over > and not immediately cleaned up. > > Si

Re: [FFmpeg-devel] [PATCH v1] libavdevice/gdigrab: change hwnd tail check fail logic to !=null

2024-08-08 Thread Zhao Zhili
> On Aug 7, 2024, at 23:58, cyfdel-at-hotmail@ffmpeg.org wrote: > > From: eaphone > > --- > libavdevice/gdigrab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c > index c91661c556..08a41c304b 100644 > --- a/libavdevic

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure required number of bytes is read

2024-08-08 Thread Michael Niedermayer
On Thu, Aug 08, 2024 at 01:09:01PM -0300, James Almer wrote: > On 8/7/2024 11:09 AM, Kacper Michajłow wrote: > > Fixes: use-of-uninitialized-value > > > > Found by OSS-Fuzz. > > --- > > libavformat/mov.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure required number of bytes is read

2024-08-08 Thread Michael Niedermayer
On Wed, Aug 07, 2024 at 04:09:20PM +0200, Kacper Michajłow wrote: > Fixes: use-of-uninitialized-value > > Found by OSS-Fuzz. > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure required number of bytes is read

2024-08-08 Thread James Almer
On 8/7/2024 11:09 AM, Kacper Michajłow wrote: Fixes: use-of-uninitialized-value Found by OSS-Fuzz. --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1052691936..f2d8aee766 100644 --- a/libavformat/mov.c +++ b/

Re: [FFmpeg-devel] Extend the PATH buffer to 2048 for RTSP

2024-08-08 Thread Michael Niedermayer
On Wed, Aug 07, 2024 at 09:03:01AM +0200, Stefano Mandelli wrote: > Recently, I have been experiencing an increasing number > of user that use ffmpeg to retrive RTSP stream from > personal mediaproxies (e.g. MediaMtx) with > authorization based on JWT. The current length of PATH > does not permit t

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wtvdec: clear sectors

2024-08-08 Thread Michael Niedermayer
On Wed, Aug 07, 2024 at 10:01:27AM +1000, Peter Ross wrote: > On Wed, Aug 07, 2024 at 12:18:51AM +0200, Michael Niedermayer wrote: > > The code can leave uninitialized holes in the array. > > Fixes: use of uninitialized values > > Fixes: > > 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzz

Re: [FFmpeg-devel] [PATCH 6/6] avformat/wtvdec: Check length of read mpeg2_descriptor

2024-08-08 Thread Michael Niedermayer
On Wed, Aug 07, 2024 at 10:02:09AM +1000, Peter Ross wrote: > On Wed, Aug 07, 2024 at 12:18:53AM +0200, Michael Niedermayer wrote: > > Fixes: Use of uninitialized value > > Fixes: > > 70900/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6286909377150976 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Use av_buffer_allocz() to avoid missing slices to have unpredictable content

2024-08-08 Thread Michael Niedermayer
On Wed, Aug 07, 2024 at 12:18:52AM +0200, Michael Niedermayer wrote: > Fixes: use of uninitialized values > Fixes: > 70885/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6F_fuzzer-4610946029387776 > (and likely others) > > Found-by: continuous fuzzing process > https://github.com/google/os

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Use av_buffer_allocz() to avoid missing slices to have unpredictable content

2024-08-08 Thread James Almer
On 8/6/2024 7:18 PM, Michael Niedermayer wrote: Fixes: use of uninitialized values Fixes: 70885/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6F_fuzzer-4610946029387776 (and likely others) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: call MediaCodec.stop on close

2024-08-08 Thread sfan5
Am 08.08.24 um 17:29 schrieb Zhao Zhili: On Aug 8, 2024, at 00:27, sfan5 wrote: Hi all, attached is a small fix for the MediaCodec code. Tested on Android 14. This can free up vital resources in case of using multiple decoding instances and there are buffer references left over and not immedi

[FFmpeg-devel] PATCH: Force vaapi image formats to NV12-only

2024-08-08 Thread Lluís Batlle i Rossell
attached >From c6439f3a74529db25777029596791a62eb3c77d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Batlle=20i=20Rossell?= Date: Thu, 8 Aug 2024 20:32:03 +0200 Subject: [PATCH] Force vaapi image formats to NV12-only Vaapi drivers often lack proper image converesions and not all situatio

[FFmpeg-devel] [PATCH v2 1/3] avcodec/vvc_parser: move avctx->has_b_frames initialization to dec

2024-08-08 Thread toqsxw
From: Wu Jianhua >From Jun Zhao : > Should we relocate this to the decoder? Other codecs typically set this > parameter in the decoder. Signed-off-by: Wu Jianhua --- libavcodec/vvc/dec.c| 1 + libavcodec/vvc_parser.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH v2 2/3] avcodec/vvc/cabac: remove vvc_refill2

2024-08-08 Thread toqsxw
From: Wu Jianhua See https://github.com/ffvvc/FFmpeg/issues/178 Signed-off-by: Wu Jianhua --- libavcodec/cabac_functions.h | 2 +- libavcodec/vvc/cabac.c | 28 +--- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/libavcodec/cabac_functions.h b/lib

[FFmpeg-devel] [PATCH v2 3/3] avcodec/vvc/dsp: prefix TxType and TxSize with VVC

2024-08-08 Thread toqsxw
From: Wu Jianhua See https://github.com/ffvvc/FFmpeg/issues/180 Signed-off-by: Wu Jianhua --- libavcodec/vvc/dsp.h | 28 ++-- libavcodec/vvc/dsp_template.c | 2 +- libavcodec/vvc/intra.c| 26 +- 3 files changed, 28 insertions(+)

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/vvc/cabac: remove vvc_refill2

2024-08-08 Thread Andreas Rheinhardt
toq...@outlook.com: > From: Wu Jianhua > > See https://github.com/ffvvc/FFmpeg/issues/178 This link only sends one to a patchwork thread to read. The commit message should instead explain why this is done on its own (and may refer to the mailing list thread for a more detailed explanation). Sam

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure required number of bytes is read

2024-08-08 Thread Andreas Rheinhardt
James Almer: > On 8/7/2024 11:09 AM, Kacper Michajłow wrote: >> Fixes: use-of-uninitialized-value >> >> Found by OSS-Fuzz. >> --- >>   libavformat/mov.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/mov.c b/libavformat/mov.c >> index 1052691936..f2d8aee766

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Use av_buffer_allocz() to avoid missing slices to have unpredictable content

2024-08-08 Thread Michael Niedermayer
On Thu, Aug 08, 2024 at 02:13:12PM -0300, James Almer wrote: > On 8/6/2024 7:18 PM, Michael Niedermayer wrote: > > Fixes: use of uninitialized values > > Fixes: > > 70885/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6F_fuzzer-4610946029387776 > > (and likely others) > > > > Found-by: cont

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header

2024-08-08 Thread Jan Ekström
On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow wrote: > > Fixes remaining \r\n is ASS header after 57c545090d. > > Signed-off-by: Kacper Michajłow > --- With an initial look this set looks good. If I understand correctly, the generic ASS encoder moved to outputting LF only in 7bf1b9b35769b376

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header

2024-08-08 Thread Kacper Michajlow
On Fri, 9 Aug 2024 at 00:04, Jan Ekström wrote: > > On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow wrote: > > > > Fixes remaining \r\n is ASS header after 57c545090d. > > > > Signed-off-by: Kacper Michajłow > > --- > > With an initial look this set looks good. If I understand correctly, > the

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Use av_buffer_allocz() to avoid missing slices to have unpredictable content

2024-08-08 Thread Kacper Michajlow
On Fri, 9 Aug 2024 at 00:06, Michael Niedermayer wrote: > > On Thu, Aug 08, 2024 at 02:13:12PM -0300, James Almer wrote: > > On 8/6/2024 7:18 PM, Michael Niedermayer wrote: > > > Fixes: use of uninitialized values > > > Fixes: > > > 70885/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6F_fuz

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: call MediaCodec.stop on close

2024-08-08 Thread Zhao Zhili
> On Aug 9, 2024, at 02:14, sfan5 wrote: > > Am 08.08.24 um 17:29 schrieb Zhao Zhili: >>> On Aug 8, 2024, at 00:27, sfan5 wrote: >>> >>> Hi all, >>> >>> attached is a small fix for the MediaCodec code. Tested on Android 14. >>> >>> This can free up vital resources in case of using multiple

Re: [FFmpeg-devel] PATCH: Force vaapi image formats to NV12-only

2024-08-08 Thread Zhao Zhili
> vaapi drivers often lack proper image converesions and not all > situations allow vagetimage or vaputimage with the image formats > reported by the api. nv12 seems allowed in all circumstances. > > with this change now one can use the hwaccel directly without > explicit conversions to nv12 for f