Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

-Original Message- From: ffmpeg-devel On Behalf Of Roger Pack Sent: Wednesday, July 17, 2024 3:03 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present > LGTM I also need this fix in

Re: [FFmpeg-devel] Add Mediacodec audio decoders support

Quoting Cosmin Stejerean via ffmpeg-devel (2024-07-16 22:14:19) > > > > On Jul 16, 2024, at 8:24 PM, Rémi Denis-Courmont wrote: > > > > Le tiistaina 16. heinäkuuta 2024, 18.48.06 EEST Cosmin Stejerean via ffmpeg- > > devel a écrit : > >> To add another data point, the platform decoders might al

[FFmpeg-devel] [PATCH] avcodec/nvenc: Rework on DTS generation

From: Zhao Zhili Before the patch, the method to generate DTS only works with timebase equal to 1/fps. With timebase like 1/1000 ./ffmpeg -i foo.mp4 -an -c:v h264_nvenc -enc_time_base 1/1000 bar.mp4 pts 0dts -3 pts 160 dts 37 pts 80 dts 77 pts 40 dts 117 <-- invalid pts 120 dts 157 pt

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

Quoting Michael Niedermayer (2024-07-16 14:14:34) > > > > Mostly to > > > > monitor what issues are reported upstream, as we get some reports in > > > > mpv fuzzing and I never know if I should report it upstream (ffmpeg) > > > > or it is already found by first-party fuzzing and I shouldn't make >

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Rework on DTS generation

On 17/07/2024 11:47, Zhao Zhili wrote: From: Zhao Zhili Before the patch, the method to generate DTS only works with timebase equal to 1/fps. With timebase like 1/1000 ./ffmpeg -i foo.mp4 -an -c:v h264_nvenc -enc_time_base 1/1000 bar.mp4 pts 0dts -3 pts 160 dts 37 pts 80 dts 77 pts 40

Re: [FFmpeg-devel] [PATCH 0/1] avfilter/framesync: fix forward EOF pts

Quoting Nicolas Gaullier (2024-07-08 14:36:38) > >Envoyé : vendredi 14 juin 2024 13:27 > >>Envoyé : lundi 3 juin 2024 12:00 > >>>Envoyé : mardi 28 mai 2024 11:11 > >>> > >>>This a new ping but I post the patch again to get fate cleanly completed > >>>on patchwork. > >>> > >>https://patchwork.ffmpe

[FFmpeg-devel] [PATCH 1/5] avutil/timecode: Use a 64bit framenum internally

Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 68550/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6424065930756096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/proj

[FFmpeg-devel] [PATCH 2/5] avformat/mxfdec: Reorder elements of expression in bisect loop

Fixes: signed integer overflow: 9223372036854775807 - -1 cannot be represented in type 'long' Fixes: 68578/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6032171648221184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 3/5] avformat/iamfdec: Check nb_layers before dereferencing layer

Fixes: dereferencing pointers near NULL Fixes: 70432/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5255672845893632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/iamfdec.c | 2 +- 1

[FFmpeg-devel] [PATCH 4/5] swscale/output: Fix integer overflows in yuv2rgba64_X_c_template

Fixes: signed integer overflow: -1082982400 + -1068681048 cannot be represented in type 'int' Fixes: 69995/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6285740271534080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 5/5] avformat/iamf_parse: Check for negative sample sizes

Fixes: index -2 out of bounds for type 'const enum AVCodecID [3]' Fixes: 69866/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-4971166119821312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libav

Re: [FFmpeg-devel] [PATCH 1/4] avformat/movenc: fix channel count and samplerate fields for IAMF tracks

On 7/17/2024 3:18 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-17 03:49:22) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2bea55e33d..5de188f4cf 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1399,6 +1399,11 @@ static int mov_write_audio_tag(AVFormatCo

Re: [FFmpeg-devel] avisynth as an internal filter, any objections?

On Tue, Jul 16, 2024 at 07:04:40PM -0600, Roger Pack wrote: > Hi all, just wondering, if I were to write a libavfilter that > basically "called out" to avisynth and had it process stuff, would > there be any ideological pushback, or would it possibly be accepted? > Cheers! If this would allow peop

Re: [FFmpeg-devel] Add Mediacodec audio decoders support

On Wed, Jul 17, 2024 at 11:38:33AM +0200, Anton Khirnov wrote: > Quoting Cosmin Stejerean via ffmpeg-devel (2024-07-16 22:14:19) > > > > > > > On Jul 16, 2024, at 8:24 PM, Rémi Denis-Courmont wrote: > > > > > > Le tiistaina 16. heinäkuuta 2024, 18.48.06 EEST Cosmin Stejerean via > > > ffmpeg-

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

Anton Khirnov (12024-07-17): > What do you think gives you the right to make such decisions on your > own? Despite what some people might think, including on occasion himself, Michael is still our project leader, appointed by our founder and embodying its spirit of freedom and experimentation. It

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

On Wed, Jul 17, 2024 at 2:22 PM Nicolas George wrote: > Anton Khirnov (12024-07-17): > > What do you think gives you the right to make such decisions on your > > own? > > Despite what some people might think, including on occasion himself, > Michael is still our project leader, appointed by our f

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

Vittorio Giovara (12024-07-17): > He is not. Stop spreading propaganda or further emails will be forwarded to > CC for disciplinary action. Can you quote the article of the code of conduct that you pretend I am violating? This use of intimidation to silence discourse that one does not like is… co

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

On Wed, Jul 17, 2024 at 2:40 PM Nicolas George wrote: > Vittorio Giovara (12024-07-17): > > He is not. Stop spreading propaganda or further emails will be forwarded > to > > CC for disciplinary action. > > Can you quote the article of the code of conduct that you pretend I am > violating? > > Thi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma

On Wed, Jul 17, 2024 at 12:17 AM Zhao Zhili wrote: > > > > On Jul 17, 2024, at 00:07, Zhao Zhili wrote: > > > > > > > >> On Jul 16, 2024, at 20:31, Nuo Mi wrote: > >> > >> On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili > wrote: > >> > >>> From: Zhao Zhili mailto:zhi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma

On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili wrote: > From: Zhao Zhili > merged. Thank you > > --- > libavcodec/vvc/filter_template.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/libavcodec/vvc/filter_template.c > b/libavcodec/vvc/filter_template.c > index 32777452b7..6dd

Re: [FFmpeg-devel] Add Mediacodec audio decoders support

On Tue, Jul 16, 2024 at 5:56 PM Cosmin Stejerean via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > > > > On Jul 16, 2024, at 4:58 PM, Zhao Zhili wrote: > > > > > > > >> On Jul 16, 2024, at 21:20, Matthieu Bouron > wrote: > >> > >> On Wed, Jul 10, 2024 at 6:31 PM Matthieu Bouron > >> wrote: >

Re: [FFmpeg-devel] avisynth as an internal filter, any objections?

On Wed, 17 Jul 2024 at 03:21, Roger Pack wrote: > > Hi all, just wondering, if I were to write a libavfilter that > basically "called out" to avisynth and had it process stuff, would > there be any ideological pushback, or would it possibly be accepted? > Cheers! Have you considered VapourSynth i

Re: [FFmpeg-devel] Add Mediacodec audio decoders support

> On Jul 17, 2024, at 5:39 PM, Paul B Mahol wrote: > > On Tue, Jul 16, 2024 at 5:56 PM Cosmin Stejerean via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > >> >> >>> On Jul 16, 2024, at 4:58 PM, Zhao Zhili wrote: >>> >>> >>> On Jul 16, 2024, at 21:20, Matthieu Bouron >> wrote: >

Re: [FFmpeg-devel] [PATCH 5/5] fftools/ffprobe: implement dv_md_compression

On Tue, Jul 16, 2024 at 01:23:17PM +0200, Niklas Haas wrote: > From: Niklas Haas > > --- > fftools/ffprobe.c | 1 + > 1 file changed, 1 insertion(+) breaks fate / needs update to fate thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The smallest minority

[FFmpeg-devel] [PATCH] avcodec/amf_enc: new encoder features support

Implemented: New usage modes for AV1 encoder. Latency mode for H264, HEVC and AV1 encoders. Adaptive Quantization (AQ) mode in AV1 encoder. --- libavcodec/amfenc.h | 2 ++ libavcodec/amfenc_av1.c | 24 +++- libavcodec/amfenc_h264.c | 5 + libavcodec/amfenc_hevc.c |

Re: [FFmpeg-devel] [PATCH 28/39] lavc/ffv1dec: fix races in accessing FFV1SliceContext.slice_damaged

On Tue, Jul 16, 2024 at 07:11:43PM +0200, Anton Khirnov wrote: > That variable is shared between frame threads in the same defective way > described in the previous commit. Fix it by adding a RefStruct-managed > arrays of flags that is propagated across frame threads in the standard > manner. > >

Re: [FFmpeg-devel] [RFC PATCH v2] avutil/error: Provide better feedback about unknown error codes

On Tue, Jul 16, 2024 at 12:13:10PM +0100, Andrew Sayers wrote: > AVERROR messages should always be less than zero, > and are usually based on three or four ASCII characters. > > For error codes that aren't explicitly handled by error.c (e.g. FFERROR_REDO), > print the ASCII code so the user has a

Re: [FFmpeg-devel] [PATCH 31/39] lavc/decode: wrap AV_FRAME_FLAG_DISCARD handling in a loop

On Tue, Jul 16, 2024 at 07:11:46PM +0200, Anton Khirnov wrote: > Makes sure discarded frames do not cause EAGAIN to be returned during > flushing, which is forbidden. > --- > libavcodec/decode.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) giving execution back to the user

[FFmpeg-devel] [PATCH 2/2] avformat/avisynth: remove mutex lock from read_close

Signed-off-by: Stephen Hutchinson --- After asking about this and testing with AviSynth+ 3.7.3 and AviSynth 2.6, it would appear that this isn't necessary. If it was to handle an edge case and said case reappears, it can be re-evaluated then. libavformat/avisynth.c | 4 1 file changed, 4 de

Re: [FFmpeg-devel] [PATCH] avformat/avisynth: remove atexit() handler

On 7/7/24 1:46 PM, Stephen Hutchinson wrote: On 7/7/24 9:50 AM, Andreas Rheinhardt wrote: avisynth_context_destroy() is currently always called while holding the lock (i.e. avisynth_mutex). Is this even necessary? It is clear that avisynth_load_library() (and the check for whether it should be

Re: [FFmpeg-devel] [PATCH] libavformat/tls_mbedtls: Changes the return code handling of mbedtls_x509_crt_parse_file

Disclaimer: I am a light contributor and do not have access to actually merge this patch, only making suggestions based on my learnings. > Sounds good. Sorry first time contributing, should I make another patch > with the change and send that through again with git send-email? Yes, except when you

Re: [FFmpeg-devel] avisynth as an internal filter, any objections?

I think this could enable use of the highly regarded, QTGMC deinterlacer which sounds appealing to me (+1 for VapourSynth instead). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

Re: [FFmpeg-devel] [PATCH 13/39] lavc/ffv1: drop redundant PlaneContext.quant_table

On Tue, Jul 16, 2024 at 07:11:28PM +0200, Anton Khirnov wrote: > It is a copy of FFV1Context.quant_tables[quant_table_index]. > --- > libavcodec/ffv1.h | 1 - > libavcodec/ffv1_template.c| 22 +++--- > libavcodec/ffv1dec.c | 28

Re: [FFmpeg-devel] avisynth as an internal filter, any objections?

On Thu, Jul 18, 2024 at 12:30 AM Marth64 wrote: > I think this could enable use of the highly regarded, > QTGMC deinterlacer which sounds appealing to me > (+1 for VapourSynth instead). > LOL, Isn't there demuxer already? Also as filter it would be less useful. > _

Re: [FFmpeg-devel] [PATCH 12/39] lavc/ffv1: drop redundant FFV1Context.quant_table

On Tue, Jul 16, 2024 at 07:11:27PM +0200, Anton Khirnov wrote: > In all cases except decoding version 1 it's either not used, or contains > a copy of a table from quant_tables, which we can just as well use > directly. > > When decoding version 1, we can just as well decode into > quant_tables[0],

Re: [FFmpeg-devel] avisynth as an internal filter, any objections?

> LOL, > Isn't there demuxer already? > Also as filter it would be less useful. I haven't actually used QTGMC. I have just read of it but have not had the time to apply it with VapourSynth. But it could be cool. ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 10/39] lavc/ffv1dec: move the bitreader to stack

On Tue, Jul 16, 2024 at 07:11:25PM +0200, Anton Khirnov wrote: > There is no reason to place it in persistent state. > --- > libavcodec/ffv1.h | 1 - > libavcodec/ffv1dec.c | 28 +++- > libavcodec/ffv1dec_template.c | 23 --- > 3 fi

Re: [FFmpeg-devel] [PATCH 09/39] lavc/ffv1: move run_index to the per-slice context

On Tue, Jul 16, 2024 at 07:11:24PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h | 3 ++- > libavcodec/ffv1dec.c | 6 +++--- > libavcodec/ffv1dec_template.c | 16 > libavcodec/ffv1enc.c | 6 +++--- > libavcodec/ffv1enc_template.c | 16 +

Re: [FFmpeg-devel] [PATCH 12/39] lavc/ffv1: drop redundant FFV1Context.quant_table

On 7/17/2024 7:37 PM, Michael Niedermayer wrote: On Tue, Jul 16, 2024 at 07:11:27PM +0200, Anton Khirnov wrote: In all cases except decoding version 1 it's either not used, or contains a copy of a table from quant_tables, which we can just as well use directly. When decoding version 1, we can j

[FFmpeg-devel] [PATCH 1/2] avformat/mov: don't export frame cropping stream side data when the clap box is a no-op

Signed-off-by: James Almer --- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ce95842ce5..20efc74f00 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1262,6 +1262,9 @@ static int mov_read_clap(MOVContext *c, AVIOConte

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: use the correct specifier for crop arguments

Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 097bd2ed48..b562e8417c 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1703,7 +1703,7 @@ static

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_demux: don't insert the crop filter if frame cropping side data defines no cropping

Signed-off-by: James Almer --- fftools/ffmpeg_demux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 528e02149f..6f7d78c896 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1014,7 +1014,8 @@ int ist_f