Re: [FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-13 Thread Rémi Denis-Courmont
Le torstaina 4. heinäkuuta 2024, 4.23.29 EEST Sean McGovern a écrit : > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index b28221f258..bbda7a02cb 100755 > --- a/configure > +++ b/configure > @@ -5493,7 +5493,7 @@ elif enabled ppc

Re: [FFmpeg-devel] [PATCH] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-13 Thread Rémi Denis-Courmont
Le sunnuntaina 7. heinäkuuta 2024, 21.21.26 EEST Sean McGovern a écrit : > RaptorCS POWER9 (8c4t) @ 2.2GHz: > flac_wasted_32_c: 50.1 > flac_wasted_32_vsx: 14.1 > --- > libavcodec/flacdsp.c | 2 ++ > libavcodec/flacdsp.h | 1 + > libavcodec/ppc/Makefile | 2 ++ > libavcod

Re: [FFmpeg-devel] [PATCH v4 3/4] lavc/vp9dsp: R-V V mc tap h v

2024-07-13 Thread Rémi Denis-Courmont
Le lauantaina 15. kesäkuuta 2024, 14.50.33 EEST u...@foxmail.com a écrit : > From: sunyuechi OK, so I realise that this review is very late, but... TBH it is very hard to review this due to the large extents of code conditionals. This should avoidable at least partly. You can name macros for e

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-13 Thread WATANABE Osamu
> @Osamu, did you check if the decoded images fall within the tolerances > specified in 15444-4? Yes, I did. It has been confirmed that the decoder passes all the test cases defined in 15444-4. The errors (PAE and MSE) in the reconstructed images are within the allowable tolerances. > On Jul

[FFmpeg-devel] [PATCH 2/2] lavc/h264dsp: R-V V high-depth add_pixels8

2024-07-13 Thread Rémi Denis-Courmont
--- libavcodec/riscv/h264addpx_rvv.S | 22 ++ libavcodec/riscv/h264dsp_init.c | 2 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/riscv/h264addpx_rvv.S b/libavcodec/riscv/h264addpx_rvv.S index fd36bd4896..3d307b2cb8 100644 --- a/libavcodec/riscv/h264addpx_rvv.S

[FFmpeg-devel] [PATCH 1/2] lavc/h264dsp: R-V V add_pixels4 and 8-bit add_pixels8

2024-07-13 Thread Rémi Denis-Courmont
--- libavcodec/riscv/Makefile| 3 +- libavcodec/riscv/h264addpx_rvv.S | 89 libavcodec/riscv/h264dsp_init.c | 11 3 files changed, 102 insertions(+), 1 deletion(-) create mode 100644 libavcodec/riscv/h264addpx_rvv.S diff --git a/libavcodec/riscv/Ma

[FFmpeg-devel] [PATCH] libavformat/tls_mbedtls: Changes the return code handling of mbedtls_x509_crt_parse_file

2024-07-13 Thread Mohit Gupta
mbedtls_x509_crt_parse_file returns an error with negative numbers, and positive numbers indicate the number of failed certificates to load from certificate specific issues, such as critical extensions. This would fix ticket #11079. Signed-off-by: Mohit Gupta --- libavformat/tls_mbedtls.c | 4

Re: [FFmpeg-devel] [PATCH] fate/lavf-container: add a test for L-HEVC remuxing

2024-07-13 Thread Anton Khirnov
Quoting James Almer (2024-07-12 14:22:11) > Signed-off-by: James Almer > --- > tests/fate-run.sh | 4 ++-- > tests/fate/lavf-container.mak | 28 +++- > tests/ref/lavf-fate/mv_hevc.mp4 | 3 +++ > 3 files changed, 20 insertions(+), 15 deletions(-) > create

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

2024-07-13 Thread Anton Khirnov
Quoting James Almer (2024-07-12 02:33:06) > Same as the framecrc muxer. IOW obfuscated and user-hostile. Please don't. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum

2024-07-13 Thread Anton Khirnov
Quoting James Almer (2024-07-12 02:33:07) > Signed-off-by: James Almer > --- > libavcodec/bsf/showinfo.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c > index 0899263545..57da3fc73c 100644 > --- a/libavcodec/bs

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

2024-07-13 Thread James Almer
On 7/13/2024 10:46 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-12 02:33:06) Same as the framecrc muxer. IOW obfuscated and user-hostile. Please don't. You mean to not implement this in any form, or try to make it more user friendly? I could remove the flags (which is admittedly o

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

2024-07-13 Thread Anton Khirnov
Quoting James Almer (2024-07-13 15:49:48) > On 7/13/2024 10:46 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-07-12 02:33:06) > >> Same as the framecrc muxer. > > > > IOW obfuscated and user-hostile. > > > > Please don't. > > You mean to not implement this in any form, or try to make it

[FFmpeg-devel] [PATCH v2] avcodec/bsf/showinfo: print packet data checksum

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bsf/showinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c index 4e31e0b5cb..715b160b60 100644 --- a/libavcodec/bsf/showinfo.c +++ b/libavcodec/bsf/showinfo.c @@ -23,6 +23,

[FFmpeg-devel] [PATCH] mailmap: add entry for myself

2024-07-13 Thread Tong Wu
Signed-off-by: Tong Wu --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index 53cb5eac26..fe019b88c7 100644 --- a/.mailmap +++ b/.mailmap @@ -24,3 +24,5 @@ rcombs Cosmin Stejerean Cosmin Stejerean via ffmpeg-devel + + -- 2.45.1.windows.1 _

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf/showinfo: print packet data checksum

2024-07-13 Thread Anton Khirnov
Quoting James Almer (2024-07-13 16:05:35) > Signed-off-by: James Almer > --- > libavcodec/bsf/showinfo.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) LGTM -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH 1/3] avutil/avassert: Add av_assert_unreachable()

2024-07-13 Thread epirat07
On 13 Jul 2024, at 2:47, Andreas Rheinhardt wrote: > Marvin Scholz: >> --- >> libavutil/avassert.h | 12 >> 1 file changed, 12 insertions(+) >> >> diff --git a/libavutil/avassert.h b/libavutil/avassert.h >> index 1895fb7551..cdab912fe4 100644 >> --- a/libavutil/avassert.h >> +++ b/li

Re: [FFmpeg-devel] [PATCH 10/11] avfilter/yadif_common: remove unused variable

2024-07-13 Thread epirat07
On 13 Jul 2024, at 2:50, Andreas Rheinhardt wrote: > Marvin Scholz: >> --- >> libavfilter/vf_yadif_videotoolbox.m | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavfilter/vf_yadif_videotoolbox.m >> b/libavfilter/vf_yadif_videotoolbox.m >> index c47d3edfb8..eb7026395e 100644 >> -

[FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h265: fix range of sps_max_sub_layers_minus1

2024-07-13 Thread James Almer
The VPS referenced by the SPS must always be present as the max value for sps_max_sub_layers_minus1 is vps_max_sub_layers_minus1. This replaces a buggy custom range check for the aforementioned field. Also, add the missing conformance check for sps_temporal_id_nesting_flag while at it. Signed-off-

[FFmpeg-devel] [PATCH 2/4] avcodec/cbs_h265: add partial support for Multilayer extension fields in parameter set NALUs

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 3 +- libavcodec/cbs_h265.h | 44 ++ libavcodec/cbs_h265_syntax_template.c | 113 +- libavcodec/hevc/ps.h | 4 +- 4 files changed, 159 insertions(+), 5 dele

[FFmpeg-devel] [PATCH 3/4] avcodec/cbs_h265: reindent after the previous commit

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 124 +- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 2f8ee0db10..1826950e8e 100644 --- a/libavcode

[FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add support for 3D Reference Displays Information SEI

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 6 libavcodec/cbs_h265.h | 16 ++ libavcodec/cbs_h265_syntax_template.c | 42 +++ 3 files changed, 64 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

2024-07-13 Thread Stefano Sabatini
On Fri, Jul 12, 2024 at 5:31 AM Marth64 wrote: > > Ping to apply on this set of 3, so I can send seeking and additional > cleanup set (as a collection). Thank you! Applied patches: eb07a59 avformat/dvdvideodec: Don't add chapter markers for empty/dummy PTTs f37f86a avformat/dvdvideodec: Remove re

[FFmpeg-devel] [PATCH 1/3] avformat/lmlm4: Move subtraction after check

2024-07-13 Thread Michael Niedermayer
This is not a bugfix in code but coverity only, it does look a little nicer though Fixes: CID732224 Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/lmlm4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/lmlm4.c b/libavformat

[FFmpeg-devel] [PATCH 2/3] avformat/lmlm4: Eliminate some AVERROR(EIO)

2024-07-13 Thread Michael Niedermayer
Found by code review related to CID732224 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/lmlm4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/lmlm4.c b/libavformat/lmlm4.c index c8355e7a8d6..cec2f7

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_xfade_opencl: Check ff_inlink_consume_frame() for failure

2024-07-13 Thread Michael Niedermayer
Fixes: CID1458127 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/vf_xfade_opencl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_xfade_opencl.c b/libavfilter/vf_xfade_opencl.c index

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

2024-07-13 Thread Marth64
Thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] checkasm/h264dsp: test TX bypass

2024-07-13 Thread Rémi Denis-Courmont
--- tests/checkasm/h264dsp.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index 67b8dce53c..1df76d72d2 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -188,23

Re: [FFmpeg-devel] [PATCH 1/2] lavc/h264dsp: R-V V add_pixels4 and 8-bit add_pixels8

2024-07-13 Thread Rémi Denis-Courmont
T-Head C908 (cycles): h264_add_pixels4_8bpp_c:93.5 h264_add_pixels4_8bpp_rvv_i32: 39.5 h264_add_pixels4_9bpp_c:87.5 h264_add_pixels4_9bpp_rvv_i64: 50.5 h264_add_pixels4_10bpp_c: 87.5 h264_add_pixels4_10bpp_rvv_i64: 50.5 h264_add_pixels4_12bpp_c: 87.5 h264_add_pixels4_1

Re: [FFmpeg-devel] [PATCH 2/2] lavc/h264dsp: R-V V high-depth add_pixels8

2024-07-13 Thread Rémi Denis-Courmont
T-Head C908 (cycles); h264_add_pixels8_9bpp_c:270.5 h264_add_pixels8_9bpp_rvv_i32: 164.2 h264_add_pixels8_10bpp_c: 270.5 h264_add_pixels8_10bpp_rvv_i32: 164.2 h264_add_pixels8_12bpp_c: 270.5 h264_add_pixels8_12bpp_rvv_i32: 164.2 h264_add_pixels8_14bpp_c: 270.5 h264_add_pi

[FFmpeg-devel] [PATCH] checkasm/h264: test weight and biweight

2024-07-13 Thread Rémi Denis-Courmont
--- tests/checkasm/h264dsp.c | 79 +++- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index d1228ed985..39397f77e1 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -29,6 +

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-13 Thread Kacper Michajlow
On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow wrote: > > On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer > wrote: > > > > On Wed, Jun 26, 2024 at 09:07:42PM +0200, Kacper Michajlow wrote: > > > Hi, > > > > > > Like in the topic. I think it would be useful to enable MSAN on > > > OSS-Fuzz. We g

[FFmpeg-devel] [PATCH] avcodec/aacenc: Correct option description for aac_coder fast

2024-07-13 Thread Marth64
The description advertises fast as "Default fast search", but this has not been the default for a long time (current default is twoloop). Signed-off-by: Marth64 --- libavcodec/aacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c i