Re: [FFmpeg-devel] [PATCH v2 1/4] avfilter/af_volumedetect.c: Move logdb function

2024-06-30 Thread Thilo Borgmann via ffmpeg-devel
On 29.06.24 21:54, Yigithan Yigit wrote: On 29 Jun 2024, at 22:22, Rémi Denis-Courmont wrote: Le perjantaina 28. kesäkuuta 2024, 23.15.20 EEST Yigithan Yigit a écrit : --- libavfilter/af_volumedetect.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/2] lavc/h264dsp: R-V V 8-bit luma loop filter

2024-06-30 Thread Rémi Denis-Courmont
T-Head C908 (cycles): h264_h_loop_filter_luma_8bpp_c: 297.5 h264_h_loop_filter_luma_8bpp_rvv_i32: 374.7 h264_v_loop_filter_luma_8bpp_c: 862.7 h264_v_loop_filter_luma_8bpp_rvv_i32: 200.7 Performance in the horizontal scenario seems worse than scalar. x86 SSE2 and AVX optimisations are s

[FFmpeg-devel] [PATCH 1/2] lavc/vc1dsp: fix potential overflow in R-V V inv_trans_4

2024-06-30 Thread Rémi Denis-Courmont
Judging by the coefficients, the last round of add/sub can overflow to 17 bits with a very small probability just as with the 8-point transform. This is not observed under FATE, but better safe than sorry. --- libavcodec/riscv/vc1dsp_rvv.S | 15 --- 1 file changed, 8 insertions(+), 7 d

Re: [FFmpeg-devel] [PATCH 2/2] lavc/h264dsp: R-V V 8-bit luma loop filter

2024-06-30 Thread Rémi Denis-Courmont
Disregard, botched send-email. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

[FFmpeg-devel] [PATCH 1/2] lavc/h264dsp: R-V V 8-bit luma loop filter

2024-06-30 Thread Rémi Denis-Courmont
T-Head C908 (cycles): h264_h_loop_filter_luma_8bpp_c: 297.5 h264_h_loop_filter_luma_8bpp_rvv_i32: 374.7 h264_v_loop_filter_luma_8bpp_c: 862.7 h264_v_loop_filter_luma_8bpp_rvv_i32: 200.7 Performance in the horizontal scenario seems worse than scalar. x86 SSE2 and AVX optimisations are s

[FFmpeg-devel] [PATCH 2/2] lavc/h264dsp: R-V V 8-bit MBAFF loop filter

2024-06-30 Thread Rémi Denis-Courmont
Performance is (unfortunately) the same as with non-MBAFF, since the hardware under test does not short-circuit vector tail calculations. (IMO, a generic solution or work-around should be agreed on, rather than bespoke approaches all over the place.) --- libavcodec/riscv/h264dsp_init.c | 4

[FFmpeg-devel] [PATCH v2 2/2] avformat/file: guard fd_dup by FD_PROTOCOL or PIPE_PROTOCOL

2024-06-30 Thread Zhao Zhili
From: Zhao Zhili fd_dup is unused when fd and pipe have been disabled. This also fix build error with wasi since 'dup' isn't available. Signed-off-by: Zhao Zhili --- libavformat/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 3fc1e741f

[FFmpeg-devel] [PATCH v2 1/2] avutil/file_open: Fix build error with wasi

2024-06-30 Thread Zhao Zhili
From: Zhao Zhili Don't assume tempnam is available when !HAVE_MKSTEMP. Check tempnam explicitly in configure. Signed-off-by: Zhao Zhili --- configure | 2 ++ libavutil/file_open.c | 8 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/configure b/configure ind

[FFmpeg-devel] [PATCH] avutil/executor: Fix missing check before using mutex

2024-06-30 Thread Zhao Zhili
From: Zhao Zhili --- The code can be simplified by always creating mutex/cond. I'm not sure it worth the overhead. Please note !HAVE_THREADS don't have the same problem since it has mock implementation of ff_mutex_lock/unlock. libavutil/executor.c | 9 ++--- 1 file changed, 6 insertions(+),

Re: [FFmpeg-devel] [PATCH v4 2/4] lavc/vp9dsp: R-V V mc bilin hv

2024-06-30 Thread flow gg
Initially, I tried using `vnclip.wi` with reference to h264, -vwadd.wxv16, v16, t4 -vnsra.wiv16, v16, 4 +vnclip.wi v16, v16, 4 but couldn't find the correct way... I think there might be some overflow issues that I didn't understand correctly. How do y

[FFmpeg-devel] [PATCH 1/2] lavc/vc1dsp: fuse multiply-adds in R-V V inv_trans_4

2024-06-30 Thread Rémi Denis-Courmont
--- libavcodec/riscv/vc1dsp_rvv.S | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/riscv/vc1dsp_rvv.S b/libavcodec/riscv/vc1dsp_rvv.S index 9d85377cec..8c127c7644 100644 --- a/libavcodec/riscv/vc1dsp_rvv.S +++ b/libavcodec/riscv/vc1dsp_rvv.S @@ -194,14 +194

[FFmpeg-devel] [PATCH 2/2] lavc/vc1dsp: fuse multiply-adds in R-V V inv_trans_8

2024-06-30 Thread Rémi Denis-Courmont
--- libavcodec/riscv/vc1dsp_rvv.S | 63 +++ 1 file changed, 27 insertions(+), 36 deletions(-) diff --git a/libavcodec/riscv/vc1dsp_rvv.S b/libavcodec/riscv/vc1dsp_rvv.S index 8c127c7644..d8b62579aa 100644 --- a/libavcodec/riscv/vc1dsp_rvv.S +++ b/libavcodec/riscv/v

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-30 Thread Stefan Westerfeld
Hi! Am 27.06.24 um 23:35 schrieb Ramiro Polla: On Thu, Jun 27, 2024 at 6:32 PM Stefan Westerfeld wrote: This will send the audio stream to an external command as wav file and read back the output of the subprocess which is also supposed to be a wav file of the same format and length. Subp

Re: [FFmpeg-devel] [PATCH 2/2] lavf/scdet: minor fix

2024-06-30 Thread Michael Niedermayer
On Sat, Jun 29, 2024 at 09:49:59AM +0800, Jun Zhao wrote: > From: Jun Zhao > > Change dbl to i64 for bool type > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_scdet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Do not EOF on WAIT events

2024-06-30 Thread Marth64
Ping on this one to fix some discs, has been tested thoroughly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Fix duration logic with 1 chapter and validate chapter range

2024-06-30 Thread Marth64
Ping on this one blocking seeking when playing one chapter (and fixing undefined option behavior). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-30 Thread Ramiro Polla
Hi, On Sun, Jun 30, 2024 at 6:19 PM Stefan Westerfeld wrote: > Am 27.06.24 um 23:35 schrieb Ramiro Polla: [...] > Note that this isn't much different than what my asubprocess filter > would do. However it is less readable and maintainable, and just leaves > subprocess management to the shell. Th

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-30 Thread James Almer
On 6/29/2024 8:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 09:52:44PM -0300, James Almer wrote: On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 01/11] MAINTAINERS: Add Timo Rothenpieler to server admins

2024-06-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a82fa58c69f..57f437cd40e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -34,8 +34,8 @@ Miscellaneous Areas === documentatio

[FFmpeg-devel] [PATCH 02/11] avcodec/vvc/dec: Check ff_init_cabac_decoder() for failure

2024-06-30 Thread Michael Niedermayer
Fixes: signed integer overflow: 1107820800 + 1107820800 cannot be represented in type 'int' Fixes: left shift of 1091059712 by 6 places cannot be represented in type 'int' Fixes: 69910/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-5162839971528704 Found-by: continuous fuzzing proc

[FFmpeg-devel] [PATCH 03/11] avcodec/aac/aacdec: Check if frame is allocated in frame_configure_elements()

2024-06-30 Thread Michael Niedermayer
I did not investigate exactly why frame is NULL, happy to provide the sample if someone wants to investigate further Fixes: NULL pointer dereference Fixes: 69893/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-4965255361396736 Found-by: continuous fuzzing process https://gith

[FFmpeg-devel] [PATCH 04/11] tools/target_enc_fuzzer: A64MULTI encoder is very slow, check and adjust threshold

2024-06-30 Thread Michael Niedermayer
Fixes: Timeout Fixes: 69097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_A64MULTI_fuzzer-5062757287264256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_enc_fuzzer.c | 10 +- 1

[FFmpeg-devel] [PATCH 05/11] tools/target_enc_fuzzer: A64MULTI5 encoder is very slow, check and adjust threshold

2024-06-30 Thread Michael Niedermayer
Fixes: Timeout Fixes: 68999/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_A64MULTI5_fuzzer-5078418784845824 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_enc_fuzzer.c | 1 + 1 file cha

[FFmpeg-devel] [PATCH 06/11] doc/examples/mux: remove nop

2024-06-30 Thread Michael Niedermayer
Found through code review related to CID1604493 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/mux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/examples/mux.c b/doc/examples/mux.c index b034aad56f7..0f3a2bb

[FFmpeg-devel] [PATCH 07/11] doc/examples/vaapi_encode: Try to check fwrite() for failure

2024-06-30 Thread Michael Niedermayer
Fixes: CID1604548 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/vaapi_encode.c | 4 1 file changed, 4 insertions(+) diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c index d5f472f6dd8..805db7e5fd8 100644 --- a/doc/ex

[FFmpeg-devel] [PATCH 08/11] fftools/ffmpeg: Check read() for failure

2024-06-30 Thread Michael Niedermayer
Fixes: CID1591932 Ignoring number of bytes read Untested, this needs a windows machine Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 88ce

[FFmpeg-devel] [PATCH 09/11] avcodec/aac/aacdec_lpd: Remove dead code

2024-06-30 Thread Michael Niedermayer
I dont intend to apply this, this patch is just to show there is dead code that needs more work in case it has been forgotten I will mark this as intentional in coverity because obviously its work in progress code (CID1603198 Logically dead code) Signed-off-by: Michael Niedermayer --- libavcod

[FFmpeg-devel] [PATCH 10/11] avcodec/aac/aacdec_usac: Avoid doing the same thing twice each iteration

2024-06-30 Thread Michael Niedermayer
This requires review by the author of the code, i have just changed this so it looks plausible, this needs to be checked against the spec Fixes: CID1603194 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_usac.c | 4 ++-- 1 file

[FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio

2024-06-30 Thread Michael Niedermayer
Fixes: CID1605475 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_usac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 9587348021e..10121dbc34f 100644 ---

[FFmpeg-devel] [PATCH 1/4] avformat/mov: check that iloc offset values fit on an int64_t

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a2e187ff2f..fd78d5f59c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8388,7 +8388,7 @@ static int mov_read_SAND(MOV

[FFmpeg-devel] [PATCH 2/4] avformat/mov: check extent_offset calculation for overflow

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index fd78d5f59c..3aa2398386 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8482,7 +8482,8 @@ static int mov_read_iloc(MOVContex

[FFmpeg-devel] [PATCH 3/4] avformat/mov: check for EOF inside the infe list parsing loop

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3aa2398386..9f6752b492 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8580,6 +8580,8 @@ static int mov_read_iinf(MOVContext *c, AVIOContex

[FFmpeg-devel] [PATCH 4/4] avformat/mov: add more checks for infe atom size

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9f6752b492..ba33e52086 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8510,6 +8510,8 @@ static int mov_read_infe(MOVContext *c, AVIOCont