Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-23 Thread Lynne via ffmpeg-devel
On 20/06/2024 04:12, Lynne wrote: On 16/06/2024 10:54, Lynne wrote: Currently, no eSBR features are supported. Thankfully, no encoders exist for it yet. ---   libavcodec/aac/aacdec_usac.c | 119 +++---   libavcodec/aacsbr.h  |  11 ++   libavcodec/aacsbr_template.c | 232 ++

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-23 Thread Derek Buitenhuis
On 6/22/2024 9:11 PM, Lynne via ffmpeg-devel wrote: > The API was committed 2 days ago, so changing these fields now > is within the realms of acceptable. > --- You also had weeks to comment on 3 revisions of the set, and it would have been nice to hear about this then instead of changing it after

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-23 Thread Derek Buitenhuis
On 6/23/2024 12:05 PM, Derek Buitenhuis wrote: > If I sound grumpy, it's because I am... the set sat commentless. The tone was unnecessary, sorry about that. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

[FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational

2024-06-23 Thread Lynne via ffmpeg-devel
This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats without hardcoding specific conversion constants. The API was committed 2 days ago, so changing t

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-23 Thread Lynne via ffmpeg-devel
On 23/06/2024 13:05, Derek Buitenhuis wrote: On 6/22/2024 9:11 PM, Lynne via ffmpeg-devel wrote: The API was committed 2 days ago, so changing these fields now is within the realms of acceptable. --- You also had weeks to comment on 3 revisions of the set, and it would have been nice to hear a

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-23 Thread Michael Niedermayer
On Sun, Jun 23, 2024 at 12:24:57AM +0200, Niklas Haas wrote: > On Sat, 22 Jun 2024 21:52:42 +0200 Michael Niedermayer > wrote: > > On Sat, Jun 22, 2024 at 05:10:28PM +0200, Niklas Haas wrote: > > > On Sat, 22 Jun 2024 15:23:22 +0100 Andrew Sayers > > > wrote: > > > > On Sat, Jun 22, 2024 at 03:

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-23 Thread Michael Niedermayer
On Sun, Jun 23, 2024 at 12:19:13AM +0200, Vittorio Giovara wrote: > On Sat, Jun 22, 2024 at 3:22 PM Niklas Haas wrote: > > > Hey, > > > > As some of you know, I got contracted (by STF 2024) to work on improving > > swscale, over the course of the next couple of months. I want to share my > > curr

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-23 Thread James Almer
On 6/22/2024 7:19 PM, Vittorio Giovara wrote: Needless to say I support the plan of renaming the library so that it can be inline with the other libraries names, and the use of a separate header since downstream applications will need to update a lot to use the new library (or the new apis in the

[FFmpeg-devel] [PATCH] avcodec/aacsbr_template: Remove unused-but-set variable

2024-06-23 Thread Andreas Rheinhardt
Also fixes a -Wdeclaration-after-statement. Signed-off-by: Andreas Rheinhardt --- libavcodec/aacsbr_template.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.c index e5bc4d4659..436b549fe7 100644 --- a/libavcodec/aacsbr_template.c +

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-23 Thread Andrew Sayers
On Sun, Jun 23, 2024 at 02:57:31PM -0300, James Almer wrote: > On 6/22/2024 7:19 PM, Vittorio Giovara wrote: > > Needless to say I support the plan of renaming the library so that it can > > be inline with the other libraries names, and the use of a separate header > > since downstream applications

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-23 Thread Paul B Mahol
On Sun, Jun 23, 2024 at 7:46 PM Michael Niedermayer wrote: > On Sun, Jun 23, 2024 at 12:19:13AM +0200, Vittorio Giovara wrote: > > On Sat, Jun 22, 2024 at 3:22 PM Niklas Haas wrote: > > > > > Hey, > > > > > > As some of you know, I got contracted (by STF 2024) to work on > improving > > > swscal

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: forward AVIO_FLAG_NONBLOCK to tcp stream

2024-06-23 Thread Timo Rothenpieler
On 03.06.2024 22:28, Timo Rothenpieler wrote: From: BtbN Fixes for example rtmps streaming over schannel. --- libavformat/tls_schannel.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index 214a47a21

Re: [FFmpeg-devel] [PATCH v2 43/71] avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic

2024-06-23 Thread Michael Niedermayer
On Sat, May 11, 2024 at 10:51:07PM +0200, Andreas Rheinhardt wrote: > There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic) > that are directly part of MpegEncContext and an array of MPVPictures > that are separately allocated and are mostly accessed via pointers > (cur|last|next)

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/j2kenc: Merge dwt_norm into lambda

2024-06-23 Thread Sean McGovern
Hi, On Fri, Jun 21, 2024, 05:39 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Michael Niedermayer: > > This moves computations out of a loop > > > > Fixes: signed integer overflow: 31665934879948800 * 9998 cannot be > represented in type 'long' > > Fixes: > 69024/clusterfuzz-test

[FFmpeg-devel] [PATCH 2/5] avcodec/hevc/hevcdec: Do not allow changes to parameter sets between slices

2024-06-23 Thread Michael Niedermayer
The slice code detects changes by comparing the pps index. That way the code cannot detect changes if the sets can change. Fixes: out of array access Fixes: 69585/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6389604524556288 Fixes: 69601/clusterfuzz-testcase-minimized-ffmpeg_AV_

[FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start

2024-06-23 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc/hevcdec.c | 3 +

[FFmpeg-devel] [PATCH 4/5] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-06-23 Thread Michael Niedermayer
An alternative would be to leave the context unchanged on failure of hls_slice_header() Fixes: out of array access Fixes: NULL pointer dereference Fixes: 69584/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5931086299856896 Fixes: 69724/clusterfuzz-testcase-minimized-ffmpeg_AV_CO

[FFmpeg-devel] [PATCH 5/5] avformat/iamf: Check substreams in ff_iamf_free_audio_element()

2024-06-23 Thread Michael Niedermayer
Fixes: member access within null pointer of type 'IAMFSubStream' (aka 'struct IAMFSubStream') Fixes: 69795/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-6216287009701888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

[FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-23 Thread Michael Niedermayer
ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/test this, so failing in this case seems safest. Fixes: member access within null pointer of type 'AACDecContext' (aka 'struct AACDecContext') Fixes: 69435/clusterfuzz-test

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Don't adapt (last|next)_pic.linesize for field pics

2024-06-23 Thread Andreas Rheinhardt
These values are not read anywhere. Furthermore, since commit fe6037fd04db8837dcdb9013f9c4ad4e7eb0592e the linesize values of the MPVWorkPictures were wrong for subsequent fields in a chain of B-pictures (as they are always doubled and no longer based upon the frame-linesizes) which can eventually

Re: [FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational

2024-06-23 Thread James Almer
On 6/23/2024 11:14 AM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats without hardcoding specific conversion cons

[FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Don't create new thread when thread_count is 1

2024-06-23 Thread Zhao Zhili
From: Zhao Zhili Make its behavior consistent with other decoders, e.g., H.264/H.265. Signed-off-by: Zhao Zhili --- libavcodec/vvc/dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index f5603306f3..4ce2b1c6bd 100644 --- a/

[FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-23 Thread Zhao Zhili
From: Zhao Zhili Before the patch, disable threads support at configure/build time was the only method to force zero thread in executor. However, it's common practice for libavcodec to run on caller's thread when user specify thread number to one. And for WASM environment, whether threads are sup

[FFmpeg-devel] [PATCH v3 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-06-23 Thread Osamu Watanabe
This commit adds suuport for CAP and CPF markers Signed-off-by: Osamu Watanabe --- libavcodec/jpeg2000.h| 8 +++ libavcodec/jpeg2000dec.c | 112 ++- libavcodec/jpeg2000dec.h | 7 +++ 3 files changed, 126 insertions(+), 1 deletion(-) diff --git a/libav

[FFmpeg-devel] [PATCH v3 2/3] avcodec/jpeg2000dec: Add support for placeholder passes

2024-06-23 Thread Osamu Watanabe
This commit adds support for placeholder pass parsing Signed-off-by: Osamu Watanabe --- libavcodec/jpeg2000.h | 2 + libavcodec/jpeg2000dec.c | 292 +++-- libavcodec/jpeg2000htdec.c | 18 +-- 3 files changed, 257 insertions(+), 55 deletions(-) diff --gi

[FFmpeg-devel] [PATCH v3 3/3] avcodec/jpeg2000dec: Fix HT decoding

2024-06-23 Thread Osamu Watanabe
This commit fixes wrong treatment of MAGBP value in Ccap15 and bugs in HT block decoding. Signed-off-by: Osamu Watanabe --- libavcodec/jpeg2000dec.c | 79 +++--- libavcodec/jpeg2000htdec.c | 208 + libavcodec/jpeg2000htdec.h | 2 +- 3 files change

[FFmpeg-devel] [PATCH v3 1/2] lavc/hevcdec: Put slice address checking after hwaccel decode slice

2024-06-23 Thread fei . w . wang-at-intel . com
From: Fei Wang Slice address tab only been updated in software decode slice data. Fixes hwaccel decoding after d725c737fe2a19091b481d4d115fd939e0a674b2. Signed-off-by: Fei Wang --- libavcodec/hevc/hevcdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a

[FFmpeg-devel] [PATCH v3 2/2] lavc/hevcdec: Update slice index before hwaccel decode slice

2024-06-23 Thread fei . w . wang-at-intel . com
From: Fei Wang Otherwise, slice index will never update for hwaccel decode, and slice RPL will be always overlap into first one which use slice index to construct. Fixes hwaccel decoding after 47d34ba7fbb81 Signed-off-by: Fei Wang --- 1. Update commit message. libavcodec/hevc/hevcdec.c | 5 +

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/hevcdec: Update slice index before use it to construct slice RPL

2024-06-23 Thread Wang, Fei W
On Fri, 2024-06-21 at 10:48 +0200, Anton Khirnov wrote: > Quoting fei.w.wang-at-intel@ffmpeg.org (2024-06-19 04:27:22) > > From: Fei Wang > > > > Fixes regression from 47d34ba7fbb81 > > "fix bug" is not a meaningful description of the problem Added more explanation in V3. Thanks. Fei >