Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff

2024-06-07 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Since the C11 support is required, those GCC versions can no longer be > supported anyhow. > --- > libavutil/arm/bswap.h| 20 > libavutil/arm/intreadwrite.h | 91 > libavutil/intreadwrite.h | 4 +- > 3 files changed,

[FFmpeg-devel] [PATCH 1/4] avformat/rmdec: use 64bit for audio_framesize checks

2024-06-07 Thread Michael Niedermayer
It is not entirely clear what would prevent such overflow so even if it is not possible, it is better to use 64bit Fixes: CID1491898 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rmdec.c | 4 ++-- 1 file changed, 2 insertions

[FFmpeg-devel] [PATCH 2/4] avformat/rtmppkt: Simplify and deobfuscate amf_tag_skip() slightly

2024-06-07 Thread Michael Niedermayer
Found while reviewing: CID1530313 Untrusted loop bound Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rtmppkt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index bb7e6d20bc8..ec10c89

[FFmpeg-devel] [PATCH 3/4] avformat/rtmpproto: Use AV_DICT_MATCH_CASE instead of litteral number

2024-06-07 Thread Michael Niedermayer
Found by reviewing: CID1530166 Free of array-typed value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index bc3d9df7b9f..b3b1e

[FFmpeg-devel] [PATCH 4/4] avformat/rtpenc_rfc4175: Use 64bit in computation if copy_offset

2024-06-07 Thread Michael Niedermayer
Found while reviewing: CID1494441 Untrusted value as argument Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rtpenc_rfc4175.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpenc_rfc4175.c b/libavformat/rtpenc_rfc4175.c

Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff

2024-06-07 Thread Rémi Denis-Courmont
Le lauantaina 8. kesäkuuta 2024, 0.26.21 EEST Andreas Rheinhardt a écrit : > (Also: IIRC Clang actually parses inline assembler and optimize it; That sounds sketchy. While FFmpeg only uses inline assembler as intrinsic ersatz, other projects can and definitely do use them for weirder stuff. That

Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff

2024-06-07 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le lauantaina 8. kesäkuuta 2024, 0.26.21 EEST Andreas Rheinhardt a écrit : >> (Also: IIRC Clang actually parses inline assembler and optimize it; > > That sounds sketchy. While FFmpeg only uses inline assembler as intrinsic > ersatz, other projects can and definitely do use

[FFmpeg-devel] [PATCH] checkasm/lls: adjust buffer sizes and alignments

2024-06-07 Thread Rémi Denis-Courmont
var must be padded. param has `order + 1`, not `order` elements and is *not* over-aligned. --- tests/checkasm/lls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/lls.c b/tests/checkasm/lls.c index a2e8f11f99..b1db21cd56 100644 --- a/tests/checkasm/lls.c +

Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff

2024-06-07 Thread Rémi Denis-Courmont
Le lauantaina 8. kesäkuuta 2024, 9.23.48 EEST Andreas Rheinhardt a écrit : > Rémi Denis-Courmont: > > Le lauantaina 8. kesäkuuta 2024, 0.26.21 EEST Andreas Rheinhardt a écrit : > >> (Also: IIRC Clang actually parses inline assembler and optimize it; > > > > That sounds sketchy. While FFmpeg only u

<    1   2