Re: [FFmpeg-devel] [PATCH v2] libavdevice: Improve example in deprecation message for opengl and sdl

2024-06-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-04-29 23:53 +0200, Alexander Strasser via ffmpeg-devel wrote: > When piping ffmpeg into ffplay both programs write a status line in > the terminal. That causes flickering and invisibility of one or the > other status line. > > As compromise set ffplay log level to warning, so it doesn't sho

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-06-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote: > Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit > : > > > +static double ff_scalarproduct_double_c(const double *v1, > > > Don't use an ff_ prefix for a static function. > > I can see over 300 such identifiers in

[FFmpeg-devel] [PATCH 3/5] lavc/vp8dsp: rework R-V V idct_dc_add4y

2024-06-02 Thread Rémi Denis-Courmont
DCT-related FFmpeg functions often add an unsigned 8-bit sample to a signed 16-bit coefficient, then clip the result back to an unsigned 8-bit value. RISC-V has no signed 16-bit to unsigned 8-bit clip, so instead our most common sequence is: VWADDU.WV set SEW to 16 bits VMAX.VV zero

[FFmpeg-devel] [PATCH 4/5] lavc/vp7dsp: add R-V V vp7_idct_dc_add4uv

2024-06-02 Thread Rémi Denis-Courmont
This is almost the same story as vp7_idct_add4y. We just have to use strided loads of 2 64-bit elements to account for the different data layout in memory. T-Head C908: vp7_idct_dc_add4uv_c: 7.5 vp7_idct_dc_add4uv_rvv_i64: 2.0 vp8_idct_dc_add4uv_c: 6.2 vp8_idct_dc_add4uv_rvv_i32: 2.2 (

[FFmpeg-devel] [PATCH 5/5] lavc/vp8dsp: remove no longer used macros

2024-06-02 Thread Rémi Denis-Courmont
--- libavcodec/riscv/vp8dsp_rvv.S | 22 -- 1 file changed, 22 deletions(-) diff --git a/libavcodec/riscv/vp8dsp_rvv.S b/libavcodec/riscv/vp8dsp_rvv.S index c83f9eec71..82489a7f14 100644 --- a/libavcodec/riscv/vp8dsp_rvv.S +++ b/libavcodec/riscv/vp8dsp_rvv.S @@ -194,28 +194,6 @

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-06-02 Thread Rémi Denis-Courmont
Le sunnuntaina 2. kesäkuuta 2024, 13.04.05 EEST Alexander Strasser via ffmpeg- devel a écrit : > On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote: > > Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a > > écrit> > > > > +static double ff_scalarproduct_double_c(const doub

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-06-02 Thread Rémi Denis-Courmont
Le sunnuntaina 2. kesäkuuta 2024, 13.30.50 EEST Rémi Denis-Courmont a écrit : > > I think Andreas remark is correct and it would be better to not use ff_ > > prefix wrongly when adding new code. > > IMO, it is worse. P.S.: It is a moot point because a *different* version of the patch was merged.

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-06-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-06-02 13:30 +0300, Rémi Denis-Courmont wrote: > Le sunnuntaina 2. kesäkuuta 2024, 13.04.05 EEST Alexander Strasser via ffmpeg- > devel a écrit : > > On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote: > > > Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a > > > écr

[FFmpeg-devel] [PATCH] libavfilter/signature_lookup: fix jaccard distance

2024-06-02 Thread Gerion Entrup
Actually, the jaccard distance is defined as D = 1 - intersect / union. Additionally, the distance value is compared against a constant that must be between 0 and 1, which is not the case here. Both facts together has led to the fact, that the function always returned a matching course signature. T

[FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread Kacper Michajłow
Fixes runtime error: member access within misaligned address for type 'av_alias64', which requires 8 byte alignment. VP9mv is aligned to 4 bytes, so instead doing 8 bytes clear, let's do 2 times 4 bytes. Signed-off-by: Kacper Michajłow --- libavcodec/vp9mvs.c | 3 ++- 1 file changed, 2 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread James Almer
On 6/2/2024 9:14 AM, Kacper Michajłow wrote: Fixes runtime error: member access within misaligned address for type 'av_alias64', which requires 8 byte alignment. VP9mv is aligned to 4 bytes, so instead doing 8 bytes clear, let's do 2 times 4 bytes. Signed-off-by: Kacper Michajłow --- libavc

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread James Almer
On 6/2/2024 10:06 AM, James Almer wrote: On 6/2/2024 9:14 AM, Kacper Michajłow wrote: Fixes runtime error: member access within misaligned address for type 'av_alias64', which requires 8 byte alignment. VP9mv is aligned to 4 bytes, so instead doing 8 bytes clear, let's do 2 times 4 bytes. Sig

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-02 Thread Sebastian Ramacher
On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > > On Sat, Mar 2, 2024, 18:19 Michael Niedermayer > > wrote: > > > > > On Sun, Mar 03, 2024 at 12:06:14AM +0100, Sebastian Ramacher wrote: > > > > On 2024-03-02 23:55:38 +0100, Michael Ni

Re: [FFmpeg-devel] [PATCH v5 00/10] aacdec: add a native xHE-AAC decoder

2024-06-02 Thread Lynne via ffmpeg-devel
On 30/05/2024 04:37, Lynne wrote: This commit adds a decoder for the frequency-domain part of USAC. Changes over version 4: - Actually reset entropy decoding upon configuration. - Support for LFE channels. Lynne (10): channel_layout: add new channel positions supported by xHE-AAC aacd

Re: [FFmpeg-devel] [PATCH v3] avformat/nutdec: Don't create inconsistent side data

2024-06-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in 65ddc74988245a01421a63c5cffa4d900c47117c. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/nutdec.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c > index 0bb7f154db

[FFmpeg-devel] [PATCH] lavu: bump minor and add APIchanges entries for the new channel positions

2024-06-02 Thread Lynne via ffmpeg-devel
--- doc/APIchanges | 6 ++ libavutil/version.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 60f056b863..e36a01336c 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,12 @@ The last version increases of all libraries w

Re: [FFmpeg-devel] [PATCH] lavu: bump minor and add APIchanges entries for the new channel positions

2024-06-02 Thread James Almer
On 6/2/2024 2:10 PM, Lynne via ffmpeg-devel wrote: --- doc/APIchanges | 6 ++ libavutil/version.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 60f056b863..e36a01336c 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,

[FFmpeg-devel] [PATCH] codec_desc: drop INTRA_ONLY flag for AAC

2024-06-02 Thread Lynne via ffmpeg-devel
Not valid anymore with xHE-AAC. --- libavcodec/codec_desc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index a28ef68061..a3b983b907 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -2697,7 +2697,7 @

Re: [FFmpeg-devel] [PATCH] lavu: bump minor and add APIchanges entries for the new channel positions

2024-06-02 Thread Lynne via ffmpeg-devel
On 02/06/2024 19:13, James Almer wrote: On 6/2/2024 2:10 PM, Lynne via ffmpeg-devel wrote: ---   doc/APIchanges  | 6 ++   libavutil/version.h | 2 +-   2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 60f056b863..e36a01336c 100644 --- a/d

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-02 Thread Michael Niedermayer
Hi On Sat, Jun 01, 2024 at 05:19:26PM +0200, Tomas Härdin wrote: [...] > > * Fund professional real live presence on multimedia / FOSS / > > buisness related > >   events. > > Also reasonable. I could help man a booth at IBC or any other event in > Europe Iam strongly in favor of that! Though

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-02 Thread Rémi Denis-Courmont
Le 2 juin 2024 21:01:43 GMT+03:00, Michael Niedermayer a écrit : >Hi > > >On Sat, Jun 01, 2024 at 05:19:26PM +0200, Tomas Härdin wrote: > >[...] > >> > * Fund professional real live presence on multimedia / FOSS / >> > buisness related >> >   events. >> >> Also reasonable. I could help man a b

Re: [FFmpeg-devel] [PATCH 03/16] avutil: add ioctl definitions for tegra devices

2024-06-02 Thread averne
Le 31/05/2024 à 23:16, Timo Rothenpieler a écrit : > On 31.05.2024 23:06, averne wrote: >> Le 30/05/2024 à 22:42, Rémi Denis-Courmont a écrit : >>> Le torstaina 30. toukokuuta 2024, 22.43.05 EEST averne a écrit : These files are taken with minimal modifications from nvidia's Linux4Tegra (

Re: [FFmpeg-devel] [PATCH 01/16] avutil/buffer: add helper to allocate aligned memory

2024-06-02 Thread averne
Le 31/05/2024 à 23:44, Michael Niedermayer a écrit : > On Fri, May 31, 2024 at 11:06:49PM +0200, averne wrote: >> Le 30/05/2024 à 22:38, Rémi Denis-Courmont a écrit : >>> Le torstaina 30. toukokuuta 2024, 22.43.03 EEST averne a écrit : This is useful eg. for memory-mapped buffers that need pag

Re: [FFmpeg-devel] [PATCH 16/17] avdevice/dshow: Initialize 2 pointers

2024-06-02 Thread Michael Niedermayer
On Mon, May 27, 2024 at 01:52:28AM +0200, Michael Niedermayer wrote: > Coverity claims these are used uninitilaized in CID1598561 Uninitialized > pointer write and CID1598565 Uninitialized pointer write > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavdevi

Re: [FFmpeg-devel] [PATCH 02/17] avcodec/dxva2: Initialize ConfigBitstreamRaw

2024-06-02 Thread Michael Niedermayer
On Mon, May 27, 2024 at 01:52:14AM +0200, Michael Niedermayer wrote: > Fixes: CID1591894 Uninitialized scalar variable > Fixes: CID1591906 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/dxva2.c | 2 +- > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/3] avformat/fwse: Remove always false expression

2024-06-02 Thread Michael Niedermayer
On Sat, May 25, 2024 at 01:18:13PM +0200, Michael Niedermayer wrote: > Fixes: CID1460758 Operands don't affect result > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/fwse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/tests/jpeg2000dwt: Use 64bit in err2 computation

2024-06-02 Thread Michael Niedermayer
On Sun, May 19, 2024 at 10:07:31PM +0200, Michael Niedermayer wrote: > This issue cannot happen with the current function parameters > > Fixes: CID1500309 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/tests/jpeg2000d

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/wavpackenc: Use unsigned for potential 31bit shift

2024-06-02 Thread Michael Niedermayer
On Sun, May 19, 2024 at 04:49:15AM +0200, Michael Niedermayer wrote: > Fixes: CID1465481 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpackenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will app

Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame()

2024-06-02 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1591924 Uninitialized scalar variable > Fixes: CID1591938 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/dxva2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext()

2024-06-02 Thread Michael Niedermayer
On Fri, May 17, 2024 at 01:19:28AM +0200, Michael Niedermayer wrote: > Helps: CID1548380 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/rv34.c | 2 ++ > 1 file changed, 2 insertions(+) will apply remaining patches [..

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/notchlc: Check init_get_bits8() for failure

2024-06-02 Thread Michael Niedermayer
On Mon, May 13, 2024 at 03:20:08AM +0200, Michael Niedermayer wrote: > Fixes: CID1500300 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/notchlc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) will apply the remai

Re: [FFmpeg-devel] [PATCH] movenc: Add an option for hiding fragments at the end

2024-06-02 Thread Martin Storsjö
On Sat, 1 Jun 2024, Dennis Sädtler via ffmpeg-devel wrote: Should the ftyp atom also be updated to remove brands no longer required for non-fragmented files? I'm not sure how important that is in real-world scenarios, so it might not be worth it to deal with some of the additional changes requi

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-02 Thread Tomas Härdin
sön 2024-06-02 klockan 20:01 +0200 skrev Michael Niedermayer: > Hi > > > On Sat, Jun 01, 2024 at 05:19:26PM +0200, Tomas Härdin wrote: > > [...] > > > > * Fund professional real live presence on multimedia / FOSS / > > > buisness related > > >   events. > > > > Also reasonable. I could help ma

Re: [FFmpeg-devel] [PATCH] area changed: scdet filter

2024-06-02 Thread radu.taraibuta
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: vineri, 31 mai 2024 00:32 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] area changed: scdet filter > > On Mon, May 13, 2024 at 06:52:19PM +0300, radu.taraib...@

Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame()

2024-06-02 Thread Michael Niedermayer
On Sun, Jun 02, 2024 at 09:10:33PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1591924 Uninitialized scalar variable > > Fixes: CID1591938 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcod

Re: [FFmpeg-devel] [PATCH] movenc: Add an option for hiding fragments at the end

2024-06-02 Thread Dennis Sädtler via ffmpeg-devel
On 2024-06-02 21:36, Martin Storsjö wrote: On Sat, 1 Jun 2024, Dennis Sädtler via ffmpeg-devel wrote: Should the ftyp atom also be updated to remove brands no longer required for non-fragmented files? I'm not sure how important that is in real-world scenarios, so it might not be worth it to de

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread Ronald S. Bultje
Hi, On Sun, Jun 2, 2024 at 9:12 AM James Almer wrote: > On 6/2/2024 10:06 AM, James Almer wrote: > > On 6/2/2024 9:14 AM, Kacper Michajłow wrote: > >> Fixes runtime error: member access within misaligned address > >> for type 'av_alias64', which requires 8 byte alignment. > >> > >> VP9mv is ali

[FFmpeg-devel] [PATCH 1/4] aacdec_usac: prevent get_bits(0) in get_escaped_value

2024-06-02 Thread Lynne via ffmpeg-devel
Some calls to get_escaped_value() specify 0 bits as the third value. This would result in get_bits(0), which is not a correct usage of the get_bits API. --- libavcodec/aac/aacdec_usac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aa

[FFmpeg-devel] [PATCH 2/4] aacdec_usac: error out on too many elements

2024-06-02 Thread Lynne via ffmpeg-devel
USAC supports up to 64 audio channels, but puts no limit on the total number of extensions that may be present. Which may mean that there's a single audio channel, with 65 thousand extension elements. We assume that 64 elements is the maximum for now. So check the value. --- libavcodec/aac/aacdec

[FFmpeg-devel] [PATCH 3/4] aacdec_usac: error out on receiving too many channels for the current layout

2024-06-02 Thread Lynne via ffmpeg-devel
Verify that we have a correct number of channels. --- libavcodec/aac/aacdec_usac.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index af3df3b449..0d5eb59de5 100644 --- a/libavcodec/aac/aacdec_usac.

[FFmpeg-devel] [PATCH 4/4] aacdec_usac: fix off by one error check on channel numbers

2024-06-02 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec_usac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 0d5eb59de5..80c6ab4e65 100644 --- a/libavcodec/aac/aacdec_usac.c +++ b/libavcodec/aac/aacdec_usac.c @@ -359,7 +359,7 @@ int ff_aac_

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread Kacper Michajlow
On Sun, 2 Jun 2024 at 23:17, Ronald S. Bultje wrote: > > Hi, > > On Sun, Jun 2, 2024 at 9:12 AM James Almer wrote: > > > On 6/2/2024 10:06 AM, James Almer wrote: > > > On 6/2/2024 9:14 AM, Kacper Michajłow wrote: > > >> Fixes runtime error: member access within misaligned address > > >> for type

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread Ronald S. Bultje
Hi, On Sun, Jun 2, 2024 at 6:43 PM Kacper Michajlow wrote: > On Sun, 2 Jun 2024 at 23:17, Ronald S. Bultje wrote: > > > > Hi, > > > > On Sun, Jun 2, 2024 at 9:12 AM James Almer wrote: > > > > > On 6/2/2024 10:06 AM, James Almer wrote: > > > > On 6/2/2024 9:14 AM, Kacper Michajłow wrote: > > >

[FFmpeg-devel] [PATCH] avcodec/aac/aacdec_usac: remove unnecessary cast

2024-06-02 Thread James Almer
Fixes "libavcodec/aac/aacdec_usac.c(543): error C2440: 'type cast': cannot convert from 'GetBitContext' to 'GetBitContext'" from msvc. Signed-off-by: James Almer --- libavcodec/aac/aacdec_usac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec_usac.c b/l

Re: [FFmpeg-devel] [PATCH] avcodec/aac/aacdec_usac: remove unnecessary cast

2024-06-02 Thread Lynne via ffmpeg-devel
On 03/06/2024 01:14, James Almer wrote: Fixes "libavcodec/aac/aacdec_usac.c(543): error C2440: 'type cast': cannot convert from 'GetBitContext' to 'GetBitContext'" from msvc. That's a very weird error. Why would they not permit casts of the same type? Signed-off-by: James Almer --- libavc

[FFmpeg-devel] [PATCH 1/9] avdevice/xcbgrab: Check sscanf() return

2024-06-02 Thread Michael Niedermayer
Alot more input checking can be performed, this is only checking the obvious missing case Fixes: CID1598562 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/xcbgrab.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --gi

[FFmpeg-devel] [PATCH 2/9] avformat/iamf_parse: Remove dead case

2024-06-02 Thread Michael Niedermayer
Fixes: CID1559546 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/iamf_parse.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c index f8074c2de1c..312090b247c 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 3/9] avformat/imfdec: Simplify get_next_track_with_minimum_timestamp()

2024-06-02 Thread Michael Niedermayer
This also makes the code more robust Fixes: CID1512414 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/imfdec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c ind

[FFmpeg-devel] [PATCH 4/9] avformat/img2dec: Move DQT after unrelated if()

2024-06-02 Thread Michael Niedermayer
Fixes: CID1494636 Missing break in switch Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/img2dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index a40675d4341..f8c1c0f3136 100644 --- a/l

[FFmpeg-devel] [PATCH 5/9] avformat/img2dec: Little JFIF / Exif cleanup

2024-06-02 Thread Michael Niedermayer
This changes the behavior and makes it behave how it probably was intended. Either way this is unlikely to result in any user visible change Fixes: CID1494637 Missing break in switch Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/img2dec.c | 6 -- 1 fil

[FFmpeg-devel] [PATCH 6/9] avformat/libzmq: Check av_strstart()

2024-06-02 Thread Michael Niedermayer
Fixes: CID1453457 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/libzmq.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c index 04c72ac601c..f4bb849e46b 100644 --- a/l

[FFmpeg-devel] [PATCH 7/9] avformat/matroskadec: Assert that num_levels is non negative

2024-06-02 Thread Michael Niedermayer
Maybe Closes: CID1452496 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 13959f8b3d4..3

[FFmpeg-devel] [PATCH 8/9] avformat/mov: Use 64bit in intermediate for current_dts

2024-06-02 Thread Michael Niedermayer
Fixes: CID1500304 Unintentional integer overflow Fixes: CID1500318 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov

[FFmpeg-devel] [PATCH 9/9] avformat/mov: Use int64_t in intermediate for corrected_dts

2024-06-02 Thread Michael Niedermayer
Fixes: CID1500312 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d15b7b70c50..93643304212 100644 --- a/libavf

Re: [FFmpeg-devel] [PATCH] x86/float_dsp: add SSE2 and AVX versions of scalarproduct_double

2024-06-02 Thread James Almer
On 5/31/2024 4:47 PM, James Almer wrote: Signed-off-by: James Almer --- libavutil/x86/float_dsp.asm| 52 ++ libavutil/x86/float_dsp_init.c | 5 2 files changed, 57 insertions(+) diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm

Re: [FFmpeg-devel] [PATCH 3/9] avformat/imfdec: Simplify get_next_track_with_minimum_timestamp()

2024-06-02 Thread Pierre-Anthony Lemieux
LGTM On Sun, Jun 2, 2024 at 7:16 PM Michael Niedermayer wrote: > > This also makes the code more robust > > Fixes: CID1512414 Uninitialized pointer read > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/imfdec.c | 5 + > 1 file changed, 1 inserti

[FFmpeg-devel] [PATCH] libavfi/dnn: enable LibTorch xpu device option support

2024-06-02 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Add xpu device support to libtorch backend. To enable xpu support you need to add "-Wl,--no-as-needed -lintel-ext-pt-gpu -Wl,--as-needed" to "--extra-libs" when configure ffmpeg. Signed-off-by: Wenbin Chen --- libavfilter/dnn/dnn_backend_torch.cpp | 16 +++- 1 fi

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-02 Thread Thilo Borgmann via ffmpeg-devel
Am 02.06.24 um 22:14 schrieb Tomas Härdin: sön 2024-06-02 klockan 20:01 +0200 skrev Michael Niedermayer: Hi On Sat, Jun 01, 2024 at 05:19:26PM +0200, Tomas Härdin wrote: [...] * Fund professional real live presence on multimedia / FOSS / buisness related   events. Also reasonable. I coul