I suggest fixing Line 416 and 430 as follows.
> - int cond = stream->pos <= length;
> + int cond = stream->pos < length;
Those are also related to the issue (ticket 10905.)
> On May 20, 2024, at 1:09, Pierre-Anthony Lemieux wrote:
>
> On Sun, May 19, 2024 at 9:02?AM Andreas Rheinhardt
> wrot
On Wo, 2024-05-08 at 09:11 +0200, David Rosca wrote:
> ---
> v2: No changes
>
> libavcodec/vaapi_av1.c | 2 +-
> libavcodec/vaapi_decode.c | 3 ++-
> libavcodec/vaapi_decode.h | 1 +
> libavcodec/vaapi_h264.c | 2 +-
> libavcodec/vaapi_hevc.c | 4 ++--
> libavcodec/vaapi_mjpeg.c | 2 +-
>
On Wo, 2024-05-08 at 17:41 +0200, David Rosca wrote:
> If there are missing references, h264 decode does error concealment
> by copying previous refs which means there will be duplicated surfaces.
> Check long_ref and frame_idx in addition to surface when looking for
> the other field to avoid tryi
Quoting Marton Balint (2024-05-18 18:11:12)
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index cba63dab5f..6e23079ceb 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1524,6 +1524,33 @@ static Demuxer *demux_alloc(void)
> return d;
> }
>
> +stat
Quoting Anton Khirnov (2024-05-27 09:51:49)
> I don't like modifying OptionsContext in its consumers (it's const for a
> reason), and it's probably not even necessary - if the semantics of the
> option is "override demuxer-reported channel layout", then you can just
> override the demuxer-reported
Quoting Marton Balint (2024-05-19 21:52:57)
> The code only set the channel layout of the AVFormatContext, so the user could
> not override the channel layout if the demuxer did not have such parameter.
>
> This used to work via the respective AVCodecContext option, but since
> 639c2f00497257cb60e
Quoting Michael Niedermayer (2024-04-27 02:36:23)
> This allows detecting issues in side data related code, same as what
> framecrc does for before already for packet data itself.
>
> Signed-off-by: Michael Niedermayer
> ---
I am against this patch. Checksumming side data is a fundamentally wron
Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
> ...its an enum entry. Do you want a design document and a proposal?
> You could talk to the person who did the research about it, JEEB.
> Why wait at all? There's only you and JEEB that care about channel
> layouts, you can review it and give
On 27/05/2024 10:40, Anton Khirnov wrote:
Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
...its an enum entry. Do you want a design document and a proposal?
You could talk to the person who did the research about it, JEEB.
Why wait at all? There's only you and JEEB that care about channel
Quoting Lynne via ffmpeg-devel (2024-05-27 10:54:40)
> On 27/05/2024 10:40, Anton Khirnov wrote:
> > Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
> >> ...its an enum entry. Do you want a design document and a proposal?
> >> You could talk to the person who did the research about it, JEEB.
>
On 27/05/2024 11:07, Anton Khirnov wrote:
Quoting Lynne via ffmpeg-devel (2024-05-27 10:54:40)
On 27/05/2024 10:40, Anton Khirnov wrote:
Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
...its an enum entry. Do you want a design document and a proposal?
You could talk to the person who did
On Sun, May 26, 2024 at 5:16 PM Frank Plowman wrote:
> Per VVCv3 p. 157, the collocated reference picture used in temporal
> motion vector prediction must have RprConstraintsActiveFlag equal to
> zero and the same CTU size as the current picture. Add these checks,
> fixing crashes decoding some
MediaCodec supports parameter "video-bitrate" to change the bitrate
on fly. This commit add possibility to use it.
It adds option -bitrate_ctrl_socket to the encoder which makes
the encoder to create an UNIX socket and listen for messages
to change the bitrate.
An example of ffmpeg execution:
Anton Khirnov:
> Quoting Andreas Rheinhardt (2024-04-17 11:29:18)
>> Anton Khirnov:
>>> It is more efficient and easier to manage.
>>> ---
>>
>> Allocating structures used by slice contexts jointly has the potential
>> downside of false sharing if the structures are not sufficiently
>> aligned/padd
parse irot box to get the transformative heif
item rotation angle.
Signed-off-by: Hacene Bouaroua
---
libavformat/avformat.h | 5 +
libavformat/isom.h | 1 +
libavformat/mov.c | 25 +
3 files changed, 31 insertions(+)
diff --git a/libavformat/avformat.h b
From: Diego Felix de Souza
The Constant Quality (CQ) range for the AV1 codec is actually 0 to
63, contrary to what is stated in the header and documentation.
Signed-off-by: Diego Felix de Souza
---
libavcodec/nvenc_av1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/l
instead of just resyncing and skipping a bunch of TS packets, leading to
a loss of frames.
Before this, a stray byte with the value of 0x47 in TP_extra_header
would throw off the detection of where TS packets start.
A typical file that could cause issues would look like this:
0300: 238f
On 5/27/2024 5:15 AM, Anton Khirnov wrote:
Quoting Michael Niedermayer (2024-04-27 02:36:23)
This allows detecting issues in side data related code, same as what
framecrc does for before already for packet data itself.
Signed-off-by: Michael Niedermayer
---
I am against this patch. Checksumm
That patch is a key part to support new features of amd next generation
gpu product.
Please review the attached patch and provide your feedback.
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To
parse irot box to get the transformative heif item rotation angle.
Signed-off-by: Hacene Bouaroua
---
libavformat/avformat.h | 5 +
libavformat/isom.h | 1 +
libavformat/mov.c | 25 +
3 files changed, 31 insertions(+)
diff --git a/libavformat/avformat.h b/
The generally expected behaviour is for software to append from the
current position, not to keep resetting. See also how shell works:
# (foo && bar) > file
...would normally concatenate the output of both commands to file.
If foo seeks like lavf, bar would instead overwrite the output of
foo (po
> On May 27, 2024, at 23:22, Rémi Denis-Courmont wrote:
>
> The generally expected behaviour is for software to append from the
> current position, not to keep resetting. See also how shell works:
> # (foo && bar) > file
> ...would normally concatenate the output of both commands to file.
>
>
---
libavcodec/riscv/lpc_init.c | 2 +-
libavcodec/riscv/lpc_rvv.S | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/riscv/lpc_init.c b/libavcodec/riscv/lpc_init.c
index f21eca4caa..d9bcbbe604 100644
--- a/libavcodec/riscv/lpc_init.c
+++ b/libavcodec/riscv/lpc_init.c
A constant (-1) is added to the length value, so we can have an added
for free, and optimise the addition away if the addend is exactly 1.
---
libavcodec/riscv/lpc_rvv.S | 2 +-
libavutil/riscv/asm.S | 9 ++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/libavcodec/risc
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks.
---
tests/checkasm/lpc.c | 51 +---
1 file changed, 48 insertions(+), 3 deletions(-)
diff --gi
Le maanantaina 27. toukokuuta 2024, 19.01.59 EEST Rémi Denis-Courmont a écrit
:
> ---
> Changes since v2:
> - Scale the error factor to length since this computes sums.
> - Check the last element from results.
> - Use fixed vector size for benchmarks.
- Test real use lag values (from FATE).
- Do n
From: Pierre-Anthony Lemieux
Addresses https://trac.ffmpeg.org/ticket/10905
Co-authored-by: Osamu Watanabe
Signed-off-by: Pierre-Anthony Lemieux
---
libavcodec/jpeg2000htdec.c | 122 ---
tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 | 2 +-
2 files changed, 63 i
On Mon, May 27, 2024 at 03:33:28PM +0200, Hacene Bouaroua wrote:
> parse irot box to get the transformative heif
> item rotation angle.
>
> Signed-off-by: Hacene Bouaroua
> ---
> libavformat/avformat.h | 5 +
> libavformat/isom.h | 1 +
> libavformat/mov.c | 25 +++
Will apply on 5/30 unless I hear otherwise.
On Mon, May 27, 2024 at 9:25 AM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Addresses https://trac.ffmpeg.org/ticket/10905
>
> Co-authored-by: Osamu Watanabe
> Signed-off-by: Pierre-Anthony Lemieux
> ---
> libavcodec/jpeg2000htdec.c |
Andreas Rheinhardt:
> The result might not fit into 32bit if an image has gigantic
> dimensions and one of the planes has a dominant value
> (particularly so if said value is big).
>
> Fixes Coverity issues #1598399, #1598401, #1598402, #1598403, #1598404.
>
> Signed-off-by: Andreas Rheinhardt
>
Andreas Rheinhardt:
> Done in 0df18f29ae218f30b3ecff7c930176b8ebee56aa,
> accidentally undone in 163e737c1793eeea9c2df15298253ffc04906afe.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/af_afir.c | 81 ++-
> libavfilter/af_afir.h | 110
applied, thanks
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Lynne via ffmpeg-devel:
> This commit adds a decoder for the frequency-domain part of USAC.
>
> What works:
> - Mono
> - Stereo (no prediction)
> - Stereo (mid/side coding)
> - Stereo (complex prediction)
>
> What's left:
> - Speech coding
>
> Known issues:
> - Desync with certain sequence
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-04-27 02:36:23)
> > This allows detecting issues in side data related code, same as what
> > framecrc does for before already for packet data itself.
> >
> > Signed-off-by: Michael Niedermayer
> > -
On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
Quoting Michael Niedermayer (2024-04-27 02:36:23)
This allows detecting issues in side data related code, same as what
framecrc does for before already for packet data itself.
Signed
If there are no zero bytes, t2 equals -1. The code cannot simply fall
through to the match case.
---
libavcodec/riscv/startcode_rvv.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/riscv/startcode_rvv.S b/libavcodec/riscv/startcode_rvv.S
index 7c43b1d7f3..36a3369431 100644
--- a/
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks.
---
tests/checkasm/lpc.c | 51 +---
1 file
On 5/27/2024 4:10 PM, James Almer wrote:
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks.
---
tests/checkasm/lpc.c | 51 +++
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
> On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
> > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
> > > Quoting Michael Niedermayer (2024-04-27 02:36:23)
> > > > This allows detecting issues in side data related code,
Le maanantaina 27. toukokuuta 2024, 22.15.40 EEST James Almer a écrit :
> On 5/27/2024 4:10 PM, James Almer wrote:
> > On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
> >> ---
> >> Changes since v2:
> >> - Scale the error factor to length since this computes sums.
> >> - Check the last element fro
On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote:
> On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
> > On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
> > > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
> > > > Quoting Michael Niedermayer (2024-04-
On 5/27/2024 4:20 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
Quoting Michael Niedermayer (2024-04-27 02:36:23)
This allows detecting
On 5/27/2024 4:31 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
Qu
On Mon, May 27, 2024 at 04:32:43PM -0300, James Almer wrote:
> On 5/27/2024 4:20 PM, Michael Niedermayer wrote:
> > On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
> > > On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
> > > > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wro
On Mon, May 27, 2024 at 04:33:21PM -0300, James Almer wrote:
> On 5/27/2024 4:31 PM, Michael Niedermayer wrote:
> > On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote:
> > > On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
> > > > On 5/27/2024 3:11 PM, Michael Niedermay
On 5/27/2024 4:50 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 04:33:21PM -0300, James Almer wrote:
On 5/27/2024 4:31 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
On 5
On Wed, May 8, 2024 at 3:13 AM David Rosca wrote:
>
> ---
> v2: No changes
>
> libavcodec/vaapi_av1.c| 2 +-
> libavcodec/vaapi_decode.c | 3 ++-
> libavcodec/vaapi_decode.h | 1 +
> libavcodec/vaapi_h264.c | 2 +-
> libavcodec/vaapi_hevc.c | 4 ++--
> libavcodec/vaapi_mjpeg.c | 2 +-
>
On Wed, May 8, 2024 at 3:13 AM David Rosca wrote:
>
> When there are multiple tiles in one slice buffer, use multiple slice
> params to avoid sending the same slice buffer multiple times and thus
> increasing the bitstream size the driver will need to upload to hw.
> ---
> v2: Avoid allocations ev
Hi,
still missing documentation and might be optimized (and maybe extended
to support gray16 - this should be simple), comments are welcome.
>From 5018f5b887ef84c19cbf3f76c6607b49a6c99f2a Mon Sep 17 00:00:00 2001
From: Stefano Sabatini
Date: Mon, 27 May 2024 11:19:08 +0200
Subject: [PATCH] lavfi:
On Fri, May 24, 2024 at 10:52:02PM +0200, Michael Niedermayer wrote:
> On Fri, May 24, 2024 at 08:21:05AM +0200, Andreas Rheinhardt wrote:
> > Michael Niedermayer:
> > > Fixes: CID1473512 Unused value
> > > Fixes: CID1529228 Unused value
> > >
> > > Sponsored-by: Sovereign Tech Fund
> > > Signed-o
On Tue, May 21, 2024 at 10:07:56AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Helps: CID1524598 Improper use of negative value
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer
> > ---
> > tools/enc_recon_frame_test.c | 3 +++
> > 1 file changed, 3
On Tue, May 21, 2024 at 04:46:46AM +0200, Michael Niedermayer wrote:
> Fixes: CID1538296 Structurally dead code
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> libavutil/random_seed.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
will apply pat
On Sat, May 18, 2024 at 05:57:35AM +0200, Michael Niedermayer wrote:
> Helps: CID1441167 Unchecked return value
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/tiff.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
will apply the patches w
On 5/27/2024 4:15 PM, James Almer wrote:
On 5/27/2024 4:10 PM, James Almer wrote:
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks.
-
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc2enc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index 365d43146d..b496f67d3a 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -106,7 +106,7 @@ typedef struct Pl
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc2enc.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index b496f67d3a..4dcf423ef1 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -106,7 +106,7 @@ ty
ff_get_encode_buffer() already emits an error message of its own.
While just at it, also check for ret < 0 instead of just ret != 0.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc2enc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/v
args->bytes here already includes prefix_bytes (see
SSIZE_ROUND macro), so including it here again and
forgetting it when offsetting skip seems wrong.
This only works because prefix_bytes is currently
always zero in this encoder.
(This has been added in b88be742fac7a77a8095e8155ba8790db4b77568
with
These strings are so short that they can be put directly
into the containing structure, avoiding the pointer
and putting it into .rodata.
Also use chars for interlaced and level while at it, as
these are so small.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc2enc.c | 5 +++--
1 file change
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc2enc.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index 8b9641916a..e72c15e6f2 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -105,9 +105,11 @@ t
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc2enc.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index e72c15e6f2..1d0754c09b 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -1026,9 +1026,9 @@ stati
On 5/27/2024 9:22 PM, James Almer wrote:
On 5/27/2024 4:15 PM, James Almer wrote:
On 5/27/2024 4:10 PM, James Almer wrote:
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
On 5/27/2024 11:49 PM, Andreas Rheinhardt wrote:
These strings are so short that they can be put directly
into the containing structure, avoiding the pointer
and putting it into .rodata.
Also use chars for interlaced and level while at it, as
these are so small.
Signed-off-by: Andreas Rheinhardt
Le 28 mai 2024 06:07:41 GMT+03:00, James Almer a écrit :
>On 5/27/2024 11:49 PM, Andreas Rheinhardt wrote:
>> These strings are so short that they can be put directly
>> into the containing structure, avoiding the pointer
>> and putting it into .rodata.
>> Also use chars for interlaced and level
64 matches
Mail list logo
