Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-24 Thread Thilo Borgmann via ffmpeg-devel
Am 22.05.24 um 14:27 schrieb Rémi Denis-Courmont: Le 22 mai 2024 00:34:03 GMT+03:00, Thilo Borgmann via ffmpeg-devel a écrit : I hope you realize what you argue in favor of. Yes. It's quoted above. Are you claiming that *no* review is better than *some* review done in *public* for all to

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-24 Thread Rémi Denis-Courmont
Le 24 mai 2024 10:11:49 GMT+03:00, Thilo Borgmann via ffmpeg-devel a écrit : >Unfortunately true, yet you argue to pay more companies to do reviews instead >having reviews funded by unbiased means. That is a blatant and libelous lie and will be reported to CC promptly. ___

[FFmpeg-devel] [PATCH 3/4] avfilter/af_aiir: Remove dead code

2024-05-24 Thread Andreas Rheinhardt
Fixes Coverity issue #1468252. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_aiir.c | 4 1 file changed, 4 deletions(-) diff --git a/libavfilter/af_aiir.c b/libavfilter/af_aiir.c index b5e5b41db6..324fc367a3 100644 --- a/libavfilter/af_aiir.c +++ b/libavfilter/af_aiir.c @@ -820,7 +8

[FFmpeg-devel] [PATCH 4/4] avfilter/af_aiir: Avoid unchecked allocation

2024-05-24 Thread Andreas Rheinhardt
W has not been checked at all; allocate it jointly with M to fix this. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_aiir.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_aiir.c b/libavfilter/af_aiir.c index 324fc367a3..7bd9e37e43 100644 --- a/li

[FFmpeg-devel] [PATCH 1/4] avfilter/vf_signalstats: Use 64bit for processing histogram

2024-05-24 Thread Andreas Rheinhardt
The result might not fit into 32bit if an image has gigantic dimensions and one of the planes has a dominant value (particularly so if said value is big). Fixes Coverity issues #1598399, #1598401, #1598402, #1598403, #1598404. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_signalstats.c |

[FFmpeg-devel] [PATCH] avfilter/af_afir: Merge header into af_afir.c

2024-05-24 Thread Andreas Rheinhardt
Done in 0df18f29ae218f30b3ecff7c930176b8ebee56aa, accidentally undone in 163e737c1793eeea9c2df15298253ffc04906afe. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_afir.c | 81 ++- libavfilter/af_afir.h | 110 -- 2 files ch

Re: [FFmpeg-devel] [PATCH] tests/checkasm/vvc_alf: Don't use declare_func_emms

2024-05-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > VVC does not have MMX code at all, so one can use the stricter > declare_func to also check that the MMX state has not been clobbered > with (which would be an ABI violation). > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/vvc_alf.c | 4 ++-- > 1 file changed,

Re: [FFmpeg-devel] [PATCH 03/10] lavc/hevcdec: allocate local_ctx as array of structs rather than pointers

2024-05-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-17 11:29:18) > Anton Khirnov: > > It is more efficient and easier to manage. > > --- > > Allocating structures used by slice contexts jointly has the potential > downside of false sharing if the structures are not sufficiently > aligned/padded. What do you sugg

Re: [FFmpeg-devel] [PATCH 06/10] lavc/hevc_ps/HEVCSPS: change flags into size-1 bitfields

2024-05-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-11 13:55:05) > Anton Khirnov: > > Reduces sizeof(HEVCSPS) by 96 bytes. > > > > Also improve flag names: drop redundant suffixes and prefixes, and > > consistently use disabled/enabled. > > --- > > libavcodec/dxva2_hevc.c| 24 - > > libavcodec/he

Re: [FFmpeg-devel] [PATCH 09/10] lavc/hevc_ps: reduce the size of ShortTermRPS.used

2024-05-24 Thread Anton Khirnov
Quoting James Almer (2024-04-10 15:42:51) > > > On 4/10/2024 10:31 AM, Anton Khirnov wrote: > > diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c > > index 5d7c6b1b64..c2b65fc201 100644 > > --- a/libavcodec/vulkan_hevc.c > > +++ b/libavcodec/vulkan_hevc.c > > @@ -374,17 +374,17 @@

Re: [FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-24 Thread Hendrik Leppkes
On Thu, May 23, 2024 at 10:38 AM wrote: > > From: llyyr > > Fields under the segmentation switch are never reset on a new frame, and > retain the value from the previous frame. This bugs out a bunch of > hwaccel drivers when segmentation is disabled but update_map isn't > reset because they don't

Re: [FFmpeg-devel] [PATCH 10/10] lavc/hevc_ps: compactify ShortTermRPS

2024-05-24 Thread Anton Khirnov
Quoting James Almer (2024-04-11 14:35:37) > > diff --git a/libavcodec/hevc_ps.h b/libavcodec/hevc_ps.h > > index 92b85115f7..a8d07aa1b2 100644 > > --- a/libavcodec/hevc_ps.h > > +++ b/libavcodec/hevc_ps.h > > @@ -70,16 +70,19 @@ typedef struct HEVCHdrParams { > > } HEVCHdrParams; > > > > typ

[FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Michael Henrik Bodenhoff via ffmpeg-devel
Hi , my team recently had to abandon switching to using FFmpeg from specific decoder implementations (NvDEC, Intel Media SDK , IPP and quite a few codec specific decoders) because of big performance issues because of the way FFmpeg works….. or at least we think it is (we’re FFmpeg noobs 😃 ) I

[FFmpeg-devel] [PATCH 2/4] avformat/matroskadec: Add assert to silence Coverity false positive

2024-05-24 Thread Andreas Rheinhardt
Helps with Coverity issue #1452453. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 2f07e11d87..13959f8b3d 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/ma

Re: [FFmpeg-devel] [PATCH] lavc/rv32dsp: remove stray load immediate

2024-05-24 Thread Rémi Denis-Courmont
Le 24 mai 2024 09:44:50 GMT+03:00, Andreas Rheinhardt a écrit : >Rémi Denis-Courmont: >> --- >> libavcodec/riscv/rv34dsp_rvv.S | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavcodec/riscv/rv34dsp_rvv.S b/libavcodec/riscv/rv34dsp_rvv.S >> index f1f6345012..8eda01665d 100644 >> -

Re: [FFmpeg-devel] [PATCH v5 0/4] Explain what "context" means

2024-05-24 Thread Andrew Sayers
On Fri, May 24, 2024 at 03:50:52AM +0200, Michael Niedermayer wrote: > On Thu, May 23, 2024 at 09:00:39PM +0100, Andrew Sayers wrote: > > Imagine you wanted to write a system that nudged people to try new codecs. > > It might say e.g. "you seem to be using H.264, would you like to try H.265?" > >

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-24 Thread Andrew Sayers
On Fri, May 17, 2024 at 03:49:58PM +0200, Michael Niedermayer wrote: > Hi all > > Before this is forgotten again, better start some dicsussion too early than > too late This comment is inspired by the other subthread, but not directly in reply to it. I'm replying to this post rather than get in

Re: [FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Andreas Rheinhardt
Michael Henrik Bodenhoff via ffmpeg-devel: > Hi , > > my team recently had to abandon switching to using FFmpeg from specific > decoder implementations (NvDEC, Intel Media SDK , IPP and quite a few codec > specific decoders) because of big performance issues because of the way > FFmpeg works…..

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/signature_lookup: fix possible division by zero

2024-05-24 Thread Gerion Entrup
Am Dienstag, 7. Mai 2024, 19:46:28 MESZ schrieb Michael Niedermayer: > On Mon, May 06, 2024 at 12:30:39AM +0200, Gerion Entrup wrote: > > --- > > libavfilter/signature_lookup.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfilter/signature_lookup.c b/libavfil

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-24 Thread Thilo Borgmann via ffmpeg-devel
On 24.05.24 11:56, Andrew Sayers wrote: On Fri, May 17, 2024 at 03:49:58PM +0200, Michael Niedermayer wrote: Hi all Before this is forgotten again, better start some dicsussion too early than too late This comment is inspired by the other subthread, but not directly in reply to it. I'm r

Re: [FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Andrey Turkin
Have to say, this issue has been a long grievance of mine. There is no reason to delay frames when the decoder is set up to ignore B frames as there is no reordering to be done; ideally this should be zero-delay case (packet goes in, frame goes out) yet the most common decoders delay frames anyway,

Re: [FFmpeg-devel] [PATCH 09/10] lavc/hevc_ps: reduce the size of ShortTermRPS.used

2024-05-24 Thread James Almer
On 5/24/2024 6:11 AM, Anton Khirnov wrote: Quoting James Almer (2024-04-10 15:42:51) On 4/10/2024 10:31 AM, Anton Khirnov wrote: diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c index 5d7c6b1b64..c2b65fc201 100644 --- a/libavcodec/vulkan_hevc.c +++ b/libavcodec/vulkan_hevc.c @

Re: [FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Ronald S. Bultje
Hi, On Fri, May 24, 2024 at 7:39 AM Andrey Turkin wrote: > Have to say, this issue has been a long grievance of mine. There is no > reason to delay frames when the decoder is set up to ignore B frames > as there is no reordering to be done > Frame threading? Ronald

Re: [FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Anton Khirnov
Quoting Andrey Turkin (2024-05-24 13:39:15) > Have to say, this issue has been a long grievance of mine. There is no > reason to delay frames when the decoder is set up to ignore B frames > as there is no reordering to be done; This only holds for pre-h264 codecs. -- Anton Khirnov __

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-24 Thread Nuo Mi
Hi @Andreas, Thank you for the review. Seems Christian still needs some guidance from you, see 1, 2, 3 On Thu, May 16, 2024 at 11:22 PM Christian wrote: > > > > On 14. May 2024, at 18:49, Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > > Christian Bartnik: > >> From: Thomas Si

Re: [FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Michael Henrik Bodenhoff via ffmpeg-devel
Hi Andrey , "when the decoder is set up to ignore B frames" How do you do that ? 😲 We must have missed something while we tried using FFmpeg, because we couldn't find a way of telling the decoder to ignore B frames, we actually got so desperate that we considered if it was possible to modify t

Re: [FFmpeg-devel] Flushing while decoding , but need already decoded frames

2024-05-24 Thread Andreas Rheinhardt
Michael Henrik Bodenhoff via ffmpeg-devel: > Hi Andrey , > > "when the decoder is set up to ignore B frames" > > How do you do that ? 😲 > > We must have missed something while we tried using FFmpeg, because we > couldn't find a way of telling the decoder to ignore B frames, we actually > got s

Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate probing of durations in mpegts/ps

2024-05-24 Thread Nicolas Gaullier
>Envoyé : lundi 29 avril 2024 19:35 >À : FFmpeg development discussions and patches >Objet : Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate probing >of durations in mpegts/ps > >>Envoyé : lundi 22 avril 2024 14:32 >>À : ffmpeg-devel@ffmpeg.org >>Objet : Re: [FFmpeg-devel] [PATCH v

Re: [FFmpeg-devel] [PATCH 0/1] avcodec/h264_parser: fix start of packet for some broken

2024-05-24 Thread Nicolas Gaullier
>Envoyé : mardi 26 mars 2024 16:10 > >This is a patch from my patch serie >https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10999 >Maybe it is easier to review it this way, independantly. >This patch shows some benefits by itself, but most importantly, it is required >for my patch serie t

[FFmpeg-devel] [PATCH] avcodec/flacdec: Remove unused variable

2024-05-24 Thread Andreas Rheinhardt
Forgotten in 0380a03f1f9d55e5690bb92bfa4897f2c728c1e5. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c index 460d3bc01e..ad921a1bd1 100644 --- a/libavcodec/flacdec.c +++ b/l

Re: [FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-05-24 Thread Wu, Tong1
>-Original Message- >From: ffmpeg-devel On Behalf Of Lynne >via ffmpeg-devel >Sent: Friday, May 24, 2024 12:11 AM >To: ffmpeg-devel@ffmpeg.org >Cc: Lynne >Subject: Re: [FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode: >introduce a base layer for vaapi encode > >On 20/05/2024 16:52, to

[FFmpeg-devel] [PATCH 1/2] checkasm/vp8dsp: share DSP context across tests

2024-05-24 Thread Rémi Denis-Courmont
This will simplify later changes. --- tests/checkasm/vp8dsp.c | 82 + 1 file changed, 34 insertions(+), 48 deletions(-) diff --git a/tests/checkasm/vp8dsp.c b/tests/checkasm/vp8dsp.c index 6e989819ef..12d2f62f2d 100644 --- a/tests/checkasm/vp8dsp.c +++ b/te

[FFmpeg-devel] [PATCH 2/2] checkasm/vp8dsp: add VP7 tests

2024-05-24 Thread Rémi Denis-Courmont
--- tests/checkasm/vp8dsp.c | 57 ++--- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/tests/checkasm/vp8dsp.c b/tests/checkasm/vp8dsp.c index 12d2f62f2d..e448fe89fc 100644 --- a/tests/checkasm/vp8dsp.c +++ b/tests/checkasm/vp8dsp.c @@ -18,8 +18

Re: [FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-05-24 Thread Lynne via ffmpeg-devel
On 24/05/2024 17:39, Wu, Tong1 wrote: -Original Message- From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Friday, May 24, 2024 12:11 AM To: ffmpeg-devel@ffmpeg.org Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode: introduce a base layer for vaapi e

Re: [FFmpeg-devel] [PATCH] avcodec/flacdec: Remove unused variable

2024-05-24 Thread James Almer
On 5/24/2024 12:37 PM, Andreas Rheinhardt wrote: Forgotten in 0380a03f1f9d55e5690bb92bfa4897f2c728c1e5. LGTM. And sorry, i was sure i had amended it locally when you pointed it out. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[FFmpeg-devel] [PATCH] lavc/flacdsp: do not assume maximum R-V VL

2024-05-24 Thread Rémi Denis-Courmont
This loop correctly assumes that VLMAX=16 (4x128-bit vectors with 32-bit elements) and 32 >= pred_order > 16. We need to alternate between VL=16 and VL=t2=pred_order-16 elements to add up to pred_order. The current code requests AVL=a2=pred_order elements. In QEMU and on thte K230 hardware, this s

[FFmpeg-devel] [PATCH] web/contact: relink code of conduct

2024-05-24 Thread Michael Niedermayer
Found-by: John Hawkinson Signed-off-by: Michael Niedermayer --- src/contact | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/contact b/src/contact index 982e9da..537ca9d 100644 --- a/src/contact +++ b/src/contact @@ -11,7 +11,7 @@ avoid https://en.wikipedia.

Re: [FFmpeg-devel] [PATCH v5 1/2] lavu/hashtable: create generic robin hood hash table

2024-05-24 Thread Michael Niedermayer
On Thu, May 23, 2024 at 03:10:04PM -0700, Connor Worley wrote: > Signed-off-by: Connor Worley > --- > libavutil/Makefile | 2 + > libavutil/hashtable.c | 192 > libavutil/hashtable.h | 91 + > libavutil/tests/hashtable.c

Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

2024-05-24 Thread Michael Niedermayer
On Thu, May 23, 2024 at 11:03:37AM +0200, Anton Khirnov wrote: > Share the code between encoding and decoding. Instead of checking every > stream's options dictionary (which is also used for other purposes), > track all used options in a dedicated dictionary. > --- > fftools/cmdutils.c| 17

[FFmpeg-devel] [PATCH] WIP: lavc/flacdsp: R-V Zvl256b lpc33

2024-05-24 Thread Rémi Denis-Courmont
flac_lpc_33_13_c: 499.7 flac_lpc_33_13_rvv_i64: 197.7 flac_lpc_33_16_c: 601.5 flac_lpc_33_16_rvv_i64: 195.2 flac_lpc_33_29_c: 1011.5 flac_lpc_33_29_rvv_i64: 300.7 flac_lpc_33_32_c: 1099.0 flac_lpc_33_32_rvv_i64: 296.7 --- libavcodec/riscv/flacdsp_init.c | 7 +-- libavcodec/riscv/flacdsp_rvv.S

Re: [FFmpeg-devel] [PATCH] WIP: lavc/flacdsp: R-V Zvl256b lpc33

2024-05-24 Thread Rémi Denis-Courmont
Le perjantaina 24. toukokuuta 2024, 23.04.40 EEST Rémi Denis-Courmont a écrit : > flac_lpc_33_13_c: 499.7 > flac_lpc_33_13_rvv_i64: 197.7 > flac_lpc_33_16_c: 601.5 > flac_lpc_33_16_rvv_i64: 195.2 > flac_lpc_33_29_c: 1011.5 > flac_lpc_33_29_rvv_i64: 300.7 > flac_lpc_33_32_c: 1099.0 > flac_lpc_33_32

Re: [FFmpeg-devel] [PATCH] avformat/demux: Remove dead stores

2024-05-24 Thread Michael Niedermayer
On Fri, May 24, 2024 at 08:21:05AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1473512 Unused value > > Fixes: CID1529228 Unused value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/demux.c | 5 - > > 1 file

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/signature_lookup: fix possible division by zero

2024-05-24 Thread Michael Niedermayer
On Fri, May 24, 2024 at 12:33:11PM +0200, Gerion Entrup wrote: > Am Dienstag, 7. Mai 2024, 19:46:28 MESZ schrieb Michael Niedermayer: > > On Mon, May 06, 2024 at 12:30:39AM +0200, Gerion Entrup wrote: > > > --- > > > libavfilter/signature_lookup.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 de

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-24 Thread Michael Niedermayer
Hi On Mon, May 20, 2024 at 09:51:25PM +0300, Rémi Denis-Courmont wrote: > Le sunnuntaina 19. toukokuuta 2024, 14.29.43 EEST Thilo Borgmann via ffmpeg- > devel a écrit : > > [...] > > > > >> * Fund administrative / maintainance work (one example is the mailman > > >> upgrade that is needed>> > >

[FFmpeg-devel] [PATCH 01/12] avutil/avassert: Add av_unreachable and av_assume() macros

2024-05-24 Thread Andreas Rheinhardt
Useful to let the compiler and static analyzers know that something is unreachable without adding an av_assert (which would be either dead for the compiler or add runtime overhead) for this. Signed-off-by: Andreas Rheinhardt --- I can add more macros if it is desired to differentiate between ASSE

[FFmpeg-devel] [PATCH 02/12] avcodec/amrwbdec: Mark default switch as unreachable

2024-05-24 Thread Andreas Rheinhardt
Alternative fix for Coverity issue #1473499 instead of a3bb269db92601e2dc0e99352468d02f7b26c7c2. Signed-off-by: Andreas Rheinhardt --- libavcodec/amrwbdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/amrwbdec.c b/libavcodec/amrwbdec.c index 21a730b835..de1e

[FFmpeg-devel] [PATCH 03/12] avcodec/proresenc_anatoliy: Mark impossible case as unreachable

2024-05-24 Thread Andreas Rheinhardt
Should fix Coverity issue 1440385. Signed-off-by: Andreas Rheinhardt --- Alternative to https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/327293.html libavcodec/proresenc_anatoliy.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/proresenc_anatoliy

[FFmpeg-devel] [PATCH 04/12] all: Use put_bytes_output() instead of put_bits_ptr - pb->buf

2024-05-24 Thread Andreas Rheinhardt
Avoids accessing internals of PutBitContext. Signed-off-by: Andreas Rheinhardt --- libavcodec/ljpegenc.c | 2 +- libavcodec/proresenc_anatoliy.c | 2 +- libavcodec/wmaenc.c | 2 +- libavformat/mpegenc.c | 4 ++-- libavformat/swfenc.c| 6 +++--- 5 files

[FFmpeg-devel] [PATCH 06/12] avcodec/pcm-dvdenc: Mark unreachable default cases as unreachable

2024-05-24 Thread Andreas Rheinhardt
Fixes a Clang warning when asserts are disabled: "variable 'quant' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]" Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvdenc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavco

[FFmpeg-devel] [PATCH 05/12] avcodec/mpeg4videodec: Mark impossible switch case as unreachable

2024-05-24 Thread Andreas Rheinhardt
Alternative to 8fc649b931a3cbc3a2dd9b50b75a9261a2fb4b49. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videodec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index df1e22207d..724ca202f5 100644 --- a/lib

[FFmpeg-devel] [PATCH 07/12] avcodec/vlc: Make code more readable with av_unreachable

2024-05-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vlc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index ee09d96fd6..f869c19650 100644 --- a/libavcodec/vlc.c +++ b/libavcodec/vlc.c @@ -49,10 +49,11 @@ v = *(const uint16_t *

[FFmpeg-devel] [PATCH 08/12] avcodec/utvideoenc: Remove always-false pixel format check

2024-05-24 Thread Andreas Rheinhardt
Mark it as unreachable instead. Signed-off-by: Andreas Rheinhardt --- libavcodec/utvideoenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/utvideoenc.c b/libavcodec/utvideoenc.c index 59e198458b..f347a33e6e 100644 --- a/libavcodec/utvideoenc.c +++ b/libavc

[FFmpeg-devel] [PATCH 09/12] avcodec/dolby_e_parse: Use av_unreachable instead of av_assert0(0)

2024-05-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dolby_e_parse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/dolby_e_parse.c b/libavcodec/dolby_e_parse.c index ffedcd99a4..62d38ab3a3 100644 --- a/libavcodec/dolby_e_parse.c +++ b/libavcodec/dolby_e_parse.c @@ -

[FFmpeg-devel] [PATCH 10/12] avcodec/put_bits: Allow to mark places where PutBitContext is flushed

2024-05-24 Thread Andreas Rheinhardt
This will allow the compiler to optimize the "is the cache full?" branches away from some put_bits(). Signed-off-by: Andreas Rheinhardt --- libavcodec/put_bits.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/put_bits.h b/libavcodec/put_bits.h index 4561dc131a..79bad1

[FFmpeg-devel] [PATCH 12/12] avcodec/speedhqenc: Use av_unreachable for unreachable condition

2024-05-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/speedhqenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/speedhqenc.c b/libavcodec/speedhqenc.c index 5b4ff4c139..29d603c729 100644 --- a/libavcodec/speedhqenc.c +++ b/libavcodec/speedhqenc.c @@ -128,7 +128,8 @@

[FFmpeg-devel] [PATCH 11/12] avcodec/e?ac3enc: Inform compiler about PutBitContext being blank

2024-05-24 Thread Andreas Rheinhardt
This turned out to be very beneficial: For GCC 13, the codesize of ac3_output_frame_header went down from 4522B to 1247B and from 10762B to 9298B for eac3_output_frame_header. For Clang 17, the numbers went down from 3923B to 2477B and from 8338B to 6548B (always with -O3). Signed-off-by: Andreas

Re: [FFmpeg-devel] FFmpeg 7.0.1

2024-05-24 Thread Michael Niedermayer
On Fri, Apr 05, 2024 at 02:15:58AM +0200, Michael Niedermayer wrote: > Hi all > > i intend to make a 7.0.1 in a few weeks for all the bug fixes that didnt > make it in 7.0 i intend to make 7.0.1 in the next days (maybe tomorrow) and 6.1.2 soon after that thx [..] -- Michael GnuPG fingerpr

[FFmpeg-devel] [PATCH 13/16] avcodec/wmaenc: Move transient PutBitContext from Context to stack

2024-05-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/wma.h| 2 -- libavcodec/wmaenc.c | 58 ++--- 2 files changed, 28 insertions(+), 32 deletions(-) diff --git a/libavcodec/wma.h b/libavcodec/wma.h index 3d0d872ea3..a909f5baa7 100644 --- a/libavcodec/wma.

[FFmpeg-devel] [PATCH 14/16] avcodec/wma: Mark ff_wma_end() as av_cold

2024-05-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/wma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wma.c b/libavcodec/wma.c index da9c914b57..257184c0d8 100644 --- a/libavcodec/wma.c +++ b/libavcodec/wma.c @@ -364,7 +364,7 @@ int ff_wma_total_gain_to_bits(int to

[FFmpeg-devel] [PATCH 15/16] avcodec/wmaenc: Use av_unreachable to mark unreachable codepath

2024-05-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/wmaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c index 7240c0895c..b4650d42b3 100644 --- a/libavcodec/wmaenc.c +++ b/libavcodec/wmaenc.c @@ -80,7 +80,7 @@ static av_cold int enco

[FFmpeg-devel] [PATCH 16/16] avcodec/wmaenc: Don't unnecessarily reset AVPacket.size

2024-05-24 Thread Andreas Rheinhardt
The packet is unreferenced generically lateron anyway. Signed-off-by: Andreas Rheinhardt --- libavcodec/wmaenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c index b4650d42b3..73ce0876c9 100644 --- a/libavcodec/wmaenc.c +++ b/libavcodec/wmaenc.c @@

[FFmpeg-devel] [PATCH v3 02/10] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-24 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors sligh

[FFmpeg-devel] [PATCH v3 00/10] aacdec: add a native xHE-AAC decoder

2024-05-24 Thread Lynne via ffmpeg-devel
This commit adds a decoder for the frequency-domain part of USAC. SBR is as of now not yet supported, will be added with a future patch. A known issue is that preroll frames (usually present quite often within the file, as xHE-AAC has real keyframes and I-frames) can cause artifacts. Lynne (10):

[FFmpeg-devel] [PATCH v3 03/10] aacdec: expose channel layout related functions

2024-05-24 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec.c | 73 - libavcodec/aac/aacdec.h | 19 +-- 2 files changed, 51 insertions(+), 41 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 35722f9b9b..40554ff9e4 100644 --- a/libavcodec/aac/aacdec.c

[FFmpeg-devel] [PATCH v3 04/10] aacdec: expose decode_tns

2024-05-24 Thread Lynne via ffmpeg-devel
USAC has the same syntax, with one minor change we can check for. --- libavcodec/aac/aacdec.c | 6 +++--- libavcodec/aac/aacdec.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 40554ff9e4..a7e5b2a369 100644 --- a/liba

[FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

2024-05-24 Thread Lynne via ffmpeg-devel
apichanges will be updated upon merging, as well as a version bump. --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 8a078d1601..4e19bbbd9e 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/ch

[FFmpeg-devel] [PATCH v3 07/10] aactab: add tables for the new USAC arithmetic coder

2024-05-24 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 376 libavcodec/aactab.h | 6 + 2 files changed, 382 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 8ce5e43974..dfb2dfd98d 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -1193,6 +11

[FFmpeg-devel] [PATCH v3 05/10] aacdec_dsp: implement 768-point transform and windowing

2024-05-24 Thread Lynne via ffmpeg-devel
Required for USAC --- libavcodec/aac/aacdec.c | 4 ++ libavcodec/aac/aacdec.h | 5 +++ libavcodec/aac/aacdec_dsp_template.c | 67 libavcodec/aac/aacdec_fixed.c| 2 + libavcodec/aac/aacdec_float.c| 4 ++ libavcodec/sinewin_f

[FFmpeg-devel] [PATCH v3 06/10] aactab: add deemphasis tables for USAC

2024-05-24 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 25 + libavcodec/aactab.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 3718b81a07..8ce5e43974 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -3377,3 +3377,28 @@ const DECLAR

[FFmpeg-devel] [PATCH v3 08/10] aactab: add new scalefactor offset tables for 96/768pt windows

2024-05-24 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 117 libavcodec/aactab.h | 4 ++ 2 files changed, 121 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index dfb2dfd98d..18afa69bad 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -154,6 +15

[FFmpeg-devel] [PATCH v3 09/10] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-24 Thread Lynne via ffmpeg-devel
This commit adds a decoder for the frequency-domain part of USAC. What works: - Mono - Stereo (no prediction) - Stereo (mid/side coding) - Stereo (complex prediction) What's left: - Speech coding Known issues: - Desync with certain sequences - Preroll crossover missing (shouldn't matter,

[FFmpeg-devel] [PATCH v3 10/10] fate: add tests for xHE-AAC

2024-05-24 Thread Lynne via ffmpeg-devel
Starting off small with a few features. Samples and reference decoded files copied from the official ISO reference suite. FATE files: https://files.lynne.ee/xhe_refs/ --- tests/fate/aac.mak | 8 1 file changed, 8 insertions(+) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 8

Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

2024-05-24 Thread Marton Balint
On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote: apichanges will be updated upon merging, as well as a version bump. --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 8a078d1601..4e19bbbd9e 100