Fixes Coverity issue #1516804.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/af_atempo.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
index 0c36eb4dd7..1aedb82060 100644
--- a/libavfilter/af_atempo.c
+++
The earlier code distinguished between a partial reset
(yae_clear()) and a complete reset (yae_release_buffers()
which also releases the buffers); this separation existed
to avoid allocations, as buffers were reallocated on reconfigs.
Yet it is pointless since a5704659e3e41b7698812b89f67d9a7467a74
Forgotten after b8f74ee57a6e9e75a507adcddf30f84dd4a39d39.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/af_atempo.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
index 110f792eec..3658348c4
Fixes Coverity issue #1506706.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 63bae9fe1c..76c542d50b 100644
--- a/libavformat/matroskaenc.c
+++ b/li
Signed-off-by: Andreas Rheinhardt
---
libavformat/riffenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c
index 8accb69541..59c9932c36 100644
--- a/libavformat/riffenc.c
+++ b/libavformat/riffenc.c
@@ -72,7 +72,7 @@ int ff_put_wa
Before the patch, opening a DASH file containing streams which require
experimental decoders was problematic. No matter where the -strict -2
was put on the command line, the option was not passed to the demuxer
for that component. This resulted in an error, prompting the user to
add the -strict -
Thanks for your review Andreas.
On 20/05/2024 21:41, Andreas Rheinhardt wrote:
> Frank Plowman:
>> Before the patch, opening a DASH file containing streams which require
>> experimental decoders was problematic. No matter where the -strict -2
>> was put on the command line, the option was not pas
Frank Plowman:
> Before the patch, opening a DASH file containing streams which require
> experimental decoders was problematic. No matter where the -strict -2
> was put on the command line, the option was not passed to the demuxer
> for that component. This resulted in an error, prompting the us
Sorry for the slow reply.
On date Wednesday 2024-05-15 16:54:19 +0100, Andrew Sayers wrote:
> Derived from detailed explanations kindly provided by Stefano Sabatini:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html
> ---
> doc/context.md | 394 +++
On date Wednesday 2024-05-15 16:54:20 +0100, Andrew Sayers wrote:
> ---
> libavutil/log.h | 11 ---
> libavutil/opt.h | 7 ---
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/libavutil/log.h b/libavutil/log.h
> index ab7ceabe22..cfbf416679 100644
> --- a/libavuti
On date Wednesday 2024-05-15 16:54:22 +0100, Andrew Sayers wrote:
> Doxygen thinks any text like "Context for foo" is a link to a struct called
> "Context".
> Add a description and a better link, to avoid confusing readers.
> ---
> libavformat/async.c | 3 +++
> libavformat/cache.c | 3 +++
> 2 f
On date Sunday 2024-05-05 22:04:36 +0100, Andrew Sayers wrote:
> I'm still travelling, so the following thoughts might be a bit
> half-formed. But I wanted to get some feedback before sitting down
> for a proper think.
[...]
> > > I've also gone through the code looking for edge cases we haven't c
E.g. the AAC stuff has been removed in
03cf10164578aed33f4d0cb5b69d63669c01a538.
Signed-off-by: Andreas Rheinhardt
---
Alternatively, we could just nuke this file.
doc/mips.txt | 6 --
1 file changed, 6 deletions(-)
diff --git a/doc/mips.txt b/doc/mips.txt
index d66ce3b447..a42546f0cd 1006
This is against the 80 char line length limit, but it is not
a hard rule anyway.
Signed-off-by: Andreas Rheinhardt
---
This is an alternative to modifying check-source.sh (for which I also
sent a patch).
doc/mips.txt | 5 ++---
libavcodec/aacsbr_fixed.c
Several files already had standard license header (namely
2-clause BSD files), yet due to the 80 char line length limit,
they were not treated as such by source-check.sh (which
fate-source uses). Therefore relax the BSD check.
Signed-off-by: Andreas Rheinhardt
---
This is the first variant. The s
Le 22 mai 2024 00:34:03 GMT+03:00, Thilo Borgmann via ffmpeg-devel
a écrit :
>>> I hope you realize what you argue in favor of.
>>
>> Yes. It's quoted above.
>>
>> Are you claiming that *no* review is better than *some* review done in
>> *public* for all to see by a paid professional just bec
Le 22 mai 2024 14:04:50 GMT+03:00, Andreas Rheinhardt
a écrit :
>Several files already had standard license header (namely
>2-clause BSD files), yet due to the 80 char line length limit,
>they were not treated as such by source-check.sh (which
>fate-source uses). Therefore relax the BSD check.
On Wed, May 22, 2024 at 12:37:37PM +0200, Stefano Sabatini wrote:
> On date Sunday 2024-05-05 22:04:36 +0100, Andrew Sayers wrote:
> > I'm still travelling, so the following thoughts might be a bit
> > half-formed. But I wanted to get some feedback before sitting down
> > for a proper think.
> [..
On Wed, May 22, 2024 at 12:29 AM Wu Jianhua wrote:
> > 发件人: ffmpeg-devel 代表 James Almer <
> jamr...@gmail.com>
> > 发送时间: 2024年5月21日 6:52
> > 收件人: ffmpeg-devel@ffmpeg.org
> > 主题: [FFmpeg-devel] [PATCH] x86/vvc_alf: use the x86inc instruction macros
> >
> > Let its magic figure out the correct mne
On 5/19/2024 10:25 AM, James Almer wrote:
The length of the sps_subpic_id[i] syntax element is sps_subpic_id_len_minus1 +
1 bits.
Signed-off-by: James Almer
---
libavformat/vvc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/vvc.c b/libavformat/vvc.c
i
On 5/19/2024 10:41 PM, James Almer wrote:
As defined in Section 8.7.3.2.1 of ISO 14496-12.
Any unsupported value will be rejected in mov_build_index() without outright
aborting demuxing.
Fixes ticket #11005.
Signed-off-by: James Almer
---
libavformat/isom.h | 2 +-
libavformat/mov.c | 4 ++
On Thu, Feb 29, 2024 at 7:19 AM llyyr wrote:
>
> segmentation.update_map is never reset to 0 on a new frame, and retains
> the value from the previous frame. This bugs out a bunch of hwaccel
> drivers when segmentation.enabled is 0 but update_map isn't because
> they don't ignore values behind swi
On Wed, May 22, 2024 at 12:08:29PM +0200, Stefano Sabatini wrote:
> On date Wednesday 2024-05-15 16:54:22 +0100, Andrew Sayers wrote:
> > Doxygen thinks any text like "Context for foo" is a link to a struct called
> > "Context".
> > Add a description and a better link, to avoid confusing readers.
Hi,
On Wed, May 22, 2024 at 10:36 AM Hendrik Leppkes
wrote:
> On Thu, Feb 29, 2024 at 7:19 AM llyyr wrote:
> >
> > segmentation.update_map is never reset to 0 on a new frame, and retains
> > the value from the previous frame. This bugs out a bunch of hwaccel
> > drivers when segmentation.enable
Otherwise Doxygen thinks any text like "Context for foo"
is a link to the async protocol's struct called "Context".
Reported-by: Andrew Sayers
Signed-off-by: Andreas Rheinhardt
---
libavformat/async.c | 22 +++---
libavformat/cache.c | 18 +-
2 files changed, 20
Andrew Sayers:
> Doxygen thinks any text like "Context for foo" is a link to a struct called
> "Context".
> Add a description and a better link, to avoid confusing readers.
> ---
> libavformat/async.c | 3 +++
> libavformat/cache.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/lib
> On May 21, 2024, at 9:19 PM, Andreas Rheinhardt
> wrote:
>
> Cosmin Stejerean via ffmpeg-devel:
>> From: Cosmin Stejerean
>>
>> These two fields are coded together into a single 16 bit integer with upper 8
>> bits for ext_mapping_idc and lower 8 bits for el_bit_depth_minus8.
>>
>> Further
From: Cosmin Stejerean
---
libavutil/dovi_meta.h | 2 ++
libavutil/version.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavutil/dovi_meta.h b/libavutil/dovi_meta.h
index e10332f8d7..e168075a24 100644
--- a/libavutil/dovi_meta.h
+++ b/libavutil/dovi_meta.h
@@ -91,6
From: Cosmin Stejerean
These two fields are coded together into a single 16 bit integer with upper 8
bits for ext_mapping_idc and lower 8 bits for el_bit_depth_minus8.
Furthermore ext_mapping_idc has two components, upper 3 bits and lower 5 bits.
---
libavcodec/dovi_rpudec.c | 7 ++-
libavc
From: Cosmin Stejerean
Some DolbyVision samples fail to parse currently due to mis-reading the
el_bit_depth_minus8 field. Upon investigation it seems that the RPU syntax has
been extended in an as of yet undocumented way by adding ext_mapping_idc and
coding it together with el_bit_depth_minus8 to
On Wed, May 22, 2024 at 11:31:52AM +0200, Stefano Sabatini wrote:
> Sorry for the slow reply.
Welcome back :)
I've gathered some critiques of my own over the past week, which I'll pepper
throughout the reply. Starting with...
The document assumes (or is at least designed to be secure against) r
On Wed, 22 May 2024 11:10:31 -0400
"Ronald S. Bultje" wrote:
> Hi,
>
> On Wed, May 22, 2024 at 10:36 AM Hendrik Leppkes
> wrote:
>
> > On Thu, Feb 29, 2024 at 7:19 AM llyyr wrote:
> > >
> > > segmentation.update_map is never reset to 0 on a new frame, and
> > > retains the value from the pr
On Wed, May 22, 2024 at 05:24:36PM +0200, Andreas Rheinhardt wrote:
> These structures should be renamed instead of adding these comments
> (which are pointless for internal developers). I just sent a patch for that.
> Thanks for pointing out the issue.
Oh, great! So the next version of this patc
VVC does not have MMX code at all, so one can use the stricter
declare_func to also check that the MMX state has not been clobbered
with (which would be an ABI violation).
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/vvc_alf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
On 22/05/2024 18:17, Philip Langdale via ffmpeg-devel wrote:
On Wed, 22 May 2024 11:10:31 -0400
"Ronald S. Bultje" wrote:
Hi,
On Wed, May 22, 2024 at 10:36 AM Hendrik Leppkes
wrote:
On Thu, Feb 29, 2024 at 7:19 AM llyyr wrote:
segmentation.update_map is never reset to 0 on a new frame,
On Wed, May 22, 2024 at 7:16 PM Lynne via ffmpeg-devel
wrote:
>
> On 22/05/2024 18:17, Philip Langdale via ffmpeg-devel wrote:
> > On Wed, 22 May 2024 11:10:31 -0400
> > "Ronald S. Bultje" wrote:
> >
> >> Hi,
> >>
> >> On Wed, May 22, 2024 at 10:36 AM Hendrik Leppkes
> >> wrote:
> >>
> >>> On Th
On Wed, 22 May 2024, Andreas Rheinhardt wrote:
VVC does not have MMX code at all, so one can use the stricter
declare_func to also check that the MMX state has not been clobbered
with (which would be an ABI violation).
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/vvc_alf.c | 4 ++--
1 f
Hi,
On Wed, May 22, 2024 at 1:28 PM Hendrik Leppkes wrote:
> On Wed, May 22, 2024 at 7:16 PM Lynne via ffmpeg-devel
> wrote:
> > I'd hate to apply fixes with no information in shared code. This can get
> > removed with no information about what relies on it.
>
> Changing 5 different hwaccel mod
From: Zhao Zhili
It's a common usecase to request a video size after crop. Before
this patch, user must know the video size before crop, then set
crop_right/crop_bottom accordingly. Since HEVC can have different
CTU size, it's not easy to get/deduce the video size before crop.
With the new width/
On 22.05.2024 02:02, Michael Niedermayer wrote:
On Tue, May 21, 2024 at 11:02:22AM +0200, Timo Rothenpieler wrote:
---
libavformat/flvdec.c | 570 +++
1 file changed, 306 insertions(+), 264 deletions(-)
infinite loops
[flv @ 0x555e803d2940] Video cod
---
libavformat/flvdec.c | 574 +++
1 file changed, 311 insertions(+), 263 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index 4f98ff348c..fe5a44a715 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -1273,6 +1273,7 @@
On Wed, 22 May 2024, Lynne via ffmpeg-devel wrote:
On 21/05/2024 23:33, Hendrik Leppkes wrote:
On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel
wrote:
It should be the case here, we shouldn't need reordering as NATIVE just
lets you specify what order the elements appear in the b
On 22/05/2024 22:15, Marton Balint wrote:
On Wed, 22 May 2024, Lynne via ffmpeg-devel wrote:
On 21/05/2024 23:33, Hendrik Leppkes wrote:
On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel
wrote:
It should be the case here, we shouldn't need reordering as NATIVE
just
lets you sp
This removes one stray LI and reworks the vector arithmetic to avoid
changing the vector configuration. On K230, this takes the 46.5 cycle
count down from 46.5 to 43.5.
---
libavcodec/riscv/rv34dsp_rvv.S | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/libavcodec/r
Le 22 mai 2024 23:28:54 GMT+03:00, "Rémi Denis-Courmont" a
écrit :
>This removes one stray LI and reworks the vector arithmetic to avoid
>changing the vector configuration. On K230, this takes the 46.5 cycle
>count down from 46.5 to 43.5.
>---
> libavcodec/riscv/rv34dsp_rvv.S | 13 ++---
On 5/22/2024 2:02 AM, Andreas Rheinhardt wrote:
Stone Chen:
Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is
only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD
is only calculated on even rows. This is calculated for all video bi
On 5/21/2024 10:12 PM, Ronald S. Bultje wrote:
Hi,
On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote:
Adds checkasm for DMVR SAD AVX2 implementation.
Benchmarks ( AMD 7940HS )
vvc_sad_8x8_c: 50.3
vvc_sad_8x8_avx2: 0.3
vvc_sad_16x16_c: 250.3
vvc_sad_16x16_avx2: 10.3
vvc_sad_32x32_c: 1020.3
vvc
On 5/21/2024 10:01 PM, Ronald S. Bultje wrote:
Hi,
On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote:
Implements AVX2 DMVR (decoder-side motion vector refinement) SAD
functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128.
To reduce complexity, SAD is only calculated on even
On Wed, May 22, 2024, 02:59 Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> The earlier code distinguished between a partial reset
> (yae_clear()) and a complete reset (yae_release_buffers()
> which also releases the buffers); this separation existed
> to avoid allocations, as buffer
Fixes: CID1503075 Unintentional integer overflow
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavdevice/pulse_audio_enc.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavdevice/pulse_audio_enc.c b/libavdevice/pulse_audio_enc.c
index
Fixes: CID1538298 Untrusted loop bound
Fixes: undefined behavior
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/ac4dec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/ac4dec.c b/libavformat/ac4dec.c
index f647f557ccd..dc6638de3a4 100644
-
Fixes: CID1505963 Unintentional integer overflow
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/ape.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/ape.c b/libavformat/ape.c
index c0e3e9f4fe6..f86ca5e894c 100644
--- a/libavf
Fixes: CID1467435 Unintentional integer overflow
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/argo_asf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 61bfc6de1fc..e08f029f80c 1006
Fixes: CID1500342 Unintentional integer overflow
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/asfdec_f.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index fcc2b98a2c4..2441cadb444 1006
Related: CID1473496 Unchecked return value
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavcodec/sga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/sga.c b/libavcodec/sga.c
index 0f42cf912b2..618df000ada 100644
--- a/libavcodec/sga.
Helps: CID1518967 Unchecked return value
Helps: CID1518968 Unchecked return value
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavcodec/tests/bitstream_template.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/tests/bitstream_template
On 5/14/2024 8:25 AM, Nuo Mi wrote:
On Mon, May 13, 2024 at 8:32 PM wrote:
From: Wu Jianhua
Perforamnce Test (fps):
clip before after delta
Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36%
RitualDance_1920x1080_60_10_420_32_LD.266 272
Timo Rothenpieler 于2024年5月21日周二 17:03写道：
>
> This is based on the preliminary spec for enhanced rtmp v2:
> https://veovera.org/docs/enhanced/enhanced-rtmp-v2
>
> The spec is not final, and can still undergo breaking changes, hence this set
> is purely for comments and review, and not ready to be
On Tue, May 21, 2024 at 9:50 AM Thilo Borgmann via ffmpeg-devel
wrote:
>
> Hi,
>
> [...]
> >>> Tests mostly work for me. There are a few images (that I reported
> >>> earlier) that give:
> >>
> >> thanks for testing!
> >>
> >>
> >>> Canvas change detected. The output will be damaged. Use -thre
Unfortunately I only test to obtain benchmarks and basic correctness. I
always feel the need for a professional to write the tests.
Rémi Denis-Courmont 于2024年5月23日周四 04:35写道：
>
>
> Le 22 mai 2024 23:28:54 GMT+03:00, "Rémi Denis-Courmont"
> a écrit :
> >This removes one stray LI and reworks the
> On May 21, 2024, at 3:19 AM, Niklas Haas wrote:
>
> On Tue, 21 May 2024 04:03:43 + Cosmin Stejerean via ffmpeg-devel
> wrote:
>>
>> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
>> index dec74ebecd..c6104f5522 100644
>> --- a/libavcodec/libaomenc.c
>> +++ b/libavcodec/li
From: Cosmin Stejerean
not all clients support metadata compression, output when
vdr_dm_metadata_changed fails the DV verifier.
---
libavcodec/dovi_rpu.h| 10 ++
libavcodec/dovi_rpuenc.c | 8 ++--
libavcodec/libaomenc.c | 3 +--
libavcodec/libsvtav1.c | 3 +--
libavcodec/
Quoting Niklas Haas (2024-04-24 12:51:55)
> Incidentally, I think it would be nice if lavfi could *automatically*
> split filter links referenced multiple times, so we could just write
> e.g. [i][ri]scale=rw:rh[o]; [ri][o]overlay[out] and have it work. Maybe
> I'll try getting that to work, next.
From: Haihao Xiang
X86ASMlibavcodec/x86/vvc/vvc_sad.o
libavcodec/x86/vvc/vvc_sad.asm:85: error: invalid number of operands
libavcodec/x86/vvc/vvc_sad.asm:87: error: invalid number of operands
Signed-off-by: Haihao Xiang
---
libavcodec/x86/vvc/vvc_sad.asm | 4 ++--
1 file changed, 2 inserti
64 matches
Mail list logo
