Re: [FFmpeg-devel] [PATCH 4/5] avcodec/sga: Check non constant init_get_bits8()

Michael Niedermayer: > Fixes: CID1473562 Unchecked return value > Fixes: CID1473592 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/sga.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/liba

[FFmpeg-devel] [PATCH 1/6] lavf/tls_mbedtls: handle more error codes for human-readable message

Signed-off-by: sfan5 --- libavformat/tls_mbedtls.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index 1a182e735e..fd6ba0b1f5 100644 --- a/libavformat/tls_mbedtls.c +++ b/libavformat/tls_mbedtls.c @@ -138,6 +138,9 @@ static void h

[FFmpeg-devel] [PATCH 2/6] lavf/tls_mbedtls: add missing call to psa_crypto_init

This is mandatory depending on configuration or at least with mbedTLS 3.6.0. Signed-off-by: sfan5 --- libavformat/tls_mbedtls.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index fd6ba0b1f5..24c3afd94c 100644 --- a/libavfo

[FFmpeg-devel] [PATCH 3/6] lavf/tls_mbedtls: hook up debug message callback

Signed-off-by: sfan5 --- libavformat/tls_mbedtls.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index 24c3afd94c..9508fe3436 100644 --- a/libavformat/tls_mbedtls.c +++ b/libavformat/tls_mbedtls.c @@ -26,6 +26,7 @@ #inc

[FFmpeg-devel] [PATCH 4/6] lavf/tls_mbedtls: fix handling of certification validation failures

We manually check the verification status after the handshake has completed using mbedtls_ssl_get_verify_result(). However with VERIFY_REQUIRED mbedtls_ssl_handshake() already returns an error, so this code is never reached. Fix that by using VERIFY_OPTIONAL, which performs the verification but

[FFmpeg-devel] [PATCH 5/6] lavf/tls_mbedtls: handle session ticket error code as no-op

When TLSv1.3 and session tickets are enabled mbedtls_ssl_read() will return an error code to inform about a received session ticket. This can simply be handled like EAGAIN instead of errornously aborting the connection. ref: https://github.com/Mbed-TLS/mbedtls/issues/8749 Signed-off-by: sfan5 --

[FFmpeg-devel] [PATCH 6/6] lavf/tls_mbedtls: add workaround for TLSv1.3 vs. verify=0

As of mbedTLS 3.6.0 TLSv1.3 is enabled by default and certificate verification is now mandatory. Our default configuration does not do verification, so downgrade to 1.2 in these situations to avoid breaking it. ref: https://github.com/Mbed-TLS/mbedtls/issues/7075 Signed-off-by: sfan5 --- libav

Re: [FFmpeg-devel] [PATCH 1/6] lavf/tls_mbedtls: handle more error codes for human-readable message

On Fri, May 17, 2024 at 10:34:26AM +0200, Sfan5 wrote: > Signed-off-by: sfan5 > --- > libavformat/tls_mbedtls.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c > index 1a182e735e..fd6ba0b1f5 100644 > --- a/libavformat/tls_mbedt

Re: [FFmpeg-devel] [PATCH 3/6] lavf/tls_mbedtls: hook up debug message callback

Le 17 mai 2024 11:34:35 GMT+03:00, Sfan5 a écrit : >Signed-off-by: sfan5 >--- > libavformat/tls_mbedtls.c | 14 ++ > 1 file changed, 14 insertions(+) > >diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c >index 24c3afd94c..9508fe3436 100644 >--- a/libavformat/tls_mbed

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

> On 14. May 2024, at 18:28, Lynne via ffmpeg-devel > wrote: > > On 14/05/2024 17:09, Christian Bartnik wrote: >> From: Thomas Siedel >> Add external decoder VVdeC for H266/VVC decoding. >> Register new decoder libvvdec. >> Add libvvdec to wrap the vvdec interface. >> Enable decoder by addin

[FFmpeg-devel] [PATCH 1/3 v3] avformat/vvc: fix writing general_constraint_info bytes

The existing implementation was completely broken. Signed-off-by: James Almer --- libavformat/Makefile| 2 +- libavformat/bitstream.c | 1 + libavformat/vvc.c | 38 -- tests/ref/fate/source | 1 + 4 files changed, 23 insertions(+), 19 deletions(

[FFmpeg-devel] [PATCH 2/3] avformat/vvc: include additional bits in general_constraint_info

Based on code from cbs_h266. Signed-off-by: James Almer --- libavformat/vvc.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c index 98177a7ad8..e8301d4247 100644 --- a/libavformat/vvc.c +++ b/libavformat/v

[FFmpeg-devel] [PATCH 3/3] configure: split ISOBMFF writer helpers into a separate component

Signed-off-by: James Almer --- configure| 10 ++ libavformat/Makefile | 16 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 275fa59bfd..b16722d83d 100755 --- a/configure +++ b/configure @@ -2587,6 +2587,7 @@ CONFIG_

[FFmpeg-devel] [RFC] STF 2025

Hi all Before this is forgotten again, better start some dicsussion too early than too late I propose that if we have the oppertunity again next year to receive a grant from STF. That we use it to fund: * Paul to work on FFmpeg full time. My idea here is that he can work on whatever he likes

Re: [FFmpeg-devel] [RFC] STF 2025

Hi, On Fri, May 17, 2024 at 9:50 AM Michael Niedermayer wrote: > * Fund professional real live presence on multimedia / FOSS / buisness > related > events. we already refund individuals but i think we are lacking on the > organizational > side. We should also have on these events at least on

Re: [FFmpeg-devel] [RFC] STF 2025

Le 17 mai 2024 16:49:58 GMT+03:00, Michael Niedermayer a écrit : >Hi all > >Before this is forgotten again, better start some dicsussion too early than >too late > >I propose that if we have the oppertunity again next year to receive a grant >from STF. That we use it to fund: > >* Paul to work

Re: [FFmpeg-devel] [RFC] STF 2025

On Fri, May 17, 2024 at 9:50 AM Michael Niedermayer wrote: > Hi all > > Before this is forgotten again, better start some dicsussion too early > than too late > > I propose that if we have the oppertunity again next year to receive a > grant > from STF. That we use it to fund: > > * Paul to work

Re: [FFmpeg-devel] [PATCH v3 5/9] lavc/vp9dsp: R-V V mc avg

Le maanantaina 13. toukokuuta 2024, 19.59.22 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp9_avg4_8bpp_c: 1.2 > vp9_avg4_8bpp_rvv_i64: 1.0 > vp9_avg8_8bpp_c: 3.7 > vp9_avg8_8bpp_rvv_i64: 1.5 > vp9_avg16_8bpp_c: 14.7 > vp9_avg16_8bpp_rvv_i64: 3.5 > vp9_avg32_8bpp_c: 57.7 > vp9_av

Re: [FFmpeg-devel] [RFC] STF 2025

On Fri, May 17, 2024 at 03:49:58PM +0200, Michael Niedermayer wrote: > Hi all > > Before this is forgotten again, better start some dicsussion too early than > too late > > I propose that if we have the oppertunity again next year to receive a grant > from STF. That we use it to fund: > > * Pau

[FFmpeg-devel] [PATCH 2/6] avformat/tls_openssl: #if ff_openssl_init/deinit() away if possible

These functions do nothing useful when used with a non-ancient version of openssl (namely 1.1.0 or above). Signed-off-by: Andreas Rheinhardt --- libavformat/network.c | 9 +++-- libavformat/tls_openssl.c | 34 -- 2 files changed, 27 insertions(+), 16 dele

[FFmpeg-devel] [PATCH 3/6] avformat/tee: Constify AVDictionaryEntry* pointee where possible

This is in preparation for using av_dict_iterate(). Signed-off-by: Andreas Rheinhardt --- libavformat/tee.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index 1cbbb80dbb..87159681ed 100644 --- a/libavformat/tee.c +++ b/libavform

[FFmpeg-devel] [PATCH 4/6] avformat/tee: Use smaller scope for variables

Signed-off-by: Andreas Rheinhardt --- libavformat/tee.c | 71 +++ 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index 87159681ed..0c0543fa65 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @

[FFmpeg-devel] [PATCH 5/6] avcodec/lib*, avformat/tee: Simplify iterating over AVDictionary

Signed-off-by: Andreas Rheinhardt --- libavcodec/libaomenc.c | 4 ++-- libavcodec/libkvazaar.c | 4 ++-- libavcodec/libsvtav1.c | 6 +++--- libavcodec/libx264.c| 4 ++-- libavcodec/libx265.c| 4 ++-- libavformat/tee.c | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-) d

[FFmpeg-devel] [PATCH 6/6] fftools, avfilter, avformat: Simplify check for "is dictionary empty?"

Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 4 ++-- fftools/ffplay.c | 4 ++-- fftools/ffprobe.c | 2 +- libavfilter/avfilter.c | 4 ++-- libavformat/aacdec.c | 2 +- libavformat/http.c | 8 libavformat/mpc.c | 2 +- libavformat/oggenc.c | 2 +-

Re: [FFmpeg-devel] [RFC] STF 2025

On 5/17/2024 2:49 PM, Michael Niedermayer wrote: > Also we need more cute girls on these events, everything i hear > its 100% male geeks/hackers. This is gross and sexist. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mlpdec: Set AV_FRAME_FLAG_KEY explicitly

Andreas Rheinhardt: > It is currently always set for all audio frames, but this is > wrong (namely for MLP/TrueHD) and will be changed. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mlpdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/mlpdec.c b/libavcodec/mlp

[FFmpeg-devel] [PATCH 1/6] avformat/utils: Use static mutexes instead of ff_lock_avformat()

Its existence is a remnant of (libavcodec's) lock-manager API which has been removed in a04c2c707de2ce850f79870e84ac9d7ec7aa9143. There is no need to use the same lock for avisynth, chromaprint or tls, so switch to ordinary static mutexes instead. Signed-off-by: Andreas Rheinhardt --- libavforma

Re: [FFmpeg-devel] [PATCH 6/6] fftools, avfilter, avformat: Simplify check for "is dictionary empty?"

On 17 May 2024, at 17:25, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg.c | 4 ++-- > fftools/ffplay.c | 4 ++-- > fftools/ffprobe.c | 2 +- > libavfilter/avfilter.c | 4 ++-- > libavformat/aacdec.c | 2 +- > libavformat/http.c | 8 ++

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/lib*, avformat/tee: Simplify iterating over AVDictionary

On 17 May 2024, at 17:25, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libaomenc.c | 4 ++-- > libavcodec/libkvazaar.c | 4 ++-- > libavcodec/libsvtav1.c | 6 +++--- > libavcodec/libx264.c| 4 ++-- > libavcodec/libx265.c| 4 ++-- > libavformat/tee

Re: [FFmpeg-devel] [PATCH 3/6] avformat/tee: Constify AVDictionaryEntry* pointee where possible

On 17 May 2024, at 17:25, Andreas Rheinhardt wrote: > This is in preparation for using av_dict_iterate(). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/tee.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/tee.c b/libavformat/tee.c > index

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/lib*, avformat/tee: Simplify iterating over AVDictionary

epira...@gmail.com: > > > On 17 May 2024, at 17:25, Andreas Rheinhardt wrote: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/libaomenc.c | 4 ++-- >> libavcodec/libkvazaar.c | 4 ++-- >> libavcodec/libsvtav1.c | 6 +++--- >> libavcodec/libx264.c| 4 ++-- >> libavcodec/libx26

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/lib*, avformat/tee: Simplify iterating over AVDictionary

On 17 May 2024, at 17:44, Andreas Rheinhardt wrote: > epira...@gmail.com: >> >> >> On 17 May 2024, at 17:25, Andreas Rheinhardt wrote: >> >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavcodec/libaomenc.c | 4 ++-- >>> libavcodec/libkvazaar.c | 4 ++-- >>> libavcodec/libsvtav1.c | 6 ++

[FFmpeg-devel] [PATCH 1/5] lavc/vp9dsp: R-V V mc avg

From: sunyuechi C908: vp9_avg4_8bpp_c: 1.2 vp9_avg4_8bpp_rvv_i64: 1.0 vp9_avg8_8bpp_c: 3.7 vp9_avg8_8bpp_rvv_i64: 1.5 vp9_avg16_8bpp_c: 14.7 vp9_avg16_8bpp_rvv_i64: 3.5 vp9_avg32_8bpp_c: 57.7 vp9_avg32_8bpp_rvv_i64: 10.0 vp9_avg64_8bpp_c: 229.0 vp9_avg64_8bpp_rvv_i64: 31.7 --- libavcodec/riscv/M

Re: [FFmpeg-devel] [PATCH v3 5/9] lavc/vp9dsp: R-V V mc avg

yeah, updated it in the reply Rémi Denis-Courmont 于2024年5月17日周五 23:11写道： > Le maanantaina 13. toukokuuta 2024, 19.59.22 EEST u...@foxmail.com a > écrit : > > From: sunyuechi > > > > C908: > > vp9_avg4_8bpp_c: 1.2 > > vp9_avg4_8bpp_rvv_i64: 1.0 > > vp9_avg8_8bpp_c: 3.7 > > vp9_avg8_8bpp_rvv_i64:

Re: [FFmpeg-devel] [PATCH 3/6] avformat/tee: Constify AVDictionaryEntry* pointee where possible

Andreas Rheinhardt: > This is in preparation for using av_dict_iterate(). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/tee.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/tee.c b/libavformat/tee.c > index 1cbbb80dbb..87159681ed 100644 >

[FFmpeg-devel] [PATCH 1/1] lavc/vc1dsp: R-V V vc1_unescape_buffer

Notes: - The loop is biased toward no unescaped bytes as that should be most common. - The input byte array is slid rather than the (8 times smaller) bit-mask, as RISC-V V does not provide a bit-mask (or bit-wise) slide instruction. - There are two comparisons with 0 per iteration, for the same r

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

> On May 14, 2024, at 9:28 AM, Lynne via ffmpeg-devel > wrote: > > On 14/05/2024 17:09, Christian Bartnik wrote: >> From: Thomas Siedel >> Add external decoder VVdeC for H266/VVC decoding. >> Register new decoder libvvdec. >> Add libvvdec to wrap the vvdec interface. >> Enable decoder by addi

[FFmpeg-devel] [PATCH 1/2] avcodec/ac3enc_template: Avoid always-true check

This might also help Coverity with issue #1596532. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc_template.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c index 49fc6d7f37..049666fdca 100644 --

[FFmpeg-devel] [PATCH 2/2] avcodec/ac3enc: Move transient PutBitContext to stack

Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 187 ++- libavcodec/ac3enc.h | 6 +- libavcodec/eac3enc.c | 123 ++-- 3 files changed, 159 insertions(+), 157 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec

[FFmpeg-devel] [PATCH] avformat/flacdec: Reorder allocations to avoid leak on error

Fixes Coverity issue #1591795. Signed-off-by: Andreas Rheinhardt --- libavformat/flacdec.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c index 3d35da5fea..3c317acaee 100644 --- a/libavformat/flacdec.c +++ b/libavform

Re: [FFmpeg-devel] [RFC] STF 2025

On Fri, May 17, 2024 at 04:26:55PM +0100, Derek Buitenhuis wrote: > On 5/17/2024 2:49 PM, Michael Niedermayer wrote: > > Also we need more cute girls on these events, everything i hear > > its 100% male geeks/hackers. > > This is gross and sexist. This was definitly not meant to be either of that

Re: [FFmpeg-devel] [RFC] STF 2025

On Fri, May 17, 2024 at 11:08:17AM -0400, Vittorio Giovara wrote: > On Fri, May 17, 2024 at 9:50 AM Michael Niedermayer > wrote: > > > Hi all > > > > Before this is forgotten again, better start some dicsussion too early > > than too late > > > > I propose that if we have the oppertunity again ne

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

In this project we prefer internal decoders to external libs. On Fri, 17 May 2024, 18:20 Cosmin Stejerean via ffmpeg-devel, < ffmpeg-devel@ffmpeg.org> wrote: > > > > On May 14, 2024, at 9:28 AM, Lynne via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > > On 14/05/2024 17:09, Christian Bart

Re: [FFmpeg-devel] [RFC] STF 2025

On 5/17/2024 7:50 PM, Michael Niedermayer wrote: > The people on the booth are predominantly male. Similarly ffmpeg-devel > is predominantly male. More gender diversity would be good. That I can agree with. - Derek ___ ffmpeg-devel mailing list ffmpeg-d

[FFmpeg-devel] [PATCH] avfilter/vf_dnn_detect: Fix segfault on init error

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_dnn_detect.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index bacea3ef29..56206d6f9f 100644 --- a/libavfilter/vf_dnn_detect.c +++ b/libavfilter/vf_dnn

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix leak on error

Do this by attaching the FilterGraph directly to more permanent storage from which it will be automatically freed. Fixes Coverity issue #1596533. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_f

[FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: fix GCC 14.1 warnings

This patch fixes warnings produced by GCC 14.1 in hwcontext_qsv.c. It fixes the issue https://trac.ffmpeg.org/ticket/11004. Best regards Oleg Tolmatcev 0001-avutil-hwcontext_qsv-fix-GCC-14.1-warnings.patch Description: Binary data ___ ffmpeg-devel mail

[FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: fix HT block decoder issue #10905

Signed-off-by: Pierre-Anthony Lemieux --- libavcodec/jpeg2000htdec.c | 122 +++-- 1 file changed, 62 insertions(+), 60 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index fa704b665e..62f70c32a8 100644 --- a/libavcodec/jpeg2000htde

[FFmpeg-devel] [PATCH 2/2] test/jpeg2000dec: regenerate ds0_ht_01_b11 (HTJ2K lossless)

Signed-off-by: Pierre-Anthony Lemieux --- tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 b/tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 index af3eaa086d..d923cc2109 100644 --- a/tests/ref/fate/jpeg20

[FFmpeg-devel] [PATCH] avcodec/tiff: Fix leak on error

Fixes Coverity issue #1516957. Signed-off-by: Andreas Rheinhardt --- libavcodec/tiff.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 19301d9e49..111ce3ea3a 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -2267,8 +2267

Re: [FFmpeg-devel] [PATCH 2/2] test/jpeg2000dec: regenerate ds0_ht_01_b11 (HTJ2K lossless)

WATANABE Osamu: > Signed-off-by: Pierre-Anthony Lemieux > --- > tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 > b/tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 > index af3eaa086d..d923cc2109 10

Re: [FFmpeg-devel] [RFC] STF 2025

Le 17 mai 2024 21:50:20 GMT+03:00, Michael Niedermayer a écrit : >Let me reword this for 2024: >The people on the booth are predominantly male. Similarly ffmpeg-devel >is predominantly male. More gender diversity would be good. As you've noted, this is an obvious problem but not an FFmpeg-spec

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder issue #10905

Signed-off-by: Pierre-Anthony Lemieux --- libavcodec/jpeg2000htdec.c | 122 --- tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 | 2 +- 2 files changed, 63 insertions(+), 61 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index fa704b66

[FFmpeg-devel] [PATCH] avcodec/vc1_parser: Check init_get_bits8()

Addresses Coverity issue #1441935. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1_parser.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vc1_parser.c b/libavcodec/vc1_parser.c index ec284dca00..a536a7bcf8 100644 --- a/libavcodec/vc1_parser.c +++ b/libav

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/sga: Check non constant init_get_bits8()

On Fri, May 17, 2024 at 09:53:21AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1473562 Unchecked return value > > Fixes: CID1473592 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/sga.c | 10

[FFmpeg-devel] [PATCH] avfilter/vf_v360: Add assert to suppress Coverity false positives

Should fix many Coverity false positives, namely #1457947-#1457994 as well as #1461195-#146210. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_v360.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index 5ea6e0d865..299dbe9ff5 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Fix leak on error

On Fri, May 17, 2024 at 09:51:05PM +0200, Andreas Rheinhardt wrote: > Fixes Coverity issue #1516957. Please mark issues that you fixed in coverity accordingly so that others (like me) see it and know what issues remain outstanding by well looking at the list of outstanding issues thx [...] -- M

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: Fix parsing of ts_layering_mode parameter

Hi, On Wed, May 15, 2024 at 11:11 PM Aaron Thompson via ffmpeg-devel wrote: > > The value was being parsed as base 4, so the value "4" was invalid and > would result in ts_layering_mode being set to 0. > > Signed-off-by: Aaron Thompson > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc1_loopfilter: Factor duplicate code in vc1_b_h_intfi_loop_filter()

On Wed, May 25, 2022 at 05:53:12PM +0200, Michael Niedermayer wrote: > On Tue, May 24, 2022 at 08:50:51PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: CID1435168 > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/vc1_loopfilter.c | 5 + > > >

[FFmpeg-devel] [PATCH 1/9] avcodec/tiff: Assert init_get_bits8() success in horizontal_fill()

Helps: CID1441167 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 19301d9e490..ca7e9f6aba9 100644 --- a/libavcodec/t

[FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray()

Helps: CID1441939 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index ca7e9f6aba9..31de6ad7308 100644 --- a/libavcodec/t

[FFmpeg-devel] [PATCH 3/9] avcodec/vble: Check av_image_get_buffer_size() for failure

Fixes: CID1461482 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vble.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vble.c b/libavcodec/vble.c index 32157913c77..c585b1ed9fc 100644 --- a/libavcodec/vble.c +

[FFmpeg-devel] [PATCH 4/9] avcodec/vc1_block: remove unused off from vc1_decode_p_mb_intfr()

Fixes: CID1435166 Unused value Fixes: CID1529221 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c index a6ee4922f95..1e8e294ad89 1006

[FFmpeg-devel] [PATCH 5/9] avcodec/vc1_block: remove unneeded store to off in vc1_decode_p_mb_intfi()

Found while reviewing code related to coverity Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c index 1e8e294ad89..322acebfe50 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 6/9] avcodec/vc1_parser: Assert init_get_bits success

The buffer used is a fixed size buffer from the context, it cannot be too large nor can it be NULL Helps: CID1441935 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH 7/9] avcodec/vlc: Cleanup on multi table alloc failure in ff_vlc_init_multi_from_lengths()

Fixes: CID1544630 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index ee09d96fd61..f46ecbb55e9 100644 --- a/libavcodec/vlc.c +++ b/lib

[FFmpeg-devel] [PATCH 8/9] avcodec/vp8: Forward return of ff_vpx_init_range_decoder()

Fixes: CID1507483 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 19f32b34006..8e91613068a 100644 --- a/libavcodec/vp8.

[FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert

Fixes: CID1452425 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 09527607767..d03a1c9dbc1 100644 --- a/libavcodec/vp3.c +

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray()

Michael Niedermayer: > Helps: CID1441939 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/tiff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > index ca7e9f6ab