Re: [FFmpeg-devel] [PATCH v4 1/3] avformat/network: add ff_neterrno2() for cases where we already have an errno

2024-04-27 Thread Andrew Sayers
On Sat, Apr 20, 2024 at 02:24:59PM +0100, Andrew Sayers wrote: > For example, WSAStartup()'s documentation says: > > "A call to the WSAGetLastError function is not needed and should not be > used" > --- > libavformat/network.c | 5 - > libavformat/network.h | 2 ++ > 2 files changed, 6 i

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/pngdec: Check last AVFrame before deref

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: NULL pointer dereference > Fixes: > 68184/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-4926478069334016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer()

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:1688 > Fixes: > 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5942090287611904 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ff

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevcdec: Check ref frame

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: NULL pointer dereferences > Fixes: > 68197/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6382538823106560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-27 Thread Michael Niedermayer
On Thu, Apr 25, 2024 at 08:15:27AM -0700, Vittorio Giovara wrote: > On Wed, Apr 24, 2024 at 3:00 PM Michael Niedermayer > wrote: > > > > Microsoft expanded into new fields with Xbox and Azure, yes. But Windows > > is still an OS, and Office is still a (un)productivity suite. > > > > > > According

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > This allows detecting issues in side data related code, same as what > framecrc does for before already for packet data itself. > > Signed-off-by: Michael Niedermayer > --- > libavformat/framecrcenc.c | 76 +- > tests/ref/fate/autorotate

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-27 Thread Michael Niedermayer
On Thu, Apr 25, 2024 at 12:26:00PM +0200, Tomas Härdin wrote: > tor 2024-04-25 klockan 02:07 +0200 skrev Michael Niedermayer: > > On Thu, Apr 25, 2024 at 12:50:02AM +0200, Tomas Härdin wrote: > > > ons 2024-04-17 klockan 15:58 +0200 skrev Michael Niedermayer: > > > > > > > * ffchat > > > >     (ex

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: NULL pointer dereference > Fixes: > 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzzer-6180311026171904 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

[FFmpeg-devel] [PATCH] avcodec/vp8: Return error on error

2024-04-27 Thread Andreas Rheinhardt
Regression since e1ba00ac8f755f37ebc8448d3dbea906d7b79da2. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index f37938ad27..19f32b3400 100644 --- a/libavcodec/vp8.c +++ b/libavcode

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This allows detecting issues in side data related code, same as what > > framecrc does for before already for packet data itself. > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/fram

[FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

2024-04-27 Thread Lynne
Hi, I'm requesting a reimbursement for attending the Khronos F2F event in Brussels on 2024-04-26, where I gave a talk about the current status of Vulkan Video integration into FFmpeg:  - Currently implemented decoding features  - What we would like to be improved (stability, speed and testing from

[FFmpeg-devel] [PATCH] vulkan_av1: Set force_integer_mv on intra frames

2024-04-27 Thread Mark Thompson
The flag in CBS is the value read from the bitstream (as required for passthrough), but the specification overrides that by setting it immediately after reading if the frame is intra. --- This is already done for DXVA and VDPAU. Also wondering whether this should be done for VAAPI? libavcodec/v

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Return error on error

2024-04-27 Thread Ronald S. Bultje
Hi, On Sat, Apr 27, 2024 at 7:47 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Regression since e1ba00ac8f755f37ebc8448d3dbea906d7b79da2. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp8.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] vulkan_av1: Set force_integer_mv on intra frames

2024-04-27 Thread Ronald S. Bultje
Hi, On Sat, Apr 27, 2024 at 9:40 AM Mark Thompson wrote: > The flag in CBS is the value read from the bitstream (as required for > passthrough), but the specification overrides that by setting it > immediately after reading if the frame is intra. > --- > This is already done for DXVA and VDPAU.

[FFmpeg-devel] [PATCH] configure: support msvc build inside WSL

2024-04-27 Thread Timo Rothenpieler
--- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8101b4fce6..b872c37933 100755 --- a/configure +++ b/configure @@ -5036,7 +5036,11 @@ probe_cc(){ else _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d '\r'

Re: [FFmpeg-devel] [PATCH] vulkan_av1: Set force_integer_mv on intra frames

2024-04-27 Thread Mark Thompson
On 27/04/2024 14:47, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 27, 2024 at 9:40 AM Mark Thompson wrote: > >> The flag in CBS is the value read from the bitstream (as required for >> passthrough), but the specification overrides that by setting it >> immediately after reading if the frame is

Re: [FFmpeg-devel] [PATCH] vulkan_av1: Set force_integer_mv on intra frames

2024-04-27 Thread Mark Thompson
On 27/04/2024 14:58, Mark Thompson wrote: > On 27/04/2024 14:47, Ronald S. Bultje wrote: >> Hi, >> >> On Sat, Apr 27, 2024 at 9:40 AM Mark Thompson wrote: >> >>> The flag in CBS is the value read from the bitstream (as required for >>> passthrough), but the specification overrides that by setting

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check

2024-04-27 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes Coverity issues #1596529, #1596531. > Introduced in 8e35e33d42efb89ff7e3da92b841a3b43a5a95bc. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_filter.c b/ffto

Re: [FFmpeg-devel] [PATCH] vulkan_av1: Set force_integer_mv on intra frames

2024-04-27 Thread Lynne
Apr 27, 2024, 16:07 by s...@jkqxz.net: > On 27/04/2024 14:58, Mark Thompson wrote: > >> On 27/04/2024 14:47, Ronald S. Bultje wrote: >> >>> Hi, >>> >>> On Sat, Apr 27, 2024 at 9:40 AM Mark Thompson wrote: >>> The flag in CBS is the value read from the bitstream (as required for passthro

[FFmpeg-devel] [PATCH 1/6] av1dec: Add force_integer_mv derived field for decoder use

2024-04-27 Thread Mark Thompson
This is not the same as the syntax element value in the frame header because the specification parsing tables override the value on intra frames. --- On 27/04/2024 15:58, Lynne wrote: > This looks better to me. HYG. Of these, only VAAPI tested. (And probably it never did anything anyway.) liba

[FFmpeg-devel] [PATCH 2/6] dxva2_av1: Use av1dec force_integer_mv value

2024-04-27 Thread Mark Thompson
--- libavcodec/dxva2_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxva2_av1.c b/libavcodec/dxva2_av1.c index 5b95f99c9b..1b55510659 100644 --- a/libavcodec/dxva2_av1.c +++ b/libavcodec/dxva2_av1.c @@ -101,7 +101,7 @@ int ff_dxva2_av1_fill_picture_parameters(

[FFmpeg-devel] [PATCH 3/6] vdpau_av1: Use av1dec force_integer_mv value

2024-04-27 Thread Mark Thompson
--- libavcodec/vdpau_av1.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/vdpau_av1.c b/libavcodec/vdpau_av1.c index b74ea6aa0c..a1aff79bb7 100644 --- a/libavcodec/vdpau_av1.c +++ b/libavcodec/vdpau_av1.c @@ -91,9 +91,7 @@ static int vdpau_av1_start_frame(AVCodec

[FFmpeg-devel] [PATCH 4/6] nvdec_av1: Use av1dec force_integer_mv value

2024-04-27 Thread Mark Thompson
--- libavcodec/nvdec_av1.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/nvdec_av1.c b/libavcodec/nvdec_av1.c index 4efa420e66..8a46db1ed5 100644 --- a/libavcodec/nvdec_av1.c +++ b/libavcodec/nvdec_av1.c @@ -106,9 +106,7 @@ static int nvdec_av1_start_frame(AVCod

[FFmpeg-devel] [PATCH 5/6] vaapi_av1: Fix force_integer_mv value

2024-04-27 Thread Mark Thompson
--- libavcodec/vaapi_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c index 1f563483b9..f61bf63098 100644 --- a/libavcodec/vaapi_av1.c +++ b/libavcodec/vaapi_av1.c @@ -220,7 +220,7 @@ static int vaapi_av1_start_frame(AVCodecC

[FFmpeg-devel] [PATCH 6/6] vulkan_av1: Fix force_integer_mv value

2024-04-27 Thread Mark Thompson
--- libavcodec/vulkan_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c index 25ab4ecc70..a550215e32 100644 --- a/libavcodec/vulkan_av1.c +++ b/libavcodec/vulkan_av1.c @@ -435,7 +435,7 @@ static int vk_av1_start_frame(AVCode

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-27 Thread Vittorio Giovara
On Sat, Apr 27, 2024 at 6:24 AM Michael Niedermayer wrote: > On Thu, Apr 25, 2024 at 08:15:27AM -0700, Vittorio Giovara wrote: > > On Wed, Apr 24, 2024 at 3:00 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > > Microsoft expanded into new fields with Xbox and Azure, yes. Bu

[FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili During the refactor progress, I have found some serious issues, which is not resolved by the patchset: 1. Tensorflow backend is broken. I think it doesn't work since 2021 at least. For example, it destroy a thread and create a new thread for each frame, and it destroy an invali

[FFmpeg-devel] [PATCH WIP 2/9] avfilter/dnn_backend_openvino: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index c4b0682f11..769ba0a54b 100644 --- a/libavfilter/dnn/dnn_b

[FFmpeg-devel] [PATCH WIP 1/9] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_STRING backend_conf

[FFmpeg-devel] [PATCH WIP 6/9] avfilter/dnn_backend_tf: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 3b4de6d13f..c7716e696d 100644 --- a/libavfilter/dnn/dnn_backend_t

[FFmpeg-devel] [PATCH WIP 3/9] avfilter/dnn_backend_openvino: simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 769ba0a54b..1acc54b791 100644 --- a/libavfilter/dnn/

[FFmpeg-devel] [PATCH WIP 5/9] avfilter/dnn_backend_tf: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 60f9e57fb7..3b4de6d13f 100644 --- a/libavfilter/dnn/dnn_bac

[FFmpeg-devel] [PATCH WIP 4/9] avfilter/dnn_backend_tf: Remove one level of indentation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index d24591b90b..60f9e57fb7 100644 --- a/libavfilter/dnn/dnn_backend_t

[FFmpeg-devel] [PATCH WIP 8/9] avfilter/dnn: Remove a level of dereference

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19 +-- libavfilter/dnn/dnn

[FFmpeg-devel] [PATCH WIP 7/9] avfilter/dnn_backend_torch: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index abdef1f178..818ec5b713 100644 --- a/libavfilter/dnn/dn

[FFmpeg-devel] [PATCH WIP 9/9] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h| 1 + 5 files changed

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-27 Thread Tomas Härdin
lör 2024-04-27 klockan 12:53 +0200 skrev Michael Niedermayer: > On Thu, Apr 25, 2024 at 12:26:00PM +0200, Tomas Härdin wrote: > > tor 2024-04-25 klockan 02:07 +0200 skrev Michael Niedermayer: > > > On Thu, Apr 25, 2024 at 12:50:02AM +0200, Tomas Härdin wrote: > > > > ons 2024-04-17 klockan 15:58 +0

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mov: Check tile_item_list

2024-04-27 Thread Michael Niedermayer
On Fri, Apr 26, 2024 at 09:30:50AM -0300, James Almer wrote: > On 4/26/2024 12:08 AM, Michael Niedermayer wrote: > > Fixes: Null pointer dereference > > Fixes: > > 67861/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5352628142800896 > > > > Found-by: continuous fuzzing process > > https:/

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/pngdec: Check last AVFrame before deref

2024-04-27 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 11:36:30AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: NULL pointer dereference > > Fixes: > > 68184/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-4926478069334016 > > > > Found-by: continuous fuzzing process > > https://github.com/g

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer()

2024-04-27 Thread Michael Niedermayer
Hi On Sat, Apr 27, 2024 at 11:47:32AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:1688 > > Fixes: > > 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5942090287611904 > > > > Found-by: cont

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevcdec: Check ref frame

2024-04-27 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 12:14:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: NULL pointer dereferences > > Fixes: > > 68197/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6382538823106560 > > > > Found-by: continuous fuzzing process > > https://github.com/

[FFmpeg-devel] [PATCH] avformat/iamfdec: check nb_streams in header read

2024-04-27 Thread Michael Niedermayer
Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid stream index.\n" failed at libavformat/demux.c:572 Fixes: 67890/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5166340789829632.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/maste

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-27 Thread Ondřej Fiala
On Sat Apr 27, 2024 at 12:24 PM CEST, Michael Niedermayer wrote: > A phone originally was a tool to call and talk to someone, to be reachable by > voice communication. > Its not a tool to write letters, until it was > Its not a tool to browse the internet until it was > Its not an assitent you coul

[FFmpeg-devel] [PATCH v2] configure: support msvc build inside WSL

2024-04-27 Thread Timo Rothenpieler
--- configure | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8101b4fce6..89af5f75e7 100755 --- a/configure +++ b/configure @@ -5036,7 +5036,12 @@ probe_cc(){ else _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d '\r

Re: [FFmpeg-devel] [PATCH v2] configure: support msvc build inside WSL

2024-04-27 Thread Sean McGovern
On Sat, Apr 27, 2024, 16:15 Timo Rothenpieler wrote: > --- > configure | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 8101b4fce6..89af5f75e7 100755 > --- a/configure > +++ b/configure > @@ -5036,7 +5036,12 @@ probe_cc(){ > el

Re: [FFmpeg-devel] [PATCH v2] configure: support msvc build inside WSL

2024-04-27 Thread Timo Rothenpieler
On 27.04.2024 22:21, Sean McGovern wrote: Aside: We are now that much closer to summoning a demon inside 'configure' *laughs*. The reasoning behind this complexification in v2 is that v1 put the string returned by cl.exe into a shell, allowing potential injection vectors. Granted, the injec

Re: [FFmpeg-devel] [PATCH] fate: allow https for git URLs

2024-04-27 Thread Timo Rothenpieler
On 24.04.2024 22:01, Timo Rothenpieler wrote: --- tests/fate.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate.sh b/tests/fate.sh index c5ee18de80..4081e865ae 100755 --- a/tests/fate.sh +++ b/tests/fate.sh @@ -30,14 +30,14 @@ lock(){ checkout(){ case

[FFmpeg-devel] [PATCH, v2] libavcodec/amfenc: Update AMF encoder options

2024-04-27 Thread Araz Iusubov
Encoder options have been updated to the current version of the AMF. Signed-off-by: Araz Iusubov --- libavcodec/amfenc_av1.c | 108 +++-- libavcodec/amfenc_h264.c | 146 +-- libavcodec/amfenc_hevc.c | 143 +-

[FFmpeg-devel] [PATCH v2] avformat/mov: free the infe allocated item data on failure

2024-04-27 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ede25d3342..9e95c6fcc0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -84,6 +84,7 @@ typedef

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

2024-04-27 Thread James Almer
On 4/26/2024 9:23 PM, James Almer wrote: On 4/26/2024 9:03 PM, Michael Niedermayer wrote: On Fri, Apr 26, 2024 at 08:57:02PM -0300, James Almer wrote: On 4/26/2024 8:52 PM, Michael Niedermayer wrote: Fixes: memleak Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-496348854072

[FFmpeg-devel] [PATCH 02/10] fftools/ffmpeg_enc: Initialize fd

2024-04-27 Thread Michael Niedermayer
Fixes: CID1520677 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 863d1a43edd..0b3f3f101a2 100644 --- a/f

[FFmpeg-devel] [PATCH 03/10] fftools/ffmpeg_enc: Initialize Decoder

2024-04-27 Thread Michael Niedermayer
Fixes: CID1591439 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 0b3f3f101a2..928114c20ff 100644 --- a/f

[FFmpeg-devel] [PATCH 04/10] fftools/ffmpeg_mux: Remove unneeded initialization

2024-04-27 Thread Michael Niedermayer
Not sure this change makes sense, the code is more robust with ret set Fixes: CID1559178 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_mux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftool

[FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_enc: simplify opaque_ref check

2024-04-27 Thread Michael Niedermayer
Found-while-revieweing: CID1520670 Dereference after null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 618ba193ff5..863d1a4

[FFmpeg-devel] [PATCH 05/10] fftools/ffmpeg_mux_init: Free pts on error

2024-04-27 Thread Michael Niedermayer
Fixes: CID1538863 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_mux_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 8797265145c..b1cb6cf7bd7 100644 --- a

[FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg_mux_init: Cleanup on error return in set_dispositions()

2024-04-27 Thread Michael Niedermayer
Fixes: CID1539099 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg.h | 9 +++-- fftools/ffmpeg_mux_init.c | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 885a7c0c102

[FFmpeg-devel] [PATCH 07/10] fftools/cmdutils: Add protective () to FLAGS

2024-04-27 Thread Michael Niedermayer
issue found while reviewing CID1452612 Free of array-typed value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index a8f5c6d89b4..d28f5f3a8bd

[FFmpeg-devel] [PATCH 08/10] fftools/ffmpeg_sched: Remove dead assignments in sch_dec_send()

2024-04-27 Thread Michael Niedermayer
Fixes: CID1592383 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_sched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index e58b00ea97b..cff824340b7 100644 --- a/fftools

[FFmpeg-devel] [PATCH 09/10] fftools/ffplay: Check return of swr_alloc_set_opts2()

2024-04-27 Thread Michael Niedermayer
This probably makes no difference but its more correct Fixes: CID1503080 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c i

[FFmpeg-devel] [PATCH 10/10] fftools/ffplay: Check vulkan_params

2024-04-27 Thread Michael Niedermayer
Fixes: CID1550133 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffplay.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 63a9806fb80..cc00e209d52 100644 --- a/fftools/

Re: [FFmpeg-devel] [PATCH] avformat/iamfdec: check nb_streams in header read

2024-04-27 Thread James Almer
On 4/27/2024 3:51 PM, Michael Niedermayer wrote: Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid stream index.\n" failed at libavformat/demux.c:572 Fixes: 67890/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5166340789829632.fuzz Found-by: continuous fuzzing pro

Re: [FFmpeg-devel] [PATCH v4] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2024-04-27 Thread Xiang, Haihao
On Do, 2024-04-25 at 09:33 +0200, David Rosca wrote: > On Fri, Nov 24, 2023 at 8:27 AM Xiang, Haihao wrote: > > > > On Vr, 2023-10-27 at 22:25 +0200, David Rosca wrote: > > > This allows some optimizations in driver, such as not having to read > > > back the data if write-only mapping is requeste

Re: [FFmpeg-devel] [PATCH] lavfi/qsv: Copy metadata fields from the given input

2024-04-27 Thread Xiang, Haihao
On Do, 2024-04-25 at 13:18 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Currently it always copies the metadata fields from the last input when > there are multiple inputs for the filter. For example, the metadata > fields from input1 are copied to the output for overlay_qsv filter, > how

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread James Almer
On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. Signed-off-by: Michael Niederm

[FFmpeg-devel] [PATCH WIP v2 8/9] avfilter/dnn: Remove a level of dereference

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19 +-- libavfilter/dnn/dnn

[FFmpeg-devel] [PATCH WIP v2 7/9] avfilter/dnn_backend_torch: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index abdef1f178..818ec5b713 100644 --- a/libavfilter/dnn/dn

[FFmpeg-devel] [PATCH WIP v2 3/9] avfilter/dnn_backend_openvino: simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 769ba0a54b..1acc54b791 100644 --- a/libavfilter/dnn/

[FFmpeg-devel] [PATCH WIP v2 4/9] avfilter/dnn_backend_tf: Remove one level of indentation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index d24591b90b..60f9e57fb7 100644 --- a/libavfilter/dnn/dnn_backend_t

[FFmpeg-devel] [PATCH WIP v2 9/9] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h| 1 + 5 files changed

[FFmpeg-devel] [PATCH WIP v2 2/9] avfilter/dnn_backend_openvino: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index c4b0682f11..769ba0a54b 100644 --- a/libavfilter/dnn/dnn_b

[FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_STRING backend_conf

[FFmpeg-devel] [PATCH WIP v2 5/9] avfilter/dnn_backend_tf: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 60f9e57fb7..3b4de6d13f 100644 --- a/libavfilter/dnn/dnn_bac

[FFmpeg-devel] [PATCH WIP v2 6/9] avfilter/dnn_backend_tf: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 3b4de6d13f..c7716e696d 100644 --- a/libavfilter/dnn/dnn_backend_t