Re: [FFmpeg-devel] [PATCH v4] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2024-04-25 Thread David Rosca
On Fri, Nov 24, 2023 at 8:27 AM Xiang, Haihao wrote: > > On Vr, 2023-10-27 at 22:25 +0200, David Rosca wrote: > > This allows some optimizations in driver, such as not having to read > > back the data if write-only mapping is requested. > > --- > > v4: overwrite + note about vaMapBuffer libva fall

Re: [FFmpeg-devel] [PATCH v2] opusdsp: add ability to modify deemphasis constant

2024-04-25 Thread Lynne
Apr 25, 2024, 02:08 by mich...@niedermayer.cc: > On Wed, Apr 24, 2024 at 12:58:54PM +0200, Lynne wrote: > >> Apr 24, 2024, 10:54 by d...@lynne.ee: >> >> > xHE-AAC relies on the same postfilter mechanism >> > that Opus uses to improve clarity (albeit with a steeper >> > deemphasis filter). >> > >>

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-25 Thread Andrew Sayers
On Sun, Apr 21, 2024 at 01:05:13AM +0200, Michael Niedermayer wrote: > On Fri, Apr 19, 2024 at 08:00:28PM +0200, Diederick C. Niehorster wrote: > > On Fri, Apr 19, 2024, 19:35 Zhao Zhili wrote: > > > > > > > > > -Original Message- > > > > From: ffmpeg-devel On Behalf Of > > > Niklas Haas

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-25 Thread Tomas Härdin
tor 2024-04-25 klockan 02:07 +0200 skrev Michael Niedermayer: > On Thu, Apr 25, 2024 at 12:50:02AM +0200, Tomas Härdin wrote: > > ons 2024-04-17 klockan 15:58 +0200 skrev Michael Niedermayer: > > > > > * ffchat > > >     (expand into realtime chat / zoom) this would > > >     bring in more users a

Re: [FFmpeg-devel] Request for Official GitHub Mirror of rtmpdump for Enhanced Security

2024-04-25 Thread Derek Buitenhuis
On 4/23/2024 10:46 PM, Michael Niedermayer wrote: > Can you elaborate what the problem is ? > I would have thought https://git.ffmpeg.org/rtmpdump.git > is secure I have to assume he means SHA-256, and not SHA-512. git apparently supports using SHA-256 instead of SHA-1 hashes, but support does no

Re: [FFmpeg-devel] [PATCH v2 0/9] HTTP rate limiting and retry improvements

2024-04-25 Thread Derek Buitenhuis
On 4/24/2024 8:43 PM, Derek Buitenhuis wrote: > Applied all your comments. > > Will wait a day and then push if no others appear. Pushed all except Retry-After support, which I need to change. While adding RFC references I noticed it can be in seconds, *or* a date... fun. Sending an updated pat

[FFmpeg-devel] [PATCH v2 1/2] avcodec/vvcdec: we need error handling if fc->ft is NULL

2024-04-25 Thread Nuo Mi
Another inter frame may be waiting on this frame. We must finish it to avoid infinite waiting. --- libavcodec/vvc/dec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index 6aeec27eaf..92999a3ce3 100644 --- a/libavcodec/vv

[FFmpeg-devel] [PATCH v2 2/2] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-25 Thread Nuo Mi
For some error bitstreams, a CTU belongs to two slices/entry points. If the decoder initializes and submmits the CTU task twice, it may crash the program or cause it to enter an infinite loop. Reported-by: Frank Plowman --- libavcodec/vvc/dec.c| 10 -- libavcodec/vvc/thread.c | 43 +

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-25 Thread Nuo Mi
Thank you, Frank Fixed by v2 On Mon, Apr 22, 2024 at 12:34 AM Frank Plowman wrote: > On 21/04/2024 15:52, Nuo Mi wrote: > > For some error bitstreams, a CTU belongs to two slices/entry points. > > If the decoder initializes and submmits the CTU task twice, it may crash > the program > > or cau

[FFmpeg-devel] [PATCH v3 0/2] HTTP Retry-After Support

2024-04-25 Thread Derek Buitenhuis
Changes since last set: * Updated commit message with RFC references. * Properly support Retry-After as both a date and integer number of seconds. I have tested this against both an HTTP-Date and seconds, and confirmed it to work. Derek Buitenhuis (2): avformat/http: Rename parse_set_cookie

[FFmpeg-devel] [PATCH v3 1/2] avformat/http: Rename parse_set_cookie_expiry_time to parse_http_date

2024-04-25 Thread Derek Buitenhuis
That is what it actually does, and it will be needed for more than the Expiry header soon. Signed-off-by: Derek Buitenhuis --- libavformat/http.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c i

[FFmpeg-devel] [PATCH v3 2/2] avformat/http: Add support for Retry-After header

2024-04-25 Thread Derek Buitenhuis
429 and 503 codes can, and often do (e.g. all Google Cloud Storage URLs can), return a Retry-After header with the error, indicating how long to wait, asd either a date, or in seconds, before retrying again. If it is not respected by, for example, using our default backoff stratetgy instead, chance

[FFmpeg-devel] [PATCH] avformat/framecrcenc: allow setting which side data parameters are printed

2024-04-25 Thread James Almer
For some side data types, the size is dependent on the arch at runtime, which is not good for FATE tests. Add an option to set which parameters may be printed, starting with size. Signed-off-by: James Almer --- libavformat/framecrcenc.c | 28 1 file changed, 28 inser

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-25 Thread Vittorio Giovara
On Wed, Apr 24, 2024 at 3:00 PM Michael Niedermayer wrote: > > Microsoft expanded into new fields with Xbox and Azure, yes. But Windows > is still an OS, and Office is still a (un)productivity suite. > > > > Accordingly, maybe you can innovate with a new project within the same > legal entity as

Re: [FFmpeg-devel] [PATCH v3 0/2] HTTP Retry-After Support

2024-04-25 Thread Martin Storsjö
On Thu, 25 Apr 2024, Derek Buitenhuis wrote: Changes since last set: * Updated commit message with RFC references. * Properly support Retry-After as both a date and integer number of seconds. I have tested this against both an HTTP-Date and seconds, and confirmed it to work. Derek Buitenhuis

[FFmpeg-devel] [PATCH] fix av_log format specifier

2024-04-25 Thread Marcus B Spencer
Signed-off-by: Marcus B Spencer --- libavcodec/bsf/noise.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c index a622855717..d36be5fab4 100644 --- a/libavcodec/bsf/noise.c +++ b/libavcodec/bsf/noise.c @@ -173,7 +173,7 @@ static i

Re: [FFmpeg-devel] [EXTERNAL] Request for Official GitHub Mirror of rtmpdump for Enhanced Security

2024-04-25 Thread Javier Matos Denizac via ffmpeg-devel
Actually, I noticed that you publish release tarballs -> http://rtmpdump.mplayerhq.hu/download/, but I don’t see a release tarball for 2.4. Would y’all be willing to publish a release for 2.4 and maybe mint and publish a release tarball for 2.6? As for why SHA-512, we use SHA-512 checksums to v

Re: [FFmpeg-devel] [EXTERNAL] Request for Official GitHub Mirror of rtmpdump for Enhanced Security

2024-04-25 Thread Derek Buitenhuis
Hi, Replies inline. On 4/26/2024 12:10 AM, Javier Matos Denizac via ffmpeg-devel wrote: > Actually, I noticed that you publish release tarballs -> > http://rtmpdump.mplayerhq.hu/download/, but I don’t see a release tarball for > 2.4. Would y’all be willing to publish a release for 2.4 and maybe

[FFmpeg-devel] [PATCH 1/6] avformat/mov: Check tile_item_list

2024-04-25 Thread Michael Niedermayer
Fixes: Null pointer dereference Fixes: 67861/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5352628142800896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +++ 1 file change

[FFmpeg-devel] [PATCH 2/6] swscale/output: Fix integer overflow in yuv2rgba64_1_c_template

2024-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -831176 * 9539 cannot be represented in type 'int' Fixes: 67869/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-5117342091640832 The input is 9bit in 16bit, the fuzzer fills all 16bit thus generating "invalid" input No overflow should happen with valid input. Fo

[FFmpeg-devel] [PATCH 3/6] swscale/output: Fix integer overflow in yuv2rgba64_full_1_c_template()

2024-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -1082982400 + -1079364728 cannot be represented in type 'int' Fixes: 67910/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-5329011971522560 The input is 9bit in 16bit, the fuzzer fills all 16bit thus generating "invalid" input No overflow should happen with valid

[FFmpeg-devel] [PATCH 4/6] avformat/iamfdec: Files without streams cannot have packets

2024-04-25 Thread Michael Niedermayer
Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid stream index.\n" failed at libavformat/demux.c:572 Fixes: 67890/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5166340789829632.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/maste

[FFmpeg-devel] [PATCH 5/6] avcodec/wavarc: fix integer overflow in decode_5elp() block type 2

2024-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 2097152000 + 107142979 cannot be represented in type 'int' Fixes: 67919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5955101769400320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

[FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: Check body_offset

2024-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 538976288 - -9223372036315799520 cannot be represented in type 'long' Fixes: 68060/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-5523457266745344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off