Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/dnn_io_proc: Take step into consideration when crop frame

2024-04-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > wenbin.chen-at-intel@ffmpeg.org > Sent: Tuesday, April 2, 2024 4:13 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/2] libavfilter/dnn_io_proc: Take step into > consideration when crop frame > > From: Wenb

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-04-04 00:57:39) > Hi > > I will try to make the 7.0 release from the release branch in the next 48h > (with some luck but easy possible it will get delayed) > i will not try to fix any issues marked as blocking 7.0 on trac, IIRC IMO people are overly eager to mar

Re: [FFmpeg-devel] [PATCH v3 0/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-04-04 Thread Nicolas Gaullier
>Envoyé : mardi 2 avril 2024 15:06 > >v3: >- Fixes case where colorspace is the first filter (no inlink) >- Illustrates with proper examples in commit msg (use yuvtestsrc instead of >testsrc) > >Please note that it is a regression compared to the previous release: >both examples (see commit msg) b

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-04-04 Thread Niklas Haas
On Tue, 02 Apr 2024 15:05:59 +0200 Nicolas Gaullier wrote: > Fixes a regression due to the fact that the colorspace filter does > not use the new API introduced by 8c7934f73ab6c568acaa. > The scale filter uses it since 45e09a30419cc2a7251e, and the setparams > filter since 3bf80df3ccd32aed23f0. >

[FFmpeg-devel] [PATCH] movenc: Remove a leftover commented out line

2024-04-04 Thread Martin Storsjö
This line originates from 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994. --- libavformat/movenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 46a5b3a62f..ccdd2dbfc9 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1173,8 +1173,6

[FFmpeg-devel] [PATCH] tests/movenc: Validate that normal muxer usage doesn't print warnings

2024-04-04 Thread Martin Storsjö
We have test to make sure that certain configurations do print warnings. However, the normal operation of the muxer within this test always printed a warning, so those tests to check for extra warnings didn't essentially guard anything. The warning that always was printed, "track 1: codec frame si

[FFmpeg-devel] [PATCH] movenc: Allow writing timed ID3 metadata

2024-04-04 Thread Martin Storsjö
This is based on a spec at https://aomediacodec.github.io/id3-emsg/, further based on ISO/IEC 23009-1:2019. Within libavformat, timed ID3 metadata (already supported by the mpegts demuxer and muxer) is handled as a separate data AVStream with codec type AV_CODEC_ID_TIMED_ID3. However, it doesn't h

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread Michael Niedermayer
On Thu, Apr 04, 2024 at 09:12:04AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-04-04 00:57:39) > > Hi > > > > I will try to make the 7.0 release from the release branch in the next 48h > > (with some luck but easy possible it will get delayed) > > i will not try to fix any issu

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread James Almer
On 4/4/2024 8:47 AM, Michael Niedermayer wrote: On Thu, Apr 04, 2024 at 09:12:04AM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-04 00:57:39) Hi I will try to make the 7.0 release from the release branch in the next 48h (with some luck but easy possible it will get delayed)

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-04-04 Thread Nicolas Gaullier
>De : Niklas Haas >Envoyé : jeudi 4 avril 2024 12:18 >> --- a/libavfilter/vf_colorspace.c >> +++ b/libavfilter/vf_colorspace.c >> @@ -433,8 +433,7 @@ static int create_filtergraph(AVFilterContext *ctx, >> if (out->color_trc != s->out_trc) s->out_txchr = NULL; >> if (in->colors

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-04-04 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : jeudi 4 avril 2024 14:02 > >>The logic that is used in the other YUV negotiation aware filters is to just >>set `out->colorspace = outlink->colorspace` and `out->color_range = >>outlink->color_range`, since the link properties are authoritative. >This is the kind

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread Michael Niedermayer
On Thu, Apr 04, 2024 at 08:50:12AM -0300, James Almer wrote: > On 4/4/2024 8:47 AM, Michael Niedermayer wrote: > > On Thu, Apr 04, 2024 at 09:12:04AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-04-04 00:57:39) > > > > Hi > > > > > > > > I will try to make the 7.0 release fr

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-04-04 Thread Niklas Haas
On Thu, 04 Apr 2024 12:01:36 + Nicolas Gaullier wrote: > >De : Niklas Haas > >Envoyé : jeudi 4 avril 2024 12:18 > >> --- a/libavfilter/vf_colorspace.c > >> +++ b/libavfilter/vf_colorspace.c > >> @@ -433,8 +433,7 @@ static int create_filtergraph(AVFilterContext *ctx, > >> if (out->color

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread Michael Niedermayer
On Thu, Apr 04, 2024 at 08:50:12AM -0300, James Almer wrote: > On 4/4/2024 8:47 AM, Michael Niedermayer wrote: > > On Thu, Apr 04, 2024 at 09:12:04AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-04-04 00:57:39) > > > > Hi > > > > > > > > I will try to make the 7.0 release fr

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread James Almer
On 4/4/2024 9:29 AM, Michael Niedermayer wrote: On Thu, Apr 04, 2024 at 08:50:12AM -0300, James Almer wrote: On 4/4/2024 8:47 AM, Michael Niedermayer wrote: On Thu, Apr 04, 2024 at 09:12:04AM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-04 00:57:39) Hi I will try to make

Re: [FFmpeg-devel] [PATCH v3 0/5] avcodec/ac3: Add aarch64 NEON DSP

2024-04-04 Thread Martin Storsjö
On Tue, 2 Apr 2024, Geoff Hill wrote: Here's v3 to push the AC-3 ARMv8 NEON experiment a step further. This version implements 5 of the AC-3 encoder DSP functions, and adds checkasm tests where missing. I've tested that the checkasm tests pass on aarch64 and x86. Thanks, I've tested that che

Re: [FFmpeg-devel] [PATCH v3 4/5] avcodec/ac3: Implement sum_square_butterfly_int32 for aarch64 NEON

2024-04-04 Thread Martin Storsjö
On Tue, 2 Apr 2024, Geoff Hill wrote: Signed-off-by: Geoff Hill --- libavcodec/aarch64/ac3dsp_init_aarch64.c | 5 + libavcodec/aarch64/ac3dsp_neon.S | 24 + tests/checkasm/ac3dsp.c | 27 3 files changed, 56 insertions(+) d

Re: [FFmpeg-devel] [PATCH] Update the Changelog for 7.0

2024-04-04 Thread Jean-Baptiste Kempf
On Thu, 4 Apr 2024, at 07:30, Vittorio Giovara wrote: > On Thu, Apr 4, 2024 at 1:28 AM Jean-Baptiste Kempf wrote: > >> On Wed, 3 Apr 2024, at 23:18, Jean-Baptiste Kempf wrote: >> > As attached. >> >> Updated version attached (v2). >> > > lgtm with AV1 capitalized Fixed & Attached. -- Jean-Bapti

Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/ac3: Implement sum_square_butterfly_float for aarch64 NEON

2024-04-04 Thread Martin Storsjö
On Tue, 2 Apr 2024, Geoff Hill wrote: Signed-off-by: Geoff Hill --- libavcodec/aarch64/ac3dsp_init_aarch64.c | 5 libavcodec/aarch64/ac3dsp_neon.S | 35 tests/checkasm/ac3dsp.c | 26 ++ 3 files changed, 66 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] Update the Changelog for 7.0

2024-04-04 Thread James Almer
On 4/4/2024 9:59 AM, Jean-Baptiste Kempf wrote: On Thu, 4 Apr 2024, at 07:30, Vittorio Giovara wrote: On Thu, Apr 4, 2024 at 1:28 AM Jean-Baptiste Kempf wrote: On Wed, 3 Apr 2024, at 23:18, Jean-Baptiste Kempf wrote: As attached. Updated version attached (v2). lgtm with AV1 capitalized

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-04-04 Thread Nicolas Gaullier
>De : ffmpeg-devel De la part de Niklas Haas >Envoyé : jeudi 4 avril 2024 14:44 > >> >> @@ -735,6 +736,9 @@ static int filter_frame(AVFilterLink *link, AVFrame >> >> *in) >> >> return res; >> >> } >> >> >> >> +out->colorspace = s->out_csp; >> >> +outlink->color_range = s->

Re: [FFmpeg-devel] [GASPP PATCH] Implicitly start out in the text section for armasm

2024-04-04 Thread Henrik Gramner via ffmpeg-devel
On Wed, Apr 3, 2024 at 3:47 PM Martin Storsjö wrote: > > This fixes assembling files starting with bare symbol declarations, > without explicitly switching to .text first. lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

[FFmpeg-devel] [PATCH] Changelog: fix typos for 7.0 section

2024-04-04 Thread Marth64
If it's not too late, I thought these fixes would make the section look nicer for this big release. --- Changelog | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Changelog b/Changelog index a65c8ceee5..7ed638514b 100644 --- a/Changelog +++ b/Changelog @@ -40,17 +40,17 @@

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-04-04 Thread Stefano Sabatini
On date Monday 2024-04-01 21:32:04 +, ffmpeg-devel Mailing List wrote: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > --- > Changelog | 4

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread Stefano Sabatini
On date Monday 2024-04-01 21:32:05 +, ffmpeg-devel Mailing List wrote: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > > Signed-off-by: Antoine Soulier > --- > Changelog| 1 + > doc/muxers.tex

Re: [FFmpeg-devel] [PATCH] Changelog: fix typos for 7.0 section

2024-04-04 Thread James Almer
On 4/4/2024 12:08 PM, Marth64 wrote: If it's not too late, I thought these fixes would make the section look nicer for this big release. --- Changelog | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Changelog b/Changelog index a65c8ceee5..7ed638514b 100644 --- a/Chan

Re: [FFmpeg-devel] [PATCH] Changelog: fix typos for 7.0 section

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 10:08:21 -0500, Marth64 wrote: > If it's not too late, I thought these fixes would make > the section look nicer for this big release. > > --- > Changelog | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Changelog b/Changelog > index a65c

Re: [FFmpeg-devel] [PATCH] Changelog: fix typos for 7.0 section

2024-04-04 Thread Marth64
Works for me. Looks great now. Thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-04-04 Thread James Almer
On 4/1/2024 6:32 PM, Antoine Soulier via ffmpeg-devel wrote: The LC3 audio codec is the default codec of Bluetooth LE audio. This is a wrapper over the liblc3 library (https://github.com/google/liblc3). Signed-off-by: Antoine Soulier --- Changelog | 4 + configure

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread James Almer
On 4/1/2024 6:32 PM, Antoine Soulier via ffmpeg-devel wrote: A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for test purpose. This is the format implemented here. Signed-off-by: Antoine Soulier --- Changelog| 1 + doc/muxers.texi | 6 ++ li

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-04-04 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > --- > Changelog | 4 + > configure | 6 ++ >

[FFmpeg-devel] [PATCH 1/2] avcodec/liblc3dec: sanitize channel count in avctx

2024-04-04 Thread James Almer
Should prevent out of array accesses. Signed-off-by: James Almer --- libavcodec/liblc3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/liblc3dec.c b/libavcodec/liblc3dec.c index c0a31bc91f..52364859d4 100644 --- a/libavcodec/liblc3dec.c +++ b/libavcodec/liblc3dec.c @@ -46,6

[FFmpeg-devel] [PATCH 2/2] avcodec/liblc3enc: don't force unspec channel layouts

2024-04-04 Thread James Almer
We only care about channel count. Layout details will be ignored either way. Signed-off-by: James Almer --- libavcodec/liblc3enc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/liblc3enc.c b/libavcodec/liblc3enc.c index 63d1645b10..5f8169a0cf 100644 --- a

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > > Signed-off-by: Antoine Soulier > --- > Changelog| 1 + > doc/muxers.texi | 6 ++ > libavformat/Makefi

Re: [FFmpeg-devel] 7.0 release

2024-04-04 Thread Michael Niedermayer
On Thu, Apr 04, 2024 at 09:51:50AM -0300, James Almer wrote: > On 4/4/2024 9:29 AM, Michael Niedermayer wrote: > > On Thu, Apr 04, 2024 at 08:50:12AM -0300, James Almer wrote: > > > On 4/4/2024 8:47 AM, Michael Niedermayer wrote: > > > > On Thu, Apr 04, 2024 at 09:12:04AM +0200, Anton Khirnov wrote

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3dec: sanitize channel count in avctx

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 13:29:35 -0300, James Almer wrote: > Should prevent out of array accesses. > > Signed-off-by: James Almer > --- > libavcodec/liblc3dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/liblc3dec.c b/libavcodec/liblc3dec.c > index c0a31bc91f..523

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/liblc3enc: don't force unspec channel layouts

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 13:29:36 -0300, James Almer wrote: > We only care about channel count. Layout details will be ignored either way. > > Signed-off-by: James Almer > --- > libavcodec/liblc3enc.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/wavarc: fix signed integer overflow in block type 6/19

2024-04-04 Thread Michael Niedermayer
On Thu, Apr 04, 2024 at 12:51:30AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2088796289 + -91276551 cannot be represented > in type 'int' > Fixes: > 67772/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6533568953122816 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/liblc3enc: don't force unspec channel layouts

2024-04-04 Thread James Almer
On 4/4/2024 1:45 PM, Stefano Sabatini wrote: On date Thursday 2024-04-04 13:29:36 -0300, James Almer wrote: We only care about channel count. Layout details will be ignored either way. Signed-off-by: James Almer --- libavcodec/liblc3enc.c | 8 +--- 1 file changed, 5 insertions(+), 3 del

Re: [FFmpeg-devel] [PATCH] avformat/httpauth: add SHA-256 Digest Authorization [update]

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 02:07:17 +, �� | Eugene wrote: > add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h > - make_digest_auth_sha() : A1hash-> a1_hash and A2hash -> a2_hash > - combine with lint fix patch > > Signed-off-by: Eugene-bitsensing > --- > libavformat/http

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread Antoine Soulier via ffmpeg-devel
In a previous patch, I modified the duration of the packet. But since, we now support seeking, I don't know how to obtain the pts of the packet (or sample position since start), without an implementation of a `read_seek()` function. Can you help me on how I can derive the pts of the packet? Thanks.

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/liblc3enc: don't force unspec channel layouts

2024-04-04 Thread Andreas Rheinhardt
James Almer: > We only care about channel count. Layout details will be ignored either way. > > Signed-off-by: James Almer > --- > libavcodec/liblc3enc.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/liblc3enc.c b/libavcodec/liblc3enc.c > index 63d1

Re: [FFmpeg-devel] [PATCH v4 1/4] avcodec/webvttdec: honour bidi marks

2024-04-04 Thread Stefano Sabatini
On date Monday 2024-02-19 22:42:24 +0100, Oneric wrote: > --- > libavcodec/webvttdec.c | 2 +- > tests/ref/fate/sub-webvtt2 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c > index 690f00dc47..990d150f16 100644 > --- a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/liblc3enc: don't force unspec channel layouts

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 18:59:09 +0200, Andreas Rheinhardt wrote: > James Almer: > > We only care about channel count. Layout details will be ignored either way. > > > > Signed-off-by: James Almer > > --- > > libavcodec/liblc3enc.c | 8 +--- > > 1 file changed, 5 insertions(+), 3 deletio

[FFmpeg-devel] [PATCH v4 0/1] avfilter/vf_colorspace: use colorspace negotiation API

2024-04-04 Thread Nicolas Gaullier
v4: - remove dynamic color_range pass-through (which requires changing outlink dynamically and is forbidden) - nits&coding style - commit msg: simplified example (+ removed example for dynamic color_range pass-through) Nicolas Gaullier (1): avfilter/vf_colorspace: use colorspace negotiation AP

[FFmpeg-devel] [PATCH v4 1/1] avfilter/vf_colorspace: use colorspace negotiation API

2024-04-04 Thread Nicolas Gaullier
Fixes a regression due to the fact that the colorspace filter does not use the new API introduced by 8c7934f73ab6c568acaa. The scale filter uses it since 45e09a30419cc2a7251e, and the setparams filter since 3bf80df3ccd32aed23f0. Example: ffprobe -f lavfi yuvtestsrc,setparams=color_primaries=bt470b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Monday 2024-04-01 21:32:05 +, ffmpeg-devel Mailing List wrote: >> A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for >> test purpose. This is the format implemented here. >> >> Signed-off-by: Antoine Soulier >> --- >> Changelog

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > In a previous patch, I modified the duration of the packet. But since, we > now support seeking, I don't know how to obtain the pts of the packet (or > sample position since start), without an implementation of a `read_seek()` > function. > Can you help me on how

Re: [FFmpeg-devel] [PATCH 5/5] avformat/pcm: Use 64bit in bitrate computation

2024-04-04 Thread Marton Balint
On Thu, 4 Apr 2024, Michael Niedermayer wrote: Fixes: signed integer overflow: 65792 * 65312 cannot be represented in type 'int' Fixes: 67819/clusterfuzz-testcase-minimized-ffmpeg_dem_WADY_fuzzer-5236100912185344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree

Re: [FFmpeg-devel] [PATCH 5/5] avformat/pcm: Use 64bit in bitrate computation

2024-04-04 Thread Andreas Rheinhardt
Marton Balint: > > > On Thu, 4 Apr 2024, Michael Niedermayer wrote: > >> Fixes: signed integer overflow: 65792 * 65312 cannot be represented in >> type 'int' >> Fixes: >> 67819/clusterfuzz-testcase-minimized-ffmpeg_dem_WADY_fuzzer-5236100912185344 >> >> Found-by: continuous fuzzing process >> ht

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-04-04 Thread Stefano Sabatini
On date Monday 2024-02-19 22:42:25 +0100, Oneric wrote: > Backslashes cannot be escaped by a backslash in any ASS renderer, > but unless followed by specific characters it is just printed out. > Insert a word-joiner character after a backslash to break up > active sequences without changing the vis

Re: [FFmpeg-devel] [PATCH v4 3/4] avcodec/{ass, webvttdec}: more portable curly brace escapes

2024-04-04 Thread Stefano Sabatini
On date Monday 2024-02-19 22:42:26 +0100, Oneric wrote: > Unlike what the old comment suggested, standard ASS has no character > escape mechanism, but a closing curly bracket doesn't even need one. > > For manual authored sub files using a full-width variant of an apropiate appropriate? > font

Re: [FFmpeg-devel] [PATCH v4 4/4] avocdec/ass: simplify linebreaks

2024-04-04 Thread Stefano Sabatini
On date Monday 2024-02-19 22:42:27 +0100, Oneric wrote: > ff_ass_subtitle_header_* still used explicit CRLF linebreaks > eventhough they will get normalised to LF later since commit > 7bf1b9b35769b37684dd2f18a54f01d852a540c8. Just directly use LF. > --- > libavcodec/ass.c | 28 ++--

[FFmpeg-devel] [PATCH 7/7] avcodec/huffyuvenc: Deduplicate options

2024-04-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvenc.c | 42 ++--- 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c index d822793406..294d6ad41c 100644 --- a/libavcodec/huffyuvenc.c +++ b/l

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-04-04 Thread Marth64
> I'm confused by this, what kind of \N > sequences might appear in an ASS file? > Can you show an offending sequence? Good day Stefano, The one I tested with was something like : Jim\Nancy I made this up while testing. But I have seen similar in real world scenarios particularly in ASS files or

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 12:56:30 -0500, Marth64 wrote: > > I'm confused by this, what kind of \N > > sequences might appear in an ASS file? > > Can you show an offending sequence? > > Good day Stefano, > > The one I tested with was something like : > Jim\Nancy Is N a literal or is this impa

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-04-04 Thread Marth64
> Is \N a special sequence in ASS-speak \N is the special line break sequence in ASS I’m not sure of other special sequences following the \ character, I yield to Oneric on this question. Best, Marth64 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-04-04 Thread Oneric
On Thu, Apr 04, 2024 at 13:26:55 -0500, Marth64 wrote: > > Is \N a special sequence in ASS-speak > \N is the special line break sequence in ASS > > I’m not sure of other special sequences following the \ character, I yield > to Oneric on this question. Standard ASS(2) and SSAv4 have \N (forced

Re: [FFmpeg-devel] [PATCH 5/5] avformat/pcm: Use 64bit in bitrate computation

2024-04-04 Thread Michael Niedermayer
On Thu, Apr 04, 2024 at 07:12:40PM +0200, Marton Balint wrote: > > > On Thu, 4 Apr 2024, Michael Niedermayer wrote: > > > Fixes: signed integer overflow: 65792 * 65312 cannot be represented in type > > 'int' > > Fixes: > > 67819/clusterfuzz-testcase-minimized-ffmpeg_dem_WADY_fuzzer-52361009121

[FFmpeg-devel] [PATCH] avcodec/dv: Don't pretend initializing work chunks can fail

2024-04-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dv.c | 4 +--- libavcodec/dv_internal.h | 2 +- libavcodec/dvdec.c | 6 +- libavcodec/dvenc.c | 6 +- 4 files changed, 4 insertions(+), 14 deletions(-) diff --git a/libavcodec/dv.c b/libavcodec/dv.c index eb49978ad8..1

[FFmpeg-devel] [PATCH v2 8/9] avcodec/huffyuvdec: Use bytestream API for byte-aligned reads

2024-04-04 Thread Andreas Rheinhardt
This also allows to remove the padding from these buffers. Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvdec.c | 53 ++--- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 12ecfcb

[FFmpeg-devel] [PATCH v2 9/9] avcodec/huffyuvdec: Use assert to check for things that can't fail

2024-04-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index e35d55c8ad..a8ccb724f5 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@ -290,13 +2

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/dv: Don't pretend initializing work chunks can fail

2024-04-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/dv.c | 4 +--- > libavcodec/dv_internal.h | 2 +- > libavcodec/dvdec.c | 6 +- > libavcodec/dvenc.c | 6 +- > 4 files changed, 4 insertions(+), 14 deletions(-) > > diff --git a/libavcodec/dv.c

[FFmpeg-devel] [PATCH 8/9] avcodec/huffyuvdec: Use assert to check for things that can't fail

2024-04-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/huffyuvdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index e35d55c8ad..a8ccb724f5 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@ -290,13 +2

[FFmpeg-devel] [PATCH 9/9] avcodec/dv: Don't pretend initializing work chunks can fail

2024-04-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dv.c | 4 +--- libavcodec/dv_internal.h | 2 +- libavcodec/dvdec.c | 6 +- libavcodec/dvenc.c | 6 +- 4 files changed, 4 insertions(+), 14 deletions(-) diff --git a/libavcodec/dv.c b/libavcodec/dv.c index eb49978ad8..1

Re: [FFmpeg-devel] [PATCH] avcodec/ppc/h264dsp: Fix left shifts of negative numbers

2024-04-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > PPC equivalent of c756b3fca240df75ffa28e75f2eb34834c10294d. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ppc/h264dsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/ppc/h264dsp.c b/libavcodec/ppc/h264dsp.c > index f50f2

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-04-04 Thread Matthieu Bouron
On Tue, Apr 02, 2024 at 02:55:16PM +0200, Matthieu Bouron wrote: > On Mon, Apr 01, 2024 at 10:03:54AM +0200, Matthieu Bouron wrote: > > On Wed, Mar 27, 2024 at 09:06:19AM -0400, Leo Izen wrote: > > > Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat, > > > and add a stub ffjni.c

[FFmpeg-devel] [PATCH] avcodec/jni: fix mixed declaration and code

2024-04-04 Thread Matthieu Bouron
--- libavcodec/jni.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/jni.c b/libavcodec/jni.c index 1193c608c3..fcb4837413 100644 --- a/libavcodec/jni.c +++ b/libavcodec/jni.c @@ -84,11 +84,13 @@ void *av_jni_get_java_vm(void *log_ctx) int av_jni_set_android_app_

Re: [FFmpeg-devel] Fixes #10509

2024-04-04 Thread Marton Balint
On Mon, 1 Apr 2024, Poorva wrote: On Sun, Mar 31, 2024 at 8:35 PM Marton Balint wrote: On Fri, 29 Mar 2024, Poorva wrote: On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoo...@gmail.com> wrote: Thank you for your feedback on the Git patch I submitted for review. I have

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-04-04 Thread Stefano Sabatini
On date Thursday 2024-04-04 20:36:50 +0200, Oneric wrote: > On Thu, Apr 04, 2024 at 13:26:55 -0500, Marth64 wrote: > > > Is \N a special sequence in ASS-speak > > \N is the special line break sequence in ASS > > > > I’m not sure of other special sequences following the \ character, I yield > > to

Re: [FFmpeg-devel] 7.0 Name

2024-04-04 Thread Michael Niedermayer
On Mon, Apr 01, 2024 at 10:00:47PM +0200, Michael Niedermayer wrote: > Hi all > > I think we didnt decide on a name for 7.0 yet > > Previously suggested names: > Darwin, > De broglie, > Dijkstra, > Galois, > Gauss, > Jacobi, > Jemison > Johnson > Leavitt > Maxwell, > Mellin, > Perelman, > Poincar

[FFmpeg-devel] [PATCH 1/2] avcodec/liblc3dec: Retrieve duration of the last packet from the demux

2024-04-04 Thread Antoine Soulier via ffmpeg-devel
From: Antoine SOULIER Use the packet duration field to invalid last samples of the last frame. --- libavcodec/liblc3dec.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/liblc3dec.c b/libavcodec/liblc3dec.c index 90da28679b..d250ace38a 100644 --- a/lib

[FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-04 Thread Antoine Soulier via ffmpeg-devel
From: Antoine SOULIER A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for test purpose. This is the format implemented here. --- Changelog| 1 + doc/muxers.texi | 6 ++ libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavform

Re: [FFmpeg-devel] 7.0 Name

2024-04-04 Thread Paul B Mahol
LibAV yet again! On Fri, Apr 5, 2024 at 12:25 AM Michael Niedermayer wrote: > On Mon, Apr 01, 2024 at 10:00:47PM +0200, Michael Niedermayer wrote: > > Hi all > > > > I think we didnt decide on a name for 7.0 yet > > > > Previously suggested names: > > Darwin, > > De broglie, > > Dijkstra, > > Ga

Re: [FFmpeg-devel] 7.0 Name

2024-04-04 Thread Michael Niedermayer
On Fri, Apr 05, 2024 at 12:25:01AM +0200, Michael Niedermayer wrote: > On Mon, Apr 01, 2024 at 10:00:47PM +0200, Michael Niedermayer wrote: > > Hi all > > > > I think we didnt decide on a name for 7.0 yet > > > > Previously suggested names: > > Darwin, > > De broglie, > > Dijkstra, > > Galois, >

[FFmpeg-devel] FFmpeg 7.0.1

2024-04-04 Thread Michael Niedermayer
Hi all i intend to make a 7.0.1 in a few weeks for all the bug fixes that didnt make it in 7.0 thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Descr

Re: [FFmpeg-devel] [PATCH] web: add a news entry for 7.0

2024-04-04 Thread James Almer
On 4/1/2024 3:07 PM, Anton Khirnov wrote: --- Now mentioning that vvcdec is experimental, as suggested by Martin on IRC. --- src/index | 28 1 file changed, 28 insertions(+) diff --git a/src/index b/src/index index 1eb5524..2deb6af 100644 --- a/src/index +++ b/src