Re: [FFmpeg-devel] [PATCH] Make Immersive Audio Model optional for MOV demuxing

2024-03-27 Thread James Almer
On 3/27/2024 8:55 PM, Eugene Zemtsov via ffmpeg-devel wrote: From: Eugene Zemtsov Signed-off-by: Eugene Zemtsov --- libavformat/mov.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c55778f3ef..662301bf67 100644

Re: [FFmpeg-devel] [PATCH] Make Immersive Audio Model optional for MOV demuxing

2024-03-27 Thread Eugene Zemtsov via ffmpeg-devel
> Can you elaborate why you need this? In configure the mov demuxer > selects iamfdec, so it will always be present and compiled. Chromium doesn't use Immersive Audio, but the code for handling it bloats Android binaries, that's why we disabled it. I have a second patch that disables iamfdec by d

[FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining

2024-03-27 Thread arch1t3cht
Fix one or more frames being dropped when starting decoding at a SEI recovery point that is very close to the end of the stream (specifically, which is less than 2 * has_b_frames frames before the end of the stream in decoding order). One case of this was reported in ticket #10936. Tested for regr

[FFmpeg-devel] [PATCH 1/3] avcodec/h264dec: Properly mark frames as recovered when draining

2024-03-27 Thread arch1t3cht
When decoding starts at a SEI recovery point very shortly before the end of the video stream, there can be frames which are decoded before the recovery point's frame is output and which will only be output once the draining has started. Previously, these frames would never be set as recovered. This

[FFmpeg-devel] [PATCH 2/3] avcodec/h264dec: Handle non-recovered frames when draining

2024-03-27 Thread arch1t3cht
When starting on a SEI recovery point close enough to the end of the stream that draining starts before the recovery point's frame is output, there can be non-recovered frames in the delayed picture buffer that would currently cause the decoder to fail to output a frame. This commit skips such fram

[FFmpeg-devel] [PATCH 3/3] avcodec/h264dec: Reindent after the previous commit

2024-03-27 Thread arch1t3cht
Signed-off-by: arch1t3cht --- libavcodec/h264dec.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 68f47912e2..6f62fadb11 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec

[FFmpeg-devel] [PATCH v1 1/7] lavc/vaapi_dec: Create VA parameters dynamically

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_decode.c | 29 ++--- libavcodec/vaapi_decode.h | 7 ++- 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index cca94b5336..1b1972a2a9 10

[FFmpeg-devel] [PATCH v1 2/7] lavc/vvc_refs: Move definition of VVC_FRAME_FLAG* to h header

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang So that hardware decoder can use the flags too. Signed-off-by: Fei Wang --- libavcodec/vvc/vvc_refs.c | 4 libavcodec/vvc/vvc_refs.h | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/vvc_refs.c b/libavcodec/vvc/vvc_refs.c index afcfc09

[FFmpeg-devel] [PATCH v1 3/7] lavc/cbs_h266: Add SliceTopLeftTileIdx to H266RawPPS

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/cbs_h266.h | 1 + libavcodec/cbs_h266_syntax_template.c | 4 2 files changed, 5 insertions(+) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 73d94157d4..19f83aeb49 100644 --- a/libavcodec/cbs_h266.h ++

[FFmpeg-devel] [PATCH v1 4/7] lavc/cbs_h266: Add NumSlicesInTile to H266RawPPS

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/cbs_h266.h | 1 + libavcodec/cbs_h266_syntax_template.c | 16 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 19f83aeb49..87bd39c6f5 100644

[FFmpeg-devel] [PATCH v1 5/7] lavc/vvc_ps: Add alf raw syntax into VVCALF

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vvc/vvc_ps.c | 10 +- libavcodec/vvc/vvc_ps.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c index 7972803da6..97eef85be9 100644 --- a/libavcodec/vvc/vvc_ps.c

[FFmpeg-devel] [PATCH v1 6/7] lavc/vvc_dec: Add hardware decode API

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vvc/vvc_refs.c | 6 libavcodec/vvc/vvcdec.c | 67 +++ libavcodec/vvc/vvcdec.h | 5 +++ 3 files changed, 72 insertions(+), 6 deletions(-) diff --git a/libavcodec/vvc/vvc_refs.c b/libavcodec/vvc/

[FFmpeg-devel] [PATCH v1 7/7] lavc/vaapi_dec: Add VVC decoder

2024-03-27 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- Changelog | 4 + configure | 3 + libavcodec/Makefile | 1 + libavcodec/hwaccels.h | 1 + libavcodec/vaapi_decode.c | 7 + libavcodec/vaapi_vvc.c| 657 ++ libav

Re: [FFmpeg-devel] [PATCH v1 6/7] lavc/vvc_dec: Add hardware decode API

2024-03-27 Thread Andreas Rheinhardt
fei.w.wang-at-intel@ffmpeg.org: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > libavcodec/vvc/vvc_refs.c | 6 > libavcodec/vvc/vvcdec.c | 67 +++ > libavcodec/vvc/vvcdec.h | 5 +++ > 3 files changed, 72 insertions(+), 6 deletions(-) > >

[FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra

2024-03-27 Thread Xiang, Haihao
From: Haihao Xiang Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10 instead for decoding. This patch fixes the error below: [hevc @ 0x55a771b80a00] No support for codec hevc profile 4. [hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel initialisation returned e

Re: [FFmpeg-devel] [PATCH 2/3] lavc/vp8dsp: R-V V put_epel v

2024-03-27 Thread flow gg
Okay, changed in the reply and github (another reason for not doing so initially was the thought that there weren't enough registers available, and that other changes would need to be made that could cause side effects, but now it's found that the vp8 registers are sufficient.. it's just that vp9 d

[FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_vaapi: Add a new quirk

2024-03-27 Thread Xiang, Haihao
From: Haihao Xiang libva2 doesn't require a fixed surface-array any more, but some driver/hardware combinations which rely on this are still used. To reduce the impact to users, add a quirk for the driver/hardware combination which supports dynamic surface pool. Signed-off-by: Haihao Xiang ---

[FFmpeg-devel] [PATCH 2/3] lavc/vaapi_decode: Use dynamic frame pool if possible

2024-03-27 Thread Xiang, Haihao
From: Haihao Xiang This allows a downstream element stores more frames from VAAPI decoders and fixes the broke cases for the driver/hardware combination which doesn't rely on fixed surface-array. For example: $ ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi \ -i input.mp4 -c:v hevc_vaapi -f

[FFmpeg-devel] [PATCH 3/3] lavfi/vaapi_vpp: Use dynamic frame pool in outlink if possible

2024-03-27 Thread Xiang, Haihao
From: Haihao Xiang This can fix the broken cases for the driver/hardware combination which doesn't rely on fixed surface-array. For example: $ ffmpeg -hwaccel_output_format vaapi -hwaccel vaapi -i input.mp4 \ -vf 'scale_vaapi=w=720:h=480' -c:v hevc_vaapi -f null - Signed-off-by: Haihao Xiang -

Re: [FFmpeg-devel] [PATCH v7 11/12] avcodec: add D3D12VA hardware HEVC encoder

2024-03-27 Thread Wu, Tong1
Kindly ping. Is there any more comment on v7? >-Original Message- >From: Wu, Tong1 >Sent: Thursday, March 14, 2024 4:15 PM >To: ffmpeg-devel@ffmpeg.org >Cc: Wu, Tong1 >Subject: [FFmpeg-devel][PATCH v7 11/12] avcodec: add D3D12VA hardware >HEVC encoder > >From: Tong Wu > >This implementa

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-27 Thread flow gg
I don't quite understand, I think here 8x8 because zve64x is not suitable for sharing, it shares between dc16x16 and dc32x32, there isn't much common code, it would require adding 3 if-else statements and function parameters, it feels okay not to extract too. Rémi Denis-Courmont 于2024年3月27日周三 23:

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000htdec: Check M_b / magp before using it in a shift

2024-03-27 Thread Michael Niedermayer
On Wed, Mar 27, 2024 at 11:13:48AM +0100, Tomas Härdin wrote: > mån 2024-03-25 klockan 21:04 +0100 skrev Michael Niedermayer: > > On Mon, Mar 25, 2024 at 08:13:13PM +0100, Michael Niedermayer wrote: > > > On Thu, Mar 21, 2024 at 04:07:14PM +0100, Tomas Härdin wrote: > > > > ons 2024-03-20 klockan 2

[FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries

2024-03-27 Thread James Almer
Enable it only for side data types that don't allow more than one entry. Signed-off-by: James Almer --- libavutil/frame.c | 59 --- libavutil/frame.h | 27 +- libavutil/tests/side_data_array.c | 52 +++---

[FFmpeg-devel] [PATCH 2/7 v4] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-27 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 53 +++ libavutil/frame.h | 34 ++ 2 files changed, 87 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d9bd19b2aa..a165e56a64 100644 --- a/libavutil/f

[FFmpeg-devel] [PATCH 3/7 v4] avutil/frame: use the same data pointer as the source entry when cloning side data

2024-03-27 Thread James Almer
src->data does not need to match src->buf->data Signed-off-by: James Almer --- libavutil/frame.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index a165e56a64..d27998d1f4 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH 4/7 v4] avutil/frame: add helper to remove side data of a given type from an array

2024-03-27 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 6 ++ libavutil/frame.h | 5 + 2 files changed, 11 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d27998d1f4..f54c1fa472 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -965,6 +965,12 @@ const AVFrameSid

[FFmpeg-devel] [PATCH 5/7 v4] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-27 Thread James Almer
av_mastering_display_metadata_alloc() is not useful in scenarios where you need to know the runtime size of AVMasteringDisplayMetadata. Signed-off-by: James Almer --- libavutil/mastering_display_metadata.c | 13 + libavutil/mastering_display_metadata.h | 9 + 2 files change

[FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames

2024-03-27 Thread James Almer
They will be useful to fill arrays stored in other structs. Signed-off-by: James Almer --- libavcodec/av1dec.c | 7 +-- libavcodec/cri.c| 3 +- libavcodec/decode.c | 99 +++-- libavcodec/decode.h | 28 ++-- libavcodec/dpx.c

[FFmpeg-devel] [PATCH 7/7 v4] avcodec/hevcdec: export global side data in AVCodecContext

2024-03-27 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 2 +- libavcodec/h2645_sei.c | 215 + libavcodec/h2645_sei.h | 2 + libavcodec/hevcdec.c | 4 + libavcodec/pthread_frame.c | 11 ++ 5 files changed, 141 insertions(+), 93 deletions

Re: [FFmpeg-devel] [PATCH 1/6 v3] avutil/frame: add a flag to allow overwritting existing entries

2024-03-27 Thread Michael Niedermayer
On Wed, Mar 27, 2024 at 04:10:43PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/frame.c | 59 +++ > libavutil/frame.h | 27 +++--- > 2 files changed, 74 insertions(+), 12 deletions(-) broke fate, but i see yo

Re: [FFmpeg-devel] [PATCH 1/6 v3] avutil/frame: add a flag to allow overwritting existing entries

2024-03-27 Thread James Almer
On 3/28/2024 12:25 AM, Michael Niedermayer wrote: On Wed, Mar 27, 2024 at 04:10:43PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavutil/frame.c | 59 +++ libavutil/frame.h | 27 +++--- 2 files changed, 74 insertions

[FFmpeg-devel] [PATCH] avcodec/ac3: Implement float_to_fixed24 for aarch64 neon

2024-03-27 Thread Geoff Hill
Tested on AWS Graviton2 (t4g.medium), NixOS 23.11, GCC 12.3: float_to_fixed24_c: 2462.7 float_to_fixed24_neon: 513.5 Signed-off-by: Geoff Hill --- libavcodec/aarch64/Makefile | 2 ++ libavcodec/aarch64/ac3dsp_init_aarch64.c | 36 +++ libavcodec/aarch64/ac3dsp_n

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: convert from lambda to qp

2024-03-27 Thread Xiang, Haihao
From: Haihao Xiang When AV_CODEC_FLAG_QSCALE is set, the value of avctx->global_quality is lambda. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 940f0

<    1   2