Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-12 Thread Andreas Rheinhardt
James Almer: > On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote: >> Affects many FATE-tests, see >> http://fate.ffmpeg.org/report.cgi?time=20240312011016&slot=ppc-linux-gcc-13.2-ubsan-altivec-qemu >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavformat/avidec.c | 2 +- >>   1 file changed, 1

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
I get it now. Disregard patch. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Check before accessing union member

2024-03-12 Thread Andreas Rheinhardt
OptionDef.u is only an offset (i.e. its off member) iff OPT_FLAG_OFFSET is true. Otherwise, the pointer arithmetic can be undefined behaviour. UBSan warns about this (on 32bit arches): src/fftools/ffmpeg_opt.c:102:15: runtime error: pointer index expression with base 0xffa4db10 overflowed to 0x560

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-12 Thread James Almer
On 3/12/2024 8:01 PM, Andreas Rheinhardt wrote: James Almer: On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote: Affects many FATE-tests, see http://fate.ffmpeg.org/report.cgi?time=20240312011016&slot=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt ---   libavformat/avide

Re: [FFmpeg-devel] [PATCH] avcodec/parser: Check next against buffer index

2024-03-12 Thread James Almer
On 6/24/2023 5:13 PM, Reimar Döffinger wrote: Hi! On 24 Jun 2023, at 21:14, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: out of array access Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b Found-by: Catena cyber Signed-off-by: Michael Niedermayer --- libavcodec/parser.c |

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Michael Niedermayer
On Mon, Mar 11, 2024 at 05:40:25PM -0400, Leo Izen wrote: > > > On 3/9/24 20:25, Michael Niedermayer wrote: > > Hi everyone > > > > Some members of the CC want to indefinitely ban Balling > > from trac. And as our doc/community.texi says: > > "Indefinite bans from the community must be confirmed

[FFmpeg-devel] [PATCH] avcodec/lossless_videoencdsp: Fix unaligned access

2024-03-12 Thread Andreas Rheinhardt
HAVE_FAST_UNALIGNED being true does not imply that one can simply read from any pointer via *(long*). It is undefined behaviour in case the pointer is not sufficiently aligned; and even if it is, it is (likely) a violation of the effective-type rules. Fix both of these by using the appropriate AV_[

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Align idct-block appropriately

2024-03-12 Thread Andreas Rheinhardt
It is accessed via AV_RN64() in ff_simple_idct_put_int32_10bit(). Should fix the UBSan failures in the mpeg4-simple-studio-profile test here: https://fate.ffmpeg.org/report.cgi?time=20240312011016&slot=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4vi

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Michael Niedermayer
Hi On Tue, Mar 12, 2024 at 01:14:45PM -0400, Ronald S. Bultje wrote: > Hello, > > On Sat, Mar 9, 2024 at 8:25 PM Michael Niedermayer > wrote: > > > Some members of the CC want to indefinitely ban Balling > > from trac. And as our doc/community.texi says: > > "Indefinite bans from the community

[FFmpeg-devel] [PATCH] avcodec/ppc/vp8dsp_altivec: Fix out-of-bounds access

2024-03-12 Thread Andreas Rheinhardt
h_subpel_filters_inner[i] and h_subpel_filters_outer[i / 2] belong together and the former allows the range 0..6, so the latter needs to support 0..3. But it has only three elements. Add another one. The value for the last element has been guesstimated from subpel_filters in libavcodec/vp8dsp.c. T

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka wrote: > On 3/8/24 4:34 AM, Rajiv Harlalka wrote: > > Check for zeros equal to the total samples early, because in case the > > check is true we would already be leaving the first few frames out. > > > > Signed-off-by: Rajiv Harlalka > > #10692 > >

[FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-12 Thread Pavel Koshevoy
From: Rajiv Harlalka Check for zeros equal to the total samples early, because in that case we would already be leaving the first few frames out. Fixes trac ticket #10692 --- libavfilter/af_atempo.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilt

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 8:22 PM Pavel Koshevoy wrote: > > > On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka > wrote: > >> On 3/8/24 4:34 AM, Rajiv Harlalka wrote: >> > Check for zeros equal to the total samples early, because in case the >> > check is true we would already be leaving the first fe

Re: [FFmpeg-devel] [PATCH v6 8/9] avcodec: add D3D12VA hardware HEVC encoder

2024-03-12 Thread Wu, Tong1
Kindly ping. Hi Mark, do you have more comments on this patch set? >Subject: [FFmpeg-devel][PATCH v6 8/9] avcodec: add D3D12VA hardware HEVC >encoder > >From: Tong Wu > >This implementation is based on D3D12 Video Encoding Spec: >https://microsoft.github.io/DirectX-Specs/d3d/D3D12VideoEncoding.

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 9:01 PM Pavel Koshevoy wrote: > From: Rajiv Harlalka > > Check for zeros equal to the total samples early, because in > that case we would already be leaving the first few frames out. > > Fixes trac ticket #10692 > --- > libavfilter/af_atempo.c | 18 +- >

Re: [FFmpeg-devel] [PATCH v6 2/9] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-03-12 Thread Lynne
Feb 29, 2024, 06:35 by tong1.wu-at-intel@ffmpeg.org: > From: Tong Wu > > Since VAAPI and future D3D12VA implementation may share the same dpb > logic and some other functions. A base layer encode context is introduced > as vaapi context's base and extract the related funtions to a common > fi

Re: [FFmpeg-devel] [PATCH] configure: add threads dep for vulkan

2024-03-12 Thread Gyan Doshi
On 2024-03-12 09:15 pm, Lynne wrote: Mar 12, 2024, 05:16 by ffm...@gyani.pro: Fixes #10900 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 05f8283af9..e0b5bcf589 100755 --- a/configure +++ b/configure @@ -3076,6 +3076,7 @@ nvdec_deps="ffnvcode

Re: [FFmpeg-devel] [PATCH] change av_ts_make_time_string precision

2024-03-12 Thread Allan Cady via ffmpeg-devel
On Tuesday, March 12, 2024 at 02:24:47 PM PDT, Marton Balint wrote: > On Tue, 12 Mar 2024, Allan Cady via ffmpeg-devel wrote: >> On Monday, March 11, 2024 at 12:11:45 PM PDT, Marton Balint >> wrote: >>> On Mon, 11 Mar 2024, Andreas Rheinhardt wrote: >>> Allan Cady via ffmpeg-devel: From:

Re: [FFmpeg-devel] [PATCH] change av_ts_make_time_string precision

2024-03-12 Thread Allan Cady via ffmpeg-devel
I've been meaning to ask -- what version of C are we using? I know it's at least 99, because of the compound literal (had to look that up). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubsc

<    1   2