On date Friday 2024-03-08 13:50:59 +, ffmpeg-devel Mailing List wrote:
> Thank you for your incredibly thorough and fast response. I've applied all
> the corrections you requested. Please let me know if there's anything else
> wrong with my patch, and thank you for your time.
>
> - asivery
On date Friday 2024-03-08 17:24:47 -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> doc/ffprobe.xsd | 50 +
> fftools/ffprobe.c | 53 ---
> tests/fate/mov.mak| 6 +-
On date Friday 2024-03-08 17:24:48 -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> doc/ffprobe.xsd | 39 ++
> fftools/ffprobe.c | 160 +++-
> tests/fate/iamf.mak | 12 +-
> tests/fate/mov.ma
On Sat, Mar 9, 2024 at 2:09 AM Muhammad Faiz wrote:
> On Fri, Mar 8, 2024 at 10:30 PM Paul B Mahol wrote:
>
> > On Fri, Mar 8, 2024 at 4:18 PM Muhammad Faiz wrote:
> >
> > > On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt <
> > > andreas.rheinha...@outlook.com> wrote:
> > >
> > > > Muhammad F
Hi Martin,
On Fri, Mar 8, 2024 at 3:38 AM Martin Storsjö wrote:
>
> This currently builds files in the libavcodec/x86/{vvc,h26x}
> subdirectories, which is somewhat unexpected when building for
> another architecture than x86.
>
> The regular arch subdirectories are handled with
>
> -include
Hi,
On Fri, Mar 8, 2024 at 3:38 AM Martin Storsjö wrote:
>
> In some builds, the following object files could be left behind
> after make clean:
>
> ./libavfilter/metal/utils.o
> ./libavfilter/metal/vf_yadif_videotoolbox.metallib.o
> ./libavcodec/x86/h26x/h2656dsp.o
> ./libavcodec/neon/mpegvideo.
Thank you, Fei,
Do you happen to know why the following clips are still failing?
CROP_A_Panasonic_4.bit
CROP_B_Panasonic_4.bit
https://github.com/ffvvc/tests/tree/main/conformance/failed/v1/CROP
On Fri, Mar 8, 2024 at 8:54 AM wrote:
> From: Fei Wang
>
> Signed-off-by: Fei Wang
> ---
> libav
Muhammad Faiz:
> On Fri, Mar 8, 2024 at 10:46 PM Andreas Rheinhardt <
> andreas.rheinha...@outlook.com> wrote:
>
>> Muhammad Faiz:
>>> On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt <
>>> andreas.rheinha...@outlook.com> wrote:
>>>
Muhammad Faiz:
> On Tue, Feb 6, 2024 at 3:58 PM Andreas
Hi Fei,
Thank you fei,
Better provide more comments
Is there any clip fail for this?
On Fri, Mar 8, 2024 at 8:55 AM wrote:
> From: Fei Wang
>
> Signed-off-by: Fei Wang
> ---
> libavcodec/vvc/vvc_ps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/vvc_p
asivery via ffmpeg-devel:
> +#include "libavutil/intreadwrite.h"
> +#include "libavutil/avstring.h"
These two headers seem unused.
> +#include "avformat.h"
> +#include "avio_internal.h"
> +#include "rawenc.h"
> +#include "mux.h"
> +
> +static int aea_write_header(AVFormatContext *s)
> +{
> +c
On Fri, Mar 8, 2024 at 11:41 PM Kieran Kunhya wrote:
> On Fri, 8 Mar 2024 at 15:04, Frank Plowman wrote:
>
> > On 08/03/2024 14:04, James Almer wrote:
> > > On 3/8/2024 11:02 AM, Kieran Kunhya wrote:
> > >> On Fri, 8 Mar 2024 at 14:00, James Almer wrote:
> > >>
> > >>> On 3/3/2024 4:35 AM, Jean
Hi, sorry for the slow reply.
On date Thursday 2024-02-29 16:23:06 +, Andrew Sayers wrote:
> There seems to be a convention for documenting ownership:
I find "ownership" a bit confusing, probably it's better to talk about
context usage.
>
> /**
> * - encoding: (who sets this in en
On date Thursday 2024-02-29 16:23:07 +, Andrew Sayers wrote:
> There seems to be a convention for documenting meanings:
>
> /**
> * Encoding: (meaning in encoding context)
> * Decoding: (meaning in decoding context)
> */
>
> At a glance, these are confusingly similar to ow
On date Friday 2024-03-08 01:53:25 +0100, Marton Balint wrote:
> Use lexical order.
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/bsf/pcm_rechunk.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
LGTM, thanks.
___
On date Friday 2024-03-08 01:53:26 +0100, Marton Balint wrote:
> Signed-off-by: Marton Balint
> ---
> libavcodec/bsf/pcm_rechunk.c | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
LGTM (although I didn't check that the *LAW values for 0 match), thanks.
___
On date Friday 2024-03-08 01:53:27 +0100, Marton Balint wrote:
> The samples I found all have 2000 sample packets, and by forcing the packet
> size with a bsf we could automagically make muxing work for packets containing
> more than 3640 samples.
>
> Signed-off-by: Marton Balint
> ---
> configu
Thank you both for the suggestions. I've updated the code as requested, and I
apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an oversight
on my part.
I have also added the stream codec check, and it did get triggered when I tried
to feed it audio that was not ATRAC1, so it see
asivery via ffmpeg-devel:
> +const char *title_contents = title_entry->value;
> +title_length = strlen(title_contents);
> +if (title_length > 256) {
> +av_log(s, AV_LOG_WARNING, "Title too long, truncated to 256
> bytes.\n");
> +title_length = 256;
>
I see, I've changed title_length to size_t, but left the warning as is to
inform the user in case truncation needs to take place.
On Saturday, March 9th, 2024 at 6:48 PM, Andreas Rheinhardt
wrote:
> asivery via ffmpeg-devel:
>
> > + const char *title_contents = title_entry->value;
> > + title
In this patchset, following improvements are prioritized and made.
(1) explicitly set mono channel layout (reviewed)
(2) add subtitle color support (reviewed; in response to feedback I have
removed the YUV option)
(3) menu support (reviewed; updated based on feedback)
When all merged, I will fol
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index b3cc32b864..ca85aa8d3d 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -932,7 +932,9 @@
Signed-off-by: Marth64
---
libavformat/Makefile | 2 +-
libavformat/dvdclut.c | 75 +++
libavformat/dvdclut.h | 37 +++
libavformat/dvdvideodec.c | 14
4 files changed, 127 insertions(+), 1 deletion(-)
create mode 100644
Signed-off-by: Marth64
---
doc/demuxers.texi | 43 +-
libavformat/dvdvideodec.c | 314 --
2 files changed, 339 insertions(+), 18 deletions(-)
diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index f4bac8f3b3..b70f3a38d7 100644
--- a/doc/demuxers
It is by no means a blocker but I think it would be nice for users to be
able view subtitle colors with the dvdvideo demuxer, after all it is part
of the presentation. There is a patch for this that has gone through
several reviews. I have (hopefully) addressed the last round of feedback,
but I wil
Signed-off-by: Marth64
---
libavcodec/ccaption_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
index 1550e4b253..d03413265a 100644
--- a/libavcodec/ccaption_dec.c
+++ b/libavcodec/ccaption_dec.c
@@ -358,7 +358,7 @@ st
Signed-off-by: Marth64
---
libavcodec/ccaption_dec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
index d03413265a..faf058ce97 100644
--- a/libavcodec/ccaption_dec.c
+++ b/libavcodec/ccaption_dec.c
@@ -948,7 +948,7 @
I am willing to maintain these into the future as needed. Thank you.
Signed-off-by: Marth64
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cc7f564f48..dd633f37e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -373,6 +373,7 @@ Muxers/Demuxers:
The caller does not need or expect it, and it can lead to terminating
filtering prematurely in case there is more than one output.
---
fftools/ffmpeg_filter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 960393b943..7
It has no reason to exist.
---
fftools/ffmpeg_filter.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 7cd5415341..a87bed6ec7 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -225
Will push tomorrow if nobody has further comments.
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with s
Fixes compiler warning introduced in v2 due to incorrect printf format for
ssize_t.
Apologies for the inconvenience.
Signed-off-by: Marth64
---
doc/demuxers.texi | 43 +-
libavformat/dvdvideodec.c | 314 --
2 files changed, 339 insertions(+), 18
Andreas Rheinhardt:
> Unnecessary since 67e7f0b0537eee1357769038270fda08fe32
> as there are no longer two opaque fields.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/libdav1d.c | 27 ---
> 1 file changed, 27 deletions(-)
>
> diff --git a/libavcodec/libdav
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> Absolutely untested (not even compiled).
>
> libavcodec/librav1e.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
> index dbd728a408..2a6d8bfbed 100644
Andreas Rheinhardt:
> Speeds up decoding and also reduces binary size.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/xpmdec.c | 25 -
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/libavcodec/xpmdec.c b/libavcodec/xpmdec.c
> index 5bc02378
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavutil/avstring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/avstring.c b/libavutil/avstring.c
> index 8751ce5576..2071dd36a5 100644
> --- a/libavutil/avstring.c
> +++ b/libavutil/avstring.
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/h264_ps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
> index dcc51b96db..3c8fc33c7f 100644
> --- a/libavcodec/h264_ps.c
> +++ b/libavcodec/h264_ps.
Andreas Rheinhardt:
> Improves performance by about 30%.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> [1] is a patch that would also move the bitreverse into the LUT;
> it didn't make a difference in the benchmarks here, but if it is
> an improvement for someone else, it could still be applied.
Andreas Rheinhardt:
> Use a small LUT instead. Improves performance.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/xbmenc.c | 21 +++--
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/xbmenc.c b/libavcodec/xbmenc.c
> index cd8b73afa3..52
Hey, no problem :)
On 09/03/2024 16:06, Stefano Sabatini wrote:
Hi, sorry for the slow reply.
On date Thursday 2024-02-29 16:23:06 +, Andrew Sayers wrote:
There seems to be a convention for documenting ownership:
I find "ownership" a bit confusing, probably it's better to talk about
con
I have attached the git patch containing the changes for your review.
This patch is submitted as part of my qualification task for Google Summer
of Code (GSoC)
0001-avfilter-f_select.c-add-support-for-iw-and-ih-consta.patch
Description: Binary data
___
Signed-off-by: Marton Balint
---
doc/APIchanges | 3 +++
libavutil/channel_layout.c | 30 ++
libavutil/channel_layout.h | 7 +++
libavutil/version.h| 2 +-
4 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/AP
Signed-off-by: Marton Balint
---
libavformat/mov_chan.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c
index 3e186b0837..ead3a9b91b 100644
--- a/libavformat/mov_chan.c
+++ b/libavformat/mov_chan.c
@@ -543,10 +543,8
Deduplicates a lot of code.
Some minor differences (mostly white space and inconsistent use of quotes) are
expected in the fate tests, there was no point aiming for exactly the same
formatting.
Signed-off-by: Marton Balint
---
libavutil/tests/channel_layout.c | 283 +++--
We lacked tests which supposed to fail, and there are some which should fail
but right now it does not. This will be fixed in a later commit.
Signed-off-by: Marton Balint
---
libavutil/tests/channel_layout.c | 26 ++
tests/ref/fate/channel_layout| 26 +
Also make initialization/uninitialization behaviour more explicit in the docs,
and make sure we do not leak a channel map on error.
Signed-off-by: Marton Balint
---
libavutil/channel_layout.c | 5 +
libavutil/channel_layout.h | 8 ++--
2 files changed, 11 insertions(+), 2 deletions(-)
d
Signed-off-by: Marton Balint
---
libavutil/channel_layout.c | 13 +
libavutil/tests/channel_layout.c | 2 ++
tests/ref/fate/channel_layout| 4 +++-
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c
index
Also make use of the av_channel_from_string() function to determine the channel
id. This fixes some parse issues in av_channel_layout_from_string().
Signed-off-by: Marton Balint
---
libavutil/channel_layout.c| 172 --
tests/ref/fate/channel_layout | 8 +-
2
On Sat, Mar 9, 2024 at 6:59 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Muhammad Faiz:
> > On Fri, Mar 8, 2024 at 10:46 PM Andreas Rheinhardt <
> > andreas.rheinha...@outlook.com> wrote:
> >
> >> Muhammad Faiz:
> >>> On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt <
> >>> an
On Sat, Mar 9, 2024 at 6:11 PM Paul B Mahol wrote:
> On Sat, Mar 9, 2024 at 2:09 AM Muhammad Faiz wrote:
>
> > On Fri, Mar 8, 2024 at 10:30 PM Paul B Mahol wrote:
> >
> > > On Fri, Mar 8, 2024 at 4:18 PM Muhammad Faiz wrote:
> > >
> > > > On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt <
> >
On Fri, Mar 08, 2024 at 09:27:47AM +0100, Anton Khirnov wrote:
> thread.h currently contains both API for decoder use and functions
> internal to lavc generic layer. Move the latter to avcodec_internal.h,
> which is a more appropriate place for them.
> ---
> libavcodec/avcodec_internal.h | 24
In Closed Captions (US), the non-breaking space (0xA0) can be used to align
text horizontally from the left by using it as a leading character.
However, CC decoder does not ignore it as a leading character like it does
an ordinary space, so a blank padding is rendered over the black CC box.
This is
On 10 Mar 2024, at 2:25, Michael Niedermayer wrote:
> Hi everyone
>
> Some members of the CC want to indefinitely ban Balling
> from trac. And as our doc/community.texi says:
> "Indefinite bans from the community must be confirmed by the General
> Assembly, in a majority vote."
>
> Thus some CC m
Following up on this from December 2023. I simplified the content and
hopefully addressed the feedback.
Signed-off-by: Marth64
---
doc/bitstream_filters.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index e06de1a
On Sun, Mar 10, 2024 at 02:36:48AM +0100, epira...@gmail.com wrote:
> On 10 Mar 2024, at 2:25, Michael Niedermayer wrote:
>
> > Hi everyone
> >
> > Some members of the CC want to indefinitely ban Balling
> > from trac. And as our doc/community.texi says:
> > "Indefinite bans from the community mus
On 10 Mar 2024, at 4:00, Michael Niedermayer wrote:
> On Sun, Mar 10, 2024 at 02:36:48AM +0100, epira...@gmail.com wrote:
>> On 10 Mar 2024, at 2:25, Michael Niedermayer wrote:
>>
>>> Hi everyone
>>>
>>> Some members of the CC want to indefinitely ban Balling
>>> from trac. And as our doc/commun
On Fri, Mar 08, 2024 at 06:34:36AM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-03-07 21:37:39)
> > On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote:
> > > Treat it analogously to stream parameters like format/dimensions/etc.
> > > This is functionally different from
Quoting Michael Niedermayer (2024-03-10 04:36:29)
> On Fri, Mar 08, 2024 at 06:34:36AM +0100, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2024-03-07 21:37:39)
> > > On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote:
> > > > Treat it analogously to stream parameters like format
57 matches
Mail list logo
