Re: [FFmpeg-devel] [PATCH] avcodec/libxeve: Use av_dict_iterate()

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libxeve.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c > index ef1681d397..c923ac1cac 100644 > --- a/libavcodec/libxeve.c > +++ b/libavcodec/libx

Re: [FFmpeg-devel] [PATCH] avutil/mem_internal: Remove unneeded headers

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Unneeded since 21814a70db08999efee49531c67f62e2678a62f4. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/mem_internal.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavutil/mem_internal.h b/libavutil/mem_internal.h > index b1d89a0605..20f9b3e3f2 1006

Re: [FFmpeg-devel] [PATCH] avcodec/refstruct: Don't use STRIDE_ALIGN for alignment

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It was always intended that the buffers returned by > RefStruct shall have the same alignment guarantees > as the buffers returned by av_malloc(); said alignment > depends upon the arch and the enabled instruction set > and the code used STRIDE_ALIGN as a proxy for this. > >

Re: [FFmpeg-devel] [PATCH] avcodec/mss[12]: Cleanup generically on init failure

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mss1.c | 3 ++- > libavcodec/mss2.c | 9 +++-- > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/mss1.c b/libavcodec/mss1.c > index fb5fc34ea1..5460673133 100644 > --- a/libavcodec/mss1.c

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Improve validity check a bit

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/decode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index da6446d879..7c67b18bc4 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/libxevd: Remove FF_CODEC_CAP_SETS_PKT_DTS cap

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This decoder implements the receive_frame API; such decoders > always have to set the pkt_dts field themselves and the avcodec > test checks for this. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libxevd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Add missing AV1 decoder->av1_parse.o dependency

2024-02-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Needed for ff_av1_framerate(). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 09ae5270b3..cf8b5aac81 100644 > --- a/libavcodec/Make

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-02-29 Thread Niklas Haas
On Wed, 28 Feb 2024 17:01:13 +0100 Andreas Rheinhardt wrote: > Niklas Haas: > > On Wed, 28 Feb 2024 16:45:50 +0100 Andreas Rheinhardt > > wrote: > >> I don't think this should be duplicated for every bitdepth. > > > > To clarify, you think the bit depth should be just treated as a runtime > >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-02-29 Thread Niklas Haas
On Thu, 29 Feb 2024 12:36:36 +0100 Andreas Rheinhardt wrote: > Niklas Haas: > > +#if BIT_DEPTH > 8 > > +# define entry int16_t > > +# define bitdepth_max ((1 << bitdepth) - 1) > > +# define HBD_DECL , const int bitdepth > > +# define HBD_CALL , bitdepth > > +# define SCALING_SIZE 4096 > > +#else

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-02-29 Thread Niklas Haas
On Thu, 29 Feb 2024 12:52:58 +0100 Andreas Rheinhardt wrote: > Niklas Haas: > > +av_assert0(out_frame->format == in_frame->format); > > You already asserted that generically at the start of > ff_aom_apply_film_grain(). Fixed. > > +if (in_frame->format != AV_PIX_FMT_YUV420P10LE) > > +

Re: [FFmpeg-devel] [PATCH 2/2] swresample/resample: rework resample_one function to work the same way as the others

2024-02-29 Thread Michael Niedermayer
On Tue, Feb 27, 2024 at 10:48:10AM +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libswresample/resample.c | 29 +++-- > libswresample/resample.h | 4 ++-- > libswresample/resample_template.c | 14 -- > 3 files changed, 21

[FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-02-29 Thread Niklas Haas
From: Niklas Haas Changes since v1: - Replaced PXSTRIDE() macro usage by explicit (char *) casts - Re-used definitions from "aom_film_grain.h" instead of duplicating - Compiled template only twice, once for 8-bit and once for 16-bit, passing bit depth explicitly as a parameter in the HBD case

[FFmpeg-devel] [PATCH v2 2/4] avcodec/aom_film_grain: implement AFGS1

2024-02-29 Thread Niklas Haas
From: Niklas Haas Based on the AOMedia Film Grain Synthesis 1 (AFGS1) spec: https://aomediacodec.github.io/afgs1-spec/ The parsing has been changed substantially relative to the AV1 film grain OBU. In particular: 1. There is the possibility of maintaining multiple independent film grain pa

[FFmpeg-devel] [PATCH v2 3/4] avcodec/h2645_sei: decode AFGS1 T.35 SEI

2024-02-29 Thread Niklas Haas
From: Niklas Haas I restricted this SEI to HEVC for now, until I see a H.264 sample. --- libavcodec/Makefile| 2 +- libavcodec/h2645_sei.c | 38 ++ libavcodec/h2645_sei.h | 3 +++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH v2 4/4] avcodec/hevcdec: apply AOM film grain synthesis

2024-02-29 Thread Niklas Haas
From: Niklas Haas Following the usual logic for H.274 film grain. --- libavcodec/Makefile | 2 +- libavcodec/hevcdec.c | 24 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index d86b4018405..440179ac797 100644

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-02-29 Thread Niklas Haas
On Thu, 29 Feb 2024 13:33:36 +0100 Niklas Haas wrote: > +// Symbols that do not depend on bit depth > +#ifndef GRAIN_WIDTH > +# define GRAIN_WIDTH 82 > +# define GRAIN_HEIGHT 73 > +# define SUB_GRAIN_WIDTH 44 > +# define SUB_GRAIN_HEIGHT 38 > +# define FG_BLOCK_SIZE 32 > +#endif Decided to move t

[FFmpeg-devel] [PATCH] avcodec: deprecate sonic

2024-02-29 Thread J. Dekker
This is an experimental and research codec of which ffmpeg is the only encoder and decoder, development has stalled since 2013 and these files don't exist in the wild. Deprecate the encoders to be removed next major bump, decoders to be removed one bump afterwards. We also disable the the encoders

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-02-29 Thread Lynne
Feb 29, 2024, 02:50 by vittorio.giov...@gmail.com: > On Wed, Feb 28, 2024 at 11:13 PM Lynne wrote: > >> Feb 28, 2024, 14:29 by mich...@niedermayer.cc: >> >> > On Wed, Feb 28, 2024 at 01:56:10PM +0100, J. Dekker wrote: >> > >> >> This was an experimental/research codec of which ffmpeg is the only

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: implement FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

2024-02-29 Thread James Almer
On 2/20/2024 7:33 PM, James Almer wrote: Fixes errors when opening streams with no extradata (like those from raw OBU sources). It also calls get_format() on new Sequence Headers when required. Signed-off-by: James Almer --- libavcodec/av1dec.c | 58 +--

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-02-29 Thread Vittorio Giovara
On Thu, Feb 29, 2024 at 2:31 PM Lynne wrote: > Feb 29, 2024, 02:50 by vittorio.giov...@gmail.com: > > > On Wed, Feb 28, 2024 at 11:13 PM Lynne wrote: > > > >> Feb 28, 2024, 14:29 by mich...@niedermayer.cc: > >> > >> > On Wed, Feb 28, 2024 at 01:56:10PM +0100, J. Dekker wrote: > >> > > >> >> This

[FFmpeg-devel] [ infra] Does main server hang?

2024-02-29 Thread Zhao Zhili
Hi, I can't pull from main developer git server. Patchwork is slow to loading. I have tried two ISP. Anything happened? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abo

[FFmpeg-devel] [PATCH] all: fix "param"s that should be "@param"

2024-02-29 Thread Andrew Sayers
Actual command: sed -i -e "s/\(^ *\\* \)\(param[^a-z]\)/\1@\2/" $( git grep -l "^ *\\* param[^a-z]" ) Signed-off-by: Andrew Sayers --- libavcodec/evrcdec.c | 10 +- libavutil/bprint.h | 12 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/evrcde

Re: [FFmpeg-devel] [ infra] Does main server hang?

2024-02-29 Thread J. Dekker
On Thu, Feb 29, 2024, at 16:27, Zhao Zhili wrote: > Hi, I can't pull from main developer git server. Patchwork is slow to loading. > I have tried two ISP. Anything happened? All seem okay for me. -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

[FFmpeg-devel] [PATCH] all: fix "@param foo[in/out]" to "@param[in, out] foo"

2024-02-29 Thread Andrew Sayers
Fix a few invalid doxygen comments: /** * @param[in,out] correctly_formatted * @param incorrect1[in] - [in] must come immediately after @param * @param incorrect2[in/out] - '/' must be ',' */ Actual command: sed -i -e "s/\(\* .*param\)\( [^\[]*\)\(\[.*\]\)/\1\3\2/g" -e "s

[FFmpeg-devel] [PATCH 0/2] Harmonise comments about ownership/meaning

2024-02-29 Thread Andrew Sayers
There seems to be a couple of documentation conventions in the code: /** * - encoding: (who sets this in encoding context) * - decoding: (who sets this in decoding context) */ int foo; /** * Encoding: (meaning in encoding context) * Decoding: (meaning in decoding context)

[FFmpeg-devel] [PATCH 1/2] avformat: harmonise "- {decoding, encoding, demuxing, muxing}: " comments

2024-02-29 Thread Andrew Sayers
There seems to be a convention for documenting ownership: /** * - encoding: (who sets this in encoding context) * - decoding: (who sets this in decoding context) */ int foo; Ensure all such comments start with a "-" and use lower case, so doxygen formats them as a bulleted

[FFmpeg-devel] [PATCH 2/2] all: harmonise "{Decoding, Encoding, Audio, Video}:" comments

2024-02-29 Thread Andrew Sayers
There seems to be a convention for documenting meanings: /** * Encoding: (meaning in encoding context) * Decoding: (meaning in decoding context) */ At a glance, these are confusingly similar to ownership comments. They are also rendered by doxygen as long, hard-to-read paragrap

[FFmpeg-devel] [PATCH v7 00/14] encoder AVCodecContext configuration side data

2024-02-29 Thread Jan Ekström
Differences to v5: 1. rebased on top of current master 2. as requested by James, there is now a function to add new frame side data by means of providing a AVBufferRef. Comparison URL (mostly configure and wrappers, avutil/frame.c): https://github.com/jeeb/ffmpeg/compare/avcodec_cll_mdcv_side_d

[FFmpeg-devel] [PATCH v7 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-02-29 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index a3f07ca089..d94710687b 100644 --- a/libavutil/frame.c +++ b/libavutil/fram

[FFmpeg-devel] [PATCH v7 02/14] avutil/frame: add helper for freeing arrays of side data

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d94710687b..615dcb1b83 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -90,6 +90,11 @@ static void frame_side_data_wipe(AVFram

[FFmpeg-devel] [PATCH v7 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 615dcb1b83..5d30887ec9 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -787,23 +787,23 @@ FF_ENABLE_DEPRECATION_WARNINGS r

[FFmpeg-devel] [PATCH v7 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-02-29 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 5d30887ec9..788999bdeb 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.

[FFmpeg-devel] [PATCH v7 05/14] avutil/frame: add helper for adding side data to array

2024-02-29 Thread Jan Ekström
Additionally, add an API test to check that the no-duplicates addition works after duplicates have been inserted. --- libavutil/Makefile | 1 + libavutil/frame.c | 17 ++ libavutil/frame.h | 21 +++ libavutil/tests/side_data_set.c | 103

[FFmpeg-devel] [PATCH v7 06/14] avutil/frame: add helper for adding existing side data to array

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 19 ++ 2 files changed, 68 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d9741240e7..99c9ce4119 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -110,6

[FFmpeg-devel] [PATCH v7 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-02-29 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 57 +++ libavutil/frame.h | 20 + 2 files changed, 58 insertions(+), 19 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 99c9ce4119..3a2084d1ca 100644

[FFmpeg-devel] [PATCH v7 08/14] avutil/frame: add helper for getting side data from array

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 3a2084d1ca..fd4b53f9ff 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -940,16 +940,26 @@ in

[FFmpeg-devel] [PATCH v7 09/14] avcodec: add frame side data array to AVCodecContext

2024-02-29 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 43859251cc..411f4caad3 100644 --- a/libavcodec/avcodec.h +++ b/libavcod

[FFmpeg-devel] [PATCH v7 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-02-29 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 30 ++ libavcodec/avcodec.h | 20 2 files changed, 50 insertions(+) diff --git a/libavcodec/a

[FFmpeg-devel] [PATCH v7 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-02-29 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index bdba50df03..e39

[FFmpeg-devel] [PATCH v7 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE test

[FFmpeg-devel] [PATCH v7 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a F

[FFmpeg-devel] [PATCH v7 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 88

[FFmpeg-devel] [PATCH 1/2] avformat/iamf_writer: update extradata from packet side data

2024-02-29 Thread James Almer
Some encoders, like flac, propagate updated extradata at the end of encoding as packet side data. Use it to update the relevant codec_config. Signed-off-by: James Almer --- libavformat/iamf.h | 13 + libavformat/iamf_parse.c| 12 + libavformat

[FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written

2024-02-29 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamfenc.c | 30 +- tests/ref/fate/iamf-5_1_4 | 14 +++--- tests/ref/fate/iamf-7_1_4 | 16 tests/ref/fate/iamf-ambisonic_1 | 10 +- tests/ref/fate/iamf-stereo | 4 ++-

[FFmpeg-devel] [PATCH] avcodec/x86/vvc/vvcdsp_init: fix linking error when configuring with --disable-ssse3 --disable-optimizations options

2024-02-29 Thread toqsxw
From: Wu Jianhua Signed-off-by: Wu Jianhua --- libavcodec/x86/vvc/vvcdsp_init.c | 115 ++- 1 file changed, 82 insertions(+), 33 deletions(-) diff --git a/libavcodec/x86/vvc/vvcdsp_init.c b/libavcodec/x86/vvc/vvcdsp_init.c index 0d2c683f0f..9ae84bda48 100644 --- a/li

Re: [FFmpeg-devel] [PATCH 2/2] swresample/resample: rework resample_one function to work the same way as the others

2024-02-29 Thread Marton Balint
On Thu, 29 Feb 2024, Michael Niedermayer wrote: On Tue, Feb 27, 2024 at 10:48:10AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- libswresample/resample.c | 29 +++-- libswresample/resample.h | 4 ++-- libswresample/resample_template

Re: [FFmpeg-devel] [ infra] Does main server hang?

2024-02-29 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 29, 2024, at 7:27 AM, Zhao Zhili wrote: > > Hi, I can't pull from main developer git server. Patchwork is slow to loading. > I have tried two ISP. Anything happened? Not sure if it's related but trac has also been very unreliable for me, with frequent "Service Unavailable" errors fro

Re: [FFmpeg-devel] [PATCH v4] libavfi/dnn: add LibTorch as one of DNN backend

2024-02-29 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 20, 2024, at 7:07 PM, wenbin.chen-at-intel@ffmpeg.org wrote: > > From: Wenbin Chen > > PyTorch is an open source machine learning framework that accelerates > the path from research prototyping to production deployment. Official > website: https://pytorch.org/. We call the C++ libr

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: remove resolve_strong_ref usage with AnyType

2024-02-29 Thread Marton Balint
On Tue, 20 Feb 2024, Marton Balint wrote: UUIDs do not have to be unique if their type sets them apart, so avoid using AnyType, since we are only interested in specific types. Ping for the series, will apply in 1-2 days. Regards, Marton Signed-off-by: Marton Balint --- libavformat/mxf.

[FFmpeg-devel] [PATCH] avformat/mpegts: detect synchronous metadata KLV more reliably

2024-02-29 Thread Marton Balint
The mpegts code historically tries to strip (the first) metadata access unit header from synchronous KLV metadata, but the detection for such streams was unreliable causing strips of asynchronous metadata or ID3 as well. MISB ST 1402 specifies required stream type, stream id and registration descr

Re: [FFmpeg-devel] [ infra] Does main server hang?

2024-02-29 Thread Michael Niedermayer
On Thu, Feb 29, 2024 at 06:25:20PM +, Cosmin Stejerean via ffmpeg-devel wrote: > > > > On Feb 29, 2024, at 7:27 AM, Zhao Zhili wrote: > > > > Hi, I can't pull from main developer git server. Patchwork is slow to > > loading. > > I have tried two ISP. Anything happened? developer git is p

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-02-29 Thread Michael Niedermayer
On Thu, Feb 29, 2024 at 03:44:46PM +0100, Vittorio Giovara wrote: > On Thu, Feb 29, 2024 at 2:31 PM Lynne wrote: > > > Feb 29, 2024, 02:50 by vittorio.giov...@gmail.com: > > > > > On Wed, Feb 28, 2024 at 11:13 PM Lynne wrote: > > > > > >> Feb 28, 2024, 14:29 by mich...@niedermayer.cc: > > >> > >

Re: [FFmpeg-devel] [PATCH] avcodec: deprecate sonic

2024-02-29 Thread Michael Niedermayer
On Thu, Feb 29, 2024 at 01:47:06PM +0100, J. Dekker wrote: > This is an experimental and research codec of which ffmpeg is the only > encoder and decoder, development has stalled since 2013 and these files > don't exist in the wild. > > Deprecate the encoders to be removed next major bump, decoder

[FFmpeg-devel] [PATCH 1/4] avcodec/lpc: Don't use AAC defines directly

2024-02-29 Thread Andreas Rheinhardt
It leads to defines for the AAC decoder being included outside of the AAC decoder. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac_defines.h | 11 +-- libavcodec/aacdec_fixed.c| 2 +- libavcodec/aacdec_template.c | 2 +- libavcodec/lpc.h | 27 ++

[FFmpeg-devel] [PATCH 2/4] avcodec/lpc: Split inline functions into a header of their own

2024-02-29 Thread Andreas Rheinhardt
And move compute_ref_coefs() to its only user: lpc.c There is no overlap between the users of compute_lpc_coefs() and lpc proper. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac_defines.h | 2 +- libavcodec/aacdec.c | 1 - libavcodec/aacdec_fixed.c| 1 - libavcodec/aa

[FFmpeg-devel] [PATCH 3/4] avcodec/aacdec: Move buffer to reduce padding

2024-02-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aacdec.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/aacdec.h b/libavcodec/aacdec.h index e23310b5b1..1b245f9258 100644 --- a/libavcodec/aacdec.h +++ b/libavcodec/aacdec.h @@ -207,6 +207,7 @@ typedef struct AACD

[FFmpeg-devel] [PATCH 4/4] avcodec/aactab: Deduplicate ltp_coef and tns_tmp2_map tables

2024-02-29 Thread Andreas Rheinhardt
This will allow to make aac_defines.h decoder-only. Signed-off-by: Andreas Rheinhardt --- libavcodec/aacdec_fixed.c| 43 libavcodec/aacdec_template.c | 4 ++-- libavcodec/aacenc_ltp.c | 4 ++-- libavcodec/aacenc_tns.c | 2 +- libavcodec/aacta

Re: [FFmpeg-devel] [PATCH 2/2] swresample/resample: rework resample_one function to work the same way as the others

2024-02-29 Thread Michael Niedermayer
On Thu, Feb 29, 2024 at 06:55:01PM +0100, Marton Balint wrote: > > > On Thu, 29 Feb 2024, Michael Niedermayer wrote: > > > On Tue, Feb 27, 2024 at 10:48:10AM +0100, Marton Balint wrote: > > > Signed-off-by: Marton Balint > > > --- > > > libswresample/resample.c | 29 +++---