Re: [FFmpeg-devel] [PATCH] libavutil/timestamp.h: Fix loss of precision in timestamps for silencedetect on long files

2024-02-22 Thread Marton Balint
On Thu, 22 Feb 2024, Allan Cady via ffmpeg-devel wrote: I had a similar thought, as all timestamps would have the same issue. This is my first contribution here, and I don't know the code very well, so I was being cautious. I'm open to expanding the scope, but I'm sure I would need some he

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Update bits_per_coded_sample after read pcmC

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili Fix #10878 --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1a1b104615..8c03c35c13 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1890,6 +1890,7 @@ static int mov_read_pcmc(MOVContext *c, AVIOContex

[FFmpeg-devel] [PATCH 2/2] avcodec/encode: Fix default setting of bits_per_raw_sample

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili bits_per_raw_sample doesn't always match size of AV_SAMPLE_FMT_, e.g., S24. --- libavcodec/encode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index a436be2657..8ca07814ee 100644 --- a/libavcodec/encode.c +++ b/libavcodec/enco

Re: [FFmpeg-devel] [PATCH v5 2/9] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-02-22 Thread Wu, Tong1
Hi Mark. Thanks for your careful review. >On 18/02/2024 08:45, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu >> >> Since VAAPI and future D3D12VA implementation may share the same dpb >> logic and some other functions. A base layer encode context is introduced >> as vaapi context's bas

Re: [FFmpeg-devel] [PATCH v5 4/9] avcodec/vaapi_encode: extract rc parameter configuration to base layer

2024-02-22 Thread Wu, Tong1
>On 18/02/2024 08:45, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu >> >> VAAPI and D3D12VA can share rate control configuration codes. Hence, it >> can be moved to base layer for simplification. >> >> Signed-off-by: Tong Wu >> --- >> libavcodec/hw_base_encode.c| 151

Re: [FFmpeg-devel] [PATCH 5/7] lavc/me_cmp: R-V V vsse vsad

2024-02-22 Thread Rémi Denis-Courmont
Le 22 février 2024 05:04:58 GMT+02:00, flow gg a écrit : >.macro vabsaddu dst src tmp >- vneg.v \tmp, \src >- vmax.vv \tmp, \src, \tmp >+ vfabs.v \tmp, \src >vwaddu.wv \dst, \dst, \tmp >.endm > >After making this change, the test

[FFmpeg-devel] [GASPP PATCH] Don't mangle .L local labels for ELF targets

2024-02-22 Thread Martin Storsjö
This fixes building FFmpeg's libavcodec/aarch64/h264idct_neon.S for a Linux target. (It's not necessary to use gas-preprocessor for such a target for a very long time, but it can be useful to be able to test gas-preprocessor there still.) --- gas-preprocessor.pl | 5 - 1 file changed, 4 insert

[FFmpeg-devel] [PATCH v2 1/3] checkasm/hevc_deblock: add luma and chroma full

2024-02-22 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/hevc_deblock.c | 246 +- 1 file changed, 215 insertions(+), 31 deletions(-) diff --git a/tests/checkasm/hevc_deblock.c b/tests/checkasm/hevc_deblock.c index 66fc8d5646..91e57f5cf5 100644 --- a/tests/checkasm/hevc_deblock

[FFmpeg-devel] [PATCH v2 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-22 Thread J. Dekker
Over/underflow in some cases. Signed-off-by: J. Dekker --- libavcodec/x86/hevcdsp_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index f5bc342cd5..8831ba957a 100644 --- a/libavcodec/x86/hevcdsp_ini

[FFmpeg-devel] [PATCH v2 3/3] avcodec/aarch64: add hevc deblock NEON

2024-02-22 Thread J. Dekker
Benched using single-threaded full decode on an Ampere Altra. Bpp Before After Speedup 8 73,3s 65,2s 1.124x 10 114,2s 104,0s 1.098x 12 125,8s 115,7s 1.087x Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_deblock_neon.S | 421 ++ libavcodec/aarch64/hevcdsp_

[FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/hwcontext_vulkan.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index d660f63afe..ee13788ead 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/h

[FFmpeg-devel] [PATCH] libavformat/rtmpproto: form full AMF message for onFCPublish response

2024-02-22 Thread Oleksandr Boiko
Signed-off-by: Oleksandr Boiko --- libavformat/rtmpproto.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 817c27b7ef..370ac3f6ae 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -1995,6 +1995,9 @@ static int send

Re: [FFmpeg-devel] [GASPP PATCH] Don't mangle .L local labels for ELF targets

2024-02-22 Thread J. Dekker
Martin Storsjö writes: > This fixes building FFmpeg's libavcodec/aarch64/h264idct_neon.S > for a Linux target. (It's not necessary to use gas-preprocessor for > such a target for a very long time, but it can be useful to be able > to test gas-preprocessor there still.) > --- > gas-preprocessor.p

Re: [FFmpeg-devel] [PATCH 7/7] lavc/me_cmp: R-V V nsse

2024-02-22 Thread Rémi Denis-Courmont
Le tiistaina 6. helmikuuta 2024, 17.56.59 EET flow gg a écrit : > Use 'static' functions where possible. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To u

Re: [FFmpeg-devel] [PATCH 7/7] lavc/me_cmp: R-V V nsse

2024-02-22 Thread flow gg
Okay, updated it in the reply Rémi Denis-Courmont 于2024年2月22日周四 23:20写道: > Le tiistaina 6. helmikuuta 2024, 17.56.59 EET flow gg a écrit : > > > > Use 'static' functions where possible. > > -- > レミ・デニ-クールモン > http://www.remlab.net/ > ___ > ffmpeg-devel

Re: [FFmpeg-devel] GSoC 2024

2024-02-22 Thread Thilo Borgmann via ffmpeg-devel
Am 02.01.24 um 22:47 schrieb Thilo Borgmann via ffmpeg-devel: Hi, the application period for GSoC 2024 begins on Jan 22nd. Everyone interested in mentoring a project in 2024, please add your idea(s) to [1]. [1] https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2024 we've been selected

Re: [FFmpeg-devel] GSoC 2024

2024-02-22 Thread Matthias Dressel
On 22.02.24 18:38, Thilo Borgmann via ffmpeg-devel wrote: Am 02.01.24 um 22:47 schrieb Thilo Borgmann via ffmpeg-devel: Hi, the application period for GSoC 2024 begins on Jan 22nd. Everyone interested in mentoring a project in 2024, please add your idea(s) to [1]. [1] https://trac.ffmpeg.o

Re: [FFmpeg-devel] GSoC 2024

2024-02-22 Thread Thilo Borgmann via ffmpeg-devel
Am 22.02.24 um 18:49 schrieb Matthias Dressel: On 22.02.24 18:38, Thilo Borgmann via ffmpeg-devel wrote: Am 02.01.24 um 22:47 schrieb Thilo Borgmann via ffmpeg-devel: Hi, the application period for GSoC 2024 begins on Jan 22nd. Everyone interested in mentoring a project in 2024, please add yo

[FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread gnattu via ffmpeg-devel
There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived device in filters like `hwupload=derive_device=videotoolbox` Signed-off-by: Gnattu OC --- libavutil/hwcontext_videotoolbox.c | 9 + 1 file changed, 9 i

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

2024-02-22 Thread Sean McGovern
Hi Marton, On Wed, Feb 21, 2024 at 6:34 PM Marton Balint wrote: > > Jpeg2000 decoder is decoding in native endian, so let's use the same > workaround > as in fate-mxf-probe-applehdr10. > > Fixes ticket #10868. > > Signed-off-by: Marton Balint > --- > tests/fate/mxf.mak | 2 +- > test

Re: [FFmpeg-devel] [PATCH v5 4/9] avcodec/vaapi_encode: extract rc parameter configuration to base layer

2024-02-22 Thread Mark Thompson
On 22/02/2024 10:10, Wu, Tong1 wrote: On 18/02/2024 08:45, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu VAAPI and D3D12VA can share rate control configuration codes. Hence, it can be moved to base layer for simplification. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Mark Thompson
On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived device in filters like `hwupload=derive_device=videotoolbox` Signed-off-by: Gnattu OC --- libavutil/hwco

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread ChenLiucheng via ffmpeg-devel
Well this does make sense. If only one type of hardware device is in use, then `-init_hw_device` will suffice. However, if we use hardware filters with different device types, such as OpenCL, and we want to switch to a VideoToolbox filter later in the chain, we will have a issue. Since there i

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Mark Thompson
On 22/02/2024 19:39, ChenLiucheng via ffmpeg-devel wrote: On Feb 23, 2024, at 03:28, Mark Thompson wrote: On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Gnattu OC via ffmpeg-devel
Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find that the current function for `vt_device_create` is essentially a no-op: it only returns an error if a user attempts to select a device, otherwise it just returns. This is generally how VideoToolbox works. If the `create

[FFmpeg-devel] [PATCH] doc: Add infra.txt

2024-02-22 Thread Michael Niedermayer
--- doc/infra.txt | 99 +++ 1 file changed, 99 insertions(+) create mode 100644 doc/infra.txt diff --git a/doc/infra.txt b/doc/infra.txt new file mode 100644 index 00..5947a2c715 --- /dev/null +++ b/doc/infra.txt @@ -0,0 +1,99 @@ +FFmpeg In

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-22 Thread Anton Khirnov
Quoting Niklas Haas (2024-02-20 21:50:33) > On Tue, 20 Feb 2024 09:50:33 +0100 Anton Khirnov wrote: > > + Each TC member must vote on such decision according to what is, in their > > + view, best for the project. If a TC member is affected by a conflict of > > + interest with regards to the case,

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-22 Thread Anton Khirnov
Quoting Rémi Denis-Courmont (2024-02-20 20:57:37) > Le tiistaina 20. helmikuuta 2024, 10.22.57 EET Anton Khirnov a écrit : > > Hi, > > in the 'avcodec/s302m: enable non-PCM decoding' thread it became > > apparent that there is wide disagreement about the interpretation of > > > > this line in the

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-22 Thread Anton Khirnov
Quoting Gyan Doshi (2024-02-22 07:50:36) > On 2024-02-20 04:39 pm, Anton Khirnov wrote: > > As for determining conflict of interest in case of dishonest TC > > members, I don't think there is a general solution for it. > > This is not about dishonesty. Imagine a TC member genuinely does not > se

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-22 Thread Anton Khirnov
Quoting Marton Balint (2024-02-20 20:32:19) > > > On Tue, 20 Feb 2024, Anton Khirnov wrote: > > > Quoting Marton Balint (2024-02-20 10:12:34) > >> We have no means to prove financial interest, because it is not public. > > > > We also have no means to prove that committee members are acting in t

Re: [FFmpeg-devel] [PATCH] doc: Add infra.txt

2024-02-22 Thread Andreas Rheinhardt
Michael Niedermayer: > --- > doc/infra.txt | 99 +++ > 1 file changed, 99 insertions(+) > create mode 100644 doc/infra.txt > > diff --git a/doc/infra.txt b/doc/infra.txt > new file mode 100644 > index 00..5947a2c715 > --- /dev/null > +++ b/

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-22 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-20 22:51:20) > On Tue, Feb 20, 2024 at 09:12:11PM +, Cosmin Stejerean via ffmpeg-devel > wrote: > > > > > > > On Feb 20, 2024, at 12:41 PM, Michael Niedermayer > > > wrote: > > > > > > On Tue, Feb 20, 2024 at 05:10:11PM +0100, Anton Khirnov wrote: > >

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

2024-02-22 Thread Tomas Härdin
tor 2024-02-22 klockan 00:34 +0100 skrev Marton Balint: > Jpeg2000 decoder is decoding in native endian, so let's use the same > workaround > as in fate-mxf-probe-applehdr10. > > Fixes ticket #10868. OK I suppose /Tomas ___ ffmpeg-devel mailing list ff

[FFmpeg-devel] [PATCH] avformat/mxfenc: add h264_mp4toannexb bitstream filter if needed when muxing h264

2024-02-22 Thread Marton Balint
Partially fixes ticket #10395. Signed-off-by: Marton Balint --- libavformat/mxfenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 61ed6fc3db..adc31c1cf4 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -3542,6

Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check

2024-02-22 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Thursday, January 25, 2024 8:54 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream > position check > > The VP8 compressed header may not be byte-al

Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in fixed()

2024-02-22 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Thursday, January 25, 2024 8:54 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in > fixed() > > This commit adds value range checks to cbs_vp8_read

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Zhao Zhili
> 在 2024年2月23日,上午4:19,Gnattu OC via ffmpeg-devel 写道: > > Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find > that the current function for `vt_device_create` is essentially a no-op: it > only returns an error if a user attempts to select a device, otherwise it > jus

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add h264_mp4toannexb bitstream filter if needed when muxing h264

2024-02-22 Thread Andreas Rheinhardt
Marton Balint: > Partially fixes ticket #10395. > > Signed-off-by: Marton Balint > --- > libavformat/mxfenc.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 61ed6fc3db..adc31c1cf4 100644 > --- a/libavformat/mxfenc.c > +

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Zhao Zhili
> 在 2024年2月23日,上午9:20,Zhao Zhili 写道: > >  >> 在 2024年2月23日,上午4:19,Gnattu OC via ffmpeg-devel 写道: >> >> Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find >> that the current function for `vt_device_create` is essentially a no-op: it >> only returns an error if a use

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-22 Thread Andreas Rheinhardt
J. Dekker: > Over/underflow in some cases. > > Signed-off-by: J. Dekker > --- > libavcodec/x86/hevcdsp_init.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c > index 31e81eb11f..11cb1b3bfd 100644 > -

Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode: Enable Macroblock based bitrate control

2024-02-22 Thread Xiang, Haihao
On Wo, 2024-02-07 at 08:40 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  doc/encoders.texi |  3 +++ >  libavcodec/vaapi_encode.c | 11 ++- >  libavcodec/vaapi_encode.h |  9 - >  3 files changed, 21 insertions(+), 2 d

Re: [FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check

2024-02-22 Thread Xiang, Haihao
On Di, 2024-02-20 at 10:32 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Supported formats are checked in base function ff_vaapi_vpp_config_output. > > Signed-off-by: Fei Wang > --- >  libavfilter/vf_tonemap_vaapi.c | 8 >  1 file changed, 8 deletions(-) > > dif

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode: remove a duplicate av_freep

2024-02-22 Thread Xiang, Haihao
On Di, 2024-02-20 at 14:27 +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > Signed-off-by: Tong Wu > --- >  libavcodec/vaapi_encode.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c > index 86f4110cd2..808b79c0c7 10

[FFmpeg-devel] [PATCH v1] lavc/vvc_ps: Correct vaule of ALF_NUM_FILTERS_CC

2024-02-22 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vvc/vvc_ps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vvc/vvc_ps.h b/libavcodec/vvc/vvc_ps.h index 5adf3f3453..1164d0eab6 100644 --- a/libavcodec/vvc/vvc_ps.h +++ b/libavcodec/vvc/vvc_ps.h @@ -152,7 +152

[FFmpeg-devel] [PATCH] avfilter/vf_scale_vulkan: Fix typo

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili Fix #10875 --- libavfilter/vf_scale_vulkan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale_vulkan.c b/libavfilter/vf_scale_vulkan.c index a1cf8b1aeb..7210509de3 100644 --- a/libavfilter/vf_scale_vulkan.c +++ b/libavfilter/vf_scale_vulka

[FFmpeg-devel] [PATCH v2] lavc/vaapi_encode: Enable Macroblock based bitrate control

2024-02-22 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- update: Print mbbrc status with "ON/OFF" instead of "0/1". doc/encoders.texi | 3 +++ libavcodec/vaapi_encode.c | 11 ++- libavcodec/vaapi_encode.h | 9 - 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/doc/en

Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode: Enable Macroblock based bitrate control

2024-02-22 Thread Wang, Fei W
On Fri, 2024-02-23 at 05:11 +, Xiang, Haihao wrote: > On Wo, 2024-02-07 at 08:40 +0800, fei.w.wang-at-intel@ffmpeg.org > wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > > doc/encoders.texi | 3 +++ > > libavcodec/vaapi_encode.c | 11 ++- > > libavcod

Re: [FFmpeg-devel] [PATCH] avcodec/evc: Remove redefine of HEVC_MAX_ENTRY_POINT_OFFSETS

2024-02-22 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of Zhao > Zhili > Sent: czwartek, 22 lutego 2024 07:42 > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili > Subject: [FFmpeg-devel] [PATCH] avcodec/evc: Remove redefine of > HEVC_MAX_ENTRY_POINT_OFFSETS > > From: Zhao Zhili > > --- >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-22 Thread Nicolas George
Anton Khirnov (12024-02-22): > In my updated proposal, based on comments by Niklas and Rémi, I'm > leaving it up to the TC member in question, based on the assumption that > TC members are honest. > > A "stronger" version could conceivably leave it to CC to decide > ambiguous cases. Feel free to p