Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-16 Thread Anton Khirnov
Quoting Gyan Doshi (2024-02-15 17:47:49) > This patch facilitates a certain productive use of ffmpeg with respect > to processing of live inputs that wasn't possible earlier, > and which currently is being used successfully by multiple people over > the past few weeks. > It applies a processing m

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-16 Thread Anton Khirnov
Quoting Tomas Härdin (2024-02-03 20:58:20) > I think people with knowledge how interlacing is handled in other > formats and codecs might want to chime in. For MPEG codecs our decoders always output (properly signalled) interlaced content as two interleaved fields in a single AVFrame flagged with

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Remove manually free AV_OPT_TYPE_STRING

2024-02-16 Thread Anton Khirnov
Quoting Zhao Zhili (2024-02-15 03:15:08) > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- > libavformat/libsrt.c | 3 --- > 1 file changed, 3 deletions(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

Re: [FFmpeg-devel] [PATCH v2] avcodec/h2645_parse: Don't treat 0x000002 as a start code and truncate

2024-02-16 Thread Anton Khirnov
Quoting Mattias Wadman (2024-02-13 11:17:46) > According to ITU-T H.265 7.4.2.1 this byte sequence should not appear in a > NAL unit but in practice in rare cases it seems it does, possibly due to buggy > encoders. Other players like VLC and Quicktime seem to be fine with it. > > Currently when th

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Check fc->ref contains valid reference

2024-02-16 Thread Anton Khirnov
Quoting Nuo Mi (2024-02-13 04:03:11) > HI Lynee, > the name is from hevc. I do not like it either, but so many functions > copied from hevc will use it. ... The naming in hevcdec is really schizophrenic, I wish somebody did something about it. Certainly do not feel compelled to use it as a model.

Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-16 Thread Anton Khirnov
Quoting Marth64 (2024-02-11 19:09:16) > +static int dvdvideo_video_stream_add(AVFormatContext *s, > + DVDVideoVTSVideoStreamEntry *entry, > + enum AVStreamParseType need_parsing) > +{ > +AVStream *st; > +FFStream *sti;

Re: [FFmpeg-devel] [PATCH 2/4 v8] avformat/mov: add support for tile HEIF still images

2024-02-16 Thread Anton Khirnov
Quoting James Almer (2024-02-11 19:56:59) > +/** > + * The video stream is intended to be merged with another stream before > + * presentation. > + * Used for example to signal the stream contains a tile from a HEIF grid. > + */ > +#define AV_DISPOSITION_TILE (1 << 21) The notion o

Re: [FFmpeg-devel] [PATCH 1/2] avutil/pixfmt: Add AV_PIX_MAX_PLANES

2024-02-16 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-08 13:57:57) > It seems we do not have a named identifier for the maximum planes of pixel > formats > > Signed-off-by: Michael Niedermayer > --- > libavutil/pixfmt.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/pixfmt.h b/libavutil/p

[FFmpeg-devel] [PATCH] avcodec/speexdec: check for sane s->frame_size values

2024-02-16 Thread James Almer
Fixes heap buffer overflows Reported-by: sploitem Signed-off-by: James Almer --- libavcodec/speexdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c index 51c5834769..4d8052d585 100644 --- a/libavcodec/speexdec.c +++ b/liba

Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-16 Thread Marth64
I will take care of it, thanks On Fri, Feb 16, 2024 at 05:38 Anton Khirnov wrote: > Quoting Marth64 (2024-02-11 19:09:16) > > +static int dvdvideo_video_stream_add(AVFormatContext *s, > > + DVDVideoVTSVideoStreamEntry *entry, > > +

Re: [FFmpeg-devel] [PATCH 2/4 v8] avformat/mov: add support for tile HEIF still images

2024-02-16 Thread James Almer
On 2/16/2024 9:50 AM, Anton Khirnov wrote: Quoting James Almer (2024-02-11 19:56:59) +/** + * The video stream is intended to be merged with another stream before + * presentation. + * Used for example to signal the stream contains a tile from a HEIF grid. + */ +#define AV_DISPOSITION_TILE

Re: [FFmpeg-devel] [PATCH 1/2] avutil/pixfmt: Add AV_PIX_MAX_PLANES

2024-02-16 Thread Michael Niedermayer
On Fri, Feb 16, 2024 at 02:39:33PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-02-08 13:57:57) > > It seems we do not have a named identifier for the maximum planes of pixel > > formats > > > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/pixfmt.h | 2 ++ > > 1 f

Re: [FFmpeg-devel] [PATCH 2/4 v8] avformat/mov: add support for tile HEIF still images

2024-02-16 Thread Anton Khirnov
Quoting James Almer (2024-02-16 17:35:13) > > > > And since we're running out of easily usable disposition bits, we > > shouldn't waste them. How about AV_DISPOSITION_SUBSTREAM? > > Maybe we could redefine and reuse AV_DISPOSITION_DEPENDENT for this? Works for me. -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: check for sane s->frame_size values

2024-02-16 Thread Michael Niedermayer
On Fri, Feb 16, 2024 at 11:19:25AM -0300, James Almer wrote: > Fixes heap buffer overflows > > Reported-by: sploitem > Signed-off-by: James Almer > --- > libavcodec/speexdec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) ok, though note that i do not know speexdec.c well enough

[FFmpeg-devel] [PATCH 1/2] avcodec/x86/fpel: Remove declarations of inexistent functions

2024-02-16 Thread Andreas Rheinhardt
Forgotten in 50a8cbb23e9a982292bf7737004c97eba776c00e and a51279bbdea0d6db920d71980262bccd0ce78226. Signed-off-by: Andreas Rheinhardt --- libavcodec/x86/fpel.h | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h index 4e83cf71c3..90f7051a48 100644

[FFmpeg-devel] [PATCH 2/2] avcodec/x86/hpeldsp_init: Avoid using ff_avg_pixels16_mmx

2024-02-16 Thread Andreas Rheinhardt
Use ff_avg_pixels16_mmxext or ff_avg_pixels16_sse2 (for users with SSE2_FAST) instead. This also allows to remove ff_avg_pixels16_mmx, as this was its last remaining user. Signed-off-by: Andreas Rheinhardt --- libavcodec/x86/fpel.asm | 1 - libavcodec/x86/fpel.h | 2 -- libavcode

[FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: move resolving Descriptors to the multi descriptor resolve function

2024-02-16 Thread Marton Balint
Also remove unused descriptor member from MXFPackage. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e42975e7fd..4e4e3e7a84 100644 --- a/libavformat/mxfdec.c +++

[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: do not use AnyType when resolving Descriptors and MultipleDescriptors

2024-02-16 Thread Marton Balint
Using AnyType should not be a problem for proper MXF files because UIDs are supposed to be unique themselves. Unfortunately that is not the case for some broken files, so let's check the type more strictly. Fixes ticket #10865. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 19

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-16 Thread Dale Curtis
On Thu, Feb 15, 2024 at 2:35 PM Michael Niedermayer wrote: > FFMIN/MAX can evaluate their arguments multiple times so avio_rb32() might > be executed more than once > Thanks. Good catch. Fixed. stco-clamp-entries-v4.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB

2024-02-16 Thread Marton Balint
On Thu, 15 Feb 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-02-13 21:27:34) On Tue, 13 Feb 2024, James Almer wrote: On 2/12/2024 6:15 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions(+) diff -

Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB

2024-02-16 Thread James Almer
On 2/16/2024 7:42 PM, Marton Balint wrote: On Thu, 15 Feb 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-02-13 21:27:34) On Tue, 13 Feb 2024, James Almer wrote: On 2/12/2024 6:15 PM, Marton Balint wrote:  Signed-off-by: Marton Balint  ---    libavutil/channel_layout.h | 4

[FFmpeg-devel] [PATCH 3/4] avcodec/h264qpel_template: Mark pointers as non-aliasing

2024-02-16 Thread Andreas Rheinhardt
It allows the compiler to combine two reads and writes of adjacent 32bit memory locations into 64bit read-writes. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264qpel_template.c | 93 +++--- 1 file changed, 52 insertions(+), 41 deletions(-) diff --git a/libavcod

[FFmpeg-devel] [PATCH 4/4] avcodec/x86/h264_qpel: Remove put_h264_qpel[48]_mmxext

2024-02-16 Thread Andreas Rheinhardt
These functions are not faster than the C versions. Signed-off-by: Andreas Rheinhardt --- libavcodec/x86/fpel.asm| 1 - libavcodec/x86/fpel.h | 2 -- libavcodec/x86/h264_qpel.c | 32 +--- 3 files changed, 21 insertions(+), 14 deletions(-) diff --git a/liba