Re: [FFmpeg-devel] [PATCH 3/3] lavc/vp8dsp: R-V V vp8_idct_dc_add4uv

2024-02-02 Thread flow gg
add check rvb in this reply flow gg 于2024年2月2日周五 13:04写道: > > From f3f8fa31167d757ceb033140eee775c59ed0759b Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 2 Feb 2024 12:50:50 +0800 Subject: [PATCH 3/3] lavc/vp8dsp: R-V V vp8_idct_dc_add4uv c908: vp8_idct_dc_add4uv_c: 387.7 vp8_idct_dc_add

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/texturedsp: fix premult2straight inversion

2024-02-02 Thread Niklas Haas
On Thu, 01 Feb 2024 17:10:50 -0800 Connor Worley wrote: > +src[0] = (uint8_t) FFMIN(r * 255 / a, 255); > +src[1] = (uint8_t) FFMIN(g * 255 / a, 255); > +src[2] = (uint8_t) FFMIN(b * 255 / a, 255); av_clip_uint8? ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec.c Fix for ticket #7395

2024-02-02 Thread Pablo Navarro
Shouldn't the result of xmlEncodeEntitiesReentrant(NULL, root_url) be freed with av_free or xmlFree? xmlChar *tmp_str = NULL; tmp_str = xmlEncodeEntitiesReentrant(NULL, root_url); xmlNodeSetContent(node, tmp_str); xmlFree(tmp_str); ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH] lavc/texturedsp: add DXT4 texturedspenc function

2024-02-02 Thread Andreas Rheinhardt
Connor Worley: > For future use in lavc/dxvenc. > > Signed-off-by: Connor Worley > --- > libavcodec/texturedsp.h| 1 + > libavcodec/texturedspenc.c | 41 ++ > 2 files changed, 42 insertions(+) > > diff --git a/libavcodec/texturedsp.h b/libavcodec/texture

Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

2024-02-02 Thread Gyan Doshi
On 2024-01-29 10:30 am, Gyan Doshi wrote: Existing use of strtoll can lead to ERANGE errors leading to incorrect storage of UMID. Plan to push tomorrow. Regards, Gyan --- libavformat/wavenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavenc.c b/lib

[FFmpeg-devel] [PATCH v3 1/9] avcodec/vaapi_encode: move pic->input_surface initialization to encode_alloc

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu When allocating the VAAPIEncodePicture, pic->input_surface can be initialized right in the place. This movement simplifies the send_frame logic and is the preparation for moving vaapi_encode_send_frame to the base layer. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode.c | 8 +

[FFmpeg-devel] [PATCH v3 3/9] avcodec/vaapi_encode: extract set_output_property to base layer

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 40 + libavcodec/hw_base_encode.h | 3 +++ libavcodec/vaapi_encode.c | 44 ++--- 3 files changed, 45 insertions(+), 42 deletions(-) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH v3 4/9] avcodec/vaapi_encode: extract rc parameter configuration to base layer

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu VAAPI and D3D12VA can share rate control configuration codes. Hence, it can be moved to base layer for simplification. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c| 151 libavcodec/hw_base_encode.h| 34 ++ libavcodec/vaapi_encode.c

[FFmpeg-devel] [PATCH v3 5/9] avcodec/vaapi_encode: extract gop configuration to base layer

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 54 + libavcodec/hw_base_encode.h | 3 +++ libavcodec/vaapi_encode.c | 52 +++ 3 files changed, 61 insertions(+), 48 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH v3 6/9] avcodec/vaapi_encode: extract a get_recon_format function to base layer

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu Get constraints and set recon frame format can be shared with other HW encoder such as D3D12. Extract this part as a new function to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 58 + libavcodec/hw_base_encode.h | 2 ++

[FFmpeg-devel] [PATCH v3 8/9] avcodec: add D3D12VA hardware HEVC encoder

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu This implementation is based on D3D12 Video Encoding Spec: https://microsoft.github.io/DirectX-Specs/d3d/D3D12VideoEncoding.html Sample command line for transcoding: ffmpeg.exe -hwaccel d3d12va -hwaccel_output_format d3d12 -i input.mp4 -c:v hevc_d3d12va output.mp4 Signed-off-by: T

[FFmpeg-devel] [PATCH v3 9/9] Changelog: add D3D12VA HEVC encoder changelog

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index c1fd66b4bd..891f23cffb 100644 --- a/Changelog +++ b/Changelog @@ -23,6 +23,7 @@ version : - ffmpeg CLI -bsf option may now be used for input as well as output - f

[FFmpeg-devel] [PATCH v3 7/9] avutil/hwcontext_d3d12va: add Flags for resource creation

2024-02-02 Thread tong1 . wu-at-intel . com
From: Tong Wu Flags field is added to support diffferent resource creation. Signed-off-by: Tong Wu --- doc/APIchanges| 3 +++ libavutil/hwcontext_d3d12va.c | 2 +- libavutil/hwcontext_d3d12va.h | 8 libavutil/version.h | 2 +- 4 files changed, 13 insertions(+

Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamf_writer: Avoid using dynamic buffer

2024-02-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/iamf_writer.c | 28 ++-- > 1 file changed, 6 insertions(+), 22 deletions(-) > > diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c > index 99602ae204..f665f45b7a 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/leaddec: Remove unnecessary VLC structures

2024-02-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > One only needs the VLCElem[]. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/leaddec.c | 48 ++-- > 1 file changed, 24 insertions(+), 24 deletions(-) > > diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c > index 4e97

Re: [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test

2024-02-02 Thread Rémi Denis-Courmont
Le 2 février 2024 01:42:20 GMT+02:00, Michael Niedermayer a écrit : >On Wed, Jan 31, 2024 at 08:00:18PM +0800, flow gg wrote: >> > >> checkasm/Makefile |1 >> checkasm/checkasm.c |3 ++ >> checkasm/checkasm.h |1 >> checkasm/rv34dsp.c | 65 >> ++

Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamf_writer: Avoid using dynamic buffer

2024-02-02 Thread James Almer
On 2/2/2024 8:30 AM, Andreas Rheinhardt wrote: Andreas Rheinhardt: Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 996

Re: [FFmpeg-devel] [PATCH 4/5] avutil/channel_layout: add av_channel_layout_retype()

2024-02-02 Thread James Almer
On 1/29/2024 8:27 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/channel_layout.c | 48 ++ libavutil/channel_layout.h | 11 + libavutil/version.h| 2 +- 4 files changed, 63 insert

Re: [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test

2024-02-02 Thread Michael Niedermayer
On Fri, Feb 02, 2024 at 02:08:29PM +0200, Rémi Denis-Courmont wrote: > > > Le 2 février 2024 01:42:20 GMT+02:00, Michael Niedermayer > a écrit : > >On Wed, Jan 31, 2024 at 08:00:18PM +0800, flow gg wrote: > >> > > > >> checkasm/Makefile |1 > >> checkasm/checkasm.c |3 ++ > >> chec

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Error pps_single_slice_per_subpic_flag

2024-02-02 Thread Nuo Mi
On Thu, Feb 1, 2024 at 10:01 PM wrote: > From: Frank Plowman > > pps_single_slice_per_subpic_flag is not yet supported. Support is WIP, > but in the meantime throw an error when trying to decode a bitstream > with it set, avoiding an out-of-bounds array access. > > Fixes: out-of-bounds array ac

Re: [FFmpeg-devel] [PATCH v4 1/8] avcodec/vvc/vvc_inter_template: move put/put_luma/put_chroma template to h2656_inter_template.c

2024-02-02 Thread Nuo Mi
On Thu, Feb 1, 2024 at 9:14 PM James Almer wrote: > On 2/1/2024 9:15 AM, Nuo Mi wrote: > > On Wed, Jan 24, 2024 at 2:17 AM wrote: > > > >> From: Wu Jianhua > >> > >> Signed-off-by: Wu Jianhua > >> --- > >> libavcodec/h26x/h2656_inter_template.c | 577 + > >> libavcod

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-02 Thread Michael Niedermayer
On Wed, Jan 31, 2024 at 10:45:50PM +, Kieran Kunhya wrote: > On Wed, 31 Jan 2024, 22:40 Michael Niedermayer, > wrote: > > > On Wed, Jan 31, 2024 at 09:54:05PM +, Kieran Kunhya wrote: > > > On Wed, 31 Jan 2024 at 21:43, Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: > > > >

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-02 Thread Kieran Kunhya
I have no relation and none of the above. There were some large items of piping that needed carrying and I did that to help my fellow human being through love of humankind. Kieran On Fri, 2 Feb 2024 at 14:52, Michael Niedermayer wrote: > On Wed, Jan 31, 2024 at 10:45:50PM +, Kieran Kunhya

[FFmpeg-devel] [PATCH 0/1] avformat/mpegts: fix first NAL start code splited in two different packets

2024-02-02 Thread Nicolas Gaullier
This issue happens in the following case: - unaligned PES and NAL encoding - the first NAL of the access unit begins at the very end of a ts packet, sometimes only the 0x00 of the trailing byte (unfortunately, this is still conformant to the standards!) - the video frame is so small (ex: typically

[FFmpeg-devel] [PATCH] avformat/mpegts: fix first NAL start code splited in two different packets

2024-02-02 Thread Nicolas Gaullier
When PES are not aligned and a tiny nal-encoded frame is contained in a single TS packet, the first NAL startcode may be split by the PES boundary, making the packet unworkable. This patch shift the PES boundaries to avoid this. Signed-off-by: Nicolas Gaullier --- libavformat/mpegts.c | 41 +++

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-02 Thread Jerome Martinez
Before this patch, the FFmpeg MXF parser correctly detects content with 2 fields in 1 AVPacket as e.g. interlaced 720x486 but the FFmpeg JPEG 2000 decoder reads the JPEG 2000 SIZ header without understanding that the indicated height is the height of 1 field only so overwrites the frame size in

[FFmpeg-devel] [PATCH] avformat/demux: Add more retries to get more stream durations

2024-02-02 Thread Nicolas Gaullier
The number of extra retries to get more than a single duration is currently limited to 1 (see commit 77a0df4b5). This patch raises this number of retries to 3 (amongst the overall 6 max retries). Exemple: this sample requires 3 retries to get all durations: http://samples.ffmpeg.org/archive/exten

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/texturedsp: fix premult2straight inversion

2024-02-02 Thread Connor Worley
Linked are some demo files. I converted a sample to DDS with texconv.exe -f DXT4 -pmalpha sample.png I converted it back to PNG against master with ffmpeg -i sample.dds master.png I converted it back to PNG against this patch with ffmpeg -i sample.dds patch.png The color in master.png is dark due

[FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Dale Curtis
The `entries` value is read directly from the stream and used to allocate memory. This change clamps `entries` to however many are possible in the remaining atom or file size (whichever is smallest). Fixes https://crbug.com/1429357 Signed-off-by: Dale Curtis --- libavformat/mov.c | 7 +++ 1

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Andreas Rheinhardt
Dale Curtis: > +// Clamp allocation size for `chunk_offsets` -- don't throw an error for > an > +// invalid count since the EOF path doesn't throw either. > +entries = > +FFMIN(entries, FFMIN(atom.size - 8, avio_size(pb) - avio_tell(pb)) / > + (atom.ty

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Dale Curtis
On Fri, Feb 2, 2024 at 3:20 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Dale Curtis: > > +// Clamp allocation size for `chunk_offsets` -- don't throw an > error for an > > +// invalid count since the EOF path doesn't throw either. > > +entries = > > +FFMIN(

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Dale Curtis
On Fri, Feb 2, 2024 at 3:42 PM Dale Curtis wrote: > On Fri, Feb 2, 2024 at 3:20 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Dale Curtis: >> > +// Clamp allocation size for `chunk_offsets` -- don't throw an >> error for an >> > +// invalid count since the EOF path

[FFmpeg-devel] [PATCH 0/2] PNG cLLi and mDVc chunk support

2024-02-02 Thread Leo Izen
This adds support for cLLi and mDVc chunks in the PNG specification[1]. [1]: https://www.w3.org/TR/png-3/ Leo Izen (2): avcodec/pngdec: read cLLi and mDVc chunks avcodec/pngenc: write cLLi and mDVc chunks libavcodec/pngdec.c | 63 + libavcodec/pn

[FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: read cLLi and mDVc chunks

2024-02-02 Thread Leo Izen
These chunks contain the Content Light Level Information and the Mastering Display Color Volume information that FFmpeg already supports as AVFrameSideData. This patch adds support for the png decoder to read these chunks if present and attach the corresponding side data to the decoded frame. Sign

[FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: write cLLi and mDVc chunks

2024-02-02 Thread Leo Izen
These chunks contain the Content Light Level Information and the Mastering Display Color Volume information that FFmpeg already supports as AVFrameSideData. This patch adds support for the png encoder to save this metadata as the corresponding chunks in the PNG stream. Signed-off-by: Leo Izen ---

Re: [FFmpeg-devel] [PATCH 3/4] lavf/demux: stop calling avcodec_close()

2024-02-02 Thread Leo Izen
On 2/1/24 03:29, Anton Khirnov wrote: Replace it with recreating the codec context. This is the last remaining blocker for deprecating avcodec_close(). --- libavformat/demux.c | 53 - 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/li

Re: [FFmpeg-devel] [PATCH 3/4] lavf/demux: stop calling avcodec_close()

2024-02-02 Thread James Almer
On 2/1/2024 5:29 AM, Anton Khirnov wrote: Replace it with recreating the codec context. This is the last remaining blocker for deprecating avcodec_close(). --- libavformat/demux.c | 53 - 1 file changed, 48 insertions(+), 5 deletions(-) diff --git

Re: [FFmpeg-devel] [RFC] Vote STF/SPI 2024-02

2024-02-02 Thread Michael Niedermayer
On Thu, Feb 01, 2024 at 05:29:26AM +0100, Michael Niedermayer wrote: > Hi all > > To do the STF/SPI thing properly, and make sure we do what the Community > wants. > We should do this vote: (unless lots of people reply and say we should skip > the vote) > (i am also CCing jonatan to make sure th

Re: [FFmpeg-devel] [PATCH] configure: fix compilation with glslang 14

2024-02-02 Thread Philip Langdale via ffmpeg-devel
On Wed, 31 Jan 2024 17:34:08 +0100 (CET) Lynne wrote: > The configure check already had fallback for the previous version > of glslang, which had different requirements for flags. > This commit simply moves the flags needed for glslang 13 to the > fallback, while first trying to use new flags for