[FFmpeg-devel] [PATCH] configure: Check for the header sys/mmap.h when checking for mmap

2024-01-11 Thread Martin Storsjö
Whenever mmap is used, we include sys/mmap.h unconditionally within HAVE_MMAP ifdefs. When building for a system (e.g. mingw) that normally lacks the mmap function, but if building with profiling enabled, the profiling runtime which gets linked in in each test executable, can contain a function na

Re: [FFmpeg-devel] [PATCH] configure: Check for the header sys/mmap.h when checking for mmap

2024-01-11 Thread 徐福隆 via ffmpeg-devel
There maybe a spelling mistake, which in "check_func_headers sys/mman.h mmap". It looks like should be "sys/mmap.h" Thanks -- Original -- From: "

Re: [FFmpeg-devel] [PATCH] configure: Check for the header sys/mmap.h when checking for mmap

2024-01-11 Thread Martin Storsjö
On Thu, 11 Jan 2024, 徐福隆 wrote: There maybe a spelling mistake, which in "check_func_headers sys/mman.h mmap". It looks like should be "sys/mmap.h" No, this is not a mistake, this is the name of the header. Have a look at libavutil/file.c or libswscale/utils.c, both which have this: #if HAV

Re: [FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests

2024-01-11 Thread James Almer
On 1/11/2024 12:17 AM, Michael Niedermayer wrote: On Wed, Jan 10, 2024 at 09:52:28AM -0300, James Almer wrote: On 1/10/2024 12:05 AM, Michael Niedermayer wrote: On Sun, Jan 07, 2024 at 06:31:00PM -0300, James Almer wrote: Covers muxing from raw pcm audio input into FLAC, using several scalable

Re: [FFmpeg-devel] [PATCH v2] checkasm: Generalize crash handling

2024-01-11 Thread Martin Storsjö
On Wed, 10 Jan 2024, Rémi Denis-Courmont wrote: Looks OK (not tested). Thanks, pushed now. // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

[FFmpeg-devel] [PATCH] checkasm: Test whether direct cycle counter access works

2024-01-11 Thread Martin Storsjö
This should print a nicer error message than crashing due to an illegal instruction, if direct cycle counter access isn't allowed. This matches the dav1d checkasm commit 95a192549a448b70d9542e840c4e34b60d09b093. --- tests/checkasm/checkasm.c | 12 +++- 1 file changed, 11 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 2/4] avformat/psxstr: fix demuxing I/O error at EOF

2024-01-11 Thread Michael Niedermayer
On Tue, Jan 02, 2024 at 02:52:11AM +, aybe aybe wrote: > This second patch fixes the following error at the end of a .STR stream > conversion: > > [in#0/psxstr @ 00681e80] Error during demuxing: I/O error > > It's been a bit of trial and error as I've never used ffmpeg, but returning

Re: [FFmpeg-devel] [PATCH 3/4] avformat/psxstr: fix unknown sector type 00/80

2024-01-11 Thread Michael Niedermayer
On Tue, Jan 02, 2024 at 02:57:18AM +, aybe aybe wrote: > This third patch fixes warnings that are false positives (still on STRv1). > > That's because these sectors are simply empty ones as can be read in "System > Description CD-ROM XA, May 1991, > 4.3.2.3". > > Haven't attempted significan

Re: [FFmpeg-devel] [PATCH] checkasm: Test whether direct cycle counter access works

2024-01-11 Thread Rémi Denis-Courmont
Le torstaina 11. tammikuuta 2024, 14.53.05 EET Martin Storsjö a écrit : > This should print a nicer error message than crashing due to > an illegal instruction, if direct cycle counter access isn't > allowed. > > This matches the dav1d checkasm commit > 95a192549a448b70d9542e840c4e34b60d09b093. >

Re: [FFmpeg-devel] [PATCH] checkasm: Test whether direct cycle counter access works

2024-01-11 Thread Martin Storsjö
On Thu, 11 Jan 2024, Rémi Denis-Courmont wrote: Le torstaina 11. tammikuuta 2024, 14.53.05 EET Martin Storsjö a écrit : This should print a nicer error message than crashing due to an illegal instruction, if direct cycle counter access isn't allowed. This matches the dav1d checkasm commit 95a1

Re: [FFmpeg-devel] [PATCH] checkasm: Test whether direct cycle counter access works

2024-01-11 Thread Rémi Denis-Courmont
Le torstaina 11. tammikuuta 2024, 16.15.29 EET Martin Storsjö a écrit : > > AV_READ_TIME() reads time, not cycles. > > Right, I can adjust the wording. Exactly what kind of measurement > AV_READ_TIME returns varies between architectures and environments indeed. In practice, yes, but I would argue

Re: [FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

2024-01-11 Thread Nuo Mi
> > > > > Yes. After we merge this, we will send out the mc x86 asm code for > review. > > It will share the same binary with HEVC. > > For SAO/Deblock, we will follow a similar approach, but it needs to be a > > little later than mc. > > For C code, we can share the binary as well, but it involves

[FFmpeg-devel] [PATCH v3 1/2] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-01-11 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvdec.c | 178 ++- 1 file changed, 177 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..65815e51f9 10

[FFmpeg-devel] [PATCH v3 2/2] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-01-11 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvenc.c | 133 +++ 1 file changed, 133 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..4485aba03c 100644 --- a/liba

[FFmpeg-devel] [PATCH v3 2/2] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-01-11 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvenc.c | 133 +++ 1 file changed, 133 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..4485aba03c 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 3/3] lavc/h264dsp: R-V V h264_add_pixels8_clear

2024-01-11 Thread flow gg
ping flow gg 于2023年12月25日周一 12:01写道: > C908 > h264_add_pixels8_clear_c: 262.0 > h264_add_pixels8_clear_rvv_i64: 59.0 > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link ab

[FFmpeg-devel] [PATCH v2] checkasm: Test whether the native FFmpeg timers work

2024-01-11 Thread Martin Storsjö
On some platforms (in particular, ARM/AArch64), the implementation of AV_READ_TIME() may use a privileged instruction - in such cases, benchmarking just fails with a SIGILL. Instead of crashing, try executing AV_READ_TIME() once within a region with the signal handler active, to allow gracefully i

[FFmpeg-devel] [PATCH] libavformat/adxdec: remove erroneous whitespace

2024-01-11 Thread Marth64
25th anniversary of the Dreamcast this year. Will follow up with FATE test. Signed-off-by: Marth64 --- libavformat/adxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/adxdec.c b/libavformat/adxdec.c index b6bd3303a7..55eabceef0 100644 --- a/libavformat/adxdec

[FFmpeg-devel] [PATCH] fate/audio: add ADX demux and decode test

2024-01-11 Thread Marth64
Necessary samples to fate-samples/adx : https://ufile.io/f/v306q Samples are re-encodes of luckynight from FATE suite. d3a67e1d21bbaa7afc8e3bd089545ad44685e0c7a4212a75f7d115b0b8d656eb luckynight.adx f994367773da8cadc5a41d7eab680a3f24685211d3564d8a806857cab47bdf25 luckynight.pcm Signed-off-by: M

[FFmpeg-devel] [PATCH] libavformat/hls: use avio_flush() to clear playlist buffer

2024-01-11 Thread Marth64
Felt that this could be handled by avio_flush(). Traced the code and it seems logical. Seems to work fine for the only sample I have right now. But curious to others opinion. Signed-off-by: Marth64 --- libavformat/hls.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib

Re: [FFmpeg-devel] [PATCH] configure: remove Bitrig OS

2024-01-11 Thread Brad Smith
On 2023-12-31 2:23 a.m., Brad Smith wrote: configure: remove Bitrig OS Bitrig has been defunct for 7 years. Signed-off-by: Brad Smith --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 42786719e9..d96b47ebe5 100755 --- a/configure +

Re: [FFmpeg-devel] [PATCH] configure: remove Bitrig OS

2024-01-11 Thread Zhao Zhili
> On Jan 12, 2024, at 08:56, Brad Smith wrote: > > On 2023-12-31 2:23 a.m., Brad Smith wrote: >> configure: remove Bitrig OS >> >> Bitrig has been defunct for 7 years. >> >> Signed-off-by: Brad Smith >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -