Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: refactor dump encoder name

2023-11-26 Thread myp...@gmail.com
On Sat, Nov 25, 2023 at 12:06 PM Zhao Zhili wrote: > > From: Zhao Zhili > > --- > libavcodec/videotoolboxenc.c | 65 +--- > 1 file changed, 38 insertions(+), 27 deletions(-) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index b8a07

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: extra members for GA v2

2023-11-26 Thread Anton Khirnov
Reminder that the vote will close on Tuesday morning. We have 28/45 votes so far, and no reported bounces. If you have not voted yet please do so ASAP. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH 1/2] tools/general_assembly: implement extra GA members

2023-11-26 Thread Anton Khirnov
Set pushed. The general_assembly.pl script should now be usable as the authoritative source for GA members. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit l

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-26 Thread Anton Khirnov
Quoting James Almer (2023-11-24 22:03:29) > On 11/24/2023 6:01 PM, Michael Niedermayer wrote: > > On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote: > >> Should simplify asm implementations, and prevent UB on at least win64. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-26 Thread Anton Khirnov
Quoting Dmitrii Ovchinnikov (2023-11-24 09:45:14) > If there are no objections, I would like to merge it in 2-3 days The code looks significantly duplicated. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: use mfxImplDescription instead of mfxExtendedDeviceId on Linux

2023-11-26 Thread Anton Khirnov
Quoting Xiang, Haihao (2023-11-24 08:38:52) > From: Haihao Xiang > > This fixed the issue mentioned in [1] > > [1] http://ffmpeg.org/pipermail/ffmpeg-user/2023-October/056983.html Commit messages should be meaningful on their own, without referring to external sources. -- Anton Khirnov __

[FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-26 Thread Gyan Doshi
3d29724c00 removed the doc entry for the option pool while adding a parser function for it at the same time! The option remains available and undeprecated. --- doc/filters.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 5268b2003c..80ffbb2c65

Re: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_d3d11va: Add option vendor_id

2023-11-26 Thread Anton Khirnov
Quoting Xiang, Haihao (2023-11-24 06:43:46) > From: Artem Galin > > User may choose the hardware via option vendor_id when multiple hardware > are available. > > Signed-off-by: Artem Galin > Signed-off-by: Haihao Xiang > --- > libavutil/hwcontext_d3d11va.c | 67 +++

Re: [FFmpeg-devel] [PATCH 3/3] lavu/hwcontext_qsv: Make sure hardware vendor is Intel for qsv on d3d11va

2023-11-26 Thread Anton Khirnov
Quoting Xiang, Haihao (2023-11-24 06:43:48) > From: Haihao Xiang > > When multiple hardware are available, the default one might not be > Intel Hareware. We can use option vendor_id to choose the required > vendor. > > Tested-by: Artem Galin > Signed-off-by: Haihao Xiang > --- > libavutil/hwc

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection

2023-11-26 Thread Anton Khirnov
Quoting Xiang, Haihao (2023-11-24 07:17:36) > From: Haihao Xiang > > It is possible that renderD128 doesn't exist but renderD129 is > available in a system (see [1]). This change can make sure the default > DRM device selection works even if renderD128 doesn't exist. > > [1] > https://github.co

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-26 Thread Anton Khirnov
Would be nice to have tests for these. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsu

Re: [FFmpeg-devel] [PATCH] checkasm: add test for dcmul_add

2023-11-26 Thread Rémi Denis-Courmont
Will push soon except for objections ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/dcadec: adjust the `ch_layout` when downmix is active

2023-11-26 Thread James Almer
On 11/26/2023 1:33 AM, Geoffrey McRae via ffmpeg-devel wrote: Applications making use of this codec with the `downmix` option are segfaulting unless the `ch_layout` is overridden after `avcodec_open2` as can be seen in projects like MythTV[1] This patch fixes this by overriding the ch_layout as

Re: [FFmpeg-devel] [PATCH] libavcodec/mlpdec: add missing correction to ch_layout when downmixing

2023-11-26 Thread James Almer
On 11/26/2023 2:01 AM, Geoffrey McRae via ffmpeg-devel wrote: This fixes corrupted audio for applications relying on ch_layout when codec downmixing is active. Signed-off-by: Geoffrey McRae --- libavcodec/mlpdec.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavco

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/get_bits: add get_leb()

2023-11-26 Thread Leo Izen
On 11/25/23 20:28, James Almer wrote: Signed-off-by: James Almer --- libavcodec/bitstream.h | 2 ++ libavcodec/bitstream_template.h | 22 ++ libavcodec/get_bits.h | 23 +++ 3 files changed, 47 insertions(+) Out of curiosity, why

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/get_bits: add get_leb()

2023-11-26 Thread James Almer
On 11/26/2023 10:40 AM, Leo Izen wrote: On 11/25/23 20:28, James Almer wrote: Signed-off-by: James Almer ---   libavcodec/bitstream.h  |  2 ++   libavcodec/bitstream_template.h | 22 ++   libavcodec/get_bits.h   | 23 +++   3 files changed,

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-26 Thread Leo Izen
On 11/26/23 05:56, Anton Khirnov wrote: Would be nice to have tests for these. I have a sample at: https://buzo.us/l.jxl It would test both of these patches. I can send a fate test for these to the ML if the sample gets uploaded. I CC'd samples-requ...@ffmpeg.org as well. - Leo Izen (Tran

[FFmpeg-devel] [PATCH] avfilter: add Affine Projection adaptive audio filter

2023-11-26 Thread Paul B Mahol
Attached. From 6c355f79e9c21a11e5e1266da7936a4ac2dc07ac Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 30 Apr 2023 17:06:00 +0200 Subject: [PATCH] avfilter: add Affine Projection adaptive audio filter Signed-off-by: Paul B Mahol --- doc/filters.texi | 43 libavfilter/Makef

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-26 Thread Dmitrii Ovchinnikov
>> The code looks significantly duplicated. This is not moved to amfenc.c since the property has different names for different encoders, and many other properties (also common to different encoders, but with different names) are separated in this way. _

Re: [FFmpeg-devel] [PATCH 1/2] tools/general_assembly: implement extra GA members

2023-11-26 Thread Alexander Strasser
On 2023-11-26 10:18 +0100, Anton Khirnov wrote: > Set pushed. > > The general_assembly.pl script should now be usable as the authoritative > source for GA members. The patches mostly LGTM. My Perl knowledge in general is really mostly from 20 years ago. So if there is any Perl-ish devil in the de

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add QOA decoder

2023-11-26 Thread James Almer
ffmpeg | branch: master | Paul B Mahol https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog>> | Sat Sep 23 16:49:25 2023 +0200| [3609d2b78340c06920973dc46b85b517c789782f] | committer: Paul B Mahol avcodec: add QOA decoder >/http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3609d2b78340c069

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-26 Thread Thilo Borgmann via ffmpeg-devel
> Am 26.11.2023 um 14:47 schrieb Leo Izen : > On 11/26/23 05:56, Anton Khirnov wrote: >> Would be nice to have tests for these. > > I have a sample at: https://buzo.us/l.jxl > > It would test both of these patches. I can send a fate test for these to the > ML if the sample gets uploaded. I CC

Re: [FFmpeg-devel] [PATCH] checkasm: add test for dcmul_add

2023-11-26 Thread Rémi Denis-Courmont
Le sunnuntaina 19. marraskuuta 2023, 0.28.10 EET flow gg a écrit : > From 2785ce57f68dbb2373c951b9432afa73796f7cc1 Mon Sep 17 00:00:00 2001 > From: sunyuechi > Date: Sat, 18 Nov 2023 10:58:17 +0800 > Subject: [PATCH] checkasm: test for dcmul_add git-am reports the patch corrupt. -- Rémi Denis-C

[FFmpeg-devel] [PATCH v5 00/14] encoder AVCodecContext configuration side data

2023-11-26 Thread Jan Ekström
Differences to v3: 1. rebased on top of current master 2. moved the addition of multiple side data entries from a generic av_frame_side_data_set_extend to avcodec as per request from James. 4. adopted various things noted by reviews Comparison URL (mostly configure and wrappers, avutil/frame.c)

[FFmpeg-devel] [PATCH v5 01/14] avutil/frame: add AVFrameSideDataSet for passing sets of side data

2023-11-26 Thread Jan Ekström
--- libavutil/frame.h | 8 1 file changed, 8 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index c0c1b23db7..6155226c1d 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -251,6 +251,14 @@ typedef struct AVFrameSideData { AVBufferRef *buf; } AVFrameSideDat

[FFmpeg-devel] [PATCH v5 02/14] avutil/frame: split side data list wiping out to non-AVFrame function

2023-11-26 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index a3f07ca089..d94710687b 100644 --- a/libavutil/frame.c +++ b/libavutil/fram

[FFmpeg-devel] [PATCH v5 03/14] avutil/frame: add helper for uninitializing side data sets

2023-11-26 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 8 2 files changed, 13 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d94710687b..941a0a8148 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -90,6 +90,11 @@ static void frame_side_data_wipe(AVFrame *fr

[FFmpeg-devel] [PATCH v5 04/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2023-11-26 Thread Jan Ekström
--- libavutil/frame.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 941a0a8148..49da452fa5 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -787,23 +787,22 @@ FF_ENABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] [PATCH v5 05/14] avutil/frame: split side data removal out to non-AVFrame function

2023-11-26 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 49da452fa5..587e212d1a 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.

[FFmpeg-devel] [PATCH v5 06/14] avutil/frame: add helper for adding side data to set

2023-11-26 Thread Jan Ekström
Additionally, add an API test to check that the no-duplicates addition works after duplicates have been inserted. --- libavutil/Makefile | 1 + libavutil/frame.c | 18 ++ libavutil/frame.h | 20 +++ libavutil/tests/side_data_set.c | 97

[FFmpeg-devel] [PATCH v5 07/14] avutil/frame: add helper for adding existing side data to set

2023-11-26 Thread Jan Ekström
--- libavutil/frame.c | 50 +++ libavutil/frame.h | 16 +++ 2 files changed, 66 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9ac3db430f..e42d9cb758 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -110,6 +1

[FFmpeg-devel] [PATCH v5 08/14] avutil/frame: add helper for getting side data from set

2023-11-26 Thread Jan Ekström
--- libavutil/frame.c | 22 +- libavutil/frame.h | 12 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index e42d9cb758..e4004daa4b 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -929,16 +929,28 @@ in

[FFmpeg-devel] [PATCH v5 09/14] avcodec: add side data set to AVCodecContext

2023-11-26 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 7 +++ libavcodec/options.c | 1 + 2 files changed, 8 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 7fb44e28f4..0c1a8ade49 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/

[FFmpeg-devel] [PATCH v5 10/14] avcodec: add helper for configuring AVCodecContext's side data set

2023-11-26 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 28 libavcodec/avcodec.h | 20 2 files changed, 48 insertions(+) diff --git a/libavcodec/avc

[FFmpeg-devel] [PATCH v5 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2023-11-26 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index fa4539664f..

[FFmpeg-devel] [PATCH v5 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2023-11-26 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE test

[FFmpeg-devel] [PATCH v5 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2023-11-26 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a F

[FFmpeg-devel] [PATCH v5 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2023-11-26 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 87

Re: [FFmpeg-devel] [PATCH] checkasm: add test for dcmul_add

2023-11-26 Thread flow gg
This is a bit confusing for me.. I tried pulling the latest code, and then used `git am checkasm-test-for-dcmul_add.patch` without any patch corruption. Rémi Denis-Courmont 于2023年11月27日周一 03:36写道: > Le sunnuntaina 19. marraskuuta 2023, 0.28.10 EET flow gg a écrit : > > From 2785ce57f68dbb2373c95

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-26 Thread Leo Izen
On 11/26/23 13:07, Thilo Borgmann wrote: Am 26.11.2023 um 14:47 schrieb Leo Izen : On 11/26/23 05:56, Anton Khirnov wrote: Would be nice to have tests for these. I have a sample at: https://buzo.us/l.jxl It would test both of these patches. I can send a fate test for these to the ML if t

[FFmpeg-devel] [PATCH v1] lavc/vaapi_encode_av1: Add qp option explicitly to set base q index

2023-11-26 Thread fei . w . wang-at-intel . com
From: Fei Wang Keep same way with librav1e/libsvtav1/qsv_av1.. to make it more acceptable instead of using global option "-global_quality". Fix #10615 Signed-off-by: Fei Wang --- doc/encoders.texi | 1 + libavcodec/vaapi_encode_av1.c | 6 ++ 2 files changed, 7 insertions(+) d

Re: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_d3d11va: Add option vendor_id

2023-11-26 Thread Xiang, Haihao
On So, 2023-11-26 at 11:49 +0100, Anton Khirnov wrote: > Quoting Xiang, Haihao (2023-11-24 06:43:46) > > From: Artem Galin > > > > User may choose the hardware via option vendor_id when multiple hardware > > are available. > > > > Signed-off-by: Artem Galin > > Signed-off-by: Haihao Xiang > >

Re: [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float

2023-11-26 Thread Chen, Wenbin
> > From: Niklas Haas > > > > This logic was incongruent with logic used elsewhere, where floating > > point formats are explicitly exempted from range conversion. Fixes an > > issue where floating point formats were not going through special > > unscaled converters even when it was otherwise poss

Re: [FFmpeg-devel] [PATCH 3/3] lavu/hwcontext_qsv: Make sure hardware vendor is Intel for qsv on d3d11va

2023-11-26 Thread Xiang, Haihao
On So, 2023-11-26 at 11:51 +0100, Anton Khirnov wrote: > Quoting Xiang, Haihao (2023-11-24 06:43:48) > > From: Haihao Xiang > > > > When multiple hardware are available, the default one might not be > > Intel Hareware. We can use option vendor_id to choose the required > > vendor. > > > > Tested

Re: [FFmpeg-devel] [PATCH 1/2] tools/general_assembly: implement extra GA members

2023-11-26 Thread Zhao Zhili
> On Nov 26, 2023, at 23:08, Alexander Strasser wrote: > > On 2023-11-26 10:18 +0100, Anton Khirnov wrote: >> Set pushed. >> >> The general_assembly.pl script should now be usable as the authoritative >> source for GA members. > > The patches mostly LGTM. > > My Perl knowledge in general is

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection

2023-11-26 Thread Xiang, Haihao
On So, 2023-11-26 at 11:55 +0100, Anton Khirnov wrote: > Quoting Xiang, Haihao (2023-11-24 07:17:36) > > From: Haihao Xiang > > > > It is possible that renderD128 doesn't exist but renderD129 is > > available in a system (see [1]). This change can make sure the default > > DRM device selection wo

[FFmpeg-devel] [PATCH v2] lavu/hwcontext_qsv: use mfxImplDescription instead of mfxExtendedDeviceId on Linux

2023-11-26 Thread Xiang, Haihao
From: Haihao Xiang mfxExtendedDeviceId mightn't be supported in certain configurations of oneVPL on Linux, so we can't ensure a property filter for mfxExtendedDeviceId.DeviceID or mfxExtendedDeviceId.VendorID works as expected. This fixed the issue mentioned in [1] [1] http://ffmpeg.org/pipermai

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: use mfxImplDescription instead of mfxExtendedDeviceId on Linux

2023-11-26 Thread Xiang, Haihao
On So, 2023-11-26 at 11:35 +0100, Anton Khirnov wrote: > Quoting Xiang, Haihao (2023-11-24 08:38:52) > > From: Haihao Xiang > > > > This fixed the issue mentioned in [1] > > > > [1] http://ffmpeg.org/pipermail/ffmpeg-user/2023-October/056983.html > > Commit messages should be meaningful on thei

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: return 0 if more data is required

2023-11-26 Thread Xiang, Haihao
From: Haihao Xiang The type of qsv decoders is FF_CODEC_CB_TYPE_DECODE which must not return AVERROR(EAGAIN). commit 42b20c9 added an assertion to check the returned value. Signed-off-by: Haihao Xiang --- libavcodec/qsvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsv

[FFmpeg-devel] [PATCH 2/2] lavc/qsvdec: reduce info message when more data is required

2023-11-26 Thread Xiang, Haihao
From: Haihao Xiang demote the info to AV_LOG_VERBOSE Signed-off-by: Haihao Xiang --- libavcodec/qsvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index b501964089..559f63698a 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/