Re: [FFmpeg-devel] [PATCH] avformat/mov: add support for multiple decryption keys

2023-11-13 Thread Adrien Guinet
On 11/12/23 18:18, Michael Niedermayer wrote: On Sun, Nov 12, 2023 at 06:06:01PM +0100, Adrien Guinet wrote: This commit introduces new options to support more than one decryption keys: * add a decryption_keys option to MOV, that supports a dictionnary of KID=>key (in hex), using AV_OPT_TYPE_

[FFmpeg-devel] [PATCH] avformat/mov: add support for multiple decryption keys

2023-11-13 Thread Adrien Guinet
This commit introduces new options to support more than one decryption keys: * add a decryption_keys option to MOV, that supports a dictionnary of KID=>key (in hex), using AV_OPT_TYPE_DICT * add the corresponding cenc_decryption_keys option to DASH --- doc/demuxers.texi

Re: [FFmpeg-devel] [PATCH] checkasm: add lossless audio DSP

2023-11-13 Thread Paul B Mahol
On Mon, Nov 13, 2023 at 7:42 AM Rémi Denis-Courmont wrote: > Hi, > > This seems to show that the SSSE3 optimisation is no better than the SSE2, > at least on my AMD Ryzen. Does anyone know why it's there? Should it be > purged? > > Not everybody have/use AMD Ryzen. > Br, > _

Re: [FFmpeg-devel] [PATCH] checkasm: add lossless audio DSP

2023-11-13 Thread Rémi Denis-Courmont
Le 13 novembre 2023 11:07:21 GMT+02:00, Paul B Mahol a écrit  : >On Mon, Nov 13, 2023 at 7:42 AM Rémi Denis-Courmont wrote: > >> Hi, >> >> This seems to show that the SSSE3 optimisation is no better than the SSE2, >> at least on my AMD Ryzen. Does anyone know why it's there? Should it be >> pur

Re: [FFmpeg-devel] [PATCH] af_afir: RISC-V V fcmul_add

2023-11-13 Thread flow gg
Sorry for the long delay in responding. How is the modified patch now? no longer using register stride(learn from your code) and have switched to shNadd instead. (using m4 and m2 as they are slightly faster than m8 and m4) benchmark: fcmul_add_c: 2179 fcmul_add_rvv_f32: 1652 Rémi Denis-Courmon

Re: [FFmpeg-devel] [PATCH] ffmpeg CLI multithreading

2023-11-13 Thread Jan Ekström
On Sat, Nov 4, 2023 at 11:22 AM Anton Khirnov wrote: > > Hi, > after ~2 years of work and ~700+ preparatory commits, here is finally > the first "fully functional" version of multithreaded ffmpeg CLI. In > quotes because due to the scale of the changes I'm sure some things got > broken and I didn'

Re: [FFmpeg-devel] [PATCH] ffmpeg CLI multithreading

2023-11-13 Thread James Almer
On 11/13/2023 9:34 AM, Jan Ekström wrote: On Sat, Nov 4, 2023 at 11:22 AM Anton Khirnov wrote: Hi, after ~2 years of work and ~700+ preparatory commits, here is finally the first "fully functional" version of multithreaded ffmpeg CLI. In quotes because due to the scale of the changes I'm sure

Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-13 Thread Ronald S. Bultje
Hi, On Mon, Nov 13, 2023 at 2:55 AM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > Oh, this is the preceding patch of: > `[FFmpeg-devel,v6] avcodec/cbs_vp8: Add support for VP8 codec bitstream` > > Probably, I need merge these two together. > It's ok like this, for me. I'll let

[FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

2023-11-13 Thread Evgeny Pavlov
This commit increase precision of Sleep() function on Windows. This fix reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. Fix for issue #10622 v2: use timeBeginPeriod/timeEndPeriod for increasing precision of Sleep() Signed-off-by: Evgeny Pavlo

[FFmpeg-devel] [PATCH 3/3] swscale/utils: don't early return in yuv alpha blendaway

2023-11-13 Thread Niklas Haas
From: Niklas Haas If changing YUV range after init results in the special converter no longer being picked, then we need the rest of the init function to have been hit. Fixes: cedf589c09c567b72bf4c1a58db53d94622567e1 --- libswscale/utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-

[FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float

2023-11-13 Thread Niklas Haas
From: Niklas Haas This logic was incongruent with logic used elsewhere, where floating point formats are explicitly exempted from range conversion. Fixes an issue where floating point formats were not going through special unscaled converters even when it was otherwise possible. --- libswscale/s

[FFmpeg-devel] [PATCH 2/3] swscale/utils: correctly return from sws_init_single_context

2023-11-13 Thread Niklas Haas
From: Niklas Haas Before cedf589, this function would return early return on RGB and float formats, as well as when range was equal. While this commit intentionally removed the early return for same-range YUV conversions, it missed that RGB and float formats that have an unscaled converter should

Re: [FFmpeg-devel] [PATCH v3 1/8] swscale: fix sws_setColorspaceDetails after sws_init_context

2023-11-13 Thread Niklas Haas
On Mon, 13 Nov 2023 04:03:08 + "Chen, Wenbin" wrote: > > > > Will apply soon. > > > Hi Niklas: > > This patchset causes a regression. > The command: "ffmpeg -i input.png -vf format=grayf32,format=gray8 output.png" > reports error. > If I configure with "--disable-sse2", the error is unseen

Re: [FFmpeg-devel] [PATCH] af_afir: RISC-V V fcmul_add

2023-11-13 Thread Rémi Denis-Courmont
Hi, Le maanantaina 13. marraskuuta 2023, 11.43.01 EET flow gg a écrit : > Sorry for the long delay in responding. No problem. Working with T-Head C910 (or C920?) cores is very tedious. I gave up on that and switched over to Kendryte K230 (based on C908) now. > How is the modified patch now?

Re: [FFmpeg-devel] [PATCH] checkasm: add lossless audio DSP

2023-11-13 Thread Rémi Denis-Courmont
Le maanantaina 13. marraskuuta 2023, 11.17.57 EET Rémi Denis-Courmont a écrit : > Le 13 novembre 2023 11:07:21 GMT+02:00, Paul B Mahol a écrit : > >On Mon, Nov 13, 2023 at 7:42 AM Rémi Denis-Courmont wrote: > >> Hi, > >> > >> This seems to show that the SSSE3 optimisation is no better than th

Re: [FFmpeg-devel] [PATCH] af_afir: RISC-V V fcmul_add

2023-11-13 Thread Paul B Mahol
On Mon, Nov 13, 2023 at 4:35 PM Rémi Denis-Courmont wrote: >Hi, > > Le maanantaina 13. marraskuuta 2023, 11.43.01 EET flow gg a écrit : > > Sorry for the long delay in responding. > > No problem. Working with T-Head C910 (or C920?) cores is very tedious. I > gave > up on that and switched ove

[FFmpeg-devel] [PATCH] avcodec/codecpar: mention how to allocate coded_side_data

2023-11-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/codec_par.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index 64882a9726..f42dd3b1d5 100644 --- a/libavcodec/codec_par.h +++ b/libavcodec/codec_par.h @@ -219,6 +219,9 @@ typedef struct AVCodecPara

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Michael Niedermayer
On Sun, Nov 12, 2023 at 09:19:57PM +0100, Paul B Mahol wrote: > On Sun, Nov 12, 2023 at 5:37 PM Michael Niedermayer > wrote: > > > On Sun, Nov 12, 2023 at 11:02:49AM +0100, Nicolas George wrote: > > > Vittorio Giovara (12023-11-11): > > > > Nice victimization, but "i'm behaving poorly because the

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Sean McGovern
On Mon, Nov 13, 2023, 11:59 Michael Niedermayer wrote: > On Sun, Nov 12, 2023 at 09:19:57PM +0100, Paul B Mahol wrote: > > On Sun, Nov 12, 2023 at 5:37 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Sun, Nov 12, 2023 at 11:02:49AM +0100, Nicolas George wrote: > > > > V

Re: [FFmpeg-devel] [PATCH 2/3] swscale/utils: correctly return from sws_init_single_context

2023-11-13 Thread Michael Niedermayer
On Mon, Nov 13, 2023 at 04:32:33PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Before cedf589, this function would return early return on RGB and float > formats, as well as when range was equal. While this commit > intentionally removed the early return for same-range YUV conversions, > it

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Zhao Zhili
> 在 2023年11月14日,上午1:45,Sean McGovern 写道: > > On Mon, Nov 13, 2023, 11:59 Michael Niedermayer > wrote: > >>> On Sun, Nov 12, 2023 at 09:19:57PM +0100, Paul B Mahol wrote: >>> On Sun, Nov 12, 2023 at 5:37 PM Michael Niedermayer < >> mich...@niedermayer.cc> >>> wrote: >>> On Sun, Nov 12, 2

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Paul B Mahol
On Mon, Nov 13, 2023 at 6:00 PM Michael Niedermayer wrote: > On Sun, Nov 12, 2023 at 09:19:57PM +0100, Paul B Mahol wrote: > > On Sun, Nov 12, 2023 at 5:37 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Sun, Nov 12, 2023 at 11:02:49AM +0100, Nicolas George wrote: > > >

[FFmpeg-devel] [PATCH] checkasm/flacdsp: fix ls/rs/ms tests

2023-11-13 Thread Rémi Denis-Courmont
decorrelate_ls, _rs and _ms are decorrelate[1], [2] and [3] respectively. The code ended up testing indep ([0]) as twice, ms never, and misnaming the other two. --- tests/checkasm/flacdsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkas

[FFmpeg-devel] [PATCH 1/2] lavc/flacdsp: R-V V packed decorrelate_{l, r}s

2023-11-13 Thread Rémi Denis-Courmont
flac_decorrelate_ms_16_c: 457.2 flac_decorrelate_ms_16_rvv_i32: 203.0 flac_decorrelate_ms_32_c: 457.2 flac_decorrelate_ms_32_rvv_i32: 203.5 flac_decorrelate_rs_16_c: 456.2 flac_decorrelate_rs_16_rvv_i32: 207.0 flac_decorrelate_rs_32_c: 456.2 flac_decorrelate_rs_32_rvv_i32: 2

[FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: R-V V decorrelate_ms packed

2023-11-13 Thread Rémi Denis-Courmont
flac_decorrelate_ms_16_c: 585.5 flac_decorrelate_ms_16_rvv_i32: 263.0 flac_decorrelate_ms_32_c: 584.7 flac_decorrelate_ms_32_rvv_i32: 250.0 --- libavcodec/riscv/flacdsp_init.c | 6 libavcodec/riscv/flacdsp_rvv.S | 49 + 2 files changed, 55 inserti

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Nicolas George
Michael Niedermayer (12023-11-13): > dear patch iam ashamed but iam not actually blocking you. What was blocking this patch is that the bug had not been properly analyzed and a review process was in progress, slowed down by Paul's own refusal of providing the info his has (most likely because that

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

2023-11-13 Thread Evgeny Pavlov
On Tue, Oct 31, 2023 at 7:13 PM Evgeny Pavlov wrote: > From: Michael Fabian 'Xaymar' Dirks > > added 10 bit support for amf hevc. > > before: > > command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va > -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf > res.dx11_hw_h264.mkv >

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Paul B Mahol
On Mon, Nov 13, 2023 at 10:32 PM Nicolas George wrote: > Michael Niedermayer (12023-11-13): > > dear patch iam ashamed but iam not actually blocking you. > > What was blocking this patch is that the bug had not been properly > analyzed and a review process was in progress, slowed down by Paul's o

Re: [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float

2023-11-13 Thread Chen, Wenbin
> From: Niklas Haas > > This logic was incongruent with logic used elsewhere, where floating > point formats are explicitly exempted from range conversion. Fixes an > issue where floating point formats were not going through special > unscaled converters even when it was otherwise possible. > ---