Re: [FFmpeg-devel] [PATCH] doc/encoders/libxvid: fix references for me_quality option

2023-10-06 Thread Stefano Sabatini
On date Wednesday 2023-09-06 10:56:43 +0530, Gyan Doshi wrote: > On 2023-08-26 04:26 pm, Stefano Sabatini wrote: > > Drop reference to constants removed in 94eed68ace9f2416af8. > > > > In particular, rename me_method to me_quality and add description for > > supported values. > > > > Address trac

Re: [FFmpeg-devel] [PATCH 3/3] doc/encoders/libx264: clarify meaning of level option

2023-10-06 Thread Stefano Sabatini
On date Wednesday 2023-09-06 11:07:23 +0530, Gyan Doshi wrote: > On 2023-08-26 06:40 am, Stefano Sabatini wrote: > > Address trac issue: > > http://trac.ffmpeg.org/ticket/3947 > > --- > > doc/encoders.texi | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] doc/encoders/libopus: clarify lowdelay and cutoff options

2023-10-06 Thread Stefano Sabatini
On date Saturday 2023-08-26 15:48:41 +0200, Stefano Sabatini wrote: > Extend descriptions for the application=lowdelay and cutoff options. > Based on notes by Mingye Wang. > > Address issue: > http://trac.ffmpeg.org/ticket/10330 > --- > doc/encoders.texi | 7 +-- > libavcodec/libopusenc

[FFmpeg-devel] [PATCH v1] avcodec/vp9_superframe_split_bsf: Fix for possible null pointer dereference

2023-10-06 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavcodec/vp9_superframe_split_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9_superframe_split_bsf.c b/libavcodec/vp9_superframe_split_bsf.c index cddd48119c..4f94afc6d9 100644 --- a/libavcodec/vp9_superframe_split_bsf.

Re: [FFmpeg-devel] [PATCH v1] avcodec/vp9_superframe_split_bsf: Fix for possible null pointer dereference

2023-10-06 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
Pointer ctx->priv_data->buffer_pkt->data, that can have only NULL value (checked at vp9_superframe_split_bsf.c:48), is dereferenced at vp9_superframe_split_bsf.c:57. > -Original Message- > From: Dawid Kozinski > Sent: piątek, 6 października 2023 13:02 > To: d.frankie...@samsung.com;

Re: [FFmpeg-devel] [PATCH 03/11] avformat/avformat: use the side data from AVStream.codecpar

2023-10-06 Thread James Almer
On 10/6/2023 12:04 AM, Andreas Rheinhardt wrote: James Almer: Deprecate AVStream.side_data and its helpers in favor of the AVStream's codecpar.side_data. This will considerably simplify the propagation of global side data to decoders and from encoders. Instead of having to do it inside packets,

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-10-06 Thread Paul B Mahol
On 9/27/23, Paul B Mahol wrote: > On 9/27/23, Michael Niedermayer wrote: >> On Wed, Sep 27, 2023 at 03:00:35PM +0200, Paul B Mahol wrote: >>> On Wed, Sep 27, 2023 at 2:57 PM Nicolas George wrote: >>> >>> > Paul B Mahol (12023-09-27): >>> > > I think that having parser is much more useful. >>> >

[FFmpeg-devel] [PATCH v1] fftools/ffmpeg_enc: NULL check for frame pointer removed

2023-10-06 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- fftools/ffmpeg_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index ec9cebbd96..61fd31823e 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -951,8 +951,8 @@ early_exit:

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg_enc: NULL check for frame pointer removed

2023-10-06 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
The pointer 'frame', which is dereferenced at ffmpeg_enc.c:930, is compared to a NULL value at ffmpeg_enc.c:955. The pointer 'frame' is checked in the video_sync_process() function before calling the adjust_frame_pts_to_encoder_tb function > -Original Message- > From: Dawid Kozinski > S

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Hendrik Leppkes
On Sun, Oct 1, 2023 at 1:39 PM Timo Rothenpieler wrote: > > On 01.10.2023 04:06, James Almer wrote: > > Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 > > It's expected behaviour to break compilation with random inter-release > versions of ffnvcodec. > It's only reliable exactly

[FFmpeg-devel] [PATCH] configure: improve libmfx deprecation warning

2023-10-06 Thread Leo Izen
The libmfx deprecation warning tells you to build against libmfx 1.x, but the actual solution is to use --enable-libvpl instead of using --enable-libmfx. Update the warning message to reflect this. Signed-off-by: Leo Izen --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) dif

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Timo Rothenpieler
On 06/10/2023 14:29, Hendrik Leppkes wrote: On Sun, Oct 1, 2023 at 1:39 PM Timo Rothenpieler wrote: On 01.10.2023 04:06, James Almer wrote: Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 It's expected behaviour to break compilation with random inter-release versions of ffn

Re: [FFmpeg-devel] [PATCH v1] avcodec/vp9_superframe_split_bsf: Fix for possible null pointer dereference

2023-10-06 Thread Andreas Rheinhardt
Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics: > > Pointer ctx->priv_data->buffer_pkt->data, that can have only NULL value > (checked at vp9_superframe_split_bsf.c:48), is dereferenced at > vp9_superframe_split_bsf.c:57. > The rationale for a patch should be includ

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Hendrik Leppkes
On Fri, Oct 6, 2023 at 3:07 PM Timo Rothenpieler wrote: > > On 06/10/2023 14:29, Hendrik Leppkes wrote: > > On Sun, Oct 1, 2023 at 1:39 PM Timo Rothenpieler > > wrote: > >> > >> On 01.10.2023 04:06, James Almer wrote: > >>> Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 > >> >

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Timo Rothenpieler
On 06/10/2023 15:31, Hendrik Leppkes wrote: On Fri, Oct 6, 2023 at 3:07 PM Timo Rothenpieler wrote: On 06/10/2023 14:29, Hendrik Leppkes wrote: On Sun, Oct 1, 2023 at 1:39 PM Timo Rothenpieler wrote: On 01.10.2023 04:06, James Almer wrote: Fixes compilation after 05f8b2ca0f7e28775837a572c

Re: [FFmpeg-devel] [REFUND-REQUEST] VDD23 Travel

2023-10-06 Thread Derek Buitenhuis
On 10/5/2023 11:46 PM, Stefano Sabatini wrote: > I confirm it looks broken, sorry for that. > I'll reach out SPI officials to get directions. They replied to my ticket today. You and Michael should be CCed. - Derek ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-06 Thread Steven Liu
Steven Liu 于2023年10月5日周四 15:25写道: > > > > Léon Spaans 于2023年10月5日 周四15:15写道: >> >> According to Patchwork the patch results in 2 "Failed to apply" warnings >> for contexts "yinshiyou/configure_loongarch64" and "andriy/configure_x86". >> >> This is not something I saw in the `make fate` output. >>

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Hendrik Leppkes
On Fri, Oct 6, 2023 at 3:47 PM Timo Rothenpieler wrote: > I'm quite confused why this specific instance suddenly causes so much upset. Because its bad form to break compilation of master, if all it took to avoid that is change the order of pushing a tag to one repo and a patch to another. - Hend

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-06 Thread Derek Buitenhuis
On 10/5/2023 6:32 PM, Lynne wrote: > I counted 2048 with af-convert. Are you referring to qaac? Referring to Apple's own documents, which have 2112 plastered everywhere. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-06 Thread Andreas Rheinhardt
Andreas Rheinhardt: > For now, this API is supposed to replace all the internal uses > of reference counted objects in libavcodec; "internal" here > means that the object is created in libavcodec and is never > put directly in the hands of anyone outside of it. > > It is intended to be made public

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-06 Thread Thierry Foucu
On Fri, Oct 6, 2023 at 10:02 AM Derek Buitenhuis wrote: > On 10/5/2023 6:32 PM, Lynne wrote: > > I counted 2048 with af-convert. Are you referring to qaac? > > Referring to Apple's own documents, which have 2112 plastered everywhere. > And another Fraunhofer implementation is padding 1600 sample

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-06 Thread Nicolas George
Andreas Rheinhardt (12023-10-06): > Will apply patches 2-16 (i.e. up to the pool API) tomorrow unless there > are objections. Have you given some thought to using a template to make the API type-safe directly? Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-06 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12023-10-06): >> Will apply patches 2-16 (i.e. up to the pool API) tomorrow unless there >> are objections. > > Have you given some thought to using a template to make the API > type-safe directly? Do you mean a template that generates functions like HEVCVPS

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-06 Thread Nicolas George
Andreas Rheinhardt (12023-10-06): > Do you mean a template that generates functions like > > HEVCVPS *ff_hevc_vps_ref(HEVCVPS *vps) > { > return ff_refstruct_ref(vps); > } > > automatically? Yes, but better, directly: void ff_hevc_vps_unref(HEVCVPS *vps) { if (atomic_fetch_sub_explicit(

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-06 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12023-10-06): >> Do you mean a template that generates functions like >> >> HEVCVPS *ff_hevc_vps_ref(HEVCVPS *vps) >> { >> return ff_refstruct_ref(vps); >> } >> >> automatically? > > Yes, but better, directly: > > void ff_hevc_vps_unref(HEVCVPS *vps) > {

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-06 Thread Léon Spaans
Thanks Steven! libavformat/hlsenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 08f3746ce7..150320a880 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1585,6 +1585,7 @@ static int hls_window(AVFo

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-06 Thread Nicolas George
Andreas Rheinhardt (12023-10-06): > And as I have already explained, I do not think that this benefit is > significant and you have provided no evidence (i.e. an example) that it > is so. Additionally, the flexibility provided by function pointers is > useful for stuff like CBS. I must have missed

[FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-06 Thread Léon Spaans
Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant playlists. Signed-off-by: Léon Spaans --- libavformat/hlsenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 08f3746ce7..8f7eee202e 100644 --- a/li

[FFmpeg-devel] [PATCH 1/3] avcodec/ffv1enc: Slice combination is unsupported

2023-10-06 Thread Michael Niedermayer
We always write minimal slices, the size calculation is wrong in some corner cases but as its always 1x1 (minus1) we can for now just hard-code it This helps with ticket 5548 Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[FFmpeg-devel] [PATCH 2/3] avcodec/ffv1: Store and reuse sx/sy

2023-10-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.c| 2 ++ libavcodec/ffv1.h| 1 + libavcodec/ffv1enc.c | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/ffv1.c b/libavcodec/ffv1.c index b6204740edb..f44fead350b 100644 --- a/libavcodec/ffv1.c +++ b/l

[FFmpeg-devel] [PATCH 3/3] [RFC] avcodec/ffv1: Better rounding for slice positions

2023-10-06 Thread Michael Niedermayer
This fixes green lines in some odd dimensions with some slice configurations like Ticket 5548 This also changes the encoder and whats encoded, and would require an update to the specification. This change attempts to limit the change to configurations that have missing lines currently. Testing is

[FFmpeg-devel] [PATCH 1/7] avcodec/wmv2dec: Parse extradata during init

2023-10-06 Thread Andreas Rheinhardt
And stop setting picture_number which was only done to not parse extradata multiple times. Signed-off-by: Andreas Rheinhardt --- libavcodec/wmv2dec.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/wmv2dec.c b/libavcodec/wmv2dec.c index 469b2c4b2b..934bf56b1

[FFmpeg-devel] [PATCH 2/7] avcodec/h261dec, vc1dec: Don't set write-only macroblock dimensions

2023-10-06 Thread Andreas Rheinhardt
They are generally set in ff_mpv_init_context_frame() (mostly called by ff_mpv_common_init()); setting them somewhere else should be avoided. Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 6 -- libavcodec/vc1dec.c | 3 --- 2 files changed, 9 deletions(-) diff --git a/libavco

[FFmpeg-devel] [PATCH 3/7] avcodec/h261dec: Don't set write-only picture_number

2023-10-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index a4e0bf9cf2..91d555a70e 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -512,10 +512,7 @@ static int

[FFmpeg-devel] [PATCH 4/7] avcodec/h261dec: Remove pointless goto

2023-10-06 Thread Andreas Rheinhardt
There is no need to parse the header twice; doing so does nothing. Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index 91d555a70e..272bbbea34 100644 --- a/libavcodec/h261dec.c +++ b/lib

[FFmpeg-devel] [PATCH 5/7] fftools/ffmpeg_demux: Don't use fake object with av_opt_eval

2023-10-06 Thread Andreas Rheinhardt
The av_opt_eval family of functions emits errors messages on error and can therefore not be used with fake objects when the AVClass has a custom item_name callback. The AVClass for AVCodecContext has such a custom callback (it searches whether an AVCodec is set to use its name). In practice it mean

[FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg_demux: Fix leak on error

2023-10-06 Thread Andreas Rheinhardt
An AVFormatContext leaks on errors that happen before it is attached to its permanent place (an InputFile). Fix this by attaching it earlier. Given that it is not documented that avformat_close_input() is usable with an AVFormatContext that has only been allocated with avformat_alloc_context() and

[FFmpeg-devel] [PATCH 7/7] avcodec/h261dec: Discard whole packet when discarding

2023-10-06 Thread Andreas Rheinhardt
(The return value doesn't really matter: For video decoders every return value >= 0 is treated as "consumed all of the input".) Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec

Re: [FFmpeg-devel] [PATCH 3/3] [RFC] avcodec/ffv1: Better rounding for slice positions

2023-10-06 Thread Jerome Martinez
On 07/10/2023 02:14, Michael Niedermayer wrote: This fixes green lines in some odd dimensions with some slice configurations like Ticket 5548 This also changes the encoder and whats encoded, and would require an update to the specification. This change attempts to limit the change to configurati