[FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-01 Thread Léon Spaans
Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant playlists. Signed-off-by: Léon Spaans --- libavformat/hlsenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 08f3746ce7..c956f11ed5 100644 --- a/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-01 Thread Timo Rothenpieler
On 01.10.2023 04:06, James Almer wrote: Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 It's expected behaviour to break compilation with random inter-release versions of ffnvcodec. It's only reliable exactly on release versions. I had planned to draw a release of the header

Re: [FFmpeg-devel] [freezedetect filter] discard frozen frames option ever added?

2023-10-01 Thread Paul B Mahol
On 10/1/23, Umberto Boccioni wrote: > [Apologies for the cross-post from User list, but in retrospect, I thought > the post was better placed here] > > I'm trying to remove frozen frames from a video with gaps in the input > stream, and the freezedetect filter appears to accurately find/list those

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-01 Thread Steven Liu
Léon Spaans 于2023年10月1日 周日17:38写道: > Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant > playlists. > > Signed-off-by: Léon Spaans > --- > libavformat/hlsenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 08

[FFmpeg-devel] [PATCH 2/9] lavf/demux: restrict video parser duration handling to just GIF

2023-10-01 Thread Anton Khirnov
The parser does not have a timebase associated with it, so in general it makes no sense for it to be exporting durations. Longer-term this should be handled more cleanly with a new parser API. --- libavformat/demux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/d

[FFmpeg-devel] [PATCH 4/9] lavc/mpegvideo_parser: reduce variable scopes

2023-10-01 Thread Anton Khirnov
Drop some variables only used in a switch(). --- libavcodec/mpegvideo_parser.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c index d0b22634bb..76cd2a5131 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 7/9] fftools/ffmpeg_dec: disregard demuxer timestamps for NOTIMESTAMPS formats

2023-10-01 Thread Anton Khirnov
In this case any timestamps are guessed by compute_pkt_fields() in libavformat. Since we are decoding the stream, we have more accurate information from the decoder and do not need any guesses. Eliminates spurious PTS gaps in a number of FATE tests. Also avoids dropping the majority of frames in

[FFmpeg-devel] [PATCH 5/9] lavc/mpegvideo_parser: improve exporting field-coding information

2023-10-01 Thread Anton Khirnov
* export AVCodecParserContext.picture_structure. * when there are two field pictures in the packet, set the interlacing parameters accordingly: * repeat_pict=1 and picture_structure=FRAME to indicate 2 fields * field_order to indicate the first field of the two --- libavcodec/mpe

[FFmpeg-devel] [PATCH 6/9] lavc/mpeg4videodec: do not invent a framerate from guessed numbers

2023-10-01 Thread Anton Khirnov
Improves timestamps for fate-m4v* --- libavcodec/mpeg4videodec.c | 3 -- tests/ref/fate/m4v | 84 +++--- tests/ref/fate/m4v-cfr | 1 + 3 files changed, 43 insertions(+), 45 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videode

[FFmpeg-devel] [PATCH 9/9] fftools/ffmpeg: move derivation of frame duration from filter framerate

2023-10-01 Thread Anton Khirnov
>From ffmpeg_enc to ffmpeg_filter, which is a more appropriate place for it. --- fftools/ffmpeg_enc.c| 9 + fftools/ffmpeg_filter.c | 6 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 6c00156121..ec9cebbd96 100644

[FFmpeg-devel] [PATCH 3/9] lavf/gifdec: do not mark as notimestamps

2023-10-01 Thread Anton Khirnov
The demuxer does not set packet timestamps itself after c6b6356635f598b095606cd126f31bc6ab916225 and instead relies on the parser to do it. However, this does not matter from the caller perspective as it still happens inside the demuxer. The demuxer should thus not be flagged as not having timestam

[FFmpeg-devel] [PATCH 8/9] fftools/ffmpeg_enc: do not round frame durations prematurely

2023-10-01 Thread Anton Khirnov
Changes the results of fate-idroq-video-encode and fate-lavf* tests, where different frames now get duplicated by framerate conversion code. --- fftools/ffmpeg_enc.c | 6 +++--- tests/ref/fate/idroq-video-encode | 2 +- tests/ref/lavf/dv_ntsc| 4 ++-- tests/ref/lavf/gxf_nt

[FFmpeg-devel] [PATCH 1/9] lavfi/yadif: update output frame durations

2023-10-01 Thread Anton Khirnov
--- libavfilter/yadif_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/yadif_common.c b/libavfilter/yadif_common.c index b26989f574..21097011f5 100644 --- a/libavfilter/yadif_common.c +++ b/libavfilter/yadif_common.c @@ -151,6 +151,7 @@ int ff_yadif_filter_frame(AVFilter

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: Don't create wrong packet durations

2023-10-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > We have to write an explicit BlockDuration element (and use > a BlockGroup instead of a SimpleBlock) in case the Track > has a DefaultDuration that is inconsistent with the duration > of the packet. > > The matroska-h264-remux test uses a file with coded fields > where the du

Re: [FFmpeg-devel] [PATCH 6/9] lavc/mpeg4videodec: do not invent a framerate from guessed numbers

2023-10-01 Thread Andreas Rheinhardt
Anton Khirnov: > Improves timestamps for fate-m4v* What makes the new cfr timestamps better? > --- > libavcodec/mpeg4videodec.c | 3 -- > tests/ref/fate/m4v | 84 +++--- > tests/ref/fate/m4v-cfr | 1 + > 3 files changed, 43 insertions(+), 45 deletion

Re: [FFmpeg-devel] [PATCH 7/9] fftools/ffmpeg_dec: disregard demuxer timestamps for NOTIMESTAMPS formats

2023-10-01 Thread Andreas Rheinhardt
Anton Khirnov: > In this case any timestamps are guessed by compute_pkt_fields() in > libavformat. Since we are decoding the stream, we have more accurate > information from the decoder and do not need any guesses. > > Eliminates spurious PTS gaps in a number of FATE tests. > > Also avoids droppi

Re: [FFmpeg-devel] [REFUND-REQUEST] VDD23 Travel

2023-10-01 Thread Derek Buitenhuis
On 9/29/2023 7:18 AM, Stefano Sabatini wrote: > Once this is approved, follow instructions here to generate a refund request: > https://www.spi-inc.org/treasurer/reimbursement-form/ One note: One step says to use the xe.com expensed calculator - however the link provided is broken. Indeed the link

[FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-01 Thread Léon Spaans
Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant playlists. Signed-off-by: Léon Spaans --- libavformat/hlsenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 08f3746ce7..150320a880 100644 --- a/li

Re: [FFmpeg-devel] [PATCH] x86inc: Add REPX macro to repeat instructions/operations

2023-10-01 Thread Henrik Gramner via ffmpeg-devel
On Fri, Sep 29, 2023 at 1:38 PM Frank Plowman wrote: > libavutil/x86/x86inc.asm | 10 ++ > 1 file changed, 10 insertions(+) LGTM. As a side note https://code.videolan.org/videolan/x86inc.asm is the upstream repo for x86inc.asm. ___ ffmpeg-deve

[FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN

2023-10-01 Thread Michael Niedermayer
EAGAIN causes an assertion failure when it is returned from the decoder Fixes: Assertion consumed != (-(11)) failed at libavcodec/decode.c:462 Fixes: assertion_IOT_instruction_decode_c_462/poc Found-by: Hardik Shah of Vehere (Dawn Treaders team) Signed-off-by: Michael Niedermayer --- libavcodec

[FFmpeg-devel] [PATCH] swscale/rgb2rgb: fix extra iteration in R-V V interleave

2023-10-01 Thread Rémi Denis-Courmont
There was an additional iteration doing nothing for each line, due to checking the selected vector length instead of the available vector length. --- libswscale/riscv/rgb2rgb_rvv.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv

[FFmpeg-devel] [PATCH] swscale/rgb2rgb: R-V V deinterleaveBytes

2023-10-01 Thread Rémi Denis-Courmont
--- libswscale/riscv/rgb2rgb_rvv.S | 26 ++ 1 file changed, 26 insertions(+) diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv/rgb2rgb_rvv.S index 71e8fac6f3..671089c842 100644 --- a/libswscale/riscv/rgb2rgb_rvv.S +++ b/libswscale/riscv/rgb2rgb_rvv.S @@ -100,6

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN

2023-10-01 Thread Kieran Kunhya
Sent from my mobile device On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, wrote: > EAGAIN causes an assertion failure when it is returned from the decoder > > Fixes: Assertion consumed != (-(11)) failed at libavcodec/decode.c:462 > Fixes: assertion_IOT_instruction_decode_c_462/poc > > Found-by:

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN

2023-10-01 Thread Michael Niedermayer
On Sun, Oct 01, 2023 at 08:24:57PM +0200, Kieran Kunhya wrote: > Sent from my mobile device > > On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, > wrote: > > > EAGAIN causes an assertion failure when it is returned from the decoder > > > > Fixes: Assertion consumed != (-(11)) failed at libavcodec/

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN

2023-10-01 Thread James Almer
On 10/1/2023 3:24 PM, Kieran Kunhya wrote: Sent from my mobile device On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, wrote: EAGAIN causes an assertion failure when it is returned from the decoder Fixes: Assertion consumed != (-(11)) failed at libavcodec/decode.c:462 Fixes: assertion_IOT_inst

Re: [FFmpeg-devel] [PATCH 4/9] lavc/mpegvideo_parser: reduce variable scopes

2023-10-01 Thread Michael Niedermayer
On Sun, Oct 01, 2023 at 02:55:47PM +0200, Anton Khirnov wrote: > Drop some variables only used in a switch(). > --- > libavcodec/mpegvideo_parser.c | 33 ++--- > 1 file changed, 14 insertions(+), 19 deletions(-) should be ok [...] -- Michael GnuPG fingerprint: 9F

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo_dec: Remove commented-out legacy cruft

2023-10-01 Thread Michael Niedermayer
On Sat, Sep 30, 2023 at 08:02:55PM +0200, Andreas Rheinhardt wrote: > Added in 80e9e63c946660304fc65fa8141ccfdbe4d196d1 for reasons > unknown to me. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo_dec.c | 4 > 1 file changed, 4 deletions(-) ok [...] -- Michael GnuP

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snow: Move dsp helper functions to snow_dwt.h

2023-10-01 Thread Michael Niedermayer
On Sat, Sep 30, 2023 at 05:07:31PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/snow.h| 38 -- > libavcodec/snow_dwt.h| 40 > libavcodec/x86/snowdsp.c | 1 - > 3 fi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snow: Move encoder-only stuff out of SnowContext

2023-10-01 Thread Michael Niedermayer
On Sat, Sep 30, 2023 at 05:01:15PM +0200, Andreas Rheinhardt wrote: > Put it into an encoder-specific context with a SnowContext > at its front. This also avoids having to include mpegvideo.h > in snow.c and snowdec.c. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/snow.h| 27 +--

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-01 Thread Steven Liu
Léon Spaans 于2023年10月1日 周日22:40写道: > Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant > playlists. > > Signed-off-by: Léon Spaans > --- > libavformat/hlsenc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/h

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-01 Thread Léon Spaans
Thanks Steven! Have a wonderful day! Léon > On 2 Oct 2023, at 01:17, Steven Liu wrote: > > Léon Spaans 于2023年10月1日 周日22:40写道: > >> Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant >> playlists. >> >> Signed-off-by: Léon Spaans >> --- >> libavformat/hlsenc.c | 6 +

Re: [FFmpeg-devel] [freezedetect filter] discard frozen frames option ever added?

2023-10-01 Thread Umberto Boccioni
> > something like > freezedetect,metadata=mode=select:key=lavfi.freezedetect.freeze_amount:value=some_frozen_amount:function=greater > > You just need to export frozen value from freezedetect filter for each > output frame metadata. > > Thanks for taking the time to respond, which I'm sure is ano

Re: [FFmpeg-devel] [freezedetect filter] discard frozen frames option ever added?

2023-10-01 Thread Paul B Mahol
On 10/2/23, Umberto Boccioni wrote: >> >> something like >> freezedetect,metadata=mode=select:key=lavfi.freezedetect.freeze_amount:value=some_frozen_amount:function=greater >> >> You just need to export frozen value from freezedetect filter for each >> output frame metadata. >> >> > Thanks for tak