[FFmpeg-devel] [PATCH 1/3] swscale/rgb2rgb: rework RISC-V V uyvytoyuv422

This avoids using relatively slow register strides. --- libswscale/riscv/rgb2rgb_rvv.S | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv/rgb2rgb_rvv.S index 008f098bfe..3e7988ca01 100644 --- a/libswscale

[FFmpeg-devel] [PATCH 2/3] swscale/rgb2rgb: avoid S-regs in RISC-V V uyvytoyuv422

We can make do with callee-clobbered registers only now. As an added bonus, this makes the code XLEN-independent. --- libswscale/riscv/rgb2rgb.c | 2 -- libswscale/riscv/rgb2rgb_rvv.S | 10 ++ 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/libswscale/riscv/rgb2rgb.c b

[FFmpeg-devel] [PATCH 3/3] swscale/rgb2rgb: unroll RISC-V V uyvytoyuv422

--- libswscale/riscv/rgb2rgb_rvv.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv/rgb2rgb_rvv.S index 3200370224..ff02eba9bf 100644 --- a/libswscale/riscv/rgb2rgb_rvv.S +++ b/libswscale/riscv/rgb2rgb_rvv.S @@ -112,14 +112

Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: Fix double-free on error

On 29.09.2023 19:28, Andreas Rheinhardt wrote: After the AVFrame has been wrapped into a buffer, it is owned by the buffer and must not be freed manually any more. Yet this happens on subsequent errors. This bug was introduced in 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b. Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

On Sat, 30 Sep 2023, Michael Niedermayer wrote: Fixes: signed integer overflow: 109817402400 * 301990077 cannot be represented in type 'long long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-6706191715139584 Found-by: continuous fuzzing process https://github.com/goo

Re: [FFmpeg-devel] [PATCH 07/14] avcodec/vorbis: Use void* logctx instead of AVCodecContext*

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vorbis.c | 8 +--- > libavcodec/vorbis.h | 4 +--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/vorbis.c b/libavcodec/vorbis.c > index d0b660b44a..3d85997576 100644 > --- a/libavcodec

[FFmpeg-devel] [PATCH] avcodec/lcldec: fix uncompressed buffer size calculation

Attached. From efa34f7cd140f4e696641ce730b8e2b97e3d8452 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 30 Sep 2023 12:33:58 +0200 Subject: [PATCH] avcodec/lcldec: fix uncompressed buffer size calculation The width is truncated to multiple of 2. Signed-off-by: Paul B Mahol --- libavcode

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

On Sat, Sep 30, 2023 at 11:35:19AM +0200, Marton Balint wrote: > > > On Sat, 30 Sep 2023, Michael Niedermayer wrote: > > > Fixes: signed integer overflow: 109817402400 * 301990077 cannot be > > represented in type 'long long' > > Fixes: > > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_f

Re: [FFmpeg-devel] [PATCH v2] avcodec/libkvazaar: Respect codec context color settings.

On Sat, Sep 30, 2023 at 12:39 AM Vittorio Giovara wrote: > > On Fri, Sep 29, 2023 at 5:12 PM John Mather via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > This patch makes the libkvazaar encoder respect color settings that are > > present on the codec context, including color range, prima

Re: [FFmpeg-devel] [PATCH v2] avcodec/libkvazaar: Respect codec context color settings.

On Sat, Sep 30, 2023 at 12:12 AM John Mather via ffmpeg-devel wrote: > > This patch makes the libkvazaar encoder respect color settings that are > present on the codec context, including color range, primaries, transfer > function and colorspace. > --- > libavcodec/libkvazaar.c | 9 + > 1

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

On Sat, Sep 30, 2023 at 04:04:03PM +0200, Michael Niedermayer wrote: > On Sat, Sep 30, 2023 at 11:35:19AM +0200, Marton Balint wrote: > > > > > > On Sat, 30 Sep 2023, Michael Niedermayer wrote: > > > > > Fixes: signed integer overflow: 109817402400 * 301990077 cannot be > > > represented in typ

[FFmpeg-devel] [PATCH 1/2] avcodec/snow: Move encoder-only stuff out of SnowContext

Put it into an encoder-specific context with a SnowContext at its front. This also avoids having to include mpegvideo.h in snow.c and snowdec.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.h| 27 +-- libavcodec/snowenc.c | 448 --- 2 files c

[FFmpeg-devel] [PATCH 2/2] avcodec/snow: Move dsp helper functions to snow_dwt.h

Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.h| 38 -- libavcodec/snow_dwt.h| 40 libavcodec/x86/snowdsp.c | 1 - 3 files changed, 40 insertions(+), 39 deletions(-) diff --git a/libavcodec/snow.h b

Re: [FFmpeg-devel] [PATCH 4/6] avformat/cafdec: saturate start + size into 64bit

On Fri, Sep 29, 2023 at 08:41:23PM -0300, James Almer wrote: > On 9/29/2023 8:19 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 64 + 9223372036854775803 cannot be > > represented in type 'long long' > > Fixes: > > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6536

[FFmpeg-devel] [PATCH] vulkan_hevc: handle non-contiguous SPS/PPS/VPS ids

Some clips (i.e. SLIST_B_Sony_9) will use PPS 0 and 8, before PPS 1-7. vulkan_hevc expects {sps,pps,vps}_list to be filled in order, which causes PPS 8 to not be added to the Vulkan session params when it is being used by a picture. This removes the expectation that these lists are filled in order

[FFmpeg-devel] [PATCH v2] vulkan_hevc: handle non-contiguous SPS/PPS/VPS ids

Some clips (i.e. SLIST_B_Sony_9) will use PPS 0 and 8, before PPS 1-7. vulkan_hevc expects {sps,pps,vps}_list to be filled in order, which causes PPS 8 to not be added to the Vulkan session params when it is being used by a picture. This removes the expectation that these lists are filled in order

[FFmpeg-devel] [PATCH] lavu/float_dsp: avoid reg-stride in R-V V reverse_fmul

This revectors the inner loop to reverse vectors element in vectors, thus eliminating the negative register stride. Note that RVV does not have a vector reverse instruction, so this uses a gather. --- libavutil/riscv/float_dsp_rvv.S | 17 +++-- 1 file changed, 11 insertions(+), 6 delet

[FFmpeg-devel] [PATCH] swscale/rgb2rgb: unroll R-V V interleave_bytes

--- libswscale/riscv/rgb2rgb_rvv.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv/rgb2rgb_rvv.S index ff02eba9bf..56539690bc 100644 --- a/libswscale/riscv/rgb2rgb_rvv.S +++ b/libswscale/riscv/rgb2rgb_rvv.S @@ -82,11 +82,11

[FFmpeg-devel] [PATCH 1/4] avcodec/mpegvideo_dec: Check for existence of planes before accesses

Fixes segfaults with -debug +nomc -flags +gray (presuming a build with --enable-gray). Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index 7aa46a4e

[FFmpeg-devel] [PATCH 2/4] avcodec/mpegvideo_dec: Don't memset twice

This has been done for the luma plane of missing FLV1 and H263 references. Also remove code duplication by reusing gray_frame(), which has been renamed to color_frame() for this purpose. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 28 +--- 1 file ch

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo_dec: Remove commented-out legacy cruft

Added in 80e9e63c946660304fc65fa8141ccfdbe4d196d1 for reasons unknown to me. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index 617109a1f7..f9fccff518 100644 --- a/l

[FFmpeg-devel] [PATCH 4/4] avcodec/h264_slice: Don't keep AVCodecContext props in sync manually

It is already done generically in update_context_from_thread() before this function is called. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_slice.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 5657327f0c..24f4690e79 10064

[FFmpeg-devel] [PATCH] lavu/float_dsp: avoid reg-stride in R-V V fmul_window

--- libavutil/riscv/float_dsp_rvv.S | 45 ++--- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/libavutil/riscv/float_dsp_rvv.S b/libavutil/riscv/float_dsp_rvv.S index 7e9e84d526..91b70bf148 100644 --- a/libavutil/riscv/float_dsp_rvv.S +++ b/libavutil/ri

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

Quoting Michael Niedermayer (2023-09-30 16:31:43) > On Sat, Sep 30, 2023 at 04:04:03PM +0200, Michael Niedermayer wrote: > > On Sat, Sep 30, 2023 at 11:35:19AM +0200, Marton Balint wrote: > > > > > > > > > On Sat, 30 Sep 2023, Michael Niedermayer wrote: > > > > > > > Fixes: signed integer overfl

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

On Sat, Sep 30, 2023 at 10:18:38PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-09-30 16:31:43) > > On Sat, Sep 30, 2023 at 04:04:03PM +0200, Michael Niedermayer wrote: > > > On Sat, Sep 30, 2023 at 11:35:19AM +0200, Marton Balint wrote: > > > > > > > > > > > > On Sat, 30 Sep 2

[FFmpeg-devel] [PATCH 01/15] avformat/concatdec: Check in/outpoint for overflow

Fixes: signed integer overflow: 9154241445400 - -915424149454600 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4739147999084544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 02/15] avformat/jacosubdec: Factorize code in get_shift() a bit

Signed-off-by: Michael Niedermayer --- libavformat/jacosubdec.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavformat/jacosubdec.c b/libavformat/jacosubdec.c index 61b1316dc9b..42c201f93af 100644 --- a/libavformat/jacosubdec.c +++ b/libavformat/jacosubdec.

[FFmpeg-devel] [PATCH 03/15] avformat/jacosubdec: avoid signed integer overflows in get_shift()

Fixes: signed integer overflow: 22014562800 * 934633746 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_JACOSUB_fuzzer-5189603246866432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 04/15] avformat/jacosubdec: Check timeres

Signed-off-by: Michael Niedermayer --- libavformat/jacosubdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/jacosubdec.c b/libavformat/jacosubdec.c index 41216081ee0..c6e5b4aa6dc 100644 --- a/libavformat/jacosubdec.c +++ b/libavformat/jacosubdec.c @

[FFmpeg-devel] [PATCH 05/15] avformat/mov: compute absolute dts difference without overflow in mov_find_next_sample()

Fixes: signed integer overflow: -9223372036854775808 - 922272641302200 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5959420033761280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 11/15] avformat/matroskadec: Check prebuffered_ns for overflow

Fixes: signed integer overflow: 9223372036630775808 + 10 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-5406131992526848 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ff

[FFmpeg-devel] [PATCH 06/15] avformat/rpl: Check for number_of_chunks overflow

Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int32_t' (aka 'int') Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_RPL_fuzzer-6086131095830528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by

[FFmpeg-devel] [PATCH 12/15] avformat/westwood_vqa: Do not leave vqfl_chunk_size invalid

Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_WSVQA_fuzzer-4613908817903616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nied

[FFmpeg-devel] [PATCH 07/15] avformat/sbgdec: Check for period overflow

Fixes: signed integer overflow: 448124699617300 - -47785768200 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-5063670588899328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 13/15] avformat/xwma: sanity check bits_per_coded_sample

Fixes: signed integer overflow: 65312 * 524296 cannot be represented in type 'int' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_XWMA_fuzzer-659597144200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

[FFmpeg-devel] [PATCH 08/15] avformat/sbgdec: Check for negative duration or un-representable end pts

Fixes: signed integer overflow: 9230955872951340 - -9223372036854775808 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6330481893572608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sig

[FFmpeg-devel] [PATCH 14/15] avformat/asfdec_f: Saturate presentation time in marker

Fixes: signed integer overflow: -9223372036315799520 - 3873890816 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5009302746431488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-of

[FFmpeg-devel] [PATCH 09/15] avformat/tta: Better totalframes check

Fixes: signed integer overflow: 4 * 740491135 cannot be represented in type 'int' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_TTA_fuzzer-6298893367508992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederm

[FFmpeg-devel] [PATCH 15/15] avcodec/h264_parser: saturate dts a bit

Fixes: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6112289464123392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 10/15] avformat/wavdec: Check left avio_tell for overflow

Fixes: signed integer overflow: 155 + 9223372036854775655 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-5364032278495232 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

Re: [FFmpeg-devel] [PATCH 12/15] avformat/westwood_vqa: Do not leave vqfl_chunk_size invalid

On Sun, Oct 01, 2023 at 12:30:43AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_WSVQA_fuzzer-4613908817903616 > > Found-by: continuous fuzzing process > https:/

[FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 Signed-off-by: James Almer --- libavutil/hwcontext_cuda.c | 4 libavutil/hwcontext_cuda_internal.h | 9 + 2 files changed, 13 insertions(+) diff --git a/libavutil/hwcontext_cuda.c b/libavutil/hwcontext_cuda.c

[FFmpeg-devel] [freezedetect filter] discard frozen frames option ever added?

[Apologies for the cross-post from User list, but in retrospect, I thought the post was better placed here] I'm trying to remove frozen frames from a video with gaps in the input stream, and the freezedetect filter appears to accurately find/list those sections. I was hoping to use the results of

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

On 9/30/2023 11:06 PM, James Almer wrote: Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 Signed-off-by: James Almer --- libavutil/hwcontext_cuda.c | 4 libavutil/hwcontext_cuda_internal.h | 9 + 2 files changed, 13 insertions(+) diff --git a/libavuti