Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-23 Thread Kyle Swanson
Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler wrote: > Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled, > support for CUDA is checked for, and then the vmaf_cuda filter needs to > depend on that check. This previous patch should do just that [0]. What's missing?

[FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-09-23 Thread Carotti, Elias via ffmpeg-devel
Hi, please find attached a patch to propagate the SSE for a frame into the encoder stats. Since libx264 already provides PSNR values, this is done by basically inverting the formula to recover the SSE values. Would it be possible to also append other values to the errors vector? E.g., libx264 also

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-23 Thread Michael Niedermayer
On Sat, Sep 23, 2023 at 02:49:47AM -0400, Neal Gompa wrote: > On Fri, Sep 22, 2023 at 12:33 PM Michael Niedermayer > wrote: > > > > On Fri, Sep 22, 2023 at 03:55:57PM +0200, Gijs Peskens wrote: > > > > > > On 21-09-2023 18:21, Michael Niedermayer wrote: > > > > Hi all > > > > > > > > As the 6.1 re

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-23 Thread Timo Rothenpieler
On 23.09.2023 11:50, Kyle Swanson wrote: Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler wrote: Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled, support for CUDA is checked for, and then the vmaf_cuda filter needs to depend on that check. This previous patch sh

[FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

2023-09-23 Thread llyyr
ab77b878f1 attempted to fix the issue of broken packets being sent to the decoder by implementing logic that kept attempting to PTS-step backwards until it reached a valid point, however applying this heuristic meant that in files that had no valid points (such as HEVC videos shot on iPhones), we'd

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/vf_psnr: add warning when color ranges differ

2023-09-23 Thread Niklas Haas
On Sat, 01 Apr 2023 10:47:35 -0700 Chema Gonzalez wrote: > The PSNR filter uses the pixel values without considering > the color ranges. This is incorrect. Patch adds a warning > so at least the user knows it. > > Let's see an example: > > (1) Let's get a simple black pixel/white pixel image. >

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/vf_libvmaf: add warning when color ranges differ

2023-09-23 Thread Kyle Swanson
Hi, On Mon, Apr 17, 2023 at 10:14 PM Chema Gonzalez wrote: > Hi Kyle, > > Thanks for your answer. > > I couldn't find how to access the color range from the filter_frame > function. I checked other filters that access `AVFrame.color_range`, > and all of them do it in the filter_frame function, n

Re: [FFmpeg-devel] [PATCH 0/1] add limited|full aliases for -color_range parameter

2023-09-23 Thread Niklas Haas
On Fri, 31 Mar 2023 08:49:55 -0700 Chema Gonzalez wrote: > Add limited|full aliases for -color_range parameter. > > Chema Gonzalez (1): > pixdesc: add limited|full aliases for -color_range parameter > > doc/codecs.texi| 2 ++ > libavcodec/options_table.h | 2 ++ > 2 files changed,

[FFmpeg-devel] [PATCH 0/2] avfilter/vf_vpp_qsv: apply 3D LUT from file

2023-09-23 Thread Chen Yufei
First time modifing FFmpeg code and sending patch, please bear with me for mistakes. Following patches add support for applying 3D LUT from file using oneVPL VPP. Limitation: The new feature is only available when `CONFIG_VAAPI` is enabled, because of my limited test environemnt and little experi

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: expose 3D LUT file parse function.

2023-09-23 Thread Chen Yufei
Signed-off-by: Chen Yufei --- libavfilter/Makefile | 8 +- libavfilter/lut3d.c| 669 + libavfilter/lut3d.h| 13 + libavfilter/vf_lut3d.c | 590 +--- 4 files changed, 689 insertions(+), 591 deletions(-) create mo

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_vpp_qsv: apply 3D LUT from file.

2023-09-23 Thread Chen Yufei
Usage: "vpp_qsv=lut3d_file=" Only enabled with VAAPI because using VASurface to store 3D LUT. Signed-off-by: Chen Yufei --- libavfilter/vf_vpp_qsv.c | 241 ++- 1 file changed, 236 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfil

[FFmpeg-devel] SDR lib comments

2023-09-23 Thread Michael Niedermayer
Hi all ive promised to write a mail about SDR at the confernece about a seperate lib, here is it (i in fact had this half written already before) The SDR code in FFmpeg was and is intended to be a plain simple libavdevice input device same as x11 and others SDR is complex and not a simple memcpy

[FFmpeg-devel] [PATCH] sdr: Remove avpriv_sdr_options

2023-09-23 Thread Michael Niedermayer
This causes issues with dlls Found-by: mkver Signed-off-by: Michael Niedermayer --- libavdevice/sdrindev.c | 10 ++- libavformat/sdr.h | 58 ++-- libavformat/sdrdemux.c | 60 +++--- 3 files changed, 68 insertions(+)

[FFmpeg-devel] [PATCH] libswresample/swresample: avoid s16p internal transfer format

2023-09-23 Thread Michael Niedermayer
From: Paul B Mahol Instead use float one by default for sample rate conversions. The s16p internal transfer format produces visible and hearable quantization artifacts. Signed-off-by: Paul B Mahol for S8 we continue to use S16 as it should have enough precision Fate is adjusted so bitexactness

Re: [FFmpeg-devel] [PATCH] libswresample/swresample: avoid s16p internal transfer format

2023-09-23 Thread Paul B Mahol
On Sat, Sep 23, 2023 at 11:02 PM Michael Niedermayer wrote: > From: Paul B Mahol > > Instead use float one by default for sample rate conversions. > The s16p internal transfer format produces visible and hearable > quantization artifacts. > > Signed-off-by: Paul B Mahol > > for S8 we continue t

[FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Paul B Mahol
Patches attached. From 5d57a04d3b4aa9b487302ab89b2a3bca4ccb9330 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Sep 2023 16:49:25 +0200 Subject: [PATCH 2/2] avcodec: add QOA decoder and parser Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c |

[FFmpeg-devel] [PATCH] avformat/subtitles: check for double BOM in UTF-16 files

2023-09-23 Thread llyyr
While these files certainly aren't the norm, and might not even be considered valid by many programs, there are plenty of older ASS tracks in UTF-16 LE/BE encoding that contain double BOMs. This patch teaches ff_text_init_avio about double BOMs and makes it check for them in UTF-16 LE/BE files. Th

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-23 Thread Neal Gompa
On Sat, Sep 23, 2023 at 6:55 AM Michael Niedermayer wrote: > > On Sat, Sep 23, 2023 at 02:49:47AM -0400, Neal Gompa wrote: > > On Fri, Sep 22, 2023 at 12:33 PM Michael Niedermayer > > wrote: > > > > > > On Fri, Sep 22, 2023 at 03:55:57PM +0200, Gijs Peskens wrote: > > > > > > > > On 21-09-2023 18

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Andreas Rheinhardt
Paul B Mahol: > +.flags = AVFMT_GENERIC_INDEX, > +.extensions = "qoa", > +.raw_codec_id = AV_CODEC_ID_QOA, This will not compile: The codec_id is only added in the second patch. > +.priv_data_size = sizeof(FFRawDemuxerContext), > +.priv_class = &ff_raw_demux

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Paul B Mahol
On Sun, Sep 24, 2023 at 2:04 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > +.flags = AVFMT_GENERIC_INDEX, > > +.extensions = "qoa", > > +.raw_codec_id = AV_CODEC_ID_QOA, > > This will not compile: The codec_id is only added in the sec

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Paul B Mahol
New patches. From 63392e60c7106bfcc6dec5fe45a9dd38f4c29e10 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Sep 2023 16:38:35 +0200 Subject: [PATCH 2/2] avformat: add QOA demuxer Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavform