[FFmpeg-devel] [PATCH 1/2] fate/ffmpeg: Add bitexact flag for ffmpeg-input-r test

2023-09-04 Thread Andreas Rheinhardt
Fixes the test when the non-bitexact MMXEXT versions of the hpeldsp functions are used. Signed-off-by: Andreas Rheinhardt --- tests/fate/ffmpeg.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 2b3135b6a6..04500d53a0 10064

[FFmpeg-devel] [PATCH 2/2] avcodec/x86/hpeldsp_vp3: Merge into hpeldsp

2023-09-04 Thread Andreas Rheinhardt
Once upon a time, 413abbe16465a7b49472ac110e42939e853e24a1 added versions of some put_no_rnd_pixels functions for use in VP3 and Theora (with an explicit check so that they are only used for VP3 and Theora). When this was moved to hpeldsp (from dsputil) in 3ced55d51c2e65b37e50d500dff88bcd80e01b9c,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_pad: respect frame colorspace tag in RGB to YUV conversion

2023-09-04 Thread Leo Izen
On 8/27/23 15:51, Leo Izen wrote: vf_pad calls ff_draw_init, which assumes BT.709 and TV range for its YUV matricies. Since the filter only accepts RGB inputs for the color argument, it needs to convert them to YUV for YUV input video, and it should respect the tagged colormatrix when doing such

[FFmpeg-devel] [PATCH 01/20] fate/matroska: Add test for remuxing non-rotation displaymatrix

2023-09-04 Thread Andreas Rheinhardt
This provides coverage for the case in which the displaymatrix is ignored. Signed-off-by: Andreas Rheinhardt --- In this case, both the x and y axis are rotated in the same way, yet both axes are scaled by different factors, so that it is not an orthogonal transformation. Yet one could still argu

[FFmpeg-devel] [PATCH 06/20] avformat/matroskdec: Factor audio parsing out of matroska_parse_tracks()

2023-09-04 Thread Andreas Rheinhardt
More exactly, factor codec-specific audio parsing out of matroska_parse_tracks(). This is intended to improve readability. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 424 ++ 1 file changed, 243 insertions(+), 181 deletions(-) diff --git

[FFmpeg-devel] [PATCH 07/20] avformat/matroskadec: Remove redundant checks

2023-09-04 Thread Andreas Rheinhardt
If the size of the data of an EbmlBin is > 0, its data is always present, as ebml_read_binary() always leaves the buffer in a consistent state (even on error). Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff

[FFmpeg-devel] [PATCH 03/20] avformat/matroskadec: Use dedicated pointer for access to codecpar

2023-09-04 Thread Andreas Rheinhardt
Shortens code and improves readability. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 98 --- 1 file changed, 50 insertions(+), 48 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index ac3800b880..fd28ff8ab2

[FFmpeg-devel] [PATCH 08/20] avformat/matroskadec: Reindent after the previous commit

2023-09-04 Thread Andreas Rheinhardt
Also fix a variable shadowing. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 251 +++--- 1 file changed, 125 insertions(+), 126 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index e30dedf434..e9ad0c7e11 100644

[FFmpeg-devel] [PATCH 09/20] avformat/matroskadec: Factor video parsing out of matroska_parse_tracks()

2023-09-04 Thread Andreas Rheinhardt
More exactly, factor codec-specific video parsing out of matroska_parse_tracks(). This is intended to improve readability. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 120 +++--- 1 file changed, 72 insertions(+), 48 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 04/20] avformat/matroskadec: Redo handling extradata allocation

2023-09-04 Thread Andreas Rheinhardt
Up until now, matroska_parse_tracks() has two main ways to set AVCodecParameters.extradata: A generic way via CodecPrivate (possibly with an offset) and by allocating a buffer manually; the pointer to this buffer is stored in a stack pointer. In particular, the latter method is problematic, as the

[FFmpeg-devel] [PATCH 05/20] avformat/matroskadec: Set AVCodecParameters earlier

2023-09-04 Thread Andreas Rheinhardt
This is in preparation for future commits. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 55 --- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 50a159460d..e1524a5

[FFmpeg-devel] [PATCH 10/20] avformat/matroskadec: Reindent after the previous commit

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 86 +++ 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 3348ce161e..854b225c9e 100644 --- a/libavformat/matroskadec.c +

[FFmpeg-devel] [PATCH 11/20] avformat/matroskadec: Move reading color space to a better place

2023-09-04 Thread Andreas Rheinhardt
Namely to a place after the AVStream has already been created, so that it can be directly attached to it. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec

[FFmpeg-devel] [PATCH 12/20] avformat/matroskadec: Avoid clobbering CodecPrivate size

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 21a0a1ecd5..147a146873 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -30

[FFmpeg-devel] [PATCH 13/20] avformat/matroskadec: Use av_dict_set_int() where appropriate

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 147a146873..ee546bfffb 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3097,7

[FFmpeg-devel] [PATCH 14/20] avformat/matroskadec: Factor parsing subtitle codecs out

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 75 --- 1 file changed, 46 insertions(+), 29 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index ee546bfffb..97e944df7c 100644 --- a/libavformat/matroskadec.c +

[FFmpeg-devel] [PATCH 15/20] avformat/matroskadec: Factor generic parsing of video tracks out

2023-09-04 Thread Andreas Rheinhardt
Out of matroska_parse_tracks(), that is. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 188 +- 1 file changed, 102 insertions(+), 86 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 97e944df7c..ec6ecb33

[FFmpeg-devel] [PATCH 17/20] avformat/matroskadec: Factor generic parsing of audio tracks out

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 79 +++ 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 1bbdb6b980..7adb72aa23 100644 --- a/libavformat/matroskadec.c +

[FFmpeg-devel] [PATCH 18/20] avformat/matroskdec: Reindent after the previous commit

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 52 +++ 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 7adb72aa23..d6545fd30d 100644 --- a/libavformat/matroskadec.c +

[FFmpeg-devel] [PATCH 19/20] avformat/matroskadec: Move WEBVTT code to mkv_parse_subtitle_codec()

2023-09-04 Thread Andreas Rheinhardt
and also perform the remainder of the subtitle parsing directly after mkv_parse_subtitle_codec(). Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 49 +-- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/libavformat/matroskadec.

[FFmpeg-devel] [PATCH 16/20] avformat/matroskadec: Reindent after the previous commit

2023-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 157 +++--- 1 file changed, 79 insertions(+), 78 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index ec6ecb33cc..1bbdb6b980 100644 --- a/libavformat/matroskadec.c +

[FFmpeg-devel] [PATCH 02/20] avformat/matroskadec: Set several stream parameters earlier

2023-09-04 Thread Andreas Rheinhardt
Don't do it in between parsing and setting extradata. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 64 +++ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index fda77b0b

Re: [FFmpeg-devel] [PATCH 15/20] avformat/matroskadec: Factor generic parsing of video tracks out

2023-09-04 Thread James Almer
On 9/4/2023 8:27 AM, Andreas Rheinhardt wrote: Out of matroska_parse_tracks(), that is. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 188 +- 1 file changed, 102 insertions(+), 86 deletions(-) diff --git a/libavformat/matroskadec.c b/l

[FFmpeg-devel] [PATCH 20/20] avformat/matroskadec: Factor parsing content encodings out

2023-09-04 Thread Andreas Rheinhardt
Namely, out of matroska_parse_tracks(). Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 146 +- 1 file changed, 79 insertions(+), 67 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 51c47e9404..0d6f153d18

Re: [FFmpeg-devel] [PATCH 1/2] fate/ffmpeg: Add bitexact flag for ffmpeg-input-r test

2023-09-04 Thread Anton Khirnov
Ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] swscale/x86/swscale: Process yuv2yuvX tails using next largest register size

2023-09-04 Thread Alan Kelly via ffmpeg-devel
Hi, Any issues with this patch or can it be merged? Thanks, Alan On Fri, Jul 14, 2023 at 12:08 PM Alan Kelly wrote: > --- > libswscale/x86/swscale.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index ff

[FFmpeg-devel] [PATCH 1/2] avcodec/rv34_parser: Merge RV30 and RV40 parsers

2023-09-04 Thread Andreas Rheinhardt
They do mostly the same. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 3 +-- libavcodec/parsers.c | 3 +-- libavcodec/rv34_parser.c | 16 ++-- 3 files changed, 4 insertions(+), 18 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 08f

[FFmpeg-devel] [PATCH 2/2] avcodec/rv34_parser: Remove unused ParseContext

2023-09-04 Thread Andreas Rheinhardt
This parser does not do frame packetization at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/rv34_parser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/rv34_parser.c b/libavcodec/rv34_parser.c index fbc764c64f..2997a4db70 100644 --- a/libavcodec/rv34_p

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rv34_parser: Merge RV30 and RV40 parsers

2023-09-04 Thread James Almer
On 9/4/2023 10:44 AM, Andreas Rheinhardt wrote: They do mostly the same. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 3 +-- libavcodec/parsers.c | 3 +-- libavcodec/rv34_parser.c | 16 ++-- 3 files changed, 4 insertions(+), 18 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rv34_parser: Merge RV30 and RV40 parsers

2023-09-04 Thread Andreas Rheinhardt
James Almer: > On 9/4/2023 10:44 AM, Andreas Rheinhardt wrote: >> They do mostly the same. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavcodec/Makefile  |  3 +-- >>   libavcodec/parsers.c |  3 +-- >>   libavcodec/rv34_parser.c | 16 ++-- >>   3 files changed, 4 insert

Re: [FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h

2023-09-04 Thread Michael Niedermayer
On Sat, Sep 02, 2023 at 06:21:40PM +0200, Andreas Rheinhardt wrote: > It is not necessary at all. So remove it. > This also breaks an inclusion cycle mem.h->avutil.h->common.h->mem.h. the mingw64 build seems not to like this In file included from src/libavutil/getenv_utf8.h:29:0,

[FFmpeg-devel] [PATCH v2 6/11] avutil/mem: Don't include avutil.h

2023-09-04 Thread Andreas Rheinhardt
It is not necessary at all. So remove it. This also breaks an inclusion cycle mem.h->avutil.h->common.h->mem.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/avfft.c| 7 --- libavcodec/avpacket.c | 1 + libavcodec/dirac_dwt.c| 1 + libav

Re: [FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h

2023-09-04 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Sep 02, 2023 at 06:21:40PM +0200, Andreas Rheinhardt wrote: >> It is not necessary at all. So remove it. >> This also breaks an inclusion cycle mem.h->avutil.h->common.h->mem.h. > > the mingw64 build seems not to like this > > In file included from src/libavutil/get

Re: [FFmpeg-devel] [PATCH v3 14/14] vvcdec: add full vvc decoder

2023-09-04 Thread Michael Niedermayer
On Sun, Sep 03, 2023 at 12:07:41AM +0800, Nuo Mi wrote: > vvc decoder plug-in to avcodec. > split frames into slices/tiles and send them to vvc_thread for further > decoding > reorder and wait for the frame decoding to be done and output the frame > > Features: > + Support I, P, B frames >

Re: [FFmpeg-devel] [PATCH v3 14/14] vvcdec: add full vvc decoder

2023-09-04 Thread Michael Niedermayer
On Mon, Sep 04, 2023 at 04:28:57PM +0200, Michael Niedermayer wrote: > On Sun, Sep 03, 2023 at 12:07:41AM +0800, Nuo Mi wrote: > > vvc decoder plug-in to avcodec. > > split frames into slices/tiles and send them to vvc_thread for further > > decoding > > reorder and wait for the frame decoding to

[FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-04 Thread James Almer
Changes since the previous version: - Reverted the undocumented usage of coded_side_data in decoding scenarios. - Changed the signature of some of the helpers to make them extensible. James Almer (17): avcodec/avcodec: add side data to AVCodecContext avcodec/codec_par: add side data to AVCodec

[FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: add side data to AVCodecContext

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.c | 2 + libavcodec/avcodec.h | 8 libavcodec/avpacket.c | 99 +++ libavcodec/packet.h | 68 + 4 files changed, 177 insertions(+) diff --git a/libavcodec/avcodec.c b/l

[FFmpeg-devel] [PATCH 02/17] avcodec/codec_par: add side data to AVCodecParameters

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/codec_par.c | 43 ++ libavcodec/codec_par.h | 6 ++ 2 files changed, 49 insertions(+) diff --git a/libavcodec/codec_par.c b/libavcodec/codec_par.c index a38a475dc7..a932323759 100644 --- a/libavcodec/codec_par

[FFmpeg-devel] [PATCH 03/17] avformat/avformat: use the side data from AVStream.codecpar

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavdevice/android_camera.c | 9 ++-- libavformat/avformat.c | 42 --- libavformat/avformat.h | 28 + libavformat/concatdec.c | 1 - libavformat/dashdec.c| 11 - libavformat/demux.c | 40 ++

[FFmpeg-devel] [PATCH 04/17] fftools/ffmpeg: stop using AVStream.side_data

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg_demux.c| 11 +++ fftools/ffmpeg_enc.c | 25 + fftools/ffmpeg_filter.c | 5 - fftools/ffmpeg_mux_init.c | 19 ++- 4 files changed, 34 insertions(+), 26 deletions(-) diff --git a/fftools/f

[FFmpeg-devel] [PATCH 05/17] fftools/ffplay: stop using AVStream.side_data

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffplay.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 006da7ab57..751526a2a3 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1916,8 +1916,12 @@ static int configure_video_filte

[FFmpeg-devel] [PATCH 09/17] fftools/ffmpeg: stop injecting stream side data in packets

2023-09-04 Thread James Almer
This is no longer needed as the side data is available for decoders in the AVCodecContext. The tests affected reflect the removal of useless CPB and Stereo 3D side data in packets. Signed-off-by: James Almer --- fftools/ffmpeg_demux.c| 22 --- tests/ref/fa

[FFmpeg-devel] [PATCH 06/17] fftools/ffprobe: stop using AVStream.side_data

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4fcfe1164b..28ccb45b26 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2279,16 +2279,9 @@ st

[FFmpeg-devel] [PATCH 10/17] fftools/ffplay: stop injecting stream side data in packets

2023-09-04 Thread James Almer
This is no longer needed as the side data is available for decoders in the AVCodecContext. Signed-off-by: James Almer --- fftools/ffplay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 751526a2a3..bedb33534d 100644 --- a/fftools/ffplay.c +++ b/fft

[FFmpeg-devel] [PATCH 07/17] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevcdec.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index df40c91ba6..dabfe89d4a 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -3337,8 +3337,15 @@ stat

[FFmpeg-devel] [PATCH 11/17] Revert "avcodec/mpeg12dec: Do not alter avctx->rc_buffer_size"

2023-09-04 Thread James Almer
This reverts commit eb88ccb92e05018b1060cf8126b30eeeff551d3b. Signed-off-by: James Almer --- libavcodec/mpeg12dec.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 36461a9ae6..2290a90778 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 08/17] avcodec/decode: check for global side data in AVCodecContext side data

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/decode.c | 55 + libavcodec/decode.h | 2 +- 2 files changed, 47 insertions(+), 10 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 169ee79acd..7a012ba419 100644 --- a/libavcodec/decod

[FFmpeg-devel] [PATCH 13/17] avcodec/mpeg12dec: stop propagating AVCPBProperties side data

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mpeg12dec.c| 10 ++ libavcodec/mpegvideo_parser.c | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 2290a90778..1accd07e9e 100644 --- a/libavcodec/mpeg12dec.c +++

[FFmpeg-devel] [PATCH 12/17] avformat/demux: propagate the internal decoder's bitrate properties

2023-09-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/demux.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/demux.c b/libavformat/demux.c index 553933a2b0..d7e34aad97 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -2976,6 +2976,24 @@ int avformat_find_str

[FFmpeg-devel] [PATCH 14/17] avcodec/avcodec: deprecate coded_side_data

2023-09-04 Thread James Almer
In favor of AVCodecContext.packet_side_data Signed-off-by: James Almer --- libavcodec/avcodec.c | 34 ++ libavcodec/avcodec.h | 7 ++- libavcodec/utils.c | 24 libavcodec/version_major.h | 1 + 4 files changed, 49

[FFmpeg-devel] [PATCH 16/17] avformat/demux: stop copying the internal AVCodecContext coded_side_data

2023-09-04 Thread James Almer
It's no longer needed Signed-off-by: James Almer --- libavformat/demux.c | 16 1 file changed, 16 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index d7e34aad97..4fff483d12 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -2433,19 +2433,6 @@ s

[FFmpeg-devel] [PATCH 15/17] avcodec/utils: move ff_add_cpb_side_data() to encoder code

2023-09-04 Thread James Almer
It's only used by encoders, so move it to prevent wrong usage. Signed-off-by: James Almer --- libavcodec/encode.c | 23 +++ libavcodec/encode.h | 5 + libavcodec/internal.h | 5 - libavcodec/libaomenc.c | 2 +- libavcodec/libopenh264enc.c

[FFmpeg-devel] [PATCH 17/17] fftools: stop propagating the encoder's coded_side_data

2023-09-04 Thread James Almer
It's no longer needed Signed-off-by: James Almer --- fftools/ffmpeg_enc.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 8ea572d497..503a2c033b 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -460,20 +460,6 @@

Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-04 Thread Derek Buitenhuis
On 9/4/2023 4:03 PM, James Almer wrote: > 71 files changed, 737 insertions(+), 415 deletions(-) I see no document updates, commit messages, or deprecation warnings that would: * Explain what and why this is happening - this should at the very least be in the commit message(s), if not a doc som

Re: [FFmpeg-devel] [PATCH 11/17] Revert "avcodec/mpeg12dec: Do not alter avctx->rc_buffer_size"

2023-09-04 Thread Andreas Rheinhardt
James Almer: > This reverts commit eb88ccb92e05018b1060cf8126b30eeeff551d3b. The commit message should explain why you are doing what you are doing and not only what you are doing. > > Signed-off-by: James Almer > --- > libavcodec/mpeg12dec.c | 11 +-- > 1 file changed, 5 insertions(+)

Re: [FFmpeg-devel] [PATCH] MULTI VLC decoding boost

2023-09-04 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fate: add rka test

2023-09-04 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-04 Thread James Almer
On 9/4/2023 12:37 PM, Derek Buitenhuis wrote: On 9/4/2023 4:03 PM, James Almer wrote: 71 files changed, 737 insertions(+), 415 deletions(-) I see no document updates, commit messages, or deprecation warnings that would: * Explain what and why this is happening - this should at the very l

Re: [FFmpeg-devel] [PATCH] fate: add rka test

2023-09-04 Thread Michael Niedermayer
On Fri, Sep 01, 2023 at 07:40:14PM +0200, Paul B Mahol wrote: > Patch attached. > fate/lossless-audio.mak |3 +++ > ref/fate/lossless-rka |1 + > 2 files changed, 4 insertions(+) > 0f3f84b5dce589a41a0abc1f1c70376363078b2b 0001-fate-add-rka-test.patch > From 74bd7f508208a3631f2587416735

Re: [FFmpeg-devel] [PATCH] avcodec/tta: fix signed overflow in decorrelate

2023-09-04 Thread Michael Niedermayer
On Sat, Aug 05, 2023 at 07:51:48PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2079654542 - -139267653 cannot be represented > in type 'int' > Fixes: > 60811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5915858409750528 > > Found-by: continuous fuzzing pro

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option

2023-09-04 Thread Michael Niedermayer
On Sat, Jun 10, 2023 at 08:31:09PM +0200, Michael Niedermayer wrote: > jpeg2000 overrides the global lowres variable with a lowres field called > reduction_factor > ffmpeg -lowres X causes the reduction_factor to be set > ffplay -lowres X causes both lowres and the reduction_factor to be set > oss

[FFmpeg-devel] [PATCH] avcodec/bonk: Fix integer overflow in predictor_calc_error()

2023-09-04 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483300 - 12285 cannot be represented in type 'int' Fixes: 59462/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-5714298807386112 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: adjust threshold for RKA

2023-09-04 Thread Michael Niedermayer
On Fri, Jun 02, 2023 at 12:25:59AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 59349/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-5334280839233536 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

[FFmpeg-devel] [PATCH] metal: Add hint to select low power device instead of the default one

2023-09-04 Thread Jérémy Demeule
SDL >= 2.28.3 introduce a renderer hint to allow selection of low-power device on default macOS backend (i.e. metal). On some system like MacBook Pro Intel with AMD card, asking for the default device will always return the AMD GPU. This is not an issue for 99% of the case when the renderer cont

Re: [FFmpeg-devel] [PATCH 1/3] swscale/x86/swscale: Process yuv2yuvX tails using next largest register size

2023-09-04 Thread Michael Niedermayer
On Mon, Sep 04, 2023 at 02:30:00PM +0200, Alan Kelly via ffmpeg-devel wrote: > Hi, > > Any issues with this patch or can it be merged? are all cases covered by tests ? if yes and the tests pass, it should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FA

[FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: add side data to AVCodecContext

2023-09-04 Thread James Almer
This will allow the propagation of global side data within the AVCodecContext instead of having to do it inside packets, and thus be available during init(). Global and frame specific side data will therefore be distinct. Signed-off-by: James Almer --- libavcodec/avcodec.c | 2 + libavcodec/av

[FFmpeg-devel] [PATCH 03/17] avformat/avformat: use the side data from AVStream.codecpar

2023-09-04 Thread James Almer
Deprecate AVStream.side_data and its helpers in favor of the AVStream's codecpar.side_data. This will considerably simplify the propagation of side data to decoders and from encoders. Signed-off-by: James Almer --- libavdevice/android_camera.c | 9 ++-- libavformat/avformat.c | 42 ---

[FFmpeg-devel] [PATCH 11/17] Revert "avcodec/mpeg12dec: Do not alter avctx->rc_buffer_size"

2023-09-04 Thread James Almer
This reverts commit eb88ccb92e05018b1060cf8126b30eeeff551d3b. AVCodecContext fields are the proper place for a decoder to export such values. This change is in preparation for the following commits. Signed-off-by: James Almer --- libavcodec/mpeg12dec.c | 11 +-- 1 file changed, 5 insert

[FFmpeg-devel] [PATCH 12/17] avformat/demux: propagate the internal decoder's bitrate properties

2023-09-04 Thread James Almer
Muxers may access this information through cpb properties within the stream's side data. Signed-off-by: James Almer --- libavformat/demux.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/demux.c b/libavformat/demux.c index 94128b00bc..606ccbd180 100644 --- a/

[FFmpeg-devel] [PATCH 14/17] avcodec/avcodec: deprecate coded_side_data

2023-09-04 Thread James Almer
In favor of AVCodecContext.packet_side_data Signed-off-by: James Almer --- libavcodec/avcodec.c | 34 ++ libavcodec/avcodec.h | 8 +++- libavcodec/utils.c | 24 libavcodec/version_major.h | 1 + 4 files changed, 5

[FFmpeg-devel] [PATCH] Changelog: Add Support hevc, vp9, av1 codec fourcclist in enhanced rtmp protocol

2023-09-04 Thread Steven Liu
Signed-off-by: Steven Liu --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 6c2622dc4e..0cfcecfb93 100644 --- a/Changelog +++ b/Changelog @@ -31,6 +31,7 @@ version : - Support HEVC,VP9,AV1 codec in enhanced flv format - apsnr and asisdr audio filters

[FFmpeg-devel] [PATCH 1/2] avcodec/vmixdec: Fix signed integer overflow in dc

2023-09-04 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483181 + 1024 cannot be represented in type 'int' Fixes: 61117/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-5387692433866752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266_syntax_template: Check num_multi_layer_olss

2023-09-04 Thread Michael Niedermayer
The constraints in the specification are self contradictionary if num_multi_layer_olss is 0 That is they require various variables to be positive and smaller than 0. So num_multi_layer_olss cannot be 0 if vps_each_layer_is_an_ols_flag is 0 Its quite possible a broader check can be used, this is j

Re: [FFmpeg-devel] [PATCH v4 7/8] lavc/vaapi_encode: Add VAAPI AV1 encoder

2023-09-04 Thread Wang, Fei W
On Thu, 2023-08-31 at 15:21 +0800, fei.w.w...@intel.com wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > Fixed the discussions in V3. @Mark, any more comment on this version? Thanks > > Changelog | 1 + > configure | 3 + > doc/encoders

Re: [FFmpeg-devel] [PATCH] Changelog: Add Support hevc, vp9, av1 codec fourcclist in enhanced rtmp protocol

2023-09-04 Thread Jean-Baptiste Kempf
On Tue, 5 Sep 2023, at 03:17, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index 6c2622dc4e..0cfcecfb93 100644 > --- a/Changelog > +++ b/Changelog > @@ -31,6 +31,7 @@ version : > - Support HEVC