[FFmpeg-devel] [PATCH v2 0/8] avfilter: cleanup openvino

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili v2: rebase on master. Please pay attension that there are a lot memleaks I don't have time to fix. With only 100 seconds of video clip, it leaks: SUMMARY: AddressSanitizer: 1416800 byte(s) leaked in 27808 allocation(s). Zhao Zhili (8): avfilter/dnn_filter_common: fix memleak

[FFmpeg-devel] [PATCH v2 1/8] avfilter/dnn_filter_common: fix memleak

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn_filter_common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/dnn_filter_common.c b/libavfilter/dnn_filter_common.c index d175c91914..3b9182c1d1 100644 --- a/libavfilter/dnn_filter_common.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH v2 2/8] avfilter/dnn_backend_openvino: fix multiple memleaks

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 4922833b07..951f179b7c 100644 --- a/libavfilt

[FFmpeg-devel] [PATCH v2 3/8] avfilter/dnn_backend_openvino: reduce indentation in free_model_ov

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili No functional changes except ensures model isn't null. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 89 +- 1 file changed, 46 insertions(+), 43 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dn

[FFmpeg-devel] [PATCH v2 5/8] avfilter/dnn_backend_openvino: fix leak or ov_core_t on error path

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 7150bf0886..b3910adfc3 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/

[FFmpeg-devel] [PATCH v2 7/8] avfilter/dnn_backend_openvino: fix input_port/output_port leaks

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index f9944211da..5de27719b2 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH v2 6/8] avfilter/dnn_backend_openvino: fix leak of ov_shape_t

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index b3910adfc3..f9944211da 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c

[FFmpeg-devel] [PATCH v2 8/8] avfilter/dnn_backend_openvino: fix wild pointer on error path

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili When ov_model_const_input_by_name/ov_model_const_output_by_name failed, input_port/output_port can be wild pointer. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn

[FFmpeg-devel] [PATCH v2 4/8] avfilter/dnn_backend_openvino: fix use uninitialized values

2023-09-02 Thread Zhao Zhili
From: Zhao Zhili Error handling was broken since neither `ret` nor `task` has being initialized on error path. --- libavfilter/dnn/dnn_backend_openvino.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn

Re: [FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function

2023-09-02 Thread Andreas Rheinhardt
Stefano Sabatini: > +static void print_frame_side_data(WriterContext *w, > + AVFrame *frame, > + AVStream *stream) I am pretty sure both frame and stream can be constified. > +{ > +int i; We support C99 variable declarations i

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Carotti, Elias via ffmpeg-devel
On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > In particular why are you turning on fast_pskip silently based on a > > completely different setting? > > The patch is fixing the regression introduced by the unconditional > setting of b_fast_pskip. > > Now the question is if

[FFmpeg-devel] [PATCH] avformat/avformat: Avoid including codec.h, frame.h

2023-09-02 Thread Andreas Rheinhardt
AVCodec is only ever used as an incomplete type (i.e. via a pointer to an AVCodec) in avformat.h and it is not really part of the core of avformat.h or libavformat; almost none of our internal users make use of it (and none make use of hwcontext.h, which is implicitly included). So switch to use st

Re: [FFmpeg-devel] [PATCH v4 06/13] avutil/frame: add helper for adding side data to set

2023-09-02 Thread James Almer
On 9/1/2023 5:38 PM, Jan Ekström wrote: Additionally, add an API test to check that the no-duplicates addition works after duplicates have been inserted. --- libavutil/Makefile | 1 + libavutil/frame.c | 18 ++ libavutil/frame.h | 20 +++ lib

Re: [FFmpeg-devel] [PATCH v4 03/13] avutil/frame: add helper for uninitializing side data sets

2023-09-02 Thread James Almer
On 9/1/2023 5:38 PM, Jan Ekström wrote: --- libavutil/frame.c | 5 + libavutil/frame.h | 8 2 files changed, 13 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4b8481b756..b03f8d6c73 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -90,6 +90,11 @@

Re: [FFmpeg-devel] [PATCH v4 08/13] avutil/frame: add helper for extending a set of side data

2023-09-02 Thread James Almer
On 9/1/2023 5:38 PM, Jan Ekström wrote: Additionally, extend the side data set FATE test to check for the invalid use case of extending a set by itself. --- libavutil/frame.c | 32 libavutil/frame.h | 15 +++ libavutil/t

Re: [FFmpeg-devel] [PATCH v4 07/13] avutil/frame: add helper for getting side data from set

2023-09-02 Thread James Almer
On 9/1/2023 5:38 PM, Jan Ekström wrote: --- libavutil/frame.c | 22 +- libavutil/frame.h | 12 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index f64ddb3645..5f74e0172b 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] Review and fix doc/examples/transcode.c - version 2

2023-09-02 Thread Stefano Sabatini
Apply various fixes to transcode.c, with some bonus patches fixing a typo and adding some debug logs in the aresample filter. In particular fixes: http://trac.ffmpeg.org/ticket/5849 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.or

[FFmpeg-devel] [PATCH 02/11] lavfi/aresample: show time_base information during setup

2023-09-02 Thread Stefano Sabatini
--- libavfilter/af_aresample.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c index f4bcc45616..b71ed5b91c 100644 --- a/libavfilter/af_aresample.c +++ b/libavfilter/af_aresample.c @@ -28,6 +28,7 @@ #include "libav

[FFmpeg-devel] [PATCH 04/11] doc/examples/transcode: factorize codec_type definition

2023-09-02 Thread Stefano Sabatini
--- doc/examples/transcode.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 81a88dd577..3c57fb36c9 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -82,6 +82,7 @@ static int open_input_file

[FFmpeg-devel] [PATCH 03/11] doc/examples/transcode: apply style fixes

2023-09-02 Thread Stefano Sabatini
--- doc/examples/transcode.c | 97 +--- 1 file changed, 50 insertions(+), 47 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index ed6ac9fa03..81a88dd577 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -82,1

[FFmpeg-devel] [PATCH 01/11] lavc/avcodec.h: fix typos in AVCodecContext.pkt_timebase description

2023-09-02 Thread Stefano Sabatini
--- libavcodec/avcodec.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 649411ac79..070e36795d 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1794,9 +1794,9 @@ typedef struct AVCodecContext { enum A

[FFmpeg-devel] [PATCH 05/11] doc/examples/transcode: improve reporting when the encoder is not found

2023-09-02 Thread Stefano Sabatini
Also return EINVAL in place of INVALIDDATA. --- doc/examples/transcode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 3c57fb36c9..dd64c38f15 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@

[FFmpeg-devel] [PATCH 09/11] doc/examples/transcode: fix timestamps scaling

2023-09-02 Thread Stefano Sabatini
Set pkt_timebase in the decoder and in the decoded frame, use it for the filterchain source, and rescale the filtered frame to the target encoder time_base. This fixes filtering in case the time base was not set in the decoder, causing the error: [in @ 0x5647fc26ec80] Invalid time base 0/1 --- do

[FFmpeg-devel] [PATCH 10/11] doc/examples/transcode: simplify selection of pix_fmt

2023-09-02 Thread Stefano Sabatini
Use ternary operator. --- doc/examples/transcode.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 524bb47f50..1d22a4b09e 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -178,11 +178,10 @

[FFmpeg-devel] [PATCH 08/11] doc/examples/transcode: use more meaningful labels for filtergraph sinks and sources

2023-09-02 Thread Stefano Sabatini
--- doc/examples/transcode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 5671c6664b..b94fdbede2 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -280,14 +280,14 @@ static int init_filte

[FFmpeg-devel] [PATCH 06/11] doc/examples/transcode: use av_buffersrc_add_frame()

2023-09-02 Thread Stefano Sabatini
Favor it over av_buffersrc_add_frame_flags, simplify. --- doc/examples/transcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index dd64c38f15..21ea14b614 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode

[FFmpeg-devel] [PATCH 11/11] doc/examples/transcode: fix selection of sample format if not set in encoder

2023-09-02 Thread Stefano Sabatini
Fix crash occurring when the list of sample formats is not defined in the encoder, use the decoder one in that case. Possibly fix issue: http://trac.ffmpeg.org/ticket/5849 --- doc/examples/transcode.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcod

[FFmpeg-devel] [PATCH 07/11] doc/examples/transcode: introduce timestamp logging

2023-09-02 Thread Stefano Sabatini
Aid timestamp debugging. --- doc/examples/transcode.c | 43 +++- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 21ea14b614..5671c6664b 100644 --- a/doc/examples/transcode.c +++ b/doc/examp

Re: [FFmpeg-devel] [PATCH 1/6] libavcodec/avcodec.h: fix typos in AVCodecContext.pkt_timebase description

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 01:14:42 +0200, Stefano Sabatini wrote: > --- > libavcodec/avcodec.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patchset dropped in favor of version 2. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 10:33:12 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > +static void print_frame_side_data(WriterContext *w, > > + AVFrame *frame, > > + AVStream *stream) > > I am pretty sure both frame and str

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 09:20:08 +, Carotti, Elias wrote: > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > In particular why are you turning on fast_pskip silently based on a > > > completely different setting? > > > > The patch is fixing the regression intro

Re: [FFmpeg-devel] [PATCH v4 08/13] avutil/frame: add helper for extending a set of side data

2023-09-02 Thread James Almer
On 9/1/2023 5:38 PM, Jan Ekström wrote: Additionally, extend the side data set FATE test to check for the invalid use case of extending a set by itself. --- libavutil/frame.c | 32 libavutil/frame.h | 15 +++ libavutil/t

[FFmpeg-devel] [PATCH v3 01/14] vvcdec: add vvc decoder stub

2023-09-02 Thread Nuo Mi
--- configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/vvc/Makefile | 4 + libavcodec/vvc/vvcdec.c | 84 +++ libavcodec/vvc/vvcdec.h | 307 6 files changed, 398 insertions(+) create mode

[FFmpeg-devel] [PATCH v3 05/14] vvcdec: add reference management

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvc_refs.c | 526 ++ libavcodec/vvc/vvc_refs.h | 47 3 files changed, 575 insertions(+), 1 deletion(-) create mode 100644 libavcodec/vvc/vvc_refs.c create mode 100644 libavcodec/vvc/vvc_refs.h diff

[FFmpeg-devel] [PATCH v3 03/14] vvcdec: add parameter parser for sps, pps, ph, sh

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile |3 +- libavcodec/vvc/vvc_ps.c | 1325 +++ libavcodec/vvc/vvc_ps.h | 274 libavcodec/vvc/vvcdec.h |4 + 4 files changed, 1605 insertions(+), 1 deletion(-) create mode 100644 libavcodec/vvc/vvc_ps.c create mode 1006

[FFmpeg-devel] [PATCH v3 13/14] vvcdec: add CTU thread logical

2023-09-02 Thread Nuo Mi
This is the main entry point for the CTU (Coding Tree Unit) decoder. The code will divide the CTU decoder into several stages. It will check the stage dependencies and run the stage decoder. --- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvc_thread.c | 805 +++

[FFmpeg-devel] [PATCH v3 04/14] vvcdec: add cabac decoder

2023-09-02 Thread Nuo Mi
add Context-based Adaptive Binary Arithmetic Coding (CABAC) decoder --- libavcodec/vvc/Makefile|2 + libavcodec/vvc/vvc_cabac.c | 2484 libavcodec/vvc/vvc_cabac.h | 126 ++ libavcodec/vvc/vvc_ctu.c | 32 + libavcodec/vvc/vvc_ctu.h | 406 ++

[FFmpeg-devel] [PATCH v3 06/14] vvcdec: add motion vector decoder

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile |1 + libavcodec/vvc/vvc_ctu.c | 20 +- libavcodec/vvc/vvc_ctu.h |2 + libavcodec/vvc/vvc_mvs.c | 1806 ++ libavcodec/vvc/vvc_mvs.h | 46 + 5 files changed, 1874 insertions(+), 1 deletion(-) create mode 100644 libavcodec

[FFmpeg-devel] [PATCH v3 07/14] vvcdec: add inter prediction

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile |1 + libavcodec/vvc/vvc_inter.c | 973 + libavcodec/vvc/vvc_inter.h | 42 ++ libavcodec/vvc/vvc_inter_template.c | 1034 +++ libavcodec/vvc/vvcdec.h |2 + libavcodec/vv

[FFmpeg-devel] [PATCH v3 09/14] vvcdec: add intra prediction

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile |3 +- libavcodec/vvc/vvc_ctu.c| 39 + libavcodec/vvc/vvc_ctu.h|2 + libavcodec/vvc/vvc_intra.c | 768 libavcodec/vvc/vvc_intra.h | 49 ++ libavcodec/vvc/vvc_intra_template.c | 1015

[FFmpeg-devel] [PATCH v3 11/14] vvcdec: add dsp init and inv transform

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile | 1 + libavcodec/vvc/vvcdsp.c | 133 +++ libavcodec/vvc/vvcdsp_template.c | 120 3 files changed, 254 insertions(+) create mode 100644 libavcodec/vvc/vvcdsp.c create mode 100644 libavcodec/v

[FFmpeg-devel] [PATCH v3 12/14] vvcdec: add CTU parser

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c | 2398 +- libavcodec/vvc/vvc_ctu.h | 11 + 2 files changed, 2404 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index d46a522a0d..a212d3a44a 100644 --- a/libavcodec/vvc/vvc_ctu.c ++

[FFmpeg-devel] [PATCH v3 08/14] vvcdec: add inv transform 1d

2023-09-02 Thread Nuo Mi
--- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvc_itx_1d.c | 713 libavcodec/vvc/vvc_itx_1d.h | 52 +++ 3 files changed, 767 insertions(+), 1 deletion(-) create mode 100644 libavcodec/vvc/vvc_itx_1d.c create mode 100644 libavcodec/vvc/vvc_itx_1d.h

[FFmpeg-devel] [PATCH v3 14/14] vvcdec: add full vvc decoder

2023-09-02 Thread Nuo Mi
vvc decoder plug-in to avcodec. split frames into slices/tiles and send them to vvc_thread for further decoding reorder and wait for the frame decoding to be done and output the frame Features: + Support I, P, B frames + Support 8/10/12 bits, chroma 400, 420, 422, and 444 and range extensi

Re: [FFmpeg-devel] [PATCH v4 10/13] ffmpeg: pass first video AVFrame's side data to encoder

2023-09-02 Thread James Almer
On 9/1/2023 5:38 PM, Jan Ekström wrote: This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/fftools/ffmpeg_enc

Re: [FFmpeg-devel] [PATCH v3 14/14] vvcdec: add full vvc decoder

2023-09-02 Thread Nuo Mi
On Sun, Sep 3, 2023 at 12:08 AM Nuo Mi wrote: > vvc decoder plug-in to avcodec. > split frames into slices/tiles and send them to vvc_thread for further > decoding > reorder and wait for the frame decoding to be done and output the frame > > Features: > + Support I, P, B frames > + Suppor

[FFmpeg-devel] [PATCH 3/7] avformat/mux: Only write HEADER marker if format has .write_header

2023-09-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index fff8094341..0cf9ebfc19 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -464,9 +464,9 @@ int avformat_write_header(A

[FFmpeg-devel] [PATCH 4/7] avformat/aviobuf: Add ffio_init_(read|write)_context()

2023-09-02 Thread Andreas Rheinhardt
Most users of ffio_init_context() simply want to wrap a buffer into an AVIOContext; they do not provide function pointers at all. Therefore this commit adds shortcuts for these two common operations. This also allows to accept const data when reading (i.e. the const is now cast away at a central p

[FFmpeg-devel] [PATCH 5/7] avutil: Move error.h from avutil.h to common.h

2023-09-02 Thread Andreas Rheinhardt
Up until now, avutil.h includes common.h which includes mem.h which includes avutil.h, so that all these headers are in fact equivalent. Yet mem.h does not need to include avutil.h at all and when it no longer does, including common.h will no longer include error.h (included by avutil.h) as well; c

[FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h

2023-09-02 Thread Andreas Rheinhardt
It is not necessary at all. So remove it. This also breaks an inclusion cycle mem.h->avutil.h->common.h->mem.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/avfft.c | 7 --- libavcodec/avpacket.c | 1 + libavcodec/dirac_dwt.c | 1 + libavcodec/ffjni.c

[FFmpeg-devel] [PATCH 7/7] avutil/avstring: Remove obsolete version.h inclusion

2023-09-02 Thread Andreas Rheinhardt
Forgotten in 30e1e7e0f324d7bf66b3b8583a3e49fd3cd101b2. Signed-off-by: Andreas Rheinhardt --- libavutil/avstring.c | 1 - libavutil/avstring.h | 1 - libavutil/spherical.c | 1 + 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c index e460

[FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP

2023-09-02 Thread Alessandro Ros
In order to send VP9 tracks with RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted into a metadata message. However, the function responsible for generating vpcCs currently returns invalid boxes, that are lacking the Version and

[FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP

2023-09-02 Thread Alessandro Ros
In order to send VP9 tracks with RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted into a metadata message. However, the function responsible for generating vpcCs currently returns invalid boxes, that are lacking the Version and

Re: [FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP

2023-09-02 Thread James Almer
On 9/2/2023 2:02 PM, Alessandro Ros wrote: In order to send VP9 tracks with RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted into a metadata message. However, the function responsible for generating vpcCs currently returns inv

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-09-02 Thread Michael Niedermayer
On Fri, Sep 01, 2023 at 08:10:11PM +0300, Rémi Denis-Courmont wrote: > Le torstaina 31. elokuuta 2023, 18.28.48 EEST Stefano Sabatini a écrit : > > On date Tuesday 2023-08-29 10:34:45 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2023-08-27 14:38:44) > > > > > > > Il sab 26 ago 2023,

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-02 Thread Michael Niedermayer
On Fri, Sep 01, 2023 at 08:38:26PM +0200, Stefano Sabatini wrote: > On date Friday 2023-09-01 18:54:40 +0200, Michael Niedermayer wrote: > > On Thu, Aug 31, 2023 at 07:16:20PM +0200, Stefano Sabatini wrote: > [...] > > > +/** > > > + * Compute and return a normalized Gaussian vector. > > > + * > >

[FFmpeg-devel] [PATCH 8/8] all: Replace __FUNCTION__ by __func__

2023-09-02 Thread Andreas Rheinhardt
Only the former is valid ISO C. Signed-off-by: Andreas Rheinhardt --- libavdevice/opengl_enc.c | 2 +- libavformat/apngdec.c| 2 +- libavformat/demux.c | 4 ++-- libavformat/mux.c| 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavdevice/opengl_enc.c b/li

[FFmpeg-devel] [PATCH 9/9] avcodec/vp8data: Use <> for inclusion of stdint.h

2023-09-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp8data.c b/libavcodec/vp8data.c index a41fc872f5..857406928a 100644 --- a/libavcodec/vp8data.c +++ b/libavcodec/vp8data.c @@ -16,7 +16,7 @@ * Foundation, In

Re: [FFmpeg-devel] [PATCH 8/8] all: Replace __FUNCTION__ by __func__

2023-09-02 Thread James Almer
On 9/2/2023 8:12 PM, Andreas Rheinhardt wrote: Only the former is valid ISO C. Don't you mean "the latter"? Signed-off-by: Andreas Rheinhardt --- libavdevice/opengl_enc.c | 2 +- libavformat/apngdec.c| 2 +- libavformat/demux.c | 4 ++-- libavformat/mux.c| 2 +- 4 fil

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 22:07:53 +0200, Michael Niedermayer wrote: > On Fri, Sep 01, 2023 at 08:38:26PM +0200, Stefano Sabatini wrote: > > On date Friday 2023-09-01 18:54:40 +0200, Michael Niedermayer wrote: > > > On Thu, Aug 31, 2023 at 07:16:20PM +0200, Stefano Sabatini wrote: > > [...] > > >