[FFmpeg-devel] [PATCH] avformat/mp3dec:Subtract known padding from duration

When an Info-tag is present, marking initial and trailing samples as padding, those samples should not be included in the calculation of track duration. This solves a surprising user experience where converting a WAV->MP3->WAV, ffprobe will show the duration of the mp3 as slightly longer than both

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

On Thu, Aug 17, 2023 at 12:42 AM Rémi Denis-Courmont wrote: > Le tiistaina 15. elokuuta 2023, 17.50.13 EEST Nuo Mi a écrit : > > The executor design pattern was inroduced by java > > < > https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/conc > > urrent/Executor.html> it also

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

> > >> +if (pthread_create(&ti->thread, NULL, executor_worker_task, > ti)) > > executor_worker_task() doesn't exist if !HAVE_THREADS, so like i said > above, wrap this for loop. > Not needed since pthread_create is defined to 0 > > ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

> > > > > + > > +#if !HAVE_THREADS > > +#define pthread_create(t, a, s, ar) 0 > > +#define pthread_join(t, r) do {} while(0) > > + > > +#define pthread_cond_init(c, a) 0 > > +#define pthread_cond_broadcast(c) do {} while(0) > > +#define pthread_cond_signal(c)

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

On 8/22/2023 9:03 AM, Nuo Mi wrote: On Thu, Aug 17, 2023 at 12:42 AM Rémi Denis-Courmont wrote: Le tiistaina 15. elokuuta 2023, 17.50.13 EEST Nuo Mi a écrit : The executor design pattern was inroduced by java < https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/conc urre

Re: [FFmpeg-devel] [RFC PATCH] avutil/avutil: make AV_TIME_BASE_Q available in C++

Quoting Zhao Zhili (2023-08-18 20: 11:31) > From: Zhao Zhili Date: Tue, 22 Aug 2023 14:29:44 +0200 Message-ID: <169270738483.26513.18411031229205897...@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 > > It still different than AV_TIME_BASE_Q in C, like you cannot take > address of AV

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

On Tue, Aug 22, 2023 at 8:23 PM James Almer wrote: > On 8/22/2023 9:03 AM, Nuo Mi wrote: > > On Thu, Aug 17, 2023 at 12:42 AM Rémi Denis-Courmont > > wrote: > > > >> Le tiistaina 15. elokuuta 2023, 17.50.13 EEST Nuo Mi a écrit : > >>> The executor design pattern was inroduced by java > >>> < > >

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

On 8/22/2023 9:30 AM, Nuo Mi wrote: On Tue, Aug 22, 2023 at 8:23 PM James Almer wrote: On 8/22/2023 9:03 AM, Nuo Mi wrote: On Thu, Aug 17, 2023 at 12:42 AM Rémi Denis-Courmont wrote: Le tiistaina 15. elokuuta 2023, 17.50.13 EEST Nuo Mi a écrit : The executor design pattern was inroduced b

Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV

On Mon, Aug 21, 2023 at 9:49 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Actually, x264 allows to select only eight or ten bit bitdepth (or both) > at configure-time. IIRC opening the encoder will fail if an eight-bit > only libx264 is used when one tries to use a 10bit pixel

[FFmpeg-devel] [PATCH v5] vvcdec: add thread executor

The executor design pattern was inroduced by java it also adapted by python Compared to handcrafted thread pool management, it greatly simpli

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

On Tue, Aug 22, 2023 at 8:32 PM James Almer wrote: > > >>> > >> > > "mem.h"->"avutil.h"->"common.h"->""->""->"" > >> > >> Why would bits/pthreadtypes.h be available if there's no pthreads? > >> > > I guess it is related to POSIX. If you check , you will find > > the following code: > > > > /* N

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

On Thu, Aug 17, 2023 at 12:36 AM Michael Niedermayer wrote: > On Tue, Aug 15, 2023 at 10:50:13PM +0800, Nuo Mi wrote: > > The executor design pattern was inroduced by java > > < > https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/concurrent/Executor.html > > > > it also adapt

Re: [FFmpeg-devel] [PATCH v1 3/6] swscale: Add explicit rgb24->yv12 conversion

On Mon, 21 Aug 2023 21:15:37 +0200, you wrote: >On Sun, Aug 20, 2023 at 07:28:40PM +0100, John Cox wrote: >> On Sun, 20 Aug 2023 19:45:11 +0200, you wrote: >> >> >On Sun, Aug 20, 2023 at 07:16:14PM +0200, Michael Niedermayer wrote: >> >> On Sun, Aug 20, 2023 at 03:10:19PM +, John Cox wrote: >

Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV

Vittorio Giovara: > On Mon, Aug 21, 2023 at 9:49 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Actually, x264 allows to select only eight or ten bit bitdepth (or both) >> at configure-time. IIRC opening the encoder will fail if an eight-bit >> only libx264 is used when one

Re: [FFmpeg-devel] [PATCH v1 3/6] swscale: Add explicit rgb24->yv12 conversion

On Tue, Aug 22, 2023 at 03:24:17PM +0100, John Cox wrote: > On Mon, 21 Aug 2023 21:15:37 +0200, you wrote: [...] > >> I can get to simple bilinear without adding so much complexity that I > >> lose the speed I need - would that be OK? > > > >Not sure simple bilinear is 100% clearly defined > >I thi

Re: [FFmpeg-devel] [PATCH] fate/matroska: Stop using unicode in command line paramters

On Mon, 21 Aug 2023, Martin Storsjö wrote: The fate-run.sh shell script exports LC_ALL=C before invoking the test executables; this is probably done for consistency. When executing Windows binaries with Wine, it normally handles UTF-8 command line parameters just fine - but with LC_ALL set to C

Re: [FFmpeg-devel] [PATCH v3 10/12] avcodec/libsvtav1: add support for writing out CLL and MDCV

On Tue, Aug 22, 2023 at 12:59 AM Andreas Rheinhardt wrote: > > Jan Ekström: > > On Sun, Aug 20, 2023 at 10:10 AM Andreas Rheinhardt > > wrote: > >> > >> Jan Ekström: > >>> These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 > >>> and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for versi