Re: [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec

2023-07-29 Thread Hendrik Leppkes
On Sat, Jul 29, 2023 at 2:26 AM Steven Liu wrote: > > read fourcc for video codec after VideoTagHeader read. > passed as parameter to flv_same_video_codec. > Add the same parameter to flv_set_video_codec, and then you can remove the entire backwards seek and just read it and adjust the size like

Re: [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec

2023-07-29 Thread Marton Balint
On Sat, 29 Jul 2023, Hendrik Leppkes wrote: On Sat, Jul 29, 2023 at 2:26 AM Steven Liu wrote: read fourcc for video codec after VideoTagHeader read. passed as parameter to flv_same_video_codec. Add the same parameter to flv_set_video_codec, and then you can remove the entire backwards se

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: remove usage of deprecated fields

2023-07-29 Thread Xiang, Haihao
On Sa, 2023-07-29 at 00:35 -0300, James Almer wrote: > Added by mistake in 88b3841149b9f41d6c5ec7930dcd5c6caf28b198. > > Signed-off-by: James Almer > --- >  libavfilter/qsvvpp.c | 9 +++-- >  1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/qsvvpp.c b/libavfilter/q

Re: [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec

2023-07-29 Thread Hendrik Leppkes
On Sat, Jul 29, 2023 at 10:46 AM Marton Balint wrote: > > > > On Sat, 29 Jul 2023, Hendrik Leppkes wrote: > > > On Sat, Jul 29, 2023 at 2:26 AM Steven Liu wrote: > >> > >> read fourcc for video codec after VideoTagHeader read. > >> passed as parameter to flv_same_video_codec. > >> > > > > Add the

Re: [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec

2023-07-29 Thread Hendrik Leppkes
On Sat, Jul 29, 2023 at 11:54 AM Hendrik Leppkes wrote: > > On Sat, Jul 29, 2023 at 10:46 AM Marton Balint wrote: > > > > > > > > On Sat, 29 Jul 2023, Hendrik Leppkes wrote: > > > > > On Sat, Jul 29, 2023 at 2:26 AM Steven Liu wrote: > > >> > > >> read fourcc for video codec after VideoTagHeader

Re: [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec

2023-07-29 Thread Steven Liu
Marton Balint 于2023年7月29日 周六16:45写道: > > > On Sat, 29 Jul 2023, Hendrik Leppkes wrote: > > > On Sat, Jul 29, 2023 at 2:26 AM Steven Liu wrote: > >> > >> read fourcc for video codec after VideoTagHeader read. > >> passed as parameter to flv_same_video_codec. > >> > > > > Add the same parameter to

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-07-29 Thread Reimar Döffinger
> On 27 Jul 2023, at 19:44, Nicolas George wrote: > > Reimar Döffinger (12023-07-27): >> Thanks, sent a new version with that updated, plus a fix for a typo >> in the commit message. > > If it is all you have changed, then I do not think I need to look at it > again. > > I do not maintain most

Re: [FFmpeg-devel] [PATCH] hevcdsp_idct_neon.S: Avoid unnecessary mov.

2023-07-29 Thread Reimar Döffinger
> On 26 Jul 2023, at 21:15, reimar.doeffin...@gmx.de wrote: > > From: Reimar Döffinger > > ret can be given an argument instead. > This is also consistent with how other assembler code > in FFmpeg does it. Now pushed. ___ ffmpeg-devel mailing list ff

[FFmpeg-devel] [PATCH] avformat/lrcdec: Fix declaration-after-statement warning

2023-07-29 Thread Andreas Rheinhardt
Happens since c0f867bf503e79eba8ee52e1ac53322f88ec2929. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavformat/lrcdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/lrcdec.c b/libavformat/lrcdec.c index 83bb4a4b75..f43e9dccf5 100644 --- a

[FFmpeg-devel] [PATCH] avformat/flvdec: handle exheader fourcc correctly in metadata

2023-07-29 Thread Marton Balint
In metadata fourcc is carried in the AMF number, not as binary. Partially based on a patch by Steven Liu. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 76 +--- 1 file changed, 30 insertions(+), 46 deletions(-) diff --git a/libavformat/flvdec.c

[FFmpeg-devel] [PATCH] avdevice: Fix disabling audiotoolbox_outdev build on iOS

2023-07-29 Thread L. E. Segovia
audiotoolbox.m uses CoreAudio APIs that are only available in macOS. The existing CoreAudio framework check is already enough for this case (as CoreAudio.h does not exist for the iDevices), however, it was never passed as a dependency of audiotoolbox_outdev. This caused the build system to include

[FFmpeg-devel] [PATCH v2] os_support, network: Fix build failure on Windows with BZIP2

2023-07-29 Thread L. E. Segovia
Including winsock2.h without WIN32_LEAN_AND_MEAN causes bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h (included transitively from windows.h). See: https://stackoverflow.com/a/27794577 Signed-off-by: L. E. Segovia --- libavformat/network.h| 1 + libavforma

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-29 Thread L. E. Segovia
Hi all, Yes, the linking step bails out with optimizations disabled under MSVC. The rest of the compilers perform DCE even at -O0, but under Windows, the /FORCE:UNRESOLVED linker flag is needed to work around this. As for the stub generation -- given the amount of places that these patches touch

[FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS

2023-07-29 Thread L. E. Segovia
audiotoolbox.m uses CoreAudio APIs that are only available in macOS. The existing CoreAudio framework check is already enough for this case (as CoreAudio.h does not exist for the iDevices), however, it was never passed as a dependency of audiotoolbox_outdev. This caused the build system to include

[FFmpeg-devel] [PATCH v5 0/4] Fix MSVC build without optimizations

2023-07-29 Thread L. E. Segovia
Sending again to fix the format=flowed mishap. L. E. Segovia (4): all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

[FFmpeg-devel] [PATCH v5 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

2023-07-29 Thread L. E. Segovia
Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/fdctdsp_init.c| 2 + libavcodec/x86/flacdsp_init.c| 8 +- libavcodec/x86/hevcdsp_init.c| 547 ++- libavc

[FFmpeg-devel] [PATCH v5 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO

2023-07-29 Thread L. E. Segovia
Continuation of e42aaaf92a4b0c88d60acc12df64c81d0887c26f Signed-off-by: L. E. Segovia --- fftools/ffprobe.c | 16 +++- fftools/opt_common.c| 12 ++-- libavformat/rtmpproto.c | 24 ++-- 3 files changed, 39 insertions(+), 13 deletions(-) diff --gi

[FFmpeg-devel] [PATCH v5 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

2023-07-29 Thread L. E. Segovia
Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/hpeldsp_init.c | 2 ++ libavcodec/x86/vc1dsp_init.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index

[FFmpeg-devel] [PATCH v5 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

2023-07-29 Thread L. E. Segovia
Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/aacencdsp_init.c| 2 ++ libavcodec/x86/aacpsdsp_init.c | 2 ++ libavcodec/x86/ac3dsp_init.c | 4 libavcodec/x86/audiodsp_init.c | 2 ++

[FFmpeg-devel] Cease and Desist for AVRadio and SDR spam on this mailing list

2023-07-29 Thread Paul B Mahol
Dear FFmpeg developers, contributors, reviewers and maintainers: This mail serves as notice to you to immediately cease and desist all harassing activities against and towards me, including but not limited to sending SDR and/or AVRadio related patches to this mailing list and/or threatening to pus