[FFmpeg-devel] [PATCH] doc/developer: Alternative to making tests a requirement.

Making tests a strict requirement could increase the burden on new developers. This is an alternative Signed-off-by: Michael Niedermayer --- doc/developer.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 0c2f2cd7d1..c7536a17b6 100644 --- a/

[FFmpeg-devel] [RFC] [PATCH] [0/1] doc/developer: Alternative to making tests a requirement.

Changing the tests to a requirement, while it seems to have overwhelming support did have 2 developers, who seemed not to like it. This is an alternative suggestion, please comment what you think. Is this better for the project in your opinion or worse ? thx ___

Re: [FFmpeg-devel] [PATCH 1/9] avradio/sdr: use AVTree for candidate stations

On Fri, Jul 07, 2023 at 07:22:16PM +0200, Michael Niedermayer wrote: > This is needed so we can keep more information about stations without > performance issues > > Signed-off-by: Michael Niedermayer > --- > libavradio/sdr.h | 4 +- > libavradio/sdrdemux.c | 126 +

[FFmpeg-devel] [PATCH] avutil: fix build failure on osx 10.4

libavutil/random_seed.c calls arc4random_buf which is not available on OSX 10.4 Tiger, but the configuration script tests for arc4random which is available. Fix the configuration test to match the actual API used. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c

Re: [FFmpeg-devel] [PATCH] avutil: fix build failure on osx 10.4

On 7/8/2023 2:48 PM, Pavel Koshevoy wrote: libavutil/random_seed.c calls arc4random_buf which is not available on OSX 10.4 Tiger, but the configuration script tests for arc4random which is available. Fix the configuration test to match the actual API used. --- configure | 2 +- 1 file changed

[FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9

Git master libjxl changed several function signatures, so this commit adds some #ifdefs to handle the new signatures without breaking old releases. --- libavcodec/libjxldec.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/libavcodec/libjxldec.c b/libavco

[FFmpeg-devel] [PATCH 1/3] avcodec/decode: move processing discard samples to its own function

Signed-off-by: James Almer --- libavcodec/decode.c | 182 +++- 1 file changed, 94 insertions(+), 88 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 269633ce10..793ab975f6 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c

[FFmpeg-devel] [PATCH 2/3] avcodec/decode: check the output frame for discard samples with all decoders

And not just those with the old decode() API. Signed-off-by: James Almer --- libavcodec/decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 793ab975f6..49c8b7e0f4 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -594,8 +594

[FFmpeg-devel] [PATCH 3/3] avcodec/decode: fill missing frame fields for all decoders

And not just those with the old decode() API. Signed-off-by: James Almer --- libavcodec/decode.c | 52 +++-- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 49c8b7e0f4..fe07e906c2 100644 --- a

Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9

On 2023-07-09 12:15 am, Leo Izen wrote: Git master libjxl changed several function signatures, so this commit adds some #ifdefs to handle the new signatures without breaking old releases. Same objection as to the patch submitted a few days ago, pasted below: 0.9.0 is still unreleased a

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/decode: move processing discard samples to its own function

James Almer: > Signed-off-by: James Almer > --- > libavcodec/decode.c | 182 +++- > 1 file changed, 94 insertions(+), 88 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 269633ce10..793ab975f6 100644 > --- a/libavcodec/decode

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/decode: move processing discard samples to its own function

On 7/8/2023 4:38 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/decode.c | 182 +++- 1 file changed, 94 insertions(+), 88 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 269633ce10..793ab

[FFmpeg-devel] [PATCH 01/18] avradio/sdrdemux: Fix uninitialized access

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index bed74ebd26..3bb5a69cf1 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1500,9 +1500,11 @@ int

[FFmpeg-devel] [PATCH 02/18] avradio/sdrdemux: factor frequency tolerance constants out

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 3bb5a69cf1..1f2d778978 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -61,6 +61,9 @@ #def

[FFmpeg-devel] [PATCH 03/18] avradio/sdr: Add fm multiple parameter

Signed-off-by: Michael Niedermayer --- doc/demuxers.texi | 7 +++ libavradio/sdr.h | 1 + libavradio/sdrdemux.c | 9 + 3 files changed, 17 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 81c46ce08f..86f031b9ed 100644 --- a/doc/demuxers.texi +++ b/doc/d

[FFmpeg-devel] [PATCH 04/18] avradio/sdrinradio: Dont automatically select 2.56Mhz on the rtlsdr

2.56Mhz produces more artifacts than lower sample rates at least in the FM broadcast band Signed-off-by: Michael Niedermayer --- libavradio/sdrinradio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavradio/sdrinradio.c b/libavradio/sdrinradio.c index c6f5742436..052

[FFmpeg-devel] [PATCH 05/18] avradio/sdrdemux: Do not timeout negative stations

If we identified that a station is an artifact of the SDR, we dont want to timeout that to avoid it being redetected as station Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavradio/sdrdemux.c b/l

[FFmpeg-devel] [PATCH 06/18] avradio/sdrinradio: Factor print_and_free_list() out

Signed-off-by: Michael Niedermayer --- libavradio/sdrinradio.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavradio/sdrinradio.c b/libavradio/sdrinradio.c index 052e2298da..e4f17f4bc9 100644 --- a/libavradio/sdrinradio.c +++ b/libavradio/sdrinra

[FFmpeg-devel] [PATCH 12/18] avradio/sdrdemux: Set AVFMTCTX_NOHEADER

This is needed as stations may not be detected immedeately Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 2bce1045f4..1c77583fd4 100644 --- a/libavradio/sdrdemux.c +++ b/libavrad

[FFmpeg-devel] [PATCH 07/18] avradio/sdrinradio: Print list of Time Sources

Signed-off-by: Michael Niedermayer --- libavradio/sdrinradio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavradio/sdrinradio.c b/libavradio/sdrinradio.c index e4f17f4bc9..af87b49495 100644 --- a/libavradio/sdrinradio.c +++ b/libavradio/sdrinradio.c @@ -171,6 +171,9 @@ static int sd

[FFmpeg-devel] [PATCH 13/18] avradio/sdrdemux: fix bug adding candidate stations and then crashing

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 1c77583fd4..5300311c3a 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1818,7 +1818,7 @@ process_

[FFmpeg-devel] [PATCH 08/18] avradio: split out vissualization code

Signed-off-by: Michael Niedermayer --- libavradio/Makefile | 4 +- libavradio/sdr.h| 21 libavradio/sdrdemux.c | 207 +++- libavradio/vissualize.c | 200 ++ 4 files changed, 238 insertions(+), 194 deleti

[FFmpeg-devel] [PATCH 14/18] avradio/sdrdemux: fm_probe: dont allow bandwidh=sample rate

if bandwidth is set incorrectly the noise floor can be very wrong, which causes issues as the threshold is based on the noise floor Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/

[FFmpeg-devel] [PATCH 09/18] avradio/sdrdemux: The RTLSDR DC artifact is not consistent

so we need to check every block, we cannot just check a few and then subtract the same value Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 1 - libavradio/sdrdemux.c | 23 +++ 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/libavradio/sdr.h

[FFmpeg-devel] [PATCH 15/18] doc: add sdr examples

Signed-off-by: Michael Niedermayer --- doc/demuxers.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 86f031b9ed..75ec55170a 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -1003,6 +1003,16 @@ No emphasis used @end table

[FFmpeg-devel] [PATCH 10/18] avradio/sdr: eliminate avpriv_*

Signed-off-by: Michael Niedermayer --- libavradio/sdr.h| 14 +++--- libavradio/sdrdemux.c | 32 libavradio/sdrinradio.c | 14 +++--- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/libavradio/sdr.h b/libavradio/sdr.h inde

[FFmpeg-devel] [PATCH 16/18] avradio/sdr: rename fft_p2

The FFT really is from the point of view of the stream Phase 1 not Phase 2 of the demodulation. Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 4 ++-- libavradio/sdrdemux.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavradio/sdr.h b/libavradio/

[FFmpeg-devel] [PATCH 11/18] avradio/vissualize: rotate waterfall

Signed-off-by: Michael Niedermayer --- libavradio/sdr.h| 1 + libavradio/vissualize.c | 35 ++- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/libavradio/sdr.h b/libavradio/sdr.h index 2940ffa389..8a2ab1c78a 100644 --- a/libavradio/sdr.h +

[FFmpeg-devel] [PATCH 17/18] avradio/sdrdemux: more correct phase 2 bandwidth of FM demodulation

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 1ded01e957..d73cbc0a06 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -840,7 +840,7 @@ static int

[FFmpeg-devel] [PATCH 18/18] avradio/sdrdemux: Fix DC offset issue in AM demodulation

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index d73cbc0a06..7cc71b2cfb 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -740,7 +740,8 @

Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote: > This is the main entry point for the CTU (Coding Tree Unit) decoder. > The code will divide the CTU decoder into several stages. > It will check the stage dependencies and run the stage decoder. > --- > libavcodec/vvc/Makefile | 3 +-

Re: [FFmpeg-devel] [PATCH v2 01/14] vvcdec: add thread executor

On Fri, Jul 07, 2023 at 10:05:27PM +0800, Nuo Mi wrote: > The executor design pattern was inroduced by java > > it also adapted by python > >

Re: [FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

On Fri, Jul 07, 2023 at 11:48:38AM +0200, Anton Khirnov wrote: > When the user explicitly specifies a pixel format that is not supported > by the encoder, ffmpeg CLI will currently use some heuristics to pick > another supported format. This is wrong and the correct action here is > to fail. > > S

Re: [FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

On Fri, Jul 07, 2023 at 11:48:38AM +0200, Anton Khirnov wrote: > When the user explicitly specifies a pixel format that is not supported > by the encoder, ffmpeg CLI will currently use some heuristics to pick > another supported format. This is wrong and the correct action here is > to fail. > > S

Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

Michael Niedermayer: > On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote: >> This is the main entry point for the CTU (Coding Tree Unit) decoder. >> The code will divide the CTU decoder into several stages. >> It will check the stage dependencies and run the stage decoder. >> --- >> libavcode

Re: [FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

Quoting Michael Niedermayer (2023-07-09 00:15:30) > On Fri, Jul 07, 2023 at 11:48:38AM +0200, Anton Khirnov wrote: > > When the user explicitly specifies a pixel format that is not supported > > by the encoder, ffmpeg CLI will currently use some heuristics to pick > > another supported format. This

Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9

On 2023-07-09 01:00 am, Leo Izen wrote: On 7/8/23 15:25, Gyan Doshi wrote: On 2023-07-09 12:15 am, Leo Izen wrote: Git master libjxl changed several function signatures, so this commit adds some #ifdefs to handle the new signatures without breaking old releases. Same objection as to the