Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Michael Niedermayer
On Fri, Jun 23, 2023 at 10:34:10AM +0800, Kieran Kunhya wrote: > FFmpeg is not the place for SDR. SDR is as large and complex as the > entirety of multimedia. > > What next, is FFmpeg going to implement TCP in userspace, Wifi, Ethernet, > an entire 4G and 5G stack? https://en.wikipedia.org/wiki/S

Re: [FFmpeg-devel] [RFC] SDR

2023-06-23 Thread James Almer
On 6/22/2023 1:09 PM, Anton Khirnov wrote: Hi, I'm sorry to say, the patch at its current state is quite far from something I'd consider acceptable for git master. 1) Given that there are sdr and sdrfile demuxers, it seems to me that the transport layer should be split into a protocol rather tha

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Kieran Kunhya
On Fri, 23 Jun 2023, 19:17 Michael Niedermayer, wrote: > On Fri, Jun 23, 2023 at 10:34:10AM +0800, Kieran Kunhya wrote: > > FFmpeg is not the place for SDR. SDR is as large and complex as the > > entirety of multimedia. > > > > What next, is FFmpeg going to implement TCP in userspace, Wifi, Ether

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/evc_frame_merge: ensure the assembled buffer fits in an AVPacket

2023-06-23 Thread James Almer
On 6/22/2023 4:29 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/evc_frame_merge_bsf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Will apply set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libplacebo: simplify SAR normalization

2023-06-23 Thread Niklas Haas
On Tue, 20 Jun 2023 17:12:48 +0200 Niklas Haas wrote: > From: Niklas Haas > > The old logic was trying to be excessively clever in "deducing" that the > user wanted to stretch/scale the image when ow/oh differed from iw/ih > aspect ratio. But this is almost surely unintended except in > patholog

[FFmpeg-devel] [PATCH 1/2] lavu/tests/cpu: stop processing the thread count

2023-06-23 Thread Anton Khirnov
Just print it as it is. Needed by the following commit. --- libavutil/tests/cpu.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavutil/tests/cpu.c b/libavutil/tests/cpu.c index a52637339d..200f20388a 100644 --- a/libavutil/tests/cpu.c +++ b/libavutil/tests/cpu.c @

[FFmpeg-devel] [PATCH 2/2] tests/fate-run: add testing with a random number of threads

2023-06-23 Thread Anton Khirnov
Useful for discovering bugs that depend on a specific thread count. Uses a simple PRNG copied from random() from libavutil/eval.c Use like THREADS=randomX for a random thread count from 1 to X, with X=16 when not specified. --- doc/fate.texi | 5 + tests/fate-run.sh | 9 + 2 files

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Rémi Denis-Courmont
Hi, Le 23 juin 2023 13:17:28 GMT+02:00, Michael Niedermayer a écrit : >On Fri, Jun 23, 2023 at 10:34:10AM +0800, Kieran Kunhya wrote: >> FFmpeg is not the place for SDR. SDR is as large and complex as the >> entirety of multimedia. >> >> What next, is FFmpeg going to implement TCP in userspace,

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Michael Niedermayer
Hi On Fri, Jun 23, 2023 at 06:37:18PM +0200, Rémi Denis-Courmont wrote: > Hi, > > Le 23 juin 2023 13:17:28 GMT+02:00, Michael Niedermayer > a écrit : > >On Fri, Jun 23, 2023 at 10:34:10AM +0800, Kieran Kunhya wrote: > >> FFmpeg is not the place for SDR. SDR is as large and complex as the > >> e

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Paul B Mahol
On Fri, Jun 23, 2023 at 8:12 PM Michael Niedermayer wrote: > Hi > > On Fri, Jun 23, 2023 at 06:37:18PM +0200, Rémi Denis-Courmont wrote: > > Hi, > > > > Le 23 juin 2023 13:17:28 GMT+02:00, Michael Niedermayer < > mich...@niedermayer.cc> a écrit : > > >On Fri, Jun 23, 2023 at 10:34:10AM +0800, Kie

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Michael Niedermayer
On Fri, Jun 23, 2023 at 08:17:16PM +0200, Paul B Mahol wrote: > On Fri, Jun 23, 2023 at 8:12 PM Michael Niedermayer > wrote: > > > Hi > > > > On Fri, Jun 23, 2023 at 06:37:18PM +0200, Rémi Denis-Courmont wrote: > > > Hi, > > > > > > Le 23 juin 2023 13:17:28 GMT+02:00, Michael Niedermayer < > > mi

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Paul B Mahol
On Fri, Jun 23, 2023 at 8:56 PM Michael Niedermayer wrote: > On Fri, Jun 23, 2023 at 08:17:16PM +0200, Paul B Mahol wrote: > > On Fri, Jun 23, 2023 at 8:12 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > Hi > > > > > > On Fri, Jun 23, 2023 at 06:37:18PM +0200, Rémi Denis-C

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread James Almer
On 6/23/2023 4:10 PM, Paul B Mahol wrote: On Fri, Jun 23, 2023 at 8:56 PM Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 08:17:16PM +0200, Paul B Mahol wrote: On Fri, Jun 23, 2023 at 8:12 PM Michael Niedermayer < mich...@niedermayer.cc> wrote: Hi On Fri, Jun 23, 2023 at 06:37:18PM +0

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Tomas Härdin
No. Absolutely not. Radio stuff belongs in radio projects such as GNU Radio. This is extreme scope creep. I can throw an AM detector together in 15 minutes. That doesn't mean it belongs in FFmpeg. You are also treading into modem territory, among other things. Please contribute to actually existi

Re: [FFmpeg-devel] [RFC] SDR

2023-06-23 Thread Tomas Härdin
tor 2023-06-22 klockan 16:57 +0200 skrev Michael Niedermayer: > If we support just audio and video (de)modulation it fits nicely in FFmpeg You have no idea what you are getting into. Are we going to implement a DVB-T demuxer in this project? For what purpose? You can just as well implement a modem

Re: [FFmpeg-devel] [RFC] SDR

2023-06-23 Thread Tomas Härdin
fre 2023-06-23 klockan 22:18 +0200 skrev Tomas Härdin: > tor 2023-06-22 klockan 16:57 +0200 skrev Michael Niedermayer: > > If we support just audio and video (de)modulation it fits nicely in > > FFmpeg > > You have no idea what you are getting into. Are we going to implement > a > DVB-T demuxer in

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-23 Thread Michael Niedermayer
Hi Tomas On Fri, Jun 23, 2023 at 10:10:29PM +0200, Tomas Härdin wrote: > No. Absolutely not. > > Radio stuff belongs in radio projects such as GNU Radio. This is > extreme scope creep. > > I can throw an AM detector together in 15 minutes. That doesn't mean it > belongs in FFmpeg. You are also t

Re: [FFmpeg-devel] [RFC] SDR

2023-06-23 Thread Michael Niedermayer
On Fri, Jun 23, 2023 at 10:19:37PM +0200, Tomas Härdin wrote: > fre 2023-06-23 klockan 22:18 +0200 skrev Tomas Härdin: > > tor 2023-06-22 klockan 16:57 +0200 skrev Michael Niedermayer: > > > If we support just audio and video (de)modulation it fits nicely in > > > FFmpeg > > > > You have no idea w

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-23 Thread Brad Smith
ping. On 2023-06-17 6:48 p.m., Brad Smith wrote: On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote: this breaks a plain configure here on ubuntu ./configure ERROR: sndio not found using pkg-config If you think configure made a mistake, make sure you are using the latest vers

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-23 Thread Michael Niedermayer
On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote: > ping. > > On 2023-06-17 6:48 p.m., Brad Smith wrote: > > On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote: > > > this breaks a plain configure > > > here on ubuntu > > > > > > ./configure > > > ERROR: sndio not found

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-23 Thread Brad Smith
On 2023-06-23 6:55 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote: ping. On 2023-06-17 6:48 p.m., Brad Smith wrote: On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote: this breaks a plain configure here on ubuntu ./configure ERROR

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-23 Thread James Almer
On 6/23/2023 7:55 PM, Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote: ping. On 2023-06-17 6:48 p.m., Brad Smith wrote: On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote: this breaks a plain configure here on ubuntu ./configure ERROR: s

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-23 Thread Michael Niedermayer
On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote: > On 2023-06-23 6:55 p.m., Michael Niedermayer wrote: > > On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote: > > > ping. > > > > > > On 2023-06-17 6:48 p.m., Brad Smith wrote: > > > > On Sun, Jun 18, 2023 at 12:01:14AM +0200, Mic

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-23 Thread Brad Smith
On 2023-06-23 7:35 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote: On 2023-06-23 6:55 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote: ping. On 2023-06-17 6:48 p.m., Brad Smith wrote: On Sun, Jun 18, 202

Re: [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests

2023-06-23 Thread Michael Niedermayer
On Sun, Jun 18, 2023 at 11:50:21PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewritin

[FFmpeg-devel] [PATCH v3 0/4] JPEG XL Parser addition

2023-06-23 Thread Leo Izen
Changes from v2: - Fix libjxldec to work with packets that are smaller than one frame - Change how code is shared between libavcodec and libavformat to be more sensible. - Fix the parser to work with large headers that proceed the codestream in a container format (for example, if several-KB

[FFmpeg-devel] [PATCH v3 1/4] avcodec/libjxldec: use internal AVFrame as buffered space

2023-06-23 Thread Leo Izen
Before this commit, the decoder erroneously assumes that the AVFrame passed to the receive_frame is the same one each time. Now it keeps an internal AVFrame to write into, and copies it over when it's done. --- libavcodec/libjxldec.c | 40 +++- 1 file changed, 2

[FFmpeg-devel] [PATCH v3 2/4] avcodec/jpegxl_parser: add JPEG XL parser

2023-06-23 Thread Leo Izen
Add a parser to libavcodec for AV_CODEC_ID_JPEGXL. It doesn't find the end of the stream in order to packetize the codec, but it does look at the headers to set preliminary information like dimensions and pixel format. Note that much of this code is duplicated from avformat/jpegxl_probe.c, but tha

[FFmpeg-devel] [PATCH v3 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-23 Thread Leo Izen
Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not animated, in order to help sort out false positives. Signed-off-by: --- tests/Makefile | 1 +

[FFmpeg-devel] [PATCH v3 3/4] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse

2023-06-23 Thread Leo Izen
This prevents code duplication in the source form by calling the parse code that was moved to avcodec last commit. The code will be duplicated in binary form for shared builds (it's not that large), but for source code it will only exist in one location now. Signed-off-by: --- libavformat/Makefi