On Tue, Jun 20, 2023 at 2:50 AM Roger Pack wrote:
> OK updated patches to work with latest git master, made coded id less
> verbose.
> These have been tested against a "real device" and seem to work properly.
> I'd like to get feedback on the Closed caption decoder first if that's
> possible.
> I
On Tue, Jun 20, 2023 at 7:19 AM wrote:
> From: Romain Beauxis
>
> Before the introduction of AV_CODEC_ID_TIMED_ID3 for timed_id3 metadata
> streams
> in mpegts (commit 4a4437c0fbc8f7afe0c533070395a42e56b4ee75),
> AV_CODEC_ID_SMPTE_KLV
> was the only existing codec for metadata.
>
> It seems that
Why have you split off the parameter set parsing into its own file? Just
asking what's the reason.
> -Original Message-
> From: ffmpeg-devel On Behalf Of James
> Almer
> Sent: niedziela, 18 czerwca 2023 00:00
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 04/10] avcodec/
On Tue, 20 Jun 2023, Lynne wrote:
Using the sqrt/cos/sin approximations we have, the only parts left
which may be inexact are multiplies and divisions in some transforms.
This seems to help somewhat, but there still are cases of inexactness,
somewhere.
The content of the tables that are ini
On 6/20/2023 4:37 AM, Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff
Engineer/Samsung Electronics wrote:
Why have you split off the parameter set parsing into its own file? Just
asking what's the reason.
I copied the design from h264. Smaller source files are better than
monolith ones. And an even
Squashed with patch 2/2, trailing whitespaces fixed and pushed
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with
It does not need to be visible outside of encode.c.
---
libavcodec/encode.c | 12 +---
libavcodec/internal.h | 6 --
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavcodec/encode.c b/libavcodec/encode.c
index 4273dceb31..2b304d0771 100644
--- a/libavcodec/encode.c
---
libavcodec/decode.c | 10 +-
libavcodec/encode.c | 24
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 7d000fec32..b5e5b4a2db 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -1744,13
Move AVCodecInternal.nb_draining_errors to it, should should not be
visible outside of decode.c.
---
libavcodec/avcodec.c | 4 +++-
libavcodec/avcodec_internal.h | 2 ++
libavcodec/decode.c | 22 --
libavcodec/internal.h | 10 +++---
libavcodec/
The goal is to distinguish between APIs provided by the generic layer to
individual codecs and APIs internal to the generic layer.
Start by moving ff_{decode,encode}_receive_frame() and
ff_{decode,encode}_preinit() into this new header, as those functions
are called from generic code and should no
Do it from ff_decode_get_packet() rather than from
avcodec_send_packet(). This way all nontrivial stages of the decoding
pipeline (i.e. other than just placing a packet at its entrance) are
pull-based rather than a mix of push an pull.
---
libavcodec/decode.c | 36 ++---
Decoding pipeline has multiple stages, some of which may have their own
delay (e.g. bitstream filters). The code currently uses
AVCodecInternal.draining to track all of them, but they do not have to
all be in sync.
---
libavcodec/decode.c | 11 +--
1 file changed, 9 insertions(+), 2 deleti
This way decoding error will not be returned when the user starts
draining the decoder, avoiding confusion over whether draining did or
did not start.
Fixes failures of fate-h264-attachment-631 for certain numbers of frame
threads (e.g. 5).
---
libavcodec/decode.c | 2 +-
1 file changed, 1 insert
Will allow making some state private to encoding/decoding in the future.
---
libavcodec/avcodec.c | 26 ++
libavcodec/avcodec_internal.h | 3 +++
libavcodec/decode.c | 15 +++
libavcodec/encode.c | 18 ++
4 files cha
Move AVCodecInternal.intra_only_flag to it, should should not be visible
outside of encode.c.
---
libavcodec/avcodec.c | 2 +-
libavcodec/avcodec_internal.h | 1 +
libavcodec/encode.c | 26 --
libavcodec/internal.h | 13 ++---
4 files ch
You can find an overview of the changes here:
https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md
and the new code here:
https://github.com/yethie/FFmpeg/blob/master/libavfilter/vf_drawtext.c
On 19/06/2023 19:56, Mark Ren wrote:
Ah alright I see. When might that push come throug
Hi Roger,
On Mon, Jun 19, 2023 at 8:50 PM Roger Pack wrote:
>
> OK updated patches to work with latest git master, made coded id less verbose.
> These have been tested against a "real device" and seem to work properly.
> I'd like to get feedback on the Closed caption decoder first if that's
> po
On 6/18/2023 8:43 PM, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/evc_parse.h | 3 ++-
libavformat/evc.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
Dropped patches 11 and 12, pushed patches 13 to 17.
___
ffmp
Signed-off-by: James Almer
---
libavformat/evcdec.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
index 890babd3cb..9c4969e78f 100644
--- a/libavformat/evcdec.c
+++ b/libavformat/evcdec.c
@@ -30,6 +30,7 @@
#include "rawdec
And return proper error codes.
Signed-off-by: James Almer
---
libavformat/evcdec.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
index 9c4969e78f..68f3a91e53 100644
--- a/libavformat/evcdec.c
+++ b/libavformat/e
Signed-off-by: James Almer
---
libavformat/evcdec.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
index 68f3a91e53..842258d229 100644
--- a/libavformat/evcdec.c
+++ b/libavformat/evcdec.c
@@ -183,15 +183,14 @@ static int ev
But ensure the value returned by evc_read_nal_unit_length() fits in an int.
Should prevent integer overflows later in the code.
Signed-off-by: James Almer
---
libavformat/evcdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
This is in preparation for the following patch.
Signed-off-by: James Almer
---
libavcodec/evc_frame_merge_bsf.c | 11 +-
libavcodec/evc_parser.c | 11 +-
libavcodec/evc_ps.c | 186 +++
libavcodec/evc_ps.h | 5 +-
4 files changed,
Signed-off-by: James Almer
---
libavcodec/evc_frame_merge_bsf.c | 6 +++-
libavcodec/evc_parse.c | 52 ++--
libavcodec/evc_parse.h | 4 +--
libavcodec/evc_parser.c | 6 +++-
4 files changed, 35 insertions(+), 33 deletions(-)
diff --git
Signed-off-by: James Almer
---
libavcodec/evc_frame_merge_bsf.c | 48 +++-
1 file changed, 17 insertions(+), 31 deletions(-)
diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c
index 3904170ebd..a9b44f4d10 100644
--- a/libavcodec/evc_frame
Signed-off-by: James Almer
---
libavcodec/evc_parse.c | 22 --
libavcodec/evc_parse.h | 22 --
libavcodec/evc_parser.c | 30 --
3 files changed, 12 insertions(+), 62 deletions(-)
diff --git a/libavcodec/evc_parse.c b/libavcode
Signed-off-by: James Almer
---
libavformat/evc.c| 5 ++---
libavformat/evc.h| 30 ++
libavformat/evcdec.c | 44
3 files changed, 36 insertions(+), 43 deletions(-)
diff --git a/libavformat/evc.c b/libavformat/evc.c
On 18 Jun 2023, at 13:16, Niklas Haas wrote:
> Changes since v1:
> - added explicit `if (s->inputs)` check to input_uninit() loop
> - added extra `!s->status` check to handle case of negative PTS on
> status change (since `s->status_pts >= 0` would fail here)
>
>
Tested and LGTM from my side
>
---
configure | 2 ++
libavutil/riscv/cpu.c | 54 ---
2 files changed, 43 insertions(+), 13 deletions(-)
diff --git a/configure b/configure
index ed9efad985..8cad88cdd2 100755
--- a/configure
+++ b/configure
@@ -5412,6 +5412,8 @@ elif enabled p
In most cases, flv_read_metabody reads pass the beginning of the meta_pos.
If the beginning of the meta_pos had been flushed from the IO buffer,
we would not be able to seek to the right position (for a nonseekable stream).
Is better to check the seek result and skip the current flv body if necess
On Tue, 20 Jun 2023 16:50:08 +0200 Marvin Scholz wrote:
> On 18 Jun 2023, at 13:16, Niklas Haas wrote:
>
> > Changes since v1:
> > - added explicit `if (s->inputs)` check to input_uninit() loop
> > - added extra `!s->status` check to handle case of negative PTS on
> > status change (since `s->s
From: Niklas Haas
The old logic was trying to be excessively clever in "deducing" that the
user wanted to stretch/scale the image when ow/oh differed from iw/ih
aspect ratio. But this is almost surely unintended except in
pathological cases, and in those cases users should simply disable
normaliz
On Tue, Jun 20, 2023 at 4:27 PM Francesco Carusi
wrote:
> You can find an overview of the changes here:
>
> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md
>
> and the new code here:
>
> https://github.com/yethie/FFmpeg/blob/master/libavfilter/vf_drawtext.c
This have been alrea
On 6/19/23 13:01, Michael Niedermayer wrote:
On Sun, Jun 18, 2023 at 06:57:58PM -0400, Leo Izen wrote:
On 6/18/23 17:50, Michael Niedermayer wrote:
Fixes: out of array read
Fixes:
59828/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5029813220671488
Found-by: continuous fuzzing
On 6/18/23 5:18 AM, Paul B Mahol wrote:
> Well, just keep that part as is currently, until someone else cleans it up.
>
> Can probing in new demuxer be smarter than just decreasing score of another
> demuxer?
A new patch is attached where the dtshddec.c probe function change is updated
to no l
libplacebo is better in every way for anything involving scaling or format
conversions
Patch attached.
>From 146e753f3e618cb986c2649f0776f66e99098dea Mon Sep 17 00:00:00 2001
From: Lynne
Date: Tue, 20 Jun 2023 18:56:26 +0200
Subject: [PATCH 1/2] lavfi: remove scale_vulkan filter
libplacebo is
Patch attached.
>From 453c513bb4960dee72228a8713375fce75a40482 Mon Sep 17 00:00:00 2001
From: Lynne
Date: Tue, 20 Jun 2023 18:59:03 +0200
Subject: [PATCH 2/2] lavfi: remove overlay_vulkan in favor of libplacebo
---
configure | 1 -
doc/filters.texi| 20 -
Lynne (12023-06-20):
> libplacebo is better in every way for anything involving scaling or format
> conversions
Is libplacebo considered a system library?
Are scaling and format conversions not considered essential parts of
FFmpeg's task?
Regards,
--
Nicolas George
signature.asc
Descripti
Lynne (12023-06-20):
> Patch attached.
>
> >From 453c513bb4960dee72228a8713375fce75a40482 Mon Sep 17 00:00:00 2001
> From: Lynne
> Date: Tue, 20 Jun 2023 18:59:03 +0200
> Subject: [PATCH 2/2] lavfi: remove overlay_vulkan in favor of libplacebo
Similar questions than for the other patch:
Is lib
On 6/20/2023 11:16 AM, Anton Khirnov wrote:
Do it from ff_decode_get_packet() rather than from
avcodec_send_packet(). This way all nontrivial stages of the decoding
pipeline (i.e. other than just placing a packet at its entrance) are
pull-based rather than a mix of push an pull.
---
libavcodec/
Fixed-point AAC decoder currently does not produce the same output on
all platforms. Until that is fixed, silence the audio stream using the
volume filter.
Also, actually use the aac_fixed decoder as was the original intent.
---
tests/fate/ffmpeg.mak | 7 +-
tests/ref/fa
On 6/20/2023 3:53 PM, Anton Khirnov wrote:
Fixed-point AAC decoder currently does not produce the same output on
all platforms. Until that is fixed, silence the audio stream using the
volume filter.
Also, actually use the aac_fixed decoder as was the original intent.
---
tests/fate/ffmpeg.mak
On 6/20/2023 3:53 PM, Anton Khirnov wrote:
Fixed-point AAC decoder currently does not produce the same output on
all platforms. Until that is fixed, silence the audio stream using the
volume filter.
Also, actually use the aac_fixed decoder as was the original intent.
---
tests/fate/ffmpeg.mak
Quoting James Almer (2023-06-20 21:39:22)
> On 6/20/2023 3:53 PM, Anton Khirnov wrote:
> > Fixed-point AAC decoder currently does not produce the same output on
> > all platforms. Until that is fixed, silence the audio stream using the
> > volume filter.
> >
> > Also, actually use the aac_fixed de
On 6/20/2023 4:41 PM, Anton Khirnov wrote:
Quoting James Almer (2023-06-20 21:39:22)
On 6/20/2023 3:53 PM, Anton Khirnov wrote:
Fixed-point AAC decoder currently does not produce the same output on
all platforms. Until that is fixed, silence the audio stream using the
volume filter.
Also, actu
Fixes ticket #10424.
Signed-off-by: James Almer
---
libavformat/id3v2.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index cb31864045..38c86a8e79 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -246,7 +246,7 @@
On Tue, 20 Jun 2023 19:32:28 +0200 Lynne wrote:
> libplacebo is better in every way for anything involving scaling or format
> conversions
Hi,
vf_libplacebo always goes through internal RGB conversion, even for no-op.
scale_vulkan (ditto overlay_vulkan) can be more efficient for simple YCbCr
fr
Jun 20, 2023, 23:58 by ffm...@haasn.xyz:
> On Tue, 20 Jun 2023 19:32:28 +0200 Lynne wrote:
>
>> libplacebo is better in every way for anything involving scaling or format
>> conversions
>>
>
> Hi,
>
> vf_libplacebo always goes through internal RGB conversion, even for no-op.
> scale_vulkan (ditt
From: Dave Airlie
av1-1-b8-03-sizeup.ivf on vulkan causes gpu hangs as none of the
images get resized when dimensions change, this detects the dim
change and calls the get_format to reinit the context.
---
libavcodec/av1dec.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
di
From: Dave Airlie
This fixes decoding av1-1-b8-22-svc-L2T1.ivf
while not breaking other videos.
---
libavcodec/vulkan_av1.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c
index 91e44ba803..005998b1bd 100644
--- a/libavc
Le mar. 20 juin 2023 à 02:10, Paul B Mahol a écrit :
>
>
>
> On Tue, Jun 20, 2023 at 7:19 AM wrote:
>>
>> From: Romain Beauxis
>>
>> Before the introduction of AV_CODEC_ID_TIMED_ID3 for timed_id3 metadata
streams
>> in mpegts (commit 4a4437c0fbc8f7afe0c533070395a42e56b4ee75),
AV_CODEC_ID_SMPTE_K
On 6/20/2023 8:58 PM, Romain Beauxis wrote:
Le mar. 20 juin 2023 à 02:10, Paul B Mahol a écrit :
On Tue, Jun 20, 2023 at 7:19 AM wrote:
From: Romain Beauxis
Before the introduction of AV_CODEC_ID_TIMED_ID3 for timed_id3 metadata
streams
in mpegts (commit 4a4437c0fbc8f7afe0c533070395a4
52 matches
Mail list logo
