[FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback

2023-06-05 Thread Roman Arzumanyan
Hello, This patch reduces vRAM usage by cuvid decoder implementation. The number of surfaces used for decoding is updated within the parser sequence decode callback. Also the "surfaces" AVDictionary option specific to cuvid was removed in favor of "extra_hw_surfaces". vRAM consumption was tested

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-05 Thread Stefano Sabatini
Il dom 4 giu 2023, 16:34 Marvin Scholz ha scritto: > On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > [...] > > About your patch, please mention that the pop operation is > > destructive. We probably want to make that behavior configurable > > through flags, but I'm fine to keep the current beh

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-05 Thread Anton Khirnov
Quoting Marvin Scholz (2023-05-01 13:44:54) > diff --git a/libavutil/dict.h b/libavutil/dict.h > index 713c9e361a..b2ab55a026 100644 > --- a/libavutil/dict.h > +++ b/libavutil/dict.h > @@ -172,6 +172,26 @@ int av_dict_set(AVDictionary **pm, const char *key, > const char *value, int flags > */ >

Re: [FFmpeg-devel] [PATCH 3/3] avutil/dict: constify av_dict_get return

2023-06-05 Thread Anton Khirnov
Quoting Marvin Scholz (2023-05-01 13:44:56) > --- > doc/examples/qsv_transcode.c | 2 +- > libavcodec/libaomenc.c | 2 +- > libavcodec/libkvazaar.c| 2 +- > libavcodec/libsvtav1.c | 2 +- > libavcodec/libvpxenc.c | 2 +- > libavcodec/libx2

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-05 Thread Anton Khirnov
Quoting Stefano Sabatini (2023-06-05 10:08:07) > Il dom 4 giu 2023, 16:34 Marvin Scholz ha scritto: > > > On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > > [...] > > > About your patch, please mention that the pop operation is > > > destructive. We probably want to make that behavior configura

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback

2023-06-05 Thread Anton Khirnov
Quoting Roman Arzumanyan (2023-06-05 09:30:07) > Hello, > > This patch reduces vRAM usage by cuvid decoder implementation. > The number of surfaces used for decoding is updated within the parser > sequence decode callback. > Also the "surfaces" AVDictionary option specific to cuvid was removed in

Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: Check for wrapped frames

2023-06-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-06-04 21:53:22) > Wrapped frames contain pointers so they need specific code to > noise them, the generic code would lead to segfaults > > Signed-off-by: Michael Niedermayer > --- > libavcodec/noise_bsf.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback

2023-06-05 Thread Roman Arzumanyan
Thanks for the review, Anton. Please find the updated patch attached. BTW - what do you mean by "you should also forward the actual error code"? Within the cuvid_handle_video_sequence() function in case of error, function still returns 0 and sets internal context error, so I kept behavior intact. D

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-05 Thread Carotti, Elias
Hi, please find attached the patch which I updated according to your suggestions. Best, Elias On Sun, 2023-06-04 at 17:29 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender

Re: [FFmpeg-devel] [PATCH v4 0/2] Animated JPEG XL Support

2023-06-05 Thread Leo Izen
On 6/2/23 11:03, Leo Izen wrote: On 5/26/23 16:55, Leo Izen wrote: Changes from v3:   - Use avctx->internal->in_pkt instead of allocating a new packet. Leo Izen (2):    avcodec/libjxldec: add animated decode support    avformat/jpegxl_anim_dec: add animated JPEG XL demuxer Will rebase onto m

Re: [FFmpeg-devel] [PATCH v2 5/5] aarch64: Add Windows runtime detection of the dotprod instructions

2023-06-05 Thread James Zern
On Tue, May 30, 2023 at 5:31 AM Martin Storsjö wrote: > > For Windows, there's no publicly defined constant for checking for > the i8mm extension yet. > --- > libavutil/aarch64/cpu.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavutil/aarch64/cpu.c b/libavutil/aarch64/c

[FFmpeg-devel] [PATCH] avcodec/jpeg2000htdec: Check for invalid magref length.

2023-06-05 Thread etemesicaleb
From: caleb --- libavcodec/jpeg2000htdec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index 51cd96e0f1..474d671ee0 100644 --- a/libavcodec/jpeg2000htdec.c +++ b/libavcodec/jpeg2000htdec.c @@ -1101,8 +1101

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Test lowres

2023-06-05 Thread Michael Niedermayer
On Sun, Jan 08, 2023 at 01:59:08PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 4 > 1 file changed, 4 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things micr

Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: Check for wrapped frames

2023-06-05 Thread Michael Niedermayer
On Mon, Jun 05, 2023 at 12:21:13PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-06-04 21:53:22) > > Wrapped frames contain pointers so they need specific code to > > noise them, the generic code would lead to segfaults > > > > Signed-off-by: Michael Niedermayer > > --- > > lib

Re: [FFmpeg-devel] [PATCH v10 0/6] Support enhanced flv in FFmpeg

2023-06-05 Thread Steven Liu
Neal Gompa 于2023年5月31日周三 13:47写道: > > On Mon, May 15, 2023 at 10:41 PM Neal Gompa wrote: > > > > On Mon, May 15, 2023 at 4:32 AM Steven Liu wrote: > > > > > > Reference file: > > > https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf > > > The Enhanced flv has been supported