[FFmpeg-devel] Add LSX optimization in avcodec and swscale.

2023-05-20 Thread Hao Chen
Retrigger the fate test. v1: Add LSX optimization in avcodec and swscale, due to the 2K series CPUs only support lsx. v2: Modified the implementation of some functions and added support for the checkasm --bench feature. v3: Fix whitespace errors in patch. [PATCH v3 1/7] avcodec/la: add LSX optim

[FFmpeg-devel] [PATCH v3 1/7] avcodec/la: add LSX optimization for h264 idct.

2023-05-20 Thread Hao Chen
From: Shiyou Yin loongson_asm.S is LoongArch asm optimization helper. Add functions: ff_h264_idct_add_8_lsx ff_h264_idct8_add_8_lsx ff_h264_idct_dc_add_8_lsx ff_h264_idct8_dc_add_8_lsx ff_h264_idct_add16_8_lsx ff_h264_idct8_add4_8_lsx ff_h264_idct_add8_8_lsx ff_h264_idct_add8_422_

[FFmpeg-devel] [PATCH v3 3/7] avcodec/la: Add LSX optimization for h264 chroma and intrapred.

2023-05-20 Thread Hao Chen
From: Lu Wang ./configure --disable-lasx ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -y /dev/null -an before: 199fps after: 214fps --- libavcodec/loongarch/Makefile |4 +- .../loongarch/h264_intrapred_init_loongarch.c | 18 +- libavcodec/loongarch/h264_intrapred_las

[FFmpeg-devel] [PATCH v3 4/7] avcodec/la: Add LSX optimization for h264 qpel.

2023-05-20 Thread Hao Chen
From: yuanhecai ./configure --disable-lasx ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -y /dev/null -an before: 214fps after: 274fps --- libavcodec/loongarch/Makefile |2 + libavcodec/loongarch/h264qpel.S | 1686 + .../loongarch/h264qpel_

[FFmpeg-devel] [PATCH v3 7/7] avutil/la: Add function performance testing

2023-05-20 Thread Hao Chen
From: yuanhecai This patch supports the use of the "checkasm --bench" testing feature on loongarch platform. Change-Id: I42790388d057c9ade0dfa38a19d9c1fd44ca0bc3 --- libavutil/loongarch/timer.h | 48 + libavutil/timer.h | 2 ++ 2 files changed, 50

[FFmpeg-devel] [PATCH v3 6/7] swscale/la: Add following builtin optimized functions

2023-05-20 Thread Hao Chen
From: Jin Bo yuv420_rgb24_lsx yuv420_bgr24_lsx yuv420_rgba32_lsx yuv420_argb32_lsx yuv420_bgra32_lsx yuv420_abgr32_lsx ./configure --disable-lasx ffmpeg -i ~/media/1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -pix_fmt rgb24 -y /dev/null -an before: 184fps after: 207fps --- libswscale/loongarch/Make

Re: [FFmpeg-devel] [PATCH v3 7/7] avutil/la: Add function performance testing

2023-05-20 Thread Rémi Denis-Courmont
Le lauantaina 20. toukokuuta 2023, 10.27.19 EEST Hao Chen a écrit : > From: yuanhecai > > This patch supports the use of the "checkasm --bench" testing feature > on loongarch platform. > > Change-Id: I42790388d057c9ade0dfa38a19d9c1fd44ca0bc3 > --- > libavutil/loongarch/timer.h | 48

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: stop using AVPacket on stack

2023-05-20 Thread Paul B Mahol
Why you doing this to me? I already did this in my patch, that you ignored. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

2023-05-20 Thread Rémi Denis-Courmont
Le perjantaina 19. toukokuuta 2023, 21.52.57 EEST Lynne a écrit : > May 19, 2023, 19:16 by r...@remlab.net: > > Le keskiviikkona 17. toukokuuta 2023, 17.54.22 EEST Lynne a écrit : > >> Finally, run: > >> make checkasm && ./tests/checkasm/checkasm --bench > >> and report on the timings for both the

Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

2023-05-20 Thread Rémi Denis-Courmont
Le keskiviikkona 17. toukokuuta 2023, 17.54.22 EEST Lynne a écrit : > Finally, run: > make checkasm && ./tests/checkasm/checkasm --bench > and report on the timings for both the C and assembly versions. > If you've made a mistake somewhere, (forgot to restore stack, or a > callee-saved register, or

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: stop using AVPacket on stack

2023-05-20 Thread James Almer
On 5/20/2023 6:41 AM, Paul B Mahol wrote: Why you doing this to me? I already did this in my patch, that you ignored. You did it in the activate patch, that i did not look at because i could not review it, sorry. Patch dropped then. ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: stop using AVPacket on stack

2023-05-20 Thread Paul B Mahol
On 5/20/23, James Almer wrote: > On 5/20/2023 6:41 AM, Paul B Mahol wrote: >> Why you doing this to me? >> I already did this in my patch, that you ignored. > > You did it in the activate patch, that i did not look at because i could > not review it, sorry. > > Patch dropped then. I can push this

[FFmpeg-devel] [IMPORTANT] Missing documentation

2023-05-20 Thread Paul B Mahol
Hi, What is about muxer/demuxer documentation? More than half is not documented at all. I'm busy working on other things, what are doc maintainers doing? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: stop using AVPacket on stack

2023-05-20 Thread James Almer
On 5/20/2023 8:43 AM, Paul B Mahol wrote: On 5/20/23, James Almer wrote: On 5/20/2023 6:41 AM, Paul B Mahol wrote: Why you doing this to me? I already did this in my patch, that you ignored. You did it in the activate patch, that i did not look at because i could not review it, sorry. Patch

[FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

2023-05-20 Thread James Almer
Vorbis is not usually supported by Smart TVs, receivers and set top boxes, so it's not a good idea to have it as the default. Signed-off-by: James Almer --- libavformat/matroskaenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/mat

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/av1dec: use av_frame_replace()

2023-05-20 Thread James Almer
On 5/18/2023 11:10 AM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/av1dec.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Will apply set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

[FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets

2023-05-20 Thread James Almer
Fixes decoding packets containing split temporal units, as generated for example by the av1_frame_split bsf. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index c15e9

[FFmpeg-devel] [PATCH] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Matthias Walliczek
Supports the european DAB+ digital radio coding Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window is not implemented" Signed-off-by: Matthias Walliczek --- libavcodec/aacdec_template.c | 21 ++ libavcodec/aacps.c | 10 +++-- libavcodec/aacps.h

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Paul B Mahol
On 5/20/23, Matthias Walliczek wrote: > Supports the european DAB+ digital radio coding > > Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT > window is not implemented" > > Signed-off-by: Matthias Walliczek > --- > libavcodec/aacdec_template.c | 21 ++ > libavcode

Re: [FFmpeg-devel] [IMPORTANT] Missing documentation

2023-05-20 Thread Gyan Doshi
On 2023-05-20 05:20 pm, Paul B Mahol wrote: Hi, What is about muxer/demuxer documentation? More than half is not documented at all. I'm busy working on other things, what are doc maintainers doing? I was in the middle of doing this in the summer of 2021 when we went into another lockdown a

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Matthias Walliczek
On 20.05.2023 15:29, Paul B Mahol wrote: On 5/20/23, Matthias Walliczek wrote: [...] +int AAC_RENAME(ff_ps_apply)(AVCodecContext *avctx, PSContext *ps, INTFLOAT L[2][38][64], INTFLOAT R[2][38][64], int top, +int frame_length_short) { INTFLOAT (*Lbuf)[32][2

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Lynne
May 20, 2023, 15:26 by matth...@walliczek.de: > Supports the european DAB+ digital radio coding > > Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window > is not implemented" > > Signed-off-by: Matthias Walliczek > --- > libavcodec/aacdec_template.c | 21 ++ > li

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Matthias Walliczek
On 20.05.2023 16:17, Lynne wrote: Yeah, no, this patch is far from complete. I have a more complete and correct patch I was working on which had a minor issue I didn't get around to fixing. I'll see if I have missed changing a constant that you haven't missed. Your patch looks definitely more

Re: [FFmpeg-devel] 回复: [PATCH] avcodec/videotoolboxenc: add low-latency encoding

2023-05-20 Thread Rick Kern
On Fri, May 19, 2023 at 2:06 PM Zhao Zhili wrote: > > > From: ffmpeg-devel On Behalf Of Rick > Kern > > Sent: 2023年5月19日 21:37 > > To: FFmpeg development discussions and patches > > Cc: zhilizhao(赵志立) > > Subject: Re: [FFmpeg-devel] 回复: [PATCH] avcodec/videotoolboxenc: add > low-latency encodi

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread Anton Khirnov
Quoting James Almer (2023-05-20 03:50:57) > Signed-off-by: James Almer > --- > libavcodec/av1dec.c | 75 + > libavcodec/av1dec.h | 4 +++ > 2 files changed, 60 insertions(+), 19 deletions(-) The patch makes the code longer and introduces an evil backw

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets

2023-05-20 Thread Anton Khirnov
Quoting James Almer (2023-05-20 15:21:13) > Fixes decoding packets containing split temporal units, as generated for > example > by the av1_frame_split bsf. > > Signed-off-by: James Almer > --- > libavcodec/libdav1d.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets

2023-05-20 Thread James Almer
On 5/20/2023 1:14 PM, Anton Khirnov wrote: Quoting James Almer (2023-05-20 15:21:13) Fixes decoding packets containing split temporal units, as generated for example by the av1_frame_split bsf. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 9 ++--- 1 file changed, 6 insertions(

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread James Almer
On 5/20/2023 1:12 PM, Anton Khirnov wrote: Quoting James Almer (2023-05-20 03:50:57) Signed-off-by: James Almer --- libavcodec/av1dec.c | 75 + libavcodec/av1dec.h | 4 +++ 2 files changed, 60 insertions(+), 19 deletions(-) The patch makes the

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets

2023-05-20 Thread Anton Khirnov
Quoting James Almer (2023-05-20 18:42:11) > On 5/20/2023 1:14 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-05-20 15:21:13) > >> Fixes decoding packets containing split temporal units, as generated for > >> example > >> by the av1_frame_split bsf. > >> > >> Signed-off-by: James Almer > >

Re: [FFmpeg-devel] 回复: [PATCH] avcodec/videotoolboxenc: add low-latency encoding

2023-05-20 Thread Zhao Zhili
> From: ffmpeg-devel On Behalf Of Rick Kern > Sent: 2023年5月20日 23:01 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] 回复: [PATCH] avcodec/videotoolboxenc: add > low-latency encoding > > On Fri, May 19, 2023 at 2:06 PM Zhao Zhili wrote: > > > > > > From: ffmpeg-d

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread Andreas Rheinhardt
James Almer: > On 5/20/2023 1:12 PM, Anton Khirnov wrote: >> Quoting James Almer (2023-05-20 03:50:57) >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/av1dec.c | 75 + >>>   libavcodec/av1dec.h |  4 +++ >>>   2 files changed, 60 insertions(+), 19

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread James Almer
On 5/20/2023 1:59 PM, Andreas Rheinhardt wrote: James Almer: On 5/20/2023 1:12 PM, Anton Khirnov wrote: Quoting James Almer (2023-05-20 03:50:57) Signed-off-by: James Almer ---   libavcodec/av1dec.c | 75 +   libavcodec/av1dec.h |  4 +++   2 files

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread Andreas Rheinhardt
James Almer: > On 5/20/2023 1:59 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 5/20/2023 1:12 PM, Anton Khirnov wrote: Quoting James Almer (2023-05-20 03:50:57) > Signed-off-by: James Almer > --- >    libavcodec/av1dec.c | 75 > +-

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread James Almer
On 5/20/2023 2:07 PM, Andreas Rheinhardt wrote: James Almer: On 5/20/2023 1:59 PM, Andreas Rheinhardt wrote: James Almer: On 5/20/2023 1:12 PM, Anton Khirnov wrote: Quoting James Almer (2023-05-20 03:50:57) Signed-off-by: James Almer ---    libavcodec/av1dec.c | 75

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread Andreas Rheinhardt
James Almer: > On 5/20/2023 2:07 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 5/20/2023 1:59 PM, Andreas Rheinhardt wrote: James Almer: > On 5/20/2023 1:12 PM, Anton Khirnov wrote: >> Quoting James Almer (2023-05-20 03:50:57) >>> Signed-off-by: James Almer >>> ---

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread James Almer
On 5/20/2023 2:17 PM, Andreas Rheinhardt wrote: James Almer: On 5/20/2023 2:07 PM, Andreas Rheinhardt wrote: James Almer: On 5/20/2023 1:59 PM, Andreas Rheinhardt wrote: James Almer: On 5/20/2023 1:12 PM, Anton Khirnov wrote: Quoting James Almer (2023-05-20 03:50:57) Signed-off-by: James A

[FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets

2023-05-20 Thread James Almer
Fixes decoding packets containing split temporal units, as generated for example by the av1_frame_split bsf. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/libavcodec/libdav1d.c b/

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread Michael Niedermayer
On Fri, May 19, 2023 at 10:50:57PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/av1dec.c | 75 + > libavcodec/av1dec.h | 4 +++ > 2 files changed, 60 insertions(+), 19 deletions(-) Crashes intermittently (so maybe its not

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread James Almer
On 5/20/2023 2:23 PM, Michael Niedermayer wrote: On Fri, May 19, 2023 at 10:50:57PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavcodec/av1dec.c | 75 + libavcodec/av1dec.h | 4 +++ 2 files changed, 60 insertions(+), 19 deletions(

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

2023-05-20 Thread Michael Niedermayer
On Sat, May 20, 2023 at 09:42:33AM -0300, James Almer wrote: > Vorbis is not usually supported by Smart TVs, receivers and set top boxes, so > it's not a good idea to have it as the default. > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 3 +-- > 1 file changed, 1 insertion(+

Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: add chroma_mc checkasm test

2023-05-20 Thread Lynne
May 18, 2023, 16:21 by d...@lynne.ee: > Checks all variants of put_h264_chroma and avg_h264_chroma. > > Patch attached. > Pushed a better and more correct version. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove hScale8To19_vsx

2023-05-20 Thread Lynne
May 18, 2023, 14:53 by d...@lynne.ee: > Fails checkasm on a Power9 DD2.2 02CY771 system. > The assembly doesn't seem to have been independently tested at all. > > https://paste.sr.ht/~ky0ko/fe255ff73fab49b0c6d335437d894c1db626289e > > Patch attached. > Pushed. Maybe PPC will get better testing on

[FFmpeg-devel] [PATCH v3] avcodec/av1dec: convert to receive_frame()

2023-05-20 Thread James Almer
This removes the overhead of inserting the av1_frame_split bsf as part of the decoding process. Signed-off-by: James Almer --- configure | 2 +- libavcodec/av1dec.c | 77 ++--- libavcodec/av1dec.h | 4 +++ 3 files changed, 63 insertions(+), 20

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

2023-05-20 Thread Kieran Kunhya
FFac3 on TVs and devices doesn't write some of the dynamic range control fields and is super quiet on a lot of TVs. I would make AAC the default. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-deve

[FFmpeg-devel] [PATCH v2] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Matthias Walliczek
Supports the european DAB+ digital radio coding Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window is not implemented" Co-developed-by: Lynne Signed-off-by: Matthias Walliczek --- libavcodec/aacdec_template.c | 17 ++ libavcodec/aacps.c | 8 +

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Lynne
May 20, 2023, 22:17 by matth...@walliczek.de: > Supports the european DAB+ digital radio coding > > Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window > is not implemented" > > Co-developed-by: Lynne > Signed-off-by: Matthias Walliczek > --- > libavcodec/aacdec_templa

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: support additional options

2023-05-20 Thread Rick Kern
Added support for more VideoToolbox encoder options: - qmin and qmax options are now used - max_slice_bytes: Max number of bytes per H.264 slice - max_ref_frames: Limit the number of reference frames - Disable open GOP when the cgop flag is set - power_efficient: Enable power-efficient mode --- li

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

2023-05-20 Thread Leo Izen
On 5/20/23 15:51, Kieran Kunhya wrote: FFac3 on TVs and devices doesn't write some of the dynamic range control fields and is super quiet on a lot of TVs. I would make AAC the default. +1 for AAC being the default, considering that it's going to be supported more than probably anything else e

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: support additional options

2023-05-20 Thread Marvin Scholz
On 21 May 2023, at 0:24, Rick Kern wrote: > Added support for more VideoToolbox encoder options: > - qmin and qmax options are now used > - max_slice_bytes: Max number of bytes per H.264 slice > - max_ref_frames: Limit the number of reference frames > - Disable open GOP when the cgop flag is se

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec: add support for AAC SBR with 960 frame length

2023-05-20 Thread Lynne
May 20, 2023, 22:47 by d...@lynne.ee: > May 20, 2023, 22:17 by matth...@walliczek.de: > >> Supports the european DAB+ digital radio coding >> >> Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window >> is not implemented" >> >> Co-developed-by: Lynne >> Signed-off-by: Ma