On Mon, 24 Apr 2023, Devin Heitmueller wrote:
Hello Marton,
Thanks for reviewing. Comments inline:
On Sun, Apr 23, 2023 at 2:43 PM Marton Balint wrote:
In general, queueing packets in specific components should be avoided if
possible. Muxed packets are normally ordered by DTS and stream i
Zhao Zhili 于2023年4月26日周三 10:49写道：
>
> From: Zhao Zhili
>
> So the values are in ascending order.
>
> Signed-off-by: Zhao Zhili
> ---
> libavcodec/options_table.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h
> in
Quoting Nicolas George (2023-04-25 19:11:44)
> Hi.
>
> I finally have some tome to go at this again.
>
> Totalizing this thread, the previous discussions and the few private
> mails I received, I conclude there is significant more support than
> opposition to AVWriter, so I am moving forward with
Not in the order in which the packets were passed to the muxer, which
may be arbitrary. This guarantees stable and predictable output.
Changes the result of fate-cover-art-mp3-id3v2-remux, where the pictures
are now ordered correctly in the file.
---
libavformat/mp3enc.c | 64
On Mon, Apr 24, 2023 at 05:55:51PM +0200, Anton Khirnov wrote:
> Current code will call avpriv_set_pts_info() for each video frame,
> possibly setting a different timebase if the stream framerate changes.
> This violates API conventions, as the timebase is supposed to stay
> constant after stream c
Signed-off-by: Nicolas George
---
libavcodec/intrax8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c
index e4c8b96c9c..c5c6727282 100644
--- a/libavcodec/intrax8.c
+++ b/libavcodec/intrax8.c
@@ -109,7 +109,7 @@ static inline void x
Fix setting the assert level.
Signed-off-by: Nicolas George
---
libavutil/avassert.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavutil/avassert.h b/libavutil/avassert.h
index 51e462bbae..8f3f72c80c 100644
--- a/libavutil/avassert.h
+++ b/libavutil/avassert.h
@@ -28,6 +28,7 @@
#defin
> On Apr 12, 2023, at 01:49, Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> ---
> libavcodec/avcodec.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
> index fb1362290f..5a96899d50 100644
> --- a/libavcodec/avcodec.c
> ++
On Wed, Apr 26, 2023 at 2:32 PM Nicolas George wrote:
>
> Fix setting the assert level.
>
> Signed-off-by: Nicolas George
> ---
> libavutil/avassert.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavutil/avassert.h b/libavutil/avassert.h
> index 51e462bbae..8f3f72c80c 100644
> ---
Hendrik Leppkes (12023-04-26):
> This is an installed header, it cannot depend on config.h
Thanks for spotting it, that was counter-intuitive since config.h is
almost indispensable to its workings.
Updated version attached, similar to what exists in common.h.
Regards,
--
Nicolas George
From
Connected FFmpeg to Mediacodec VP8 encoder
---
configure | 1 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/mediacodec_wrapper.c | 4
libavcodec/mediacodecenc.c | 29 +
5 files changed, 36 insert
Connected FFmpeg to Mediacodec AV1 encoder
---
configure | 1 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/mediacodec_wrapper.c | 12
libavcodec/mediacodecenc.c | 115
5 files changed, 1
Hi Lance,
Thank you for your review. Comments inline.
On Tue, Apr 25, 2023 at 10:28 AM Lance Wang wrote:
> > +/* Based on the target FPS, figure out the expected cc_count and
> > number of
> > + 608 tuples per packet. See ANSI/CTA-708-E Sec 4.3.6.1. */
> > +for (i = 0; i < (sizeo
Hello Marton,
On Wed, Apr 26, 2023 at 3:36 AM Marton Balint wrote:
> Okay, I realized there is one thing here I don't understand. What if we
> interleave data packets the same way as others, but we don't wait for them
> in order to start flushing packet queues?
>
> So I wonder, if you removed the
Hi Marton,
Sorry, I'm now recognizing I should have answered this email prior to
the later one. Comments inline:
On Tue, Apr 25, 2023 at 5:59 PM Marton Balint wrote:
> > Regarding the use of avpriv_packet_list() as opposed to
> > avpacket_queue_*, I used the avpacket_queue functions for consist
From: Pierre-Anthony Lemieux
---
libavformat/imf_cpl.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
index ad84a68b13..a7cf5fa360 100644
--- a/libavformat/imf_cpl.c
+++ b/libavformat/imf_cpl.c
@@ -608,11 +608,10 @
From: Pierre-Anthony Lemieux
---
libavformat/tests/imf.c | 65 +
tests/ref/fate/imf | 2 ++
2 files changed, 67 insertions(+)
diff --git a/libavformat/tests/imf.c b/libavformat/tests/imf.c
index 2cacb43f47..cfd84fb8c8 100644
--- a/libavformat/tests/
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Ting Fu
> Sent: Monday, March 6, 2023 9:56 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend as
> unsupported
>
> Native is deprecated value for backed_type option. Modify re
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Ting Fu
> Sent: Monday, March 6, 2023 9:56 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH V6 2/3] lavfi/dnn: Modified DNN native
> backend related tools and docs.
>
> Deleted the native backend related files in
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Ting Fu
> Sent: Monday, March 6, 2023 9:56 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH V6 3/3] lavfi/dnn: Remove DNN native
> backend
This commit LGTM, thanks.
___
20 matches
Mail list logo
