[FFmpeg-devel] [PATCH 1/2] avfilter/vf_tpad: use enum for start/stop_mode

2023-04-19 Thread Marvin Scholz
--- libavfilter/vf_tpad.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c index f0c065f0c3..88c3c99de4 100644 --- a/libavfilter/vf_tpad.c +++ b/libavfilter/vf_tpad.c @@ -27,6 +27,12 @@ #include "formats.h"

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_tpad: accept hardware frames in clone-only mode

2023-04-19 Thread Marvin Scholz
When no drawing is to be performed, tpad can work fine with hardware frames, so advertise this in the query_formats callback and ensure the drawing context is never initialized when just cloning frames. --- libavfilter/vf_tpad.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_tpad: accept hardware frames in clone-only mode

2023-04-19 Thread Marvin Scholz
On 19 Apr 2023, at 12:42, Marvin Scholz wrote: > When no drawing is to be performed, tpad can work fine with > hardware frames, so advertise this in the query_formats > callback and ensure the drawing context is never initialized > when just cloning frames. > --- > libavfilter/vf_tpad.c | 15 ++

Re: [FFmpeg-devel] [PATCH v20 08/10] avformat/mov_demuxer: Extended MOV demuxer to handle EVC video content

2023-04-19 Thread James Almer
On 4/18/2023 7:32 AM, Dawid Kozinski wrote: - Added evc extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- libavformat/demux.c | 1 + libavformat/mov.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/demux.c b/libavf

Re: [FFmpeg-devel] [PATCH v20 07/10] avformat/mov_muxer: Extended MOV muxer to handle EVC video content

2023-04-19 Thread James Almer
On 4/18/2023 7:32 AM, Dawid Kozinski wrote: diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c index 86c7272525..2a29823b2e 100644 --- a/libavformat/isom_tags.c +++ b/libavformat/isom_tags.c @@ -147,6 +147,8 @@ const AVCodecTag ff_codec_movvideo_tags[] = { { AV_CODEC_ID_H264, MK

Re: [FFmpeg-devel] [PATCH v20 02/10] avcodec/evc_parser: Added parser implementation for EVC format

2023-04-19 Thread James Almer
On 4/18/2023 7:30 AM, Dawid Kozinski wrote: static EVCParserSliceHeader *parse_slice_header(const uint8_t *bs, int bs_size, EVCParserContext *ev) { GetBitContext gb; EVCParserSliceHeader *sh; EVCParserPPS *pps; EVCParserSPS *sps; int num_tiles_in_slice = 0; int slice_pic

Re: [FFmpeg-devel] [PATCH] yuv4mpegenc: add bitdepth multiplier after rounding width.

2023-04-19 Thread Ronald S. Bultje
Hi, On Mon, Apr 17, 2023 at 11:00 AM Ronald S. Bultje wrote: > Fixes output of HBD odd-width chroma. > --- > libavformat/yuv4mpegenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/yuv4mpegenc.c b/libavformat/yuv4mpegenc.c > index fc6b08e0cd..2fa5ee2714

Re: [FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common code changes

2023-04-19 Thread Lynne
Apr 17, 2023, 11:25 by an...@khirnov.net: > Quoting Lynne (2023-03-14 07:33:43) > >> From 6e2dfc44e50798264eb16bc2dcabfdbf2fbac2d7 Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Thu, 15 Dec 2022 01:06:52 +0100 >> Subject: [PATCH 24/92] hwconfig: add a new HWACCEL_CAP_THREAD_SAFE for >> threads

Re: [FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common code changes

2023-04-19 Thread Lynne
Apr 17, 2023, 11:07 by an...@khirnov.net: > Quoting Anton Khirnov (2023-04-16 22:38:16) > >> Quoting Lynne (2023-03-14 07:33:43) >> > From 61f412eea3fbcb1e2a8625796760c0e24fa3fb83 Mon Sep 17 00:00:00 2001 >> > From: Lynne >> > Date: Tue, 17 Jan 2023 05:01:45 +0100 >> > Subject: [PATCH 27/92] h264

Re: [FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common code changes

2023-04-19 Thread Lynne
Apr 17, 2023, 11:46 by an...@khirnov.net: > Quoting Lynne (2023-03-14 07:33:43) > >> From e37330cf6a1f768c733ca6d0b23b9e5847a5fe4f Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Thu, 10 Mar 2022 18:03:05 +0100 >> Subject: [PATCH 25/92] avcodec: add AVHWAccel.free_frame_priv callback >> diff --g

Re: [FFmpeg-devel] [PATCH] avutil/frame: use bitfields for some boolean and enum fields

2023-04-19 Thread Lynne
Apr 17, 2023, 19:27 by jamr...@gmail.com: > On 4/17/2023 2:25 PM, Lynne wrote: > >> Apr 17, 2023, 17:15 by jamr...@gmail.com: >> >>> On 4/17/2023 12:00 PM, Lynne wrote: >>> Apr 17, 2023, 16:40 by jamr...@gmail.com: > Should reduce the size of AVFrame in the next major bump without ch

[FFmpeg-devel] [PATCH] 0001-libavutil-tx-Check-also-for-ARCH_X86.patch

2023-04-19 Thread Alessandro Bono
Fallout from 9787005846893c1d1c01cb8ac71abed91980b218. While it doesn't make sense to pass --enable-x86asm option in a arm64 build, this is the only place where we don't check also for ARCH_X86 when we check for HAVE_X86ASM in code that is not x86-specific. As a consequence we get: ``` Undefined s

[FFmpeg-devel] [PATCH v3 0/3] RGB mjpeg fixes (with FATE tests)

2023-04-19 Thread Leo Izen
This is the same patchset as v2, with an additional patch to fix TRAC issue #10910 which was broken before any of the recent RGB mjpeg patches. Leo Izen (3): avcodec/mjpegdec: fix non-subsampled RGB JPEGs avcodec/mjpeg: fix weird RGB-subsampled baseline JPEGs fate: add tests for RGB jpegs

[FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Leo Izen
The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 created a regression for non-subsampled progressive RGB jpegs. This should fix that. --- libavcodec/mjpegdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index

[FFmpeg-devel] [PATCH v3 2/3] avcodec/mjpeg: fix weird RGB-subsampled baseline JPEGs

2023-04-19 Thread Leo Izen
These were broken before any of the recent RGB JPEG commits. This is an additional fix to bring them in line with the rest of the RGB jpegs, which should now all work after the previous patch. Fixes #10190. --- libavcodec/mjpegdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavc

[FFmpeg-devel] [PATCH v3 3/3] fate: add tests for RGB jpegs

2023-04-19 Thread Leo Izen
Added framecrc tests for RGB JPEGs to verify future changes to the decoder. --- tests/fate/image.mak | 9 + tests/ref/fate/jpg-rgb-221 | 6 ++ tests/ref/fate/jpg-rgb-baseline| 6 ++ tests/ref/fate/jpg-rgb-progressive | 6 ++ 4 files changed, 27 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix regression with baseline RGB JPEGs

2023-04-19 Thread Michael Niedermayer
On Thu, Apr 13, 2023 at 08:45:06AM -0400, Leo Izen wrote: > Commit b18a9c29713abc3a1b081de3f320ab53a47120c6 introduced a regression > that broke some baseline RGB jpegs. (See Trac issue #4045). This fixes > that. > > Signed-off-by: Leo Izen > --- > libavcodec/mjpegdec.c | 5 - > 1 file chang

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix regression with baseline RGB JPEGs

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 08:30:13PM +0200, Michael Niedermayer wrote: > On Thu, Apr 13, 2023 at 08:45:06AM -0400, Leo Izen wrote: > > Commit b18a9c29713abc3a1b081de3f320ab53a47120c6 introduced a regression > > that broke some baseline RGB jpegs. (See Trac issue #4045). This fixes > > that. > > > >

Re: [FFmpeg-devel] [PATCH v3 0/3] RGB mjpeg fixes (with FATE tests)

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 02:11:23PM -0400, Leo Izen wrote: > This is the same patchset as v2, with an additional patch to fix TRAC issue > #10910 > which was broken before any of the recent RGB mjpeg patches. > > Leo Izen (3): > avcodec/mjpegdec: fix non-subsampled RGB JPEGs > avcodec/mjpeg: f

Re: [FFmpeg-devel] [PATCH v3 3/3] fate: add tests for RGB jpegs

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 02:11:26PM -0400, Leo Izen wrote: > Added framecrc tests for RGB JPEGs to verify future changes to the > decoder. > --- > tests/fate/image.mak | 9 + > tests/ref/fate/jpg-rgb-221 | 6 ++ > tests/ref/fate/jpg-rgb-baseline| 6 ++ > te

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: > The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 > created a regression for non-subsampled progressive RGB jpegs. This > should fix that. > --- > libavcodec/mjpegdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Leo Izen
On 4/19/23 14:58, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 created a regression for non-subsampled progressive RGB jpegs. This should fix that. --- libavcodec/mjpegdec.c | 3 ++- 1 fi

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix regression with baseline RGB JPEGs

2023-04-19 Thread Leo Izen
On 4/19/23 14:33, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 08:30:13PM +0200, Michael Niedermayer wrote: On Thu, Apr 13, 2023 at 08:45:06AM -0400, Leo Izen wrote: Commit b18a9c29713abc3a1b081de3f320ab53a47120c6 introduced a regression that broke some baseline RGB jpegs. (See Trac issue

[FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report

2023-04-19 Thread Anton Khirnov
When an encoder exports sum-of-squared-differences information in encoded packets, print_report() will print PSNR information in the status line. However, * the code computing PSNR assumes 8bit 420 video and prints incorrect values otherwise; there are no issues on trac about this * only a few en

[FFmpeg-devel] [PATCH 03/25] lavfi/avf_concat: rescale frame durations

2023-04-19 Thread Anton Khirnov
--- libavfilter/avf_concat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index c85c17b51f..af758c5292 100644 --- a/libavfilter/avf_concat.c +++ b/libavfilter/avf_concat.c @@ -179,6 +179,7 @@ static int push_frame(AVFilterContext *ctx, uns

[FFmpeg-devel] [PATCH 02/25] fftools/ffmpeg_filter: drop unused AUTO_INSERT_FILTER_INPUT()

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 21 - 1 file changed, 21 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 52a5d19351..ea182089b1 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1035,27 +1035,6 @@ static int configure_input_

[FFmpeg-devel] [PATCH 01/25] fftools/ffmpeg_filter: drop write-only FilterGraph.reconfiguration

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg.h| 1 - fftools/ffmpeg_filter.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index a9302a95f0..72020c8f3a 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -325,7 +325,6 @@ typedef struct FilterGraph { const char

[FFmpeg-devel] [PATCH 04/25] fftools/ffmpeg_enc: always use video frame durations when available

2023-04-19 Thread Anton Khirnov
Previously they would only be used with trivial filtergraphs, because filters did not handle frame durations. That is no longer true - most filters process frame durations properly (there may still be some that don't - this change will help finding and fixing them). Improves output video frame dur

[FFmpeg-devel] [PATCH 06/25] fftools/ffmpeg_enc: move handling final frames to video_sync_process()

2023-04-19 Thread Anton Khirnov
This code properly belongs there. --- fftools/ffmpeg_enc.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index e63da2ec97..859c7fdeee 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @

[FFmpeg-devel] [PATCH 07/25] fftools/ffmpeg: stop using InputStream.pts in ts_discontinuity_detect()

2023-04-19 Thread Anton Khirnov
ts_discontinuity_detect() is applied right after demuxing, while InputStream.pts is a post-decoding timestamp, which may be delayed with respect to demuxing by an arbitrary amount (e.g. depending on the thread count when frame threading is used). --- fftools/ffmpeg.c | 2 +- 1 file changed, 1 inse

[FFmpeg-devel] [PATCH 12/25] fftools/ffmpeg_mux_init: drop OutputStream.filters[_script]

2023-04-19 Thread Anton Khirnov
They are not needed outside of ost_get_filters(), so make them stack variables there. --- fftools/ffmpeg.h | 2 -- fftools/ffmpeg_mux_init.c | 28 +++- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 72020

[FFmpeg-devel] [PATCH 11/25] fftools/ffmpeg_mux_init: move check for mixing simple/complex filters

2023-04-19 Thread Anton Khirnov
Do it in ost_get_filters() together with other similar checks. Will be useful in following commits. Also, improve the log message. --- fftools/ffmpeg_mux_init.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmp

[FFmpeg-devel] [PATCH 13/25] fftools/ffmpeg: remove unused function arguments

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg_mux.c | 4 ++-- fftools/ffmpeg_mux_init.c | 9 - 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index a2e8873ad2..368a7000a9 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -255,7 +255,7 @@

[FFmpeg-devel] [PATCH 22/25] fftools/ffmpeg_filter: reindent after previous commit

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index cfd93a0f9d..b26160b375 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -196,39 +

[FFmpeg-devel] [PATCH 09/25] fftools/ffmpeg: replace stream timebase with packet one where appropriate

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index f2e9832003..e6ee3ce557 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1146,7 +1146,7 @@ static int decode_audio(InputS

[FFmpeg-devel] [PATCH 08/25] fftools/ffmpeg: stop setting InputStream.pts for streamcopy

2023-04-19 Thread Anton Khirnov
It is not used in that case anymore. Forgotten in d56652fdc8e1315309516be320a7250854550fa5. --- fftools/ffmpeg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index cc087ea7de..f2e9832003 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1743,7 +1743

[FFmpeg-devel] [PATCH 10/25] fftools/ffmpeg_mux_init: consolidate handling -filter for audio/video

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg_mux_init.c | 68 +-- 1 file changed, 30 insertions(+), 38 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 89c0ac90ea..7c35d6b582 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -

[FFmpeg-devel] [PATCH 20/25] fftools/ffmpeg: move filtering functions to ffmpeg_filter

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg.c| 216 +--- fftools/ffmpeg.h| 20 fftools/ffmpeg_filter.c | 202 + 3 files changed, 223 insertions(+), 215 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index e6ee3ce5

[FFmpeg-devel] [PATCH 05/25] fftools/ffmpeg_enc: rename next_picture to frame

2023-04-19 Thread Anton Khirnov
The name is misleading, because it is not a picture in the sense of MPEG terminology (which define "picture" as "frame or field"), but always a full frame. 'next' is also redundant and/or misleading, because it is the _current_ frame to be encoded. --- fftools/ffmpeg_enc.c | 36 +--

[FFmpeg-devel] [PATCH 15/25] fftools/ffmpeg: reindent after previous commit

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg_mux_init.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 28254cb49b..ad5a451581 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -128,21 +12

[FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

2023-04-19 Thread Anton Khirnov
Start by moving OutputStream.filtered_frame to it, which really belong to the filtergraph rather than the output stream. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_filter.c | 31 ++- fftools/ffmpeg_mux.c | 1 - fftools/ffmpeg_mux_init.c | 4 4 fi

[FFmpeg-devel] [PATCH 25/25] fftools/ffmpeg_filter: make ifilter_parameters_from_frame() static

2023-04-19 Thread Anton Khirnov
It is no longer used outside of this file. --- fftools/ffmpeg.h| 1 - fftools/ffmpeg_filter.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index e3530d1699..43073f9a3c 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -801,

[FFmpeg-devel] [PATCH 16/25] fftools/ffmpeg_filter: add a function for creating a filtergraph

2023-04-19 Thread Anton Khirnov
Code creating a new filtergraph is currently duplicated in 3 places. This commit unifies it and moves towards making filtergraphs more self-contained. --- fftools/ffmpeg.h| 8 fftools/ffmpeg_filter.c | 18 +- fftools/ffmpeg_opt.c| 14 +- 3 files ch

[FFmpeg-devel] [PATCH 17/25] fftools/ffmpeg_mux_init: drop a redundant assignment

2023-04-19 Thread Anton Khirnov
OutputFilter.format is initialized in ofilter_alloc(). --- fftools/ffmpeg_mux_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index ad5a451581..1a63908074 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1259

[FFmpeg-devel] [PATCH 21/25] fftools/ffmpeg: move freeing a filtergraph into a separate function

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg.c| 42 +++ fftools/ffmpeg.h| 2 ++ fftools/ffmpeg_filter.c | 44 + 3 files changed, 49 insertions(+), 39 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 248c22a4ff..

[FFmpeg-devel] [PATCH 24/25] fftools/ffmpeg: deprecate -adrift_threshold

2023-04-19 Thread Anton Khirnov
This option has had no effect since -async was removed in 3d86a13b47b726e49c2d780c5f723c290e8a36b4 --- doc/ffmpeg.texi | 6 -- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_opt.c | 14 -- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffm

[FFmpeg-devel] [PATCH 19/25] fftools/ffmpeg_mux_init: rename init_output_filter() to ost_add_from_filter()

2023-04-19 Thread Anton Khirnov
The previous name is misleading, because the function does not actually initialize any filters - it creates a new output stream and binds a filtergraph output to it. --- fftools/ffmpeg_mux_init.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b

[FFmpeg-devel] [PATCH 18/25] fftools/ffmpeg: simplify init_output_filter()

2023-04-19 Thread Anton Khirnov
--- fftools/ffmpeg_mux_init.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 1a63908074..db1f9fa9a6 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1245,16 +1245,7 @@ static Outp

[FFmpeg-devel] [PATCH 14/25] fftools/ffmpeg_mux_init: drop useless new_stream_{data, unknown}

2023-04-19 Thread Anton Khirnov
Their only function is checking that encoding was not specified for data/unknown-type streams, but the check is broken because enc_ctx will not be created in ost_add() unless a valid encoder can be found. Add an actually working check for all types for which encoding is not supported in choose_enc

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 03:23:41PM -0400, Leo Izen wrote: > On 4/19/23 14:58, Michael Niedermayer wrote: > > On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: > > > The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 > > > created a regression for non-subsampled progressive RG

Re: [FFmpeg-devel] [PATCH 04/25] fftools/ffmpeg_enc: always use video frame durations when available

2023-04-19 Thread James Almer
On 4/19/2023 4:52 PM, Anton Khirnov wrote: diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index e3dc858bc3..9aaec277f1 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -1005,24 +1005,17 @@ static void do_video_out(OutputFile *of, AVRational frame_rate; int64_t

Re: [FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 09:48:32PM +0200, Anton Khirnov wrote: > When an encoder exports sum-of-squared-differences information in > encoded packets, print_report() will print PSNR information in the > status line. However, > * the code computing PSNR assumes 8bit 420 video and prints incorrect >

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/jpeg2000dec: add support for HTJ2K block decoding

2023-04-19 Thread Tomas Härdin
Looks like my comments have been addressed, especially per-CB style /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report

2023-04-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-04-19 22:53:02) > On Wed, Apr 19, 2023 at 09:48:32PM +0200, Anton Khirnov wrote: > > When an encoder exports sum-of-squared-differences information in > > encoded packets, print_report() will print PSNR information in the > > status line. However, > > > * the code

Re: [FFmpeg-devel] [PATCH 04/25] fftools/ffmpeg_enc: always use video frame durations when available

2023-04-19 Thread Anton Khirnov
Quoting James Almer (2023-04-19 22:42:24) > On 4/19/2023 4:52 PM, Anton Khirnov wrote: > > diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c > > index e3dc858bc3..9aaec277f1 100644 > > --- a/fftools/ffmpeg_enc.c > > +++ b/fftools/ffmpeg_enc.c > > @@ -1005,24 +1005,17 @@ static void do_video_

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Leo Izen
On 4/19/23 16:37, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 03:23:41PM -0400, Leo Izen wrote: On 4/19/23 14:58, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 created a regression f

Re: [FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 11:06:09PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-04-19 22:53:02) > > On Wed, Apr 19, 2023 at 09:48:32PM +0200, Anton Khirnov wrote: > > > When an encoder exports sum-of-squared-differences information in > > > encoded packets, print_report() will pr

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/jpeg2000dec: add support for HTJ2K block decoding

2023-04-19 Thread Pierre-Anthony Lemieux
On Wed, Apr 19, 2023 at 1:55 PM Tomas Härdin wrote: > > Looks like my comments have been addressed, especially per-CB style Thanks for the review. I plan to merge the patchset this weekend. > > /Tomas > > ___ > ffmpeg-devel mailing list > ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/hevc_ps: further constrain allowed num_ref_loc_offsets values

2023-04-19 Thread James Almer
On 4/17/2023 11:16 AM, James Almer wrote: The spec says: "The value of num_ref_loc_offsets shall be in the range of 0 to vps_max_layers_minus1, inclusive". Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 13 +++-- libavcodec/hevc_ps.h | 2 +- 2 files changed, 8 insertions(+),

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Caleb Etemesi
if the problem you are trying to solve is upsampling, the agreed samples are usually 422,444 and 420 (Y,Cb,Cr order) but there can be files with sampling factors like 242, since the jfif spec isn't to restrictive on what sampling factors are allowed,libjpeg(and it's cousin libjpeg-turbo) support s

Re: [FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report

2023-04-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-04-20 00:12:48) > On Wed, Apr 19, 2023 at 11:06:09PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-04-19 22:53:02) > > > On Wed, Apr 19, 2023 at 09:48:32PM +0200, Anton Khirnov wrote: > > > > When an encoder exports sum-of-squared-differences in