[FFmpeg-devel] [PATCH] ffmpeg: pass encoder init AVFrame side data to output AVStream

2023-03-05 Thread Jan Ekström
This enables passing through various side data during encoding, which is not yet in AVCodecContext/AVCodecParameters, but is read from AVStream side data in muxers. Additionally, add a FATE test that demonstrates PNG->J2K MP4 transcoding with the ICC profile getting passed through. --- fftools/ff

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters

2023-03-05 Thread Stefano Sabatini
On date Wednesday 2023-03-01 15:33:51 +0100, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-03-01 01:05:29) [...] > > BTW, I noticied this as part of debugging transcode.c (which looks > > broken at the moment), since the timebase is read as 0/1 from the > > decoder context, it would be a va

[FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation

2023-03-05 Thread Michael Niedermayer
Fixes: left shift of 538976288 by 13 places cannot be represented in type 'int' Fixes: 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Ni

[FFmpeg-devel] [PATCH 2/2] avformat/wavdec: Check that smv block fits in available space

2023-03-05 Thread Michael Niedermayer
Fixes: OOM Fixes: 56271/clusterfuzz-testcase-minimized-ffmpeg_dem_WAV_fuzzer-5290810045497344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/wavdec.c | 4 1 file changed, 4 insertions(+

Re: [FFmpeg-devel] [PATCH] lavc/avcodec.h: extend documentation for avcodec_open2()

2023-03-05 Thread Stefano Sabatini
On date Wednesday 2023-03-01 15:04:16 +0800, "zhilizhao(赵志立)" wrote: > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index 9a0fe97cad..fbf1d3d83c 100644 > > --- a/libavcodec/avcodec.h > > +++ b/libavcodec/avcodec.h > > @@ -2418,8 +2418,14 @@ int avcodec_parameters_to_context(AVCode

Re: [FFmpeg-devel] [PATCH] tests: actually test yadif's 10 and 16-bit functions

2023-03-05 Thread James Darnley
On 2/20/23 14:06, James Darnley wrote: On 2/20/23 13:49, Nicolas George wrote: James Darnley (12023-02-20): snip Moving scale before yadif is right, but format= is redundant with -pix_fmt. Regards, So the patch should just be moving the scale filter first?  Sure.  Any other comments?  I

[FFmpeg-devel] trac optimization

2023-03-05 Thread Michael Niedermayer
Hi due to continuing performance issues (and complaints) about trac speed ive switched the database to WAL mode. This should make th db signifciantly faster but iam not sure the database was the limiting factor. Now reading and writing can proceed concurrently, before writes would block everything

[FFmpeg-devel] [PATCH v4] avformat: Add support for embedding cover art in Ogg files

2023-03-05 Thread Zsolt Vadász
This version can actually be applied to master. Also added checks to ensure there won't be an OGGStreamContext for the cover art to suppress warnings in mpv. Signed-off-by: Zsolt Vadasz --- libavformat/flac_picture.c | 132 ++ libavformat/flac_picture.h | 5 + libavformat/f

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation

2023-03-05 Thread Paul B Mahol
On 3/5/23, Michael Niedermayer wrote: > Fixes: left shift of 538976288 by 13 places cannot be represented in type > 'int' > Fixes: > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424 > Please make sure that this does not break decoding. > Found-by: continuous fu

Re: [FFmpeg-devel] [PATCH] ffmpeg: pass encoder init AVFrame side data to output AVStream

2023-03-05 Thread Jan Ekström
On Sun, Mar 5, 2023 at 1:17 PM Jan Ekström wrote: > > This enables passing through various side data during encoding, > which is not yet in AVCodecContext/AVCodecParameters, but is read > from AVStream side data in muxers. > > Additionally, add a FATE test that demonstrates PNG->J2K MP4 > transcod

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation

2023-03-05 Thread Michael Niedermayer
On Sun, Mar 05, 2023 at 05:37:09PM +0100, Paul B Mahol wrote: > On 3/5/23, Michael Niedermayer wrote: > > Fixes: left shift of 538976288 by 13 places cannot be represented in type > > 'int' > > Fixes: > > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424 > > > >

Re: [FFmpeg-devel] Subject: [PATCH v4] avformat: Add support for embedding cover art in Ogg files

2023-03-05 Thread Marton Balint
On Sat, 4 Mar 2023, Zsolt Vadász wrote: Signed-off-by: Zsolt Vadasz --- libavformat/flac_picture.c | 132 ++ libavformat/flac_picture.h | 5 + libavformat/flacenc.c | 90 +-- libavformat/oggenc.c | 217 ++--- 4 files ch

Re: [FFmpeg-devel] [PATCH v4] avformat: Add support for embedding cover art in Ogg files

2023-03-05 Thread Michael Niedermayer
On Sun, Mar 05, 2023 at 03:59:41PM +, Zsolt Vadász wrote: > This version can actually be applied to master. Also added checks to > ensure there won't be an OGGStreamContext for the cover art to suppress > warnings in mpv. > > Signed-off-by: Zsolt Vadasz > --- > libavformat/flac_picture.c | 1

[FFmpeg-devel] [PATCH] vulkan: Fix win/i386 calling convention and pointer/int conversion error

2023-03-05 Thread Martin Storsjö
This fixes the following two errors when compiling with a modern version of Clang for Windows/i386: src/libavutil/hwcontext_vulkan.c:738:32: error: incompatible function pointer types initializing 'PFN_vkDebugUtilsMessengerCallbackEXT' (aka 'unsigned int (*)(enum VkDebugUtilsMessageSeverityFlagB

Re: [FFmpeg-devel] [PATCH v2 2/8] avformat/mov: check that pcmC box is of the expected type

2023-03-05 Thread Jan Ekström
On Mon, Feb 27, 2023 at 6:26 PM Jan Ekström wrote: > > On Mon, Feb 27, 2023 at 3:36 PM Tomas Härdin wrote: > > > > lör 2023-02-25 klockan 02:28 +0800 skrev Zhao Zhili: > > > From: Jan Ekström > > > > > > As per 23003-5:2020 this box is defined as > > > PCMConfig extends FullBox(‘pcmC’, version =

Re: [FFmpeg-devel] [PATCH v2 3/8] avformat/mov: base the endianness on just the LSB

2023-03-05 Thread Jan Ekström
On Mon, Feb 27, 2023 at 3:37 PM Tomas Härdin wrote: > > lör 2023-02-25 klockan 02:28 +0800 skrev Zhao Zhili: > > From: Jan Ekström > > > > As per 23003-5:2020, the rest of the bits are reserved, and thus > > in the future they may be utilized for something else. > > > > Quote: > > format_flags is

Re: [FFmpeg-devel] [PATCH] avfilter/graphparser: fix filter instance name when an id is provided

2023-03-05 Thread James Almer
On 3/2/2023 10:02 AM, James Almer wrote: Restores the behavior of naming the instance filter@id, which was accidentally changed to simpy id in commit f17051eaae. Fixes ticket #10226. Signed-off-by: James Almer --- libavfilter/graphparser.c | 7 --- 1 file changed, 4 insertions(+), 3 de

[FFmpeg-devel] [PATCH 1/3] avcodec/escape124: fix signdness of end of input check

2023-03-05 Thread Michael Niedermayer
Fixes: Timeout Fixes: 56561/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ESCAPE124_fuzzer-5560363635834880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/escape124.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 2/3] avcodec/escape124: Fix some return codes

2023-03-05 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/escape124.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/escape124.c b/libavcodec/escape124.c index e9c6b2df1b..064a4e6bf5 100644 --- a/libavcodec/escape124.c +++ b/libavcodec/escape124.c @@ -89,11

[FFmpeg-devel] [PATCH 3/3] avcodec/escape124: Simplify unpack_codebook()

2023-03-05 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/escape124.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavcodec/escape124.c b/libavcodec/escape124.c index 064a4e6bf5..e8a8395f4b 100644 --- a/libavcodec/escape124.c +++ b/libavcodec/escape124.c @@ -97,15

[FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-03-05 Thread asivery
Signed-off-by: asivery --- libavformat/matroska.c | 1 + libavformat/matroskadec.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 90d94b65bf..37305a523c 100644 --- a/libavformat/matroska.c +++ b/libavformat/matroska.c @@ -55,6 +55,7 @@ co

Re: [FFmpeg-devel] RFC: opinions on making fftools work like a library

2023-03-05 Thread Steven Liu
Zhao Zhili 于2023年3月3日周五 18:15写道: > > I'd like to know what do you think about making fftools work like a > library, like what ffmpeg-kit already did, but with built-in support. > > https://github.com/arthenica/ffmpeg-kit > >FFmpegKit is a collection of tools to use FFmpeg in Android, iOS, >

[FFmpeg-devel] [PATCH] codec/arm/hevcdsp_idct_neon: remove duplicate mov

2023-03-05 Thread xufuji456
--- libavcodec/arm/hevcdsp_idct_neon.S | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libavcodec/arm/hevcdsp_idct_neon.S b/libavcodec/arm/hevcdsp_idct_neon.S index 41ca3b83a8..66ed1c6785 100644 --- a/libavcodec/arm/hevcdsp_idct_neon.S +++ b/libavcodec/arm/hevcdsp_i

[FFmpeg-devel] [PATCH v2] avcodec/mathops: Optimize generic mid_pred function

2023-03-05 Thread Junxian Zhu
From: Junxian Zhu Rewrite mid_pred function in generic mathops.h, reduce branch jump to improve performance. And because nowadays new version compiler can compile enough short asmbbely code as handwritting in these function, so remove specified optimized mips inline asmbbely mathops.h. Signed

Re: [FFmpeg-devel] [PATCH v2] avcodec/mathops: Optimize generic mid_pred function

2023-03-05 Thread James Almer
On 3/5/2023 11:38 PM, Junxian Zhu wrote: From: Junxian Zhu Rewrite mid_pred function in generic mathops.h, reduce branch jump to improve performance. And because nowadays new version compiler can compile enough short asmbbely code as handwritting in these function, so remove specified optimiz

[FFmpeg-devel] [PATCH v3 1/5] avformat/mov: fix ISO/IEC 23003-5 support

2023-03-05 Thread Zhao Zhili
From: Zhao Zhili Missing floating-point formats support. Signed-off-by: Zhao Zhili --- libavformat/isom.h | 2 ++ libavformat/mov.c | 49 ++ 2 files changed, 51 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index 5107b4eb74..4

[FFmpeg-devel] [PATCH v3 0/5] add PCM in mp4 support

2023-03-05 Thread Zhao Zhili
From: Zhao Zhili This patchset adds support of demux/mux PCM in mp4, and related channel layout information. PCM in mp4 is defined by ISO/IEC 23003-5. The channel layout tag 'chn' is defined by ISO/IEC 14496-12 with reference to ISO/IEC 23001-8. v3: 1. Rebase on master 2. Reorder the patchset to

[FFmpeg-devel] [PATCH v3 2/5] avformat/isom_tags: remove ipcm from movaudio_tags

2023-03-05 Thread Zhao Zhili
From: Zhao Zhili ipcm is defined by ISO/IEC 23003-5, not defined by quicktime. After adding ISO/IEC 23003-5 support, we don't need it for ticket #9219. Signed-off-by: Zhao Zhili --- libavformat/isom_tags.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/isom_tags.c b/libavform

[FFmpeg-devel] [PATCH v3 4/5] avformat/movenc: add PCM in mp4 support

2023-03-05 Thread Zhao Zhili
From: Zhao Zhili It's defined by ISO/IEC 23003-5. Fixes ticket #10185 Signed-off-by: Zhao Zhili --- libavformat/movenc.c | 84 +++- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c4fcb5f8b

[FFmpeg-devel] [PATCH v3 5/5] fate/mov: add PCM in mp4 test

2023-03-05 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- tests/fate/mov.mak | 12 tests/filtergraphs/mov-mp4-pcm | 5 + tests/ref/fate/mov-mp4-pcm | 27 +++ tests/ref/fate/mov-mp4-pcm-float | 7 +++ 4 files changed, 51 insertions(+) cr

[FFmpeg-devel] [PATCH v3 3/5] avformat/mov: parse ISO-14496-12 ChannelLayout

2023-03-05 Thread Zhao Zhili
From: Zhao Zhili Only support chnl version 0 now. Signed-off-by: Zhao Zhili --- libavformat/mov.c | 85 +++- libavformat/mov_chan.c | 296 + libavformat/mov_chan.h | 26 3 files changed, 406 insertions(+), 1 deletion(-) diff --git a/