Re: [FFmpeg-devel] [PATCH v3] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-28 Thread Xiang, Haihao
On Di, 2023-01-17 at 12:17 +0100, David Rosca wrote: > v3: pic_order_cnt steps by 2 > --- > libavcodec/vaapi_encode_h264.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c > index f15bcc6..de0951f 1

Re: [FFmpeg-devel] [PATCH] avfilter: add VA-API variants of the stack filters

2023-01-28 Thread Xiang, Haihao
On Do, 2023-01-19 at 16:30 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Include hstack_vaapi, vstack_vaapi and xstack_vaapi. They may accept > input streams with different sizes. libva2 (VA-API 1.0+) is required. > > Example: > $ ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi -i inp

[FFmpeg-devel] [PATCH 3/3] doc/ffmpeg: drop non-existent -dc option

2023-01-28 Thread Anton Khirnov
--- doc/ffmpeg.texi | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 67b3294256..6b93386b49 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1041,8 +1041,6 @@ version > 1: @code{out= %2d st= %2d frame= %5d q= %2.1f PSNR= %6.2f f_size= %6d s_size=

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: add an AVClass to MuxStream/OutputStream

2023-01-28 Thread Anton Khirnov
Use it for logging. This makes log messages related to this output stream more consistent. --- fftools/ffmpeg.c | 95 fftools/ffmpeg.h | 5 +- fftools/ffmpeg_demux.c| 10 +-- fftools/ffmpeg_mux.c | 13 ++-- fftools/ffmpeg_mux.h | 3 +

[FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: add an AVClass to Muxer/OutputFile

2023-01-28 Thread Anton Khirnov
Use it for logging. This makes log messages related to this output file more consistent. --- fftools/ffmpeg.h | 2 + fftools/ffmpeg_mux.c | 26 +++- fftools/ffmpeg_mux.h | 3 + fftools/ffmpeg_mux_init.c | 133 +++--- 4 files changed, 96 i

Re: [FFmpeg-devel] [PATCH 3/3] doc/ffmpeg: drop non-existent -dc option

2023-01-28 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: add an AVClass to MuxStream/OutputStream

2023-01-28 Thread Paul B Mahol
Probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: add an AVClass to Muxer/OutputFile

2023-01-28 Thread Paul B Mahol
Probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/19] lavc/avcodec: improve enc/dec API doxy

2023-01-28 Thread Anton Khirnov
Will push the set tomorrow if nobody has further comments. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.or

Re: [FFmpeg-devel] [PATCH 01/19] lavc/avcodec: improve enc/dec API doxy

2023-01-28 Thread Marvin Scholz
On 25 Jan 2023, at 17:55, Anton Khirnov wrote: > Change return value descriptions into proper lists. > --- > libavcodec/avcodec.h | 81 +++- > 1 file changed, 42 insertions(+), 39 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH 01/19] lavc/avcodec: improve enc/dec API doxy

2023-01-28 Thread Anton Khirnov
Quoting Marvin Scholz (2023-01-28 12:37:42) > > > On 25 Jan 2023, at 17:55, Anton Khirnov wrote: > > > Change return value descriptions into proper lists. > > --- > > libavcodec/avcodec.h | 81 +++- > > 1 file changed, 42 insertions(+), 39 deletions(-) >

[FFmpeg-devel] [PATCH] lavc/avcodec: improve enc/dec API doxy

2023-01-28 Thread Anton Khirnov
Change return value descriptions into proper lists. --- libavcodec/avcodec.h | 79 ++-- 1 file changed, 39 insertions(+), 40 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 0ac581d660..ad6377e8d8 100644 --- a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 32/32] avutil/{color_utils, csp}: merge color_utils into csp and expose API

2023-01-28 Thread Leo Izen
libavutil/color_utils contains some avpriv_ symbols that map enum AVTransferCharacteristic values to gamma-curve approximations and to the actual transfer functions to invert them (i.e. -> linear). There's two issues with this: (1) avpriv is evil and should be avoided whenever possible (2) libavut

Re: [FFmpeg-devel] drawtext filter

2023-01-28 Thread Francesco Carusi
On 27/01/2023 18:31, Paul B Mahol wrote: On 1/27/23, Francesco Carusi wrote: On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: The drawtext reinit command is also used in the docs as an

Re: [FFmpeg-devel] [PATCH 01/19] lavc/avcodec: improve enc/dec API doxy

2023-01-28 Thread Marvin Scholz
On 28 Jan 2023, at 14:23, Anton Khirnov wrote: > Quoting Marvin Scholz (2023-01-28 12:37:42) >> >> >> On 25 Jan 2023, at 17:55, Anton Khirnov wrote: >> >>> Change return value descriptions into proper lists. >>> --- >>> libavcodec/avcodec.h | 81 +++- >>>

Re: [FFmpeg-devel] drawtext filter

2023-01-28 Thread Paul B Mahol
On 1/28/23, Francesco Carusi wrote: > On 27/01/2023 18:31, Paul B Mahol wrote: >> On 1/27/23, Francesco Carusi wrote: >>> On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: > On 26/01/2023 14:21, Paul B Mahol wrote: >> On 1/26/23, Francesco Carusi wrote: >

[FFmpeg-devel] [PATCH] lavfi/vf_ssim360: Fix compilation with MSVC

2023-01-28 Thread Martin Storsjö
Don't use "static const" for compile time float constants, but use defines. This fixes the following error: src/libavfilter/vf_ssim360.c(549): error C2099: initializer is not a constant Signed-off-by: Martin Storsjö --- libavfilter/vf_ssim360.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [FFmpeg-devel] [PATCH] lavfi/vf_ssim360: Fix compilation with MSVC

2023-01-28 Thread Martin Storsjö
On Sat, 28 Jan 2023, Martin Storsjö wrote: Don't use "static const" for compile time float constants, but use defines. This fixes the following error: src/libavfilter/vf_ssim360.c(549): error C2099: initializer is not a constant Signed-off-by: Martin Storsjö --- libavfilter/vf_ssim360.c | 6 +

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Fix left-shift of negative value

2023-01-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_ssim360.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c index a0bf73da1e..89f5100740 100644 --- a/libavfilter/vf_ssim360.c +++ b/libavfilter/vf_ssim360.c @@ -547,7 +547,7

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_ssim360: Don't initialize twice

2023-01-28 Thread Andreas Rheinhardt
The FILTER_INPUTS and FILTER_OUTPUTS macros already set AVFilter.(inputs|outputs); Clang therefore emits a warning for this: "initializer overrides prior initialization of this subobject [-Winitializer-overrides]" Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_ssim360.c | 2 -- 1 file chan

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_ssim369: Constify AVFilter

2023-01-28 Thread Andreas Rheinhardt
This brings ff_vf_ssim360 in line with its declaration in allfilters.c; this discrepancy is actually undefined behaviour. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_ssim360.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_s

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Fix left-shift of negative value

2023-01-28 Thread Anton Khirnov
set LGTM thanks, -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-28 Thread Marton Balint
On Fri, 27 Jan 2023, Marton Balint wrote: On Fri, 27 Jan 2023, James Almer wrote: On 1/27/2023 3:04 PM, Anton Khirnov wrote: Quoting Marton Balint (2023-01-27 18:59:39) On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do f

[FFmpeg-devel] [PATCH 1/4] avcodec: add AVCodecContext.frame_num as 64 bit variant to frame_number

2023-01-28 Thread Marton Balint
Frame counters can overflow relatively easily (INT_MAX number of frames is slightly more than 1 year for 60 fps content), so make sure we use 64 bit values for them. Also deprecate the old 32 bit frame_number attribute. Signed-off-by: Marton Balint --- doc/APIchanges | 4 +

[FFmpeg-devel] [PATCH 2/4] avcodec/diracdec: do not use AVFrame.display_picture_number for decoding

2023-01-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/diracdec.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index a5cad29597..22a2925188 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo_enc: do not use AVFrame.*_picture_number for encoding

2023-01-28 Thread Marton Balint
Move these fields to MPEGPicture instead and use that. Signed-off-by: Marton Balint --- libavcodec/mpeg12enc.c | 4 ++-- libavcodec/mpegpicture.c | 4 libavcodec/mpegpicture.h | 3 +++ libavcodec/mpegvideo_enc.c | 17 ++--- libavcodec/ratecontrol.c | 4 ++-- libavc

[FFmpeg-devel] [PATCH 4/4] avutil/frame: deprecate AVFrame.coded_picture_number and display_picture_number

2023-01-28 Thread Marton Balint
Their usefulness are questionable, very few decoders set them, and their type should have been int64_t. A replacement field can be added later if a valid use case is found. Signed-off-by: Marton Balint --- doc/APIchanges | 4 doc/examples/demuxing_decoding.c | 4 ++-- ff

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: use 32pixel alignment for bink

2023-01-28 Thread Michael Niedermayer
On Fri, Jan 27, 2023 at 10:59:38AM +1100, Peter Ross wrote: > On Sun, Jan 22, 2023 at 01:02:21AM +0100, Michael Niedermayer wrote: > > bink supports 16x16 blocks in chroma planes thus we need to allocate enough. > > Fixes: out of array access > > Fixes: > > 55026/clusterfuzz-testcase-minimized-ffm