Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread Anton Khirnov
I still think we should do a deprecation+replacement like we do for everything else. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmp

Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2023-01-27 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
Hi, It's been almost a month since we submitted our latest changes to the FFmpeg patchwork. I know that EVC implementation isn't the only thing you are working on at the moment but we'd like to do another step forward, toward merging our implementation into the master branch of the FFmpeg reposi

[FFmpeg-devel] [PATCH] avcodec/libjxl: respect AVCodecContext->bits_per_raw_sample

2023-01-27 Thread Leo Izen
libjxl only accepts 16-bit buffers with its API, but it can accept 9-bit to 15-bit input via a 16-bit buffer, provided the flag is set declaring the buffer to be of the respective significant depth. Likewise, it can only provide pixel data on decode as a 16-bit buffer (if higher than 8) but does p

[FFmpeg-devel] [PATCH 1/4] lavfi/framesync: use a local variable to shorten code

2023-01-27 Thread Anton Khirnov
--- libavfilter/framesync.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index ee91e4cf68..153db4fa21 100644 --- a/libavfilter/framesync.c +++ b/libavfilter/framesync.c @@ -201,24 +201,23 @

[FFmpeg-devel] [PATCH 4/4] lavfi/framesync: reindent after previous commit

2023-01-27 Thread Anton Khirnov
--- libavfilter/framesync.c | 56 - 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index b52cf318c0..9986b04e48 100644 --- a/libavfilter/framesync.c +++ b/libavfilter/framesync.c @@ -368,35 +

[FFmpeg-devel] [PATCH 2/4] lavfi/framesync: reorder functions to avoid a forward declaration

2023-01-27 Thread Anton Khirnov
--- libavfilter/framesync.c | 144 1 file changed, 71 insertions(+), 73 deletions(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index 153db4fa21..fdcc3b57c8 100644 --- a/libavfilter/framesync.c +++ b/libavfilter/framesync.c @@ -73,8 +73

[FFmpeg-devel] [PATCH 3/4] lavfi/framesync: add syncing via external timestamp map

2023-01-27 Thread Anton Khirnov
Useful when there is some external process that determines canonical frame synchronization. E.g. the framerate conversion code in ffmpeg CLI. --- doc/filters.texi| 6 ++ libavfilter/framesync.c | 121 ++-- libavfilter/framesync.h | 11 3 files ch

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/framesync: add syncing via external timestamp map

2023-01-27 Thread Paul B Mahol
On 1/27/23, Anton Khirnov wrote: > Useful when there is some external process that determines canonical > frame synchronization. E.g. the framerate conversion code in ffmpeg CLI. > --- > doc/filters.texi| 6 ++ > libavfilter/framesync.c | 121 ++-- >

[FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: fix type for old_limit

2023-01-27 Thread Jeffrey Chapuis
old_limit is of type float like limit, sorry about that. Signed-off-by: Ashyni --- libavfilter/vf_cropdetect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_cropdetect.c b/libavfilter/vf_cropdetect.c index 724047f864..56457ee90b 100644 --- a/libavfilter/vf_cr

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: fix type for old_limit

2023-01-27 Thread Jeffrey Chapuis
patch attached.From 555e1a9f45c99a3e3d15225c17bd98d52855a03d Mon Sep 17 00:00:00 2001 From: Ashyni Date: Fri, 27 Jan 2023 14:20:50 +0100 Subject: [PATCH] avfilter/vf_cropdetect: fix type for old_limit Signed-off-by: Ashyni --- libavfilter/vf_cropdetect.c | 2 +- 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH 26/31] avcodec/avcodec: Remove AV_CODEC_FLAG2_DROP_FRAME_TIMECODE

2023-01-27 Thread Andreas Rheinhardt
It has been deprecated in 94d68a41fabb55dd8c7e59b88fe4a28a637d1e5f and can't be set via AVOptions. The only codecs that use it (the MPEG-1/2 encoders) have private options for this. So remove it. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 5 - libavcodec/mpeg12enc.c | 1 -

[FFmpeg-devel] [PATCH 27/31] avformat/avformat: Remove AVOutputFormat.data_codec

2023-01-27 Thread Andreas Rheinhardt
No AVOutputFormat has this set. Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.h | 1 - libavformat/format.c| 2 -- libavformat/mux_utils.c | 3 +-- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index daa396e5a2..02

[FFmpeg-devel] [PATCH 28/31] avformat/avformat: Move codecpar up in AVStream

2023-01-27 Thread Andreas Rheinhardt
It is the most commonly used field and moving it to the start e.g. allows to encode the offset in a pointer+offset addressing mode on one byte on x86. Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

[FFmpeg-devel] [PATCH 29/31] avcodec: Make avcodec_decode_subtitle2 accept a const AVPacket*

2023-01-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- doc/APIchanges| 3 +++ fftools/ffmpeg.c | 4 ++-- fftools/ffprobe.c | 2 +- libavcodec/avcodec.h | 3 +-- libavcodec/decode.c | 9 - libavcodec/version.h | 2 +- tools/target_dec_fuzzer.c | 4 ++-- 7 files

[FFmpeg-devel] [PATCH 30/31] avformat/demux: Avoid stack packet when decoding frame

2023-01-27 Thread Andreas Rheinhardt
Possible now that avcodec_decode_subtitle2() accepts a const AVPacket*. Signed-off-by: Andreas Rheinhardt --- I don't like postponing FF_API_INIT_PACKET. Will look into this. libavformat/demux.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/demux

[FFmpeg-devel] [PATCH v7 0/3] ffmpeg: add video heartbeat capability to fix_sub_duration

2023-01-27 Thread Jan Ekström
Changes from v6: - Rebased on top of current master - Changed the option to only affect InputStreams that are mapped to the same output as a heartbeat stream as per Anton's review. Jan Ekström (3): ffmpeg: refactor post-decoding steps for subtitles into a function ffmpeg: move decoded fra

[FFmpeg-devel] [PATCH v7 1/3] ffmpeg: refactor post-decoding steps for subtitles into a function

2023-01-27 Thread Jan Ekström
From: Jan Ekström This enables us to later call this when generating additional subtitles for splitting purposes. Co-authored-by: Andrzej Nadachowski Signed-off-by: Jan Ekström --- fftools/ffmpeg.c | 49 +++- 1 file changed, 28 insertions(+), 21 de

[FFmpeg-devel] [PATCH v7 2/3] ffmpeg: move decoded frame counter from after post-processing to decode

2023-01-27 Thread Jan Ekström
From: Jan Ekström This way we can call process_subtitles without causing the decoded frame counter to get bumped. Additionally, this now takes into mention all of the decoded subtitle frames without fix_sub_duration latency/buffering, or filtering out decoded reset/end subtitles without any rend

[FFmpeg-devel] [PATCH v7 3/3] ffmpeg: add video heartbeat capability to fix_sub_duration

2023-01-27 Thread Jan Ekström
From: Jan Ekström Splits the currently handled subtitle at random access point packets that can be configured to follow a specific output stream. Currently only subtitle streams which are directly mapped into the same output in which the heartbeat stream resides are affected. This way the subtit

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/framesync: use a local variable to shorten code

2023-01-27 Thread Nicolas George
Anton Khirnov (12023-01-27): > --- > libavfilter/framesync.c | 33 - > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c > index ee91e4cf68..153db4fa21 100644 > --- a/libavfilter/framesync.c > +++ b

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/framesync: reorder functions to avoid a forward declaration

2023-01-27 Thread Nicolas George
Anton Khirnov (12023-01-27): > --- > libavfilter/framesync.c | 144 > 1 file changed, 71 insertions(+), 73 deletions(-) Getting rid of the forward declaration would be a good idea. But the order you have put the functions is completely illogical. For examp

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/framesync: add syncing via external timestamp map

2023-01-27 Thread Nicolas George
Anton Khirnov (12023-01-27): > Useful when there is some external process that determines canonical > frame synchronization. E.g. the framerate conversion code in ffmpeg CLI. > --- > doc/filters.texi| 6 ++ > libavfilter/framesync.c | 121 ++-- > libav

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2023-01-27 Thread Jean-Baptiste Kempf
Hello, On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote: > Hi, > >>>When was this release released? > The release was 13.12.2022 >>> Is it headers only or is it runtime too? > it still supports old drivers, but to use the av1 encoder, you need an > up-to-date driver version and a supported

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2023-01-27 Thread Gyan Doshi
On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote: Hello, On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote: Hi, When was this release released? The release was 13.12.2022 Is it headers only or is it runtime too? it still supports old drivers, but to use the av1 encoder, you need

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2023-01-27 Thread Jean-Baptiste Kempf
On Fri, 27 Jan 2023, at 16:58, Gyan Doshi wrote: > On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote: >> Hello, >> >> On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote: >>> Hi, >>> > When was this release released? >>> The release was 13.12.2022 > Is it headers only or is it runtime

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2023-01-27 Thread Gyan Doshi
On 2023-01-27 09:30 pm, Jean-Baptiste Kempf wrote: On Fri, 27 Jan 2023, at 16:58, Gyan Doshi wrote: On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote: Hello, On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote: Hi, When was this release released? The release was 13.12.2022 Is it h

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/framesync: add syncing via external timestamp map

2023-01-27 Thread Anton Khirnov
Quoting Nicolas George (2023-01-27 15:53:42) > framesync generates output based on its input. Therefore to force > timestamps on output frames you need to force timestamps on input > frames. This is not forcing timestamps on output frames. This is solving the general problem where the correct matc

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/avfilter: export process_options()

2023-01-27 Thread Anton Khirnov
If nobody has further comments, I would like to push this set next week. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/avfilter: export process_options()

2023-01-27 Thread Nicolas George
Anton Khirnov (12023-01-27): > If nobody has further comments, I would like to push this set next week. I have already said I would have comments. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat: add SDNS demuxer

2023-01-27 Thread Paul B Mahol
Patch attached. From f98e8a2931327c0b45aa7183d4ae3bd780382806 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 27 Jan 2023 17:00:36 +0100 Subject: [PATCH] avformat: add SDNS demuxer Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavform

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/avfilter: export process_options()

2023-01-27 Thread Anton Khirnov
Quoting Nicolas George (2023-01-27 17:48:02) > Anton Khirnov (12023-01-27): > > If nobody has further comments, I would like to push this set next week. > > I have already said I would have comments. Send them then. It's been almost two weeks since my initial RFC, and the code is quite straightfo

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/avfilter: export process_options()

2023-01-27 Thread Nicolas George
Anton Khirnov (12023-01-27): > Send them then. > It's been almost two weeks since my initial RFC, And if you have to wait ten more weeks for a proper review, you will wait ten more weeks. > and the code is quite > straightforward. No, it is not. I

Re: [FFmpeg-devel] [PATCH 1/2] amfenc: Update the min version to 1.4.28.0 for AMF SDK.

2023-01-27 Thread Gyan Doshi
On 2023-01-27 09:34 pm, Gyan Doshi wrote: On 2023-01-27 09:30 pm, Jean-Baptiste Kempf wrote: On Fri, 27 Jan 2023, at 16:58, Gyan Doshi wrote: On 2023-01-27 09:17 pm, Jean-Baptiste Kempf wrote: Hello, On Tue, 20 Dec 2022, at 18:48, Dmitrii Ovchinnikov wrote: Hi, When was this release r

Re: [FFmpeg-devel] drawtext filter

2023-01-27 Thread Francesco Carusi
On 26/01/2023 17:37, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: The drawtext reinit command is also used in the docs as an example for the sendcmd filter, so I thought it was fine to use commands in tha

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: fix type for old_limit

2023-01-27 Thread Paul B Mahol
On 1/27/23, Jeffrey Chapuis wrote: > patch attached. applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH 1/1] avformat/assenc: avoid incorrect copy of null terminator

2023-01-27 Thread Tim Angus
When writing a subtitle SSA/ASS subtitle file, the AVCodecParameters::extradata buffer is written directly to the output. In the case where the buffer is filled from a matroska source file produced by some older versions of Handbrake, this buffer ends with a null terminating character, which is the

Re: [FFmpeg-devel] drawtext filter

2023-01-27 Thread Paul B Mahol
On 1/27/23, Francesco Carusi wrote: > On 26/01/2023 17:37, Paul B Mahol wrote: >> On 1/26/23, Francesco Carusi wrote: >>> On 26/01/2023 14:21, Paul B Mahol wrote: On 1/26/23, Francesco Carusi wrote: > The drawtext reinit command is also used in the docs as an example for > the sendc

Re: [FFmpeg-devel] [PATCH] avcodec: add CBD2 DPCM decoder

2023-01-27 Thread Paul B Mahol
On 1/24/23, Paul B Mahol wrote: > Hi, > > Patch attached. > Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.

Re: [FFmpeg-devel] [PATCH 2/2] FATE: add tests for v360/ssim360 filters

2023-01-27 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-01-26 11:37:55) > Anton Khirnov: > > Would someone please copy > > https://up.khirnov.net/d8.mkv to > > spherical/Worlds_First_Live_360_Rocket_Launch-_Orbital_ATK_CRS-7_cut.mkv > > > > Thanks > > 1. Why don't you use a smaller file? 700kb does not seem especially

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread Marton Balint
On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do for everything else. You mean you want to introduce a new 64 bit member and deprecate the old 32 bit field? E.g. int64_t frame_num; attribute_deprcated int frame_number And during

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread Anton Khirnov
Quoting Marton Balint (2023-01-27 18:59:39) > > > On Fri, 27 Jan 2023, Anton Khirnov wrote: > > > I still think we should do a deprecation+replacement like we do for > > everything else. > > You mean you want to introduce a new 64 bit member and deprecate the old > 32 bit field? > > E.g. > >

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread James Almer
On 1/27/2023 3:04 PM, Anton Khirnov wrote: Quoting Marton Balint (2023-01-27 18:59:39) On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do for everything else. You mean you want to introduce a new 64 bit member and deprecate the old 32

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread Marton Balint
On Fri, 27 Jan 2023, James Almer wrote: On 1/27/2023 3:04 PM, Anton Khirnov wrote: Quoting Marton Balint (2023-01-27 18:59:39) On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do for everything else. You mean you want to intro

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-27 Thread James Almer
On 1/26/2023 7:49 PM, Jean-Baptiste Kempf wrote: Tbh, I don't see why we should do a 5.2, seeing that 6.0 would be the same features-set with just the ABI change, aka removing deprecated symbols. Also, doing a 5.2 which would not be a LTS, while 5.1 is a LTS is not only very weird, but it also

[FFmpeg-devel] [PATCH] lavc: add null codecs

2023-01-27 Thread Anton Khirnov
They discard all input without ever returning any output. Useful for development. --- libavcodec/Makefile | 4 ++ libavcodec/allcodecs.c | 6 +++ libavcodec/codec_desc.c | 12 ++ libavcodec/codec_id.h | 10 + libavcodec/null.c | 96 +

Re: [FFmpeg-devel] [PATCH] lavc: add null codecs

2023-01-27 Thread Paul B Mahol
On 1/27/23, Anton Khirnov wrote: > They discard all input without ever returning any output. Useful for > development. > --- > libavcodec/Makefile | 4 ++ > libavcodec/allcodecs.c | 6 +++ > libavcodec/codec_desc.c | 12 ++ > libavcodec/codec_id.h | 10 + > libavcodec/null.c

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc.c -- correctly re-emit extradata ahead of IDR pictures

2023-01-27 Thread John Coiner
From: John Coiner This is the proposed fix for https://trac.ffmpeg.org/ticket/10148 Very sorry to send the same patch 3 times; this time with `git send-email' so it should be legal :) --- libavformat/mpegtsenc.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH] avformat/rawdec: set correct timebase and framerate for raw video demuxers

2023-01-27 Thread Michael Niedermayer
On Thu, Jan 26, 2023 at 05:43:35PM +0100, Paul B Mahol wrote: > Patch attached. > rawdec.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > 68cb1c17a97b978f91793cc65f1ff9814bf99350 > 0001-avformat-rawdec-set-correct-timebase-and-framerate-f.patch > From b3e0b2efa3055be6b78d28345

[FFmpeg-devel] [PATCH] frame durations for framesync

2023-01-27 Thread Paul B Mahol
Patches attached. From b4f835c4ef6e0e0bbe6adef8235381e56f3f91df Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 27 Jan 2023 23:34:02 +0100 Subject: [PATCH 1/4] avfilter/framesync: calculate frame duration too Signed-off-by: Paul B Mahol --- libavfilter/framesync.c | 20 --

Re: [FFmpeg-devel] [PATCH] XMD demuxer and decoder

2023-01-27 Thread Michael Niedermayer
On Wed, Jan 25, 2023 at 10:28:38PM +0100, Paul B Mahol wrote: > Patch attached. breaks probetest tools/probetest 256 4096 testing size=1 testing size=2 testing size=4 testing size=8 testing size=16 testing size=32 testing size=64 testing size=128 testing size=256 testing size=512 testing size=10

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/scale_qsv: simplify scale_qsv filter

2023-01-27 Thread Xiang, Haihao
On Di, 2023-01-17 at 14:20 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Use QSVVPPContext as a base context of QSVScaleContext, hence we may > re-use functions defined for QSVVPPContext to manage MFX session for > scale_qsv filter. > > In addition, system memory has been taken into accou