Re: [FFmpeg-devel] [PATCH 3/5] avcodec/012v: Order operations for odd size handling

2023-01-16 Thread Paul B Mahol
On 1/13/23, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZERO12V_fuzzer-6714182078955520.fuzz > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZERO12V_fuzzer-6698145212137472.fuzz > > Found-by: continuo

Re: [FFmpeg-devel] [PATCH v2] avformat/segment: calculate segment durations correctly.

2023-01-16 Thread Gyan Doshi
Pushed as 01f46f18dbcdf323ceb4fdff7358cf3ca71366e6 On 2023-01-15 09:49 am, Gyan Doshi wrote: On 2023-01-12 11:29 am, Gyan Doshi wrote: On 2023-01-07 05:37 pm, Gyan Doshi wrote: segment_time and segment_times are defined as duration specifications, not timestamps, so calculation of segment

[FFmpeg-devel] [PATCH] avcodec/scpr3: Check bx

2023-01-16 Thread Michael Niedermayer
Fixes: Out of array access Fixes: 55102/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-4877396618903552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/scpr3.c | 3 +++ 1 file c

Re: [FFmpeg-devel] [PATCH] trailing padding

2023-01-16 Thread Tobias Rapp
On 12/01/2023 10:41, Paul B Mahol wrote: Patches attached, ffmpeg.c should really not ignore initial padding and trailing padding. I guess ffprobe.xsd should be updated, too. Did you run FATE? Regards, Tobias ___ ffmpeg-devel mailing list ffmpeg-de

[FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-16 Thread James Almer
It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us an "Open ABI season" in which we can do breaking changes (like changing public struct offsets, public enum values, adding fields to structs that have their size tied to the ABI

[FFmpeg-devel] [PATCH 01/26] avcodec: remove FF_API_OPENH264_SLICE_MODE

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libopenh264enc.c | 16 libavcodec/version_major.h | 1 - 2 files changed, 17 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index bbd6969568..99d1c67154 100644 --- a/libavcodec/libopenh264enc.c +++

[FFmpeg-devel] [PATCH 02/26] avcodec: remove FF_API_OPENH264_CABAC

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libopenh264enc.c | 6 -- libavcodec/version_major.h | 1 - 2 files changed, 7 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 99d1c67154..84c1d8b59c 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/

[FFmpeg-devel] [PATCH 03/26] avcodec: remove FF_API_UNUSED_CODEC_CAPS

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/codec.h | 11 --- libavcodec/version_major.h | 1 - 2 files changed, 12 deletions(-) diff --git a/libavcodec/codec.h b/libavcodec/codec.h index 77a1a3f5a2..e10fcb9c7c 100644 --- a/libavcodec/codec.h +++ b/libavcodec/codec.h @@ -143,17 +1

[FFmpeg-devel] [PATCH 04/26] avcodec: remove FF_API_THREAD_SAFE_CALLBACKS

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 5 - libavcodec/avcodec.h | 21 --- libavcodec/decode.c | 13 -- libavcodec/encode.c | 7 +- libavcodec/frame_thread_encoder.c | 20 --- libavcodec/pthread_frame.c| 237 +

[FFmpeg-devel] [PATCH 09/26] avcodec: remove FF_API_FLAG_TRUNCATED

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 9 - libavcodec/codec.h | 6 libavcodec/decode.c| 4 --- libavcodec/h263_parser.c | 11 -- libavcodec/h263_parser.h | 29 --- libavcodec/h263dec.c | 42 ---

[FFmpeg-devel] [PATCH 05/26] avcodec: remove FF_API_DEBUG_MV

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 11 --- libavcodec/version_major.h | 1 - 2 files changed, 12 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c1a4fbf4d0..4e8417ca07 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1

[FFmpeg-devel] [PATCH 06/26] avcodec: remove FF_API_GET_FRAME_CLASS

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 8 libavcodec/options.c | 33 - libavcodec/version_major.h | 1 - 3 files changed, 42 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 4e8417ca07..ee5acc5c9b 10

[FFmpeg-devel] [PATCH 10/26] avcodec: remove FF_API_SUB_TEXT_FORMAT

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 9 - libavcodec/options_table.h | 4 libavcodec/version_major.h | 1 - 3 files changed, 14 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 86228e64b4..e2582f2484 100644 --- a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 07/26] avcodec: remove FF_API_AUTO_THREADS

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/codec.h | 3 --- libavcodec/version_major.h | 1 - 2 files changed, 4 deletions(-) diff --git a/libavcodec/codec.h b/libavcodec/codec.h index e10fcb9c7c..8bf85b2f9c 100644 --- a/libavcodec/codec.h +++ b/libavcodec/codec.h @@ -125,9 +125,6 @@ *

[FFmpeg-devel] [PATCH 11/26] avformat: remove FF_API_LAVF_PRIV_OPT

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavformat/avformat.h | 3 --- libavformat/version_major.h | 1 - 2 files changed, 4 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 1d97d56ac5..b40492703c 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -13

[FFmpeg-devel] [PATCH 12/26] avformat: remove FF_API_AVIOCONTEXT_WRITTEN

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavformat/avio.h | 10 -- libavformat/aviobuf.c | 10 -- libavformat/version_major.h | 1 - 3 files changed, 21 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index 4bf6b1fbda..5f13e0622d 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 08/26] avcodec: remove FF_API_AVCTX_TIMEBASE

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1_parser.c| 3 --- libavcodec/avcodec.c | 5 - libavcodec/avcodec.h | 3 +-- libavcodec/avs2_parser.c | 4 ++-- libavcodec/avs3_parser.c | 4 ++-- libavcodec/cpia.c | 8 --- libavcodec/d

[FFmpeg-devel] [PATCH 13/26] avformat: remove FF_HLS_TS_OPTIONS

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavformat/hlsenc.c| 3 --- libavformat/version_major.h | 1 - 2 files changed, 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 39df9becc7..32491b4534 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -3116,9 +31

[FFmpeg-devel] [PATCH 14/26] avformat: remove FF_API_AVSTREAM_CLASS

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg_mux_init.c | 11 --- libavformat/avformat.h | 2 -- libavformat/options.c | 3 --- libavformat/version_major.h | 1 - 4 files changed, 17 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 9e

[FFmpeg-devel] [PATCH 15/26] avfilter: remove FF_API_SWS_PARAM_OPTION

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavfilter/buffersrc.c | 11 --- libavfilter/version_major.h | 1 - 2 files changed, 12 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index ae8bba19b0..ba17450b93 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buf

[FFmpeg-devel] [PATCH 16/26] avfilter: remove FF_API_BUFFERSINK_ALLOC

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavfilter/buffersink.c| 22 -- libavfilter/buffersink.h| 36 libavfilter/version_major.h | 1 - 3 files changed, 59 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c ind

[FFmpeg-devel] [PATCH 18/26] avdevice: remove FF_API_DEVICE_CAPABILITIES

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavdevice/avdevice.c | 19 -- libavdevice/avdevice.h | 130 libavdevice/version_major.h | 1 - 3 files changed, 150 deletions(-) diff --git a/libavdevice/avdevice.c b/libavdevice/avdevice.c index 58996404b3..f

[FFmpeg-devel] [PATCH 17/26] avfilter: remove FF_API_PAD_COUNT

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavfilter/avfilter.c | 21 - libavfilter/avfilter.h | 10 -- libavfilter/version_major.h | 2 -- 3 files changed, 33 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index c2ecdffa6f..ed363351ad 1006

[FFmpeg-devel] [PATCH 19/26] avutil: remove FF_API_D2STR

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavutil/avstring.c | 10 -- libavutil/avstring.h | 9 - libavutil/tests/avstring.c | 16 libavutil/version.h| 1 - 4 files changed, 36 deletions(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c ind

[FFmpeg-devel] [PATCH 20/26] avutil: remove FF_API_DECLARE_ALIGNED

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/qdmc.c| 1 + libavutil/mem.h | 80 libavutil/mem_internal.h | 2 - libavutil/version.h | 1 - 4 files changed, 1 insertion(+), 83 deletions(-) diff --git a/libavcodec/qdmc.c b/libavcodec/q

[FFmpeg-devel] [PATCH 21/26] avutil: remove FF_API_COLORSPACE_NAME

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 17 - libavutil/frame.h | 9 - libavutil/version.h | 1 - 3 files changed, 27 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index fa9b11aa54..3198a50f67 100644 --- a/libavutil/frame.c +++ b/libavut

[FFmpeg-devel] [PATCH 22/26] avutil: remove FF_API_AV_MALLOCZ_ARRAY

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- libavutil/mem.c | 10 -- libavutil/mem.h | 8 libavutil/version.h | 1 - 3 files changed, 19 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 18aff5291f..36b8940a0c 100644 --- a/libavutil/mem.c +++ b/libavutil/mem.c @@ -2

[FFmpeg-devel] [PATCH 23/26] avutil/version: postpone the remaining API deprecations

2023-01-16 Thread James Almer
They are too recent. Signed-off-by: James Almer --- fftools/ffprobe.c | 2 +- libavutil/version.h | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index b9310a2d25..ac650145ef 100644 --- a/fftools/ffprobe.c +++ b/fftools/f

[FFmpeg-devel] [PATCH 24/26] avcodec/version: postpone the remaining API deprecations

2023-01-16 Thread James Almer
They are either too recent, or still need work like FF_API_INIT_PACKET. Signed-off-by: James Almer --- libavcodec/version_major.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h index e162bf708c..dda17fffe2

[FFmpeg-devel] [PATCH 26/26] Bump major versions of all libraries

2023-01-16 Thread James Almer
Signed-off-by: James Almer --- doc/APIchanges | 16 libavcodec/version.h| 2 +- libavcodec/version_major.h | 2 +- libavdevice/version.h | 4 ++-- libavdevice/version_major.h | 2 +- libavfilter/version.h | 2 +- libavfilter/version_major.h

[FFmpeg-devel] [PATCH 25/26] avformat/version: postpone the remaining API deprecations

2023-01-16 Thread James Almer
They are either too recent, or still need work like FF_API_COMPUTE_PKT_FIELDS2. Signed-off-by: James Almer --- libavformat/version_major.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/version_major.h b/libavformat/version_major.h index 1db8e7600e..b11f811

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Tomas Härdin
lör 2023-01-14 klockan 16:48 +0100 skrev Jerome Martinez: > Before the patch: > - stored values were rounded to upper 16 multiple also for formats > not > using macroblocks (should be st->codecpar->width and > st->codecpar->height when not MPEG formats; note that I found no > other > muxer doing

Re: [FFmpeg-devel] GSoC 2023

2023-01-16 Thread Nuo Mi
On Mon, Jan 16, 2023 at 6:18 AM Thilo Borgmann wrote: > Am 15.01.23 um 15:28 schrieb Nuo Mi: > > On Sun, Jan 15, 2023 at 9:27 PM Ronald S. Bultje > wrote: > > > >> Hi, > >> > >> On Sun, Jan 15, 2023 at 4:20 AM Nuo Mi wrote: > >> > >>> Is it finalized? Any chance to add some items in > >>> http

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Nicolas Gaullier
>Before the patch: >- stored values were rounded to upper 16 multiple also for formats not using >macroblocks (should be st->codecpar->width and >st->codecpar->height when not MPEG formats; note that I found no other >muxer doing the rounding for AVC, only for MPEG-2 Video, but I find no reason

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-16 Thread Tomas Härdin
lör 2023-01-14 klockan 16:45 +0100 skrev Jerome Martinez: > The arbitrary short element codes are the ones used by another muxer > ( > files available at > https://www.digitizationguidelines.gov/guidelines/MXF_app_sampleFiles.html#2022 >   > ) > > The support of RGBA descriptor is added, mainly

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-16 Thread Jerome Martinez
On 16/01/2023 15:00, Tomas Härdin wrote: JPEG2000 will also need an RGBA descriptor filled out, might be good to prepare for that. this was the idea behind the way it is coded, so there is only a new mxf_write_jpeg2000_desc function to write, like the one for FFV1 i.e. static void mxf_write_j

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Jerome Martinez
On 16/01/2023 14:50, Tomas Härdin wrote: lör 2023-01-14 klockan 16:48 +0100 skrev Jerome Martinez: Before the patch: - stored values were rounded to upper 16 multiple also for formats not using macroblocks (should be st->codecpar->width and st->codecpar->height when not MPEG formats; note that I

Re: [FFmpeg-devel] GSoC 2023

2023-01-16 Thread Jean-Baptiste Kempf
On Mon, 16 Jan 2023, at 14:53, Nuo Mi wrote: > Seems too hurried for this time. Maybe next time I disagree: we can do (and should do) a small task for VVC dec in GSoC 2023, like a fringe feature, not from the mainline. jb -- Jean-Baptiste Kempf - President +33 672 704 734 ___

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Jerome Martinez
On 16/01/2023 15:00, Nicolas Gaullier wrote: Before the patch: - stored values were rounded to upper 16 multiple also for formats not using macroblocks (should be st->codecpar->width and st->codecpar->height when not MPEG formats; note that I found no other muxer doing the rounding for AVC, only

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Nicolas Gaullier
>> The width is one thing; for whatever reason, there is a divergence between >> DV100 on one hand and AVCI/XDCAMHD35 on the other. In my understanding, in >> current practices, DV obey s337 (stored width includes scaling) but >> >xdcam&avci does not, so current code is fine but maybe this is an

[FFmpeg-devel] [PATCH] avcodec/png: support sRGB and cICP chunks

2023-01-16 Thread Leo Izen
This commit adds decode-side support for sRGB chunks and cICP chunks. The sRGB chunk is part of the PNG specification, 2nd edition, and FFmpeg already supports writing this chunk on the encode-side, but this chunk is ignored upon decode. This commit causes the PNG decoder to tag the output video s

[FFmpeg-devel] [PATCH] configure: check for sysctl.h explicitly

2023-01-16 Thread Aman Karmani
From: Aman Karmani HAVE_SYSCTL is used to guard #include , so make sure we only define it when that header is present. In recent glibc, the header was removed: https://sourceware.org/pipermail/glibc-cvs/2020q2/069366.html Signed-off-by: Aman Karmani --- configure: check for sysctl.h explic

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

2023-01-16 Thread Stefano Sabatini
On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote: > > > On Jan 1, 2023, at 03:26, Stefano Sabatini wrote: > > > > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > >> For some samples the pkt->pts is always missing, use the pkt->dts > >> instead. > > If some

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

2023-01-16 Thread zhilizhao(赵志立)
> On Jan 17, 2023, at 07:41, Stefano Sabatini wrote: > > On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote: >> >>> On Jan 1, 2023, at 03:26, Stefano Sabatini wrote: >>> >>> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: For some samples the pkt->pts

[FFmpeg-devel] [PATCH 1/3] lavfi/scale_qsv: simplify scale_qsv filter

2023-01-16 Thread Xiang, Haihao
From: Haihao Xiang Use QSVVPPContext as a base context of QSVScaleContext, hence we may re-use functions defined for QSVVPPContext to manage MFX session for scale_qsv filter. In addition, system memory has been taken into account in QSVVVPPContext, we may add support for non-QSV pixel formats in

[FFmpeg-devel] [PATCH 2/3] lavfi/scale_qsv: re-use VPPContext for scale_qsv filter

2023-01-16 Thread Xiang, Haihao
From: Haihao Xiang QSVScaleContext and VPPContext have the same base context, and all features in scale_qsv are implemented in vpp_qsv filter, so scale_qsv can be taken as a special case of vpp_qsv filter, and we may use VPPContext with a different option array, preinit callback and supported pi

[FFmpeg-devel] [PATCH 3/3] lavfi/vpp_qsv: factor common QSV filter definition

2023-01-16 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavfilter/vf_vpp_qsv.c | 126 --- 1 file changed, 51 insertions(+), 75 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 34732bb2c9..34e530e244 100644 --- a/libavfilter/vf