[FFmpeg-devel] [PATCH 01/13] fftools/ffmpeg: stop explicitly closing decoders

It serves no purpose, they will be closed and freed in avcodec_free_context() called from ist_free(). --- fftools/ffmpeg.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 3767ab444b..ba91af2c95 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c

[FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg: move force-keyframe-related vars to a separate struct

There are 8 of them and they are typically used together. Allows to pass just this struct to forced_kf_apply(), which makes it clear that the rest of the OutputStream is not accessed there. --- fftools/ffmpeg.c | 92 +++ fftools/ffmpeg.h | 25 +

[FFmpeg-devel] [PATCH 06/13] fftools/ffmpeg: move logging filtered frame timestamps

Do it right after the frame is received from the filtergraph. This is a more logical place for this and will simplify future commits. --- fftools/ffmpeg.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 44582e3568..263670d

[FFmpeg-devel] [PATCH 03/13] fftools/ffmpeg: store forced keyframe pts in AV_TIME_BASE_Q

Rather than the encoder timebase. Since the times are parsed as microseconds, this will not reduce precision, except possibly when chapter times are used and the chapter timebase happens to be better aligned with the encoder timebase, which is unlikely. This will allow parsing the keyframe times e

[FFmpeg-devel] [PATCH 07/13] fftools/ffmpeg: set AVFrame.time_base after filtering

Makes it easier to track what timebase are the frame timestamps in and allows to stop accessing filters in code that shouldn't deal with filtering. --- fftools/ffmpeg.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 263670d3f5

[FFmpeg-devel] [PATCH 08/13] fftools/ffmpeg: stop calling adjust_frame_pts_to_encoder_tb() for audio

Almost none of that function's complexity is useful for audio, it can be replaced by a simple av_rescale_q(). --- fftools/ffmpeg.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2ee40890a9..cb65f26100 100644 --- a/fftools/f

[FFmpeg-devel] [PATCH 04/13] fftools/ffmpeg: parse forced keyframes in of_open()

Allows to remove the ugly of_get_chapters() wrapper. --- fftools/ffmpeg.c | 89 fftools/ffmpeg.h | 2 - fftools/ffmpeg_mux.c | 8 --- fftools/ffmpeg_mux_init.c | 106 ++ 4 files changed, 106 insertions

[FFmpeg-devel] [PATCH 09/13] fftools/ffmpeg: call check_recording_time() with actual frame pts

Not its estimated value that will not necessarily be used. --- fftools/ffmpeg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index cb65f26100..e56681a461 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -936,9 +936,6 @@ static

[FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg: avoid storing full forced keyframe spec

It is not needed after the spec is parsed. Also avoids ugly string comparisons for each video frame. --- fftools/ffmpeg.c | 7 ++- fftools/ffmpeg.h | 7 ++- fftools/ffmpeg_mux.c | 1 - fftools/ffmpeg_mux_init.c | 35 --- 4 files cha

[FFmpeg-devel] [PATCH 10/13] fftools/ffmpeg: only convert video frame pts if we have a frame

Calling adjust_frame_pts_to_encoder_tb() with a NULL frame does not perform a meaningful action. --- fftools/ffmpeg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index e56681a461..8f27b5ca3f 100644 --- a/fftools/ffmpeg.c +++ b/fftool

[FFmpeg-devel] [PATCH 12/13] fftools/ffmpeg: remove a useless inner block

adjust_frame_pts_to_encoder_tb() is so small that this serves no useful purpose. --- fftools/ffmpeg.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0128476f57..045cc609b9 100644 --- a/fftools/ffmpeg.c +++ b/fftools/

[FFmpeg-devel] [PATCH 11/13] fftools/ffmpeg: drop an always-false check

--- fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 8f27b5ca3f..0128476f57 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -678,7 +678,7 @@ static double adjust_frame_pts_to_encoder_tb(OutputFile *of, OutputStr

[FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg: cosmetics

Reindent after previous commit and break/split some lines as appropriate. --- fftools/ffmpeg.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 045cc609b9..771219f7df 100644 --- a/fftools/ffmpeg.c +++ b/fftools/

Re: [FFmpeg-devel] [PATCH] avfilter: add showcwt multimedia filter

On 11/25/22, Paul B Mahol wrote: > Hello, > > Patch attached. > Improved patch attached. Added slide & direction options. From ceecc1537b96f5639b98b490cd07a0f0a18439c3 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 19 Nov 2022 19:01:23 +0100 Subject: [PATCH] avfilter: add showcwt multim

Re: [FFmpeg-devel] [PATCH 1/2] lavf: stop honoring AVFMT_FLAG_AUTO_BSF

On 2022-11-25 11:30 pm, Anton Khirnov wrote: There should no longer be reason for the callers to disable this. In-muxer bitstream filtering should be considered a part of the muxer internals and invisible to the caller. --- libavformat/internal.h | 5 + libavformat/movenc.c|

Re: [FFmpeg-devel] [PATCH 07/31] avutil: use av_dict_iterate

On 25 Nov 2022, at 13:50, Andreas Rheinhardt wrote: > Marvin Scholz: >> --- >> libavutil/opt.c| 12 ++-- >> libavutil/tests/dict.c | 10 +- >> 2 files changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index a3940f47fb..0a

[FFmpeg-devel] [PATCH v2 00/31] Use av_dict_iterate where approproate

Changes to v1: - Fixed 0 used as NULL pointer in wtvenc - Dropped change to the dict test - Narrowed variabel scope/removed unnecessary variables in fftools/ffmpeg_filter.c --- This patchset replaces the common use of: av_dict_get(format_options, "", entry, AV_DICT_IGNORE_SUFFIX) with the ne

[FFmpeg-devel] [PATCH v2 01/31] fftools: use av_dict_iterate

--- fftools/cmdutils.c | 2 +- fftools/ffmpeg.c| 2 +- fftools/ffmpeg_demux.c | 5 ++--- fftools/ffmpeg_filter.c | 3 +-- fftools/ffmpeg_opt.c| 2 +- fftools/ffplay.c| 4 ++-- fftools/ffprobe.c | 6 +++--- 7 files changed, 11 insertions(+), 13 deletions(-) diff --g

[FFmpeg-devel] [PATCH v2 02/31] fftools: use av_dict_get_string

Instead of manually assembling the string, use av_dict_get_string which handles things like proper escaping too (even though it is not yet needed here). --- fftools/ffmpeg_filter.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/fftools/ffmpe

[FFmpeg-devel] [PATCH v2 03/31] avcodec/librav1e: use av_dict_iterate

--- libavcodec/librav1e.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 4f424caf5b..f48d5e0eb4 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -243,8 +243,8 @@ static av_cold int librav1e_encode_init(AV

[FFmpeg-devel] [PATCH v2 04/31] avcodec/librav1e: remove unnecessary variable

--- libavcodec/librav1e.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index f48d5e0eb4..3481b7637d 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -245,8 +245,7 @@ static av_cold int librav1e_encode_init(AVCo

[FFmpeg-devel] [PATCH v2 05/31] avcodec/libvpxenc: use av_dict_iterate

--- libavcodec/libvpxenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 667cffc200..9aa5510c28 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -900,7 +900,7 @@ static av_cold int vpx_init(AVCodecCo

[FFmpeg-devel] [PATCH v2 12/31] avformat/vorbiscomment: use av_dict_iterate

--- libavformat/vorbiscomment.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/vorbiscomment.c b/libavformat/vorbiscomment.c index 13ee065a44..abe12fd586 100644 --- a/libavformat/vorbiscomment.c +++ b/libavformat/vorbiscomment.c @@ -45,17 +45,17 @@ i

[FFmpeg-devel] [PATCH v2 06/31] avformat/smjpegenc: use av_dict_iterate

--- libavformat/smjpegenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/smjpegenc.c b/libavformat/smjpegenc.c index 888ece2f7c..edba08cf9b 100644 --- a/libavformat/smjpegenc.c +++ b/libavformat/smjpegenc.c @@ -35,7 +35,7 @@ typedef struct SMJPEGMuxContext {

[FFmpeg-devel] [PATCH v2 13/31] avfilter/vf_libvmaf: use av_dict_iterate

--- libavfilter/vf_libvmaf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index 8f649c5b02..2586f37d99 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/vf_libvmaf.c @@ -236,9 +236,9 @@ static int parse_fea

[FFmpeg-devel] [PATCH v2 07/31] avutil: use av_dict_iterate

--- libavutil/opt.c| 12 ++-- libavutil/tests/dict.c | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index a3940f47fb..0a909a8b22 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1742,14 +1742,14 @@ void av_opt_free(vo

[FFmpeg-devel] [PATCH v2 14/31] avfilter/f_metadata: use av_dict_iterate

--- libavfilter/f_metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c index 82491f2bb8..4b7cfb0cb7 100644 --- a/libavfilter/f_metadata.c +++ b/libavfilter/f_metadata.c @@ -308,7 +308,7 @@ static int filter_frame(AVF

[FFmpeg-devel] [PATCH v2 08/31] avfilter/vf_scale: use av_dict_iterate

--- libavfilter/vf_scale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 2b12cf283c..b95e2e6c66 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -555,8 +555,8 @@ static int config_props(AVFilterLink

[FFmpeg-devel] [PATCH v2 15/31] avformat/cafenc: use av_dict_iterate

--- libavformat/cafenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/cafenc.c b/libavformat/cafenc.c index b90811d46f..b8317cd5ed 100644 --- a/libavformat/cafenc.c +++ b/libavformat/cafenc.c @@ -113,7 +113,7 @@ static int caf_write_header(AVFormatContext *

[FFmpeg-devel] [PATCH v2 09/31] avfilter/vf_coreimage: use av_dict_iterate

--- libavfilter/vf_coreimage.m | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m index 874bdc8c56..b1959861de 100644 --- a/libavfilter/vf_coreimage.m +++ b/libavfilter/vf_coreimage.m @@ -416,8 +416,8 @@ stat

[FFmpeg-devel] [PATCH v2 16/31] doc/examples/metadata: use av_dict_iterate

--- doc/examples/metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/metadata.c b/doc/examples/metadata.c index 7c44009a24..734b12df16 100644 --- a/doc/examples/metadata.c +++ b/doc/examples/metadata.c @@ -52,7 +52,7 @@ int main (int argc, char **argv)

[FFmpeg-devel] [PATCH v2 10/31] avcodec/libxavs2: use av_dict_iterate

--- libavcodec/libxavs2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 1672edfc07..c493ddc325 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -96,8 +96,8 @@ static av_cold int xavs2_init(AVCodecContext

[FFmpeg-devel] [PATCH v2 17/31] avformat/movenc: use av_dict_iterate

--- libavformat/movenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 064b541972..7b00e65cdd 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4110,7 +4110,7 @@ static int mov_write_mdta_hdlr_tag(AVIOCo

[FFmpeg-devel] [PATCH v2 11/31] avcodec/avpacket: use av_dict_iterate

--- libavcodec/avpacket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index bcbc4166cb..5fef65e97a 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -316,7 +316,7 @@ uint8_t *av_packet_pack_dictionary(AVDictionar

[FFmpeg-devel] [PATCH v2 18/31] avformat/metadata: use av_dict_iterate

--- libavformat/metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/metadata.c b/libavformat/metadata.c index b9b6de7972..a0258ea125 100644 --- a/libavformat/metadata.c +++ b/libavformat/metadata.c @@ -29,14 +29,14 @@ void ff_metadata_conv(AVDictionary **

[FFmpeg-devel] [PATCH v2 19/31] avformat/flvenc: use av_dict_iterate

--- libavformat/flvenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 59be11eba8..128ae8ebc0 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -277,7 +277,7 @@ static void write_metadata(AVFormatContext *s,

[FFmpeg-devel] [PATCH v2 20/31] avformat/hls: use av_dict_iterate

And constify oldentry too while at it. --- libavformat/hls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 402eb2b5a0..926d053939 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1104,10 +1104,10 @@ static void parse

[FFmpeg-devel] [PATCH v2 21/31] avformat/lrcenc: use av_dict_iterate

--- libavformat/lrcenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/lrcenc.c b/libavformat/lrcenc.c index f7a5a6982d..2d6ca33e38 100644 --- a/libavformat/lrcenc.c +++ b/libavformat/lrcenc.c @@ -63,8 +63,7 @@ static int lrc_write_header(AVFormatContext *s)

[FFmpeg-devel] [PATCH v2 22/31] avformat/dump: use av_dict_iterate

--- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 225f80ac22..d31e4c2ec6 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -140,7 +140,7 @@ static void dump_metadata(void *ctx, const AVDictionary *m,

[FFmpeg-devel] [PATCH v2 23/31] avformat/wtvenc: use av_dict_iterate

--- libavformat/wtvenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/wtvenc.c b/libavformat/wtvenc.c index 7e28b2082e..62dca62b06 100644 --- a/libavformat/wtvenc.c +++ b/libavformat/wtvenc.c @@ -670,12 +670,12 @@ static void write_table_entries_attrib(AV

[FFmpeg-devel] [PATCH v2 24/31] avformat/ffmetaenc: use av_dict_iterate

--- libavformat/ffmetaenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmetaenc.c b/libavformat/ffmetaenc.c index edd66e1a04..f27ac1ac50 100644 --- a/libavformat/ffmetaenc.c +++ b/libavformat/ffmetaenc.c @@ -40,8 +40,8 @@ static void write_escape_str(AVIOC

[FFmpeg-devel] [PATCH v2 25/31] avformat/id3v2enc: use av_dict_iterate

--- libavformat/id3v2enc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/id3v2enc.c b/libavformat/id3v2enc.c index 515d2efd7d..ac907c2758 100644 --- a/libavformat/id3v2enc.c +++ b/libavformat/id3v2enc.c @@ -150,7 +150,7 @@ static int id3v2_put_priv(ID3v

[FFmpeg-devel] [PATCH v2 26/31] avformat/nutenc: use av_dict_iterate

--- libavformat/nutenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c index 1afdeeb8ab..ff81ee34aa 100644 --- a/libavformat/nutenc.c +++ b/libavformat/nutenc.c @@ -516,7 +516,7 @@ static int add_info(AVIOContext *bc, c

[FFmpeg-devel] [PATCH v2 27/31] avformat/apetag: use av_dict_iterate

--- libavformat/apetag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/apetag.c b/libavformat/apetag.c index e861aac0f8..f2794c46f2 100644 --- a/libavformat/apetag.c +++ b/libavformat/apetag.c @@ -175,7 +175,7 @@ static int string_is_ascii(const uint8_t *str)

[FFmpeg-devel] [PATCH v2 28/31] avformat/asfenc: use av_dict_iterate

--- libavformat/asfenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/asfenc.c b/libavformat/asfenc.c index 70800a6df5..47240fc0a8 100644 --- a/libavformat/asfenc.c +++ b/libavformat/asfenc.c @@ -570,10 +570,10 @@ static int asf_write_header1(AVFormatContext

[FFmpeg-devel] [PATCH v2 29/31] avformat/http: use av_dict_iterate

--- libavformat/http.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index c5c48c7900..7bce821535 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1021,11 +1021,11 @@ static int parse_cookie(HTTPContext *s, const char

[FFmpeg-devel] [PATCH v2 30/31] avformat/matroskaenc: use av_dict_iterate

--- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 2be4f87284..2deb4284e8 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -2048,7 +2048,7 @@ static int mkv_write_tag

[FFmpeg-devel] [PATCH v2 31/31] avformat/fifo: use av_dict_iterate

--- libavformat/fifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 7b35c9bf02..c125a97b0d 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@ -148,8 +148,8 @@ static int fifo_thread_write_header(FifoThreadContext *ct

Re: [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

Hi again, Pinging again for review. I've asked for clarification about how should the EXTERNAL_ checks be dealt with, but I've not received any response here. Best, amyspark On 07/11/2022 11:48, L. E. Segovia wrote: > Ping for review. > > amyspark > > On 03/11/2022 13:36, L. E. Segovia wrote:

Re: [FFmpeg-devel] GitHub releases section is very old

On Sat, Oct 29, 2022 at 09:31:04PM +0200, Michael Niedermayer wrote: > On Sat, Oct 29, 2022 at 02:53:34PM +0200, Timo Rothenpieler wrote: > > On 29.10.2022 14:36, * Neustradamus * wrote: > > > Hello all, > > > > > > It is possible to remove all releases from GitHub? > > > Because at right, we can

[FFmpeg-devel] [PATCH] SECURITY: This is for github

--- SECURITY.md | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 SECURITY.md diff --git a/SECURITY.md b/SECURITY.md new file mode 100644 index 00..6e80133cf4 --- /dev/null +++ b/SECURITY.md @@ -0,0 +1,10 @@ +# Security Policy + +## Reporting a Vulnerability + +Please